[lng-odp] [API-NEXT PATCH 3/6] linux-generic: socket mmap: implement pktio_start and pktio_stop

2015-08-13 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- platform/linux-generic/pktio/socket_mmap.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/platform/linux-generic/pktio/socket_mmap.c b/platform/linux-generic/pktio/socket_mmap.c index 7d42678..f9ba74e 100644 ---

[lng-odp] [API-NEXT PATCH 2/6] linux-generic: loop: implement pktio_start and pktio_stop

2015-08-13 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- platform/linux-generic/pktio/loop.c | 21 + 1 file changed, 21 insertions(+) diff --git a/platform/linux-generic/pktio/loop.c b/platform/linux-generic/pktio/loop.c index 188a9ee..8c45e47 100644 ---

[lng-odp] [Bug 1750] New: sendmmsg pktio error handle

2015-08-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1750 Bug ID: 1750 Summary: sendmmsg pktio error handle Product: OpenDataPlane Version: unspecified Hardware: Other OS: Linux Status: UNCONFIRMED Severity:

[lng-odp] [API-NEXT PATCH 0/6] implementation of odp_pktio_start and _stop

2015-08-13 Thread Maxim Uvarov
odp_pktio_start() and odp_pktio_stop() API function uses to control pktio inside worker or to start/stop pktio from control thread. Patch set includes: - linux-generic implementation - validation test suite - fixes to all apps uses odp_pktio_open(). For now I left current logic if it will be

[lng-odp] [API-NEXT PATCH 1/6] linux-generic: add pktio_start and pktio_stop

2015-08-13 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- .../linux-generic/include/odp_packet_io_internal.h | 6 platform/linux-generic/odp_packet_io.c | 34 ++ 2 files changed, 40 insertions(+) diff --git

Re: [lng-odp] [PATCHv4] example:generator:move verbose from worker to control

2015-08-13 Thread Krishna Garapati
Stuart, does this patch look ok ? On 7 August 2015 at 15:37, Maxim Uvarov maxim.uva...@linaro.org wrote: On 08/07/15 15:23, Krishna Garapati wrote: I will look into the API replacement. If I understood your comment correctly, I am already reusing the initial calculated num_workers and

Re: [lng-odp] [API-NEXT PATCH 3/6] linux-generic: socket mmap: implement pktio_start and pktio_stop

2015-08-13 Thread Bill Fischofer
On Thu, Aug 13, 2015 at 6:45 AM, Maxim Uvarov maxim.uva...@linaro.org wrote: Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- platform/linux-generic/pktio/socket_mmap.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

[lng-odp] [PATCHv5 3/3] test: pktio: add tests for segmented packets

2015-08-13 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- test/validation/pktio/pktio.c | 73 --- test/validation/pktio/pktio.h | 3 +- 2 files changed, 64 insertions(+), 12 deletions(-) diff --git a/test/validation/pktio/pktio.c

[lng-odp] [API-NEXT PATCH 5/6] validation: test odp_pktio_start and odp_pktio_stop

2015-08-13 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- test/validation/pktio/pktio.c | 112 ++ 1 file changed, 112 insertions(+) diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index ebe34fa..f8a8981 100644 ---

[lng-odp] [API-NEXT PATCH 4/6] linux-generic: socket: implement pktio_start and pktio_stop

2015-08-13 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- platform/linux-generic/pktio/socket.c | 29 + 1 file changed, 29 insertions(+) diff --git a/platform/linux-generic/pktio/socket.c b/platform/linux-generic/pktio/socket.c index 55c3594..0c56d70 100644 ---

Re: [lng-odp] [API-NEXT PATCH 2/6] linux-generic: loop: implement pktio_start and pktio_stop

2015-08-13 Thread Bill Fischofer
On Thu, Aug 13, 2015 at 6:45 AM, Maxim Uvarov maxim.uva...@linaro.org wrote: Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- platform/linux-generic/pktio/loop.c | 21 + 1 file changed, 21 insertions(+) diff --git a/platform/linux-generic/pktio/loop.c

[lng-odp] [PATCHv5 1/3] linux-generic: pktio: remove basic socket implementation

2015-08-13 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- example/generator/odp_generator.c | 1 - example/ipsec/odp_ipsec.c | 1 - example/packet/odp_pktio.c | 1 - .../linux-generic/include/odp_packet_io_internal.h |

[lng-odp] [PATCHv5 2/3] linux-generic: pktio: handle segmented packet in socket mode

2015-08-13 Thread Nicolas Morey-Chaisemartin
Fixes bug #1670 Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- platform/linux-generic/include/odp_packet_socket.h | 3 - platform/linux-generic/pktio/socket.c | 85 +++--- 2 files changed, 57 insertions(+), 31 deletions(-) diff --git

[lng-odp] [PATCHv5 0/3] Remove basic pktio sock and support segmented packet​

2015-08-13 Thread Nicolas Morey-Chaisemartin
Changes since v4: Fixed bug by rewriting packet allocation to use _odp_packet_alloc() to allocate the largest possible packet instead of (wrongly) computing it from segment length. Also dropped now unused data from pkt_sock_t Changes since v3: Fix long line Make pktio_suite_init static

[lng-odp] [API-NEXT PATCH 6/6] linux-generic: default state for pktio is STOP

2015-08-13 Thread Maxim Uvarov
After open pktio remains stopped. Inside worker thread (after all configuration done it should be started.) In that patch I just start it everywhere to keep original logic and be easy for review. Putting it inside worker threads will require thread arguments change and understanding logic of

[lng-odp] [Bug 1542] Untested API verify_pmr_ip_proto

2015-08-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1542 --- Comment #2 from Bala Manoharan bala.manoha...@linaro.org --- V2 submitted: https://patches.linaro.org/52328/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

[lng-odp] [Bug 1545] Untested API verify_pmr_tcp_dport

2015-08-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1545 --- Comment #2 from Bala Manoharan bala.manoha...@linaro.org --- v2 submitted: https://patches.linaro.org/52328/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

[lng-odp] [Bug 1544] Untested API verify_pmr_tcp_sport

2015-08-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1544 --- Comment #2 from Bala Manoharan bala.manoha...@linaro.org --- v2 submitted: https://patches.linaro.org/52328/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

[lng-odp] [Bug 1546] Untested API verify_pmr_udp_dport

2015-08-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1546 --- Comment #2 from Bala Manoharan bala.manoha...@linaro.org --- v2 submitted: https://patches.linaro.org/52328/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

Re: [lng-odp] [API-NEXT PATCH 2/6] linux-generic: loop: implement pktio_start and pktio_stop

2015-08-13 Thread Maxim Uvarov
On 08/13/15 15:44, Bill Fischofer wrote: @@ -72,6 +76,9 @@ static int loopback_send(pktio_entry_t *pktio_entry, odp_packet_t pkt_tbl[], queue_entry_t *qentry; unsigned i; + if (pktio_entry-s.state == STATE_STOP) + return 0; +

[lng-odp] [API-NEXT PATCH v3 3/3] validation: packet: test if user area is properly set

2015-08-13 Thread Zoltan Kiss
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- test/validation/packet/packet.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/test/validation/packet/packet.c b/test/validation/packet/packet.c index 99a6745..36edc12 100644 ---

[lng-odp] ODP Website update: testing

2015-08-13 Thread Marshall Guillory
The Testing Results page should be easier to see results from jenkins/ci builds (along with the previous coverity badges). Please let Mike or I know if you find defects. http://www.opendataplane.org/testing/ -- Sincerely, Marshall Guillory Technical Program Enabler, Agile Coach, Scrum master

[lng-odp] [API-NEXT PATCH v3 1/3] api: pool: add packet user area initializer for pool creation parameters

2015-08-13 Thread Zoltan Kiss
Applications can preset certain parts of the packet user area, so when that memory will be allocated it starts from a known state. If the platform allocates the memory during pool creation, it's enough to run the constructor after that. If it's allocating memory on demand, it should call the

[lng-odp] [API-NEXT PATCH v3 2/3] linux-generic: pool: implement user area init support

2015-08-13 Thread Zoltan Kiss
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- platform/linux-generic/odp_pool.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c index 14221fd..2cc8441 100644 --- a/platform/linux-generic/odp_pool.c +++

[lng-odp] [API-NEXT PATCH v2] api: packet: allow access to packet RSS hash values

2015-08-13 Thread Zoltan Kiss
Applications can read the computed hash (if any) and set it if they changed the packet headers or if the platform haven't calculated the hash. Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- v2: - focus on RSS hash only - use setter/getter's include/odp/api/packet.h | 28

Re: [lng-odp] [PATCH 3/3] test: validation: system unitalicized variable

2015-08-13 Thread Bill Fischofer
s/unitalicized/uninitialized Autocorrect strikes again? On Thu, Aug 13, 2015 at 2:04 PM, Mike Holmes mike.hol...@linaro.org wrote: It is possible that a code change leaves s=NULL; default char_ok to failure Signed-off-by: Mike Holmes mike.hol...@linaro.org ---

[lng-odp] [PATCH 1/3] test: validation: mask_common: remove unused variable

2015-08-13 Thread Mike Holmes
str_sz is not used, remove it Signed-off-by: Mike Holmes mike.hol...@linaro.org --- test/validation/common/mask_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/validation/common/mask_common.c b/test/validation/common/mask_common.c index fce7725..119c2bb 100644

Re: [lng-odp] [API-NEXT PATCH v2] api: packet: allow access to packet RSS hash values

2015-08-13 Thread Bill Fischofer
On Thu, Aug 13, 2015 at 12:52 PM, Zoltan Kiss zoltan.k...@linaro.org wrote: Applications can read the computed hash (if any) and set it if they changed the packet headers or if the platform haven't calculated the hash. Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- v2: - focus on

[lng-odp] [PATCH 2/3] test: validation: classification: unused variable

2015-08-13 Thread Mike Holmes
retval is not used, remove it Signed-off-by: Mike Holmes mike.hol...@linaro.org --- test/validation/classification/odp_classification_tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/validation/classification/odp_classification_tests.c

[lng-odp] [PATCH 3/3] test: validation: system unitalicized variable

2015-08-13 Thread Mike Holmes
It is possible that a code change leaves s=NULL; default char_ok to failure Signed-off-by: Mike Holmes mike.hol...@linaro.org --- test/validation/system/system.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/validation/system/system.c b/test/validation/system/system.c

Re: [lng-odp] [PATCH 1/3] test: validation: mask_common: remove unused variable

2015-08-13 Thread Bill Fischofer
Actually, let me rescind that reviewed-by. See comments inline. On Thu, Aug 13, 2015 at 2:41 PM, Bill Fischofer bill.fischo...@linaro.org wrote: On Thu, Aug 13, 2015 at 2:04 PM, Mike Holmes mike.hol...@linaro.org wrote: str_sz is not used, remove it Signed-off-by: Mike Holmes

Re: [lng-odp] [API-NEXT PATCH v3 3/3] validation: packet: test if user area is properly set

2015-08-13 Thread Bill Fischofer
Note: I've verified that this also passes, as expected, when the checkpatch issue identified in Part 2/3 is resolved by removing the extra parens. On Thu, Aug 13, 2015 at 12:28 PM, Zoltan Kiss zoltan.k...@linaro.org wrote: Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org

Re: [lng-odp] [API-NEXT PATCH v3 2/3] linux-generic: pool: implement user area init support

2015-08-13 Thread Bill Fischofer
On Thu, Aug 13, 2015 at 12:28 PM, Zoltan Kiss zoltan.k...@linaro.org wrote: Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- platform/linux-generic/odp_pool.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/platform/linux-generic/odp_pool.c

Re: [lng-odp] [PATCH 1/3] test: validation: mask_common: remove unused variable

2015-08-13 Thread Bill Fischofer
On Thu, Aug 13, 2015 at 2:04 PM, Mike Holmes mike.hol...@linaro.org wrote: str_sz is not used, remove it Signed-off-by: Mike Holmes mike.hol...@linaro.org Reviewed-by: Bill Fischofer bill.fischo...@linaro.org --- test/validation/common/mask_common.c | 2 +- 1 file changed, 1

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: pool: add packet user area initializer for pool creation parameters

2015-08-13 Thread Bill Fischofer
Some grammatical nits: On Thu, Aug 13, 2015 at 12:28 PM, Zoltan Kiss zoltan.k...@linaro.org wrote: Applications can preset certain parts of the packet user area, so when that memory will be allocated it starts from a known state. If the platform allocates the memory during pool creation, it's

[lng-odp] [Bug 1615] odp_timer fails in CI with Segmentation fault

2015-08-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1615 --- Comment #7 from Mike Holmes mike.hol...@linaro.org --- Patch committed https://git.linaro.org/lng/odp.git/commit/6788a0e25b2f9c244668cf3d6f71d0f2eaefd32f That may provide the fix, watching CI for re-occurrence. -- You are receiving this mail

Re: [lng-odp] [PATCH 2/3] test: validation: classification: unused variable

2015-08-13 Thread Bill Fischofer
On Thu, Aug 13, 2015 at 2:04 PM, Mike Holmes mike.hol...@linaro.org wrote: retval is not used, remove it Signed-off-by: Mike Holmes mike.hol...@linaro.org --- test/validation/classification/odp_classification_tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [lng-odp] [PATCH] linux-generic: pktio: always test loop interface

2015-08-13 Thread Mike Holmes
ping - can we close this for 1.3 ? On 6 August 2015 at 06:22, Maxim Uvarov maxim.uva...@linaro.org wrote: On 08/06/15 12:55, Stuart Haslam wrote: Test using the loop interface even when running as root. https://bugs.linaro.org/show_bug.cgi?id=1735 Signed-off-by: Stuart Haslam

[lng-odp] [Bug 1615] odp_timer fails in CI with Segmentation fault

2015-08-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1615 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Assignee|christian.ziet...@linaro.or |lng-odp@lists.linaro.org

[lng-odp] [Bug 1746] checkpatch.pl generates warning on ODP long function

2015-08-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1746 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Priority|--- |Lowest

[lng-odp] [Bug 1670] Segmented packet not supported by socket pktio

2015-08-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1670 --- Comment #13 from Mike Holmes mike.hol...@linaro.org --- Latest v5 http://patches.opendataplane.org/patch/2732/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp