Re: [lng-odp] [API-NEXT PATCH] linux-generic: tm: use intermediate casts to avoid strict warnings

Macros would probably be a good idea, however I wanted to get this fix in now and let Alex and/or Barry recommend further code restructure based on their more thorough analysis. This isn't the first time M32_ON_64 issues have been flagged. I've added testing with this to my own checklist and it

Re: [lng-odp] [API-NEXT PATCHv2 5/5] example: classifier: add odp_cls_cos_pool_set() api

On 23.11.15 12:12, Balasubramanian Manoharan wrote: Adds packet pool to CoS using odp_cls_cos_pool_set() api. Signed-off-by: Balasubramanian Manoharan --- example/classifier/odp_classifier.c | 37 ++--- 1 file changed, 30

[lng-odp] [Bug 1905] CID 154167: Memory - illegal accesses: /helper/lineartable.c

https://bugs.linaro.org/show_bug.cgi?id=1905 --- Comment #2 from Mike Holmes --- (In reply to huanggaoyang from comment #1) > checked the length of the input name at the beginning. > 74 if (strlen(name) >= ODPH_TABLE_NAME_LEN || capacity < 1 || > 75

Re: [lng-odp] [API-NEXT 0/3] Add validation for crypto auth decoding

These should apply to master not API-NEXT since they don't touch the API. On 27 November 2015 at 03:42, Nicolas Morey-Chaisemartin wrote: > This adds tests for the auth/hash check function in crypto > > Nicolas Morey-Chaisemartin (3): > validation: crypto: support auth

Re: [lng-odp] [API-NEXT 0/3] Add validation for crypto auth decoding

Except they do not apply on master because of the API in the crypto validation suite brought by the AES-GCM. On 11/30/2015 06:09 PM, Mike Holmes wrote: > These should apply to master not API-NEXT since they don't touch the API. > > > On 27 November 2015 at 03:42, Nicolas Morey-Chaisemartin

Re: [lng-odp] [API-NEXT PATCHv2 4/5] validation: classification: add odp_cls_cos_pool_set() api

Yes. This issue was pointed out by Stuart as well. I will add detailed test case to test pool allocation with Cos. Regards, Bala On 30 November 2015 at 14:49, Ivan Khoronzhuk wrote: > Hi, Bala > > I didn't look deep enough in this validation test but seems it doesn't

[lng-odp] [API-NEXT PATCH] linux-generic: tm: use intermediate casts to avoid strict warnings

Signed-off-by: Bill Fischofer --- .../include/odp_traffic_mngr_internal.h| 15 +++--- platform/linux-generic/odp_name_table.c| 58 -- platform/linux-generic/odp_pkt_queue.c | 12 ++---

Re: [lng-odp] [API-NEXT PATCHv12 0/3] Egress Traffic Manager

On 25 November 2015 at 08:25, Bill Fischofer wrote: > > > On Wed, Nov 25, 2015 at 6:45 AM, Anders Roxell > wrote: > >> On 25 November 2015 at 11:09, Maxim Uvarov >> wrote: >> > On 11/25/2015 01:01, Bill Fischofer

Re: [lng-odp] [API-NEXT 0/3] Add validation for crypto auth decoding

On 30 November 2015 at 12:28, Nicolas Morey-Chaisemartin wrote: > Except they do not apply on master because of the API in the crypto > validation suite brought by the AES-GCM. > Fair comment :) I did run them against api-next and saw no issues there, but I will double check,

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

On 30/11/15 13:31, Savolainen, Petri (Nokia - FI/Espoo) wrote: diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h index 01f770f..7b258c3 100644 --- a/include/odp/api/pool.h +++ b/include/odp/api/pool.h @@ -42,21 +42,25 @@ extern "C" { #define ODP_POOL_NAME_LEN 32 /** - *

Re: [lng-odp] [API-NEXT PATCH] api: init: allow implementation to use private ways for its own configuration

On 30/11/15 12:02, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] Sent: Thursday, November 26, 2015 4:35 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Cc: bill.fischo...@linaro.org;

[lng-odp] [PATCH 2/3] CHANGELOG: initial revision

With the addition of an RPM package to the existing debian package we need to have a single change log for the ODP API and the linux-generic implementation. The debian and RPM change logs then just list packaging changes. Create an initial copy of the old debian log. Signed-off-by: Mike Holmes

[lng-odp] [PATCH 3/3] update version number from v1.4.1.0 to v1.5.0.0

Signed-off-by: Mike Holmes --- CHANGELOG | 34 ++ include/odp/api/version.h | 4 ++-- pkg/debian/changelog | 5 + pkg/rpm/odp.spec | 2 ++ 4 files changed, 43 insertions(+), 2 deletions(-) diff --git

[lng-odp] [PATCH 1/3] Revert "update version number from v1.4.1.0 to v1.5.0.0"

This reverts commit 8cb80afde4a9e00cfea4bed5ecf721d6577793c4. --- include/odp/api/version.h | 4 ++-- pkg/debian/changelog | 36 2 files changed, 2 insertions(+), 38 deletions(-) diff --git a/include/odp/api/version.h b/include/odp/api/version.h index

Re: [lng-odp] [API-NEXT PATCH v3 6/7] api: time: make odp_local_time to be monotonic wall time

Why not just have one patch for API ... include/odp/api/time.h| 3 +- ... and move everything else in another patch(es). The old implementation and usage of the API is still functionally correct after API change. It may not be optimal (does not exploit the knowledge

Re: [lng-odp] [API-NEXT PATCH v3 7/7] validation: time: align tests with current time API

> -Original Message- > From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] > Sent: Monday, November 30, 2015 4:47 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH v3 7/7] validation: time: align > tests with

Re: [lng-odp] [PATCH] linux-generic: pktio: add tap pktio type

OK. I try to prepare them. Best regards, Ilya Maximets. On 27.11.2015 13:19, Maxim Uvarov wrote: > Hello Ilya, > > Thanks for sending that patch. Tap pktio should be interesting. > To accept it we also need coverage validation tests. > > Best regards, > Maxim. > > > On 11/25/2015 17:15, Ilya

Re: [lng-odp] [API-NEXT PATCH] api: init: allow implementation to use private ways for its own configuration

> -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Thursday, November 26, 2015 4:35 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Cc: bill.fischo...@linaro.org; mike.hol...@linaro.org > Subject: Re: [API-NEXT PATCH] api: init:

Re: [lng-odp] [API-NEXT PATCH v3 6/7] api: time: make odp_local_time to be monotonic wall time

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Ivan Khoronzhuk > Sent: Monday, November 23, 2015 11:21 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCH v3 6/7] api: time: make odp_local_time > to be monotonic wall

Re: [lng-odp] [API-NEXT PATCHv2 4/5] validation: classification: add odp_cls_cos_pool_set() api

Hi, Bala I didn't look deep enough in this validation test but seems it doesn't check pool assignments for CoS. To check if pool is correctly assigned to some CoS the separate pool should be created instead of using default. The default pool from pktio is used by CoS in case if special pool was

Re: [lng-odp] [PATCH v3 0/3] add warnings to improve timer usage

Merged, Maxim. On 11/19/2015 17:30, Ivan Khoronzhuk wrote: This series is intended to help user to set timer in frames that OS allows him. The timer resolution shouldn't be better than system allows, minimum timeout shouldn't be more than resolution, and warn application that CPU0, that is used

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

> > + > > + /** 0: User area content may be > overwritten when > > + packet is stored in the pool. If > init > > + callback function is defined, it > is > > +

Re: [lng-odp] [API-NEXT PATCH v3 1/7] validation: time: don't assign int directly to odp_time_t

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Ivan Khoronzhuk > Sent: Monday, November 23, 2015 11:21 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCH v3 1/7] validation: time: don't assign > int directly to

Re: [lng-odp] [API-NEXT PATCH v3 6/7] api: time: make odp_local_time to be monotonic wall time

On 30.11.15 16:07, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Ivan Khoronzhuk Sent: Monday, November 23, 2015 11:21 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT PATCH v3 6/7]

Re: [lng-odp] [API-NEXT PATCH v3 7/7] validation: time: align tests with current time API

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Ivan Khoronzhuk > Sent: Monday, November 23, 2015 11:21 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCH v3 7/7] validation: time: align tests > with current time API >

Re: [lng-odp] [API-NEXT PATCH v3 7/7] validation: time: align tests with current time API

On 30.11.15 16:17, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Ivan Khoronzhuk Sent: Monday, November 23, 2015 11:21 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT PATCH v3 7/7]