Re: [lng-odp] [API-NEXT PATCH v6] 0/9] api: time: update local time to be monotonic

Lets check with HO, they were applied fine last time. On 04.12.15 11:36, Maxim Uvarov wrote: Hello Ivan, The hole patch set looks like good. But it looks like patch order is wrong or some patches needs to be merged. If I apply only 8 patches there is error: Test:

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

> -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Thursday, December 03, 2015 8:27 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user > area init > > > >

Re: [lng-odp] [PATCHv2 0/3] TAP pktio

Hi Stuart, can you please also review that pktio change? Maxim. On 12/02/2015 16:13, Ilya Maximets wrote: Creates a new pktio type that allows for creating and sending/receiving packets through TAP interface. Detailed description in commit-message of patch "[PATCHv2 2/3] linux-generic: pktio:

Re: [lng-odp] [API-NEXT PATCH] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

Bill, here is the same problem which I had with mine updated IPC patches. odp-check says that there is no hash_main binary so test fails. I think something like that is needed. But it does not help: +++ b/test/validation/hash/Makefile.am @@ -3,7 +3,7 @@ include ../Makefile.inc

Re: [lng-odp] [PATCHv2] validation:pktio : Fix UDP checksum computation

On Thu, Oct 22, 2015 at 8:55 AM, wrote: > From: Grigore Ion > > The UDP checksum is computed in the CPU endianness. The returned result > must be converted to the BE ordering when it is used to update the UDP > checksum in a packet. > >

Re: [lng-odp] [PATCHv2] helper : Fix UDP checksum computation

On Thu, Oct 22, 2015 at 7:02 AM, wrote: > From: Grigore Ion > > This patch fixes the following problems: > - checksum computation for LE platforms > - checksum is computed in the CPU endianness. The returned result > must be converted to the

Re: [lng-odp] [PATCH] helper: fix strncpy in table support

On Thu, Dec 3, 2015 at 12:49 PM, Mike Holmes wrote: > Fixes Bug 1905 - CID 154167: > > Calling strncpy with a maximum size argument of ODP_TABLE_NAME_LEN > bytes on destination array tbl->name of size ODP_TABLE_NAME_LEN bytes > might leave the destination string

Re: [lng-odp] [PATCH] doc: build users and implementers guide in the build tree instead of the source tree

git clean -xdf && ./bootstrap && mkdir doctest && cd doctest && ../configure --enable-user-guides && make -C doc If you do this the doc will not have the images linked correctly, open the html to see this odp/doctest/doc/output/users-guide.html Currently the images get generated and stay in the

Re: [lng-odp] [PATCHv2] helper : Fix UDP checksum computation

Hi, What is the status of this patch ? Example or test applications using odph_ipv4_udp_chksum function may fail on LE platforms. Thanks, Grig -Original Message- From: ion.grig...@freescale.com [mailto:ion.grig...@freescale.com] Sent: Thursday, October 22, 2015 3:03 PM To:

Re: [lng-odp] [API-NEXT PATCH] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

Per our discussion a few moments ago, When I run the following: GIT_BRANCH=api-next PATCH_DIR=$HOME/linaro/tmcrcfix CLEANUP=0 ./build.sh it executes cleanly for me, so I'm not sure what the problem is. On Fri, Dec 4, 2015 at 5:52 AM, Maxim Uvarov wrote: > Bill, here

[lng-odp] [API-NEXT PATCH v7 0/9] api: time: update local time to be monotonic

This series is intended to modify time API to be used as monotonic wall time in order to simplify time API usage and create prerequisites for adding global time API. Since v6: - changed patch order a little to pass validation tests - fixed issue with pktio perf test - no functional changes Since

[lng-odp] [API-NEXT PATCH v7 1/9] validation: time: don't assign int directly to odp_time_t

Under opaque type can be structure that cannot be used with direct values, So, use conversion functions to get time_t to avoid build issues. Reviewed-by: Petri Savolainen Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 4

[lng-odp] [API-NEXT PATCH v7 2/9] test: performance: pktio: don't use direct arithmetic operations with odp_time_t

It was missed while unbinding cycles from time API names. Correct is as it prevents for adding structure under odp_time_t. Reviewed-by: Petri Savolainen Signed-off-by: Ivan Khoronzhuk --- test/performance/odp_pktio_perf.c | 9 ++--- 1

[lng-odp] [API-NEXT PATCH v7 3/9] linux-generic: schedule: use schedule time in ns

In the schedule_loop the wait time is passed in units of scheduler time. At this moment there is no difference between wait time and odp_time, but in case if odp_time is smth different from uint64_t, it cannot be directly passed as uint64_t. So better to pass scheduler time as ns and convert them

[lng-odp] [API-NEXT PATCH v7 8/9] linux-generic: align with new wall time API

The local time API supposes the time source is wall time. So correct linux-generic implementation. Reviewed-by: Petri Savolainen Signed-off-by: Ivan Khoronzhuk --- platform/linux-generic/include/odp_internal.h | 2 +

[lng-odp] [API-NEXT PATCH v7 7/9] validation: time: align tests with current time API

Add test for odp_time_sum, odp_time_cmp, odp_time_to_u64 APIs. Sophisticate a little tests for odp_time_diff, odp_time_local_from_ns, odp_time_local_to_ns APIs. Check time on monotony. Reviewed-by: Petri Savolainen Signed-off-by: Ivan Khoronzhuk

[lng-odp] [API-NEXT PATCH v7 6/9] api: time: make odp_local_time to be monotonic wall time

It's more convenient the local time to be a monotonic wall time. That means time starts from 0 and not wraps. It allows to use local time in similar manner as it's supposed to be used with global time and the 64-bit timer is enough to guarantee it. Reviewed-by: Petri Savolainen

[lng-odp] [API-NEXT PATCH v7 5/9] performance: sched: use ODP time API instead of clock_gettime

The time API can be used instead of Posix clock_gettime as more accurate and OS independent. Reviewed-by: Petri Savolainen Signed-off-by: Ivan Khoronzhuk --- test/performance/odp_scheduling.c | 37 + 1

Re: [lng-odp] [PATCH] validation: scheduler: use fail timeout when waiting on events in chaos

On Thu, Dec 3, 2015 at 10:37 AM, Ivan Khoronzhuk wrote: > In case if smth bad was happened and events are not received, > it's better finish than looping forever. > > Signed-off-by: Ivan Khoronzhuk > Reviewed-by: Bill Fischofer

[lng-odp] [PATCH] doc: guides: embed icons and images in html

The icons in the generated guide have a system dependent location. If the system used to view the docs does not have asciidoc installed no icons will be displayed. Embed the images so that the output is self-contained. Signed-off-by: Mike Holmes ---

[lng-odp] [API-NEXT PATCH v7 9/9] test/example: use local time API as wall time

The local time API is supposed to behave like wall time now, so correct it in examples and tests. Reviewed-by: Petri Savolainen Signed-off-by: Ivan Khoronzhuk --- example/generator/odp_generator.c | 10 +-

Re: [lng-odp] [API-NEXT PATCH v6] 0/9] api: time: update local time to be monotonic

Maxim, I've corrected the defects in v7. Please, merge. On 04.12.15 11:36, Maxim Uvarov wrote: Hello Ivan, The hole patch set looks like good. But it looks like patch order is wrong or some patches needs to be merged. If I apply only 8 patches there is error: Test: