Re: [lng-odp] [PATCH] example: classifier: fix add queue param init call

On Fri, Dec 11, 2015 at 02:46:28PM +0530, Balasubramanian Manoharan wrote: > Fixes crash caused by queue param not being initialized. > > Signed-off-by: Balasubramanian Manoharan That fixed it.. Reviewed-by: Stuart Haslam > --- >

Re: [lng-odp] [PATCH] configure.ac: add user_guides config status

Merged. On 12/11/2015 02:17, Bill Fischofer wrote: On Thu, Dec 10, 2015 at 3:08 PM, Mike Holmes > wrote: Signed-off-by: Mike Holmes > Reviewed-by: Bill Fischofer

Re: [lng-odp] [PATCH] example: classifier: fix add queue param init call

Ok, you added that init() inside that commit of api-next: commit 8da0ee0b2a43bfdd5b0d37d2d2a10a45bbf2d7bd Author: Balasubramanian Manoharan Date: Thu Dec 3 16:16:06 2015 +0530 example: classifier: add odp_cls_cos_pool_set() api Adds packet pool to CoS

Re: [lng-odp] [PATCH] example: classifier: fix add queue param init call

It is fine from my side. Regards, Bala On 11 December 2015 at 14:56, Maxim Uvarov wrote: > Ok, you added that init() inside that commit of api-next: > > commit 8da0ee0b2a43bfdd5b0d37d2d2a10a45bbf2d7bd > Author: Balasubramanian Manoharan >

Re: [lng-odp] [API-NEXT PATCH v3] api: atomic: added atomic_lock_free_u64

Merged with spell fix. Maxim. On 11/12/2015 11:30, Petri Savolainen wrote: Platforms may support some uint64 operations lock-free and others not. For example, inc_64 can be natively supported but cas_64 (or max_64/min_64) not. User may be able to switch to 32 bit variables when a 64 bit

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

On 11.12.2015 12:19, Maxim Uvarov wrote: > On 12/11/2015 10:39, Ilya Maximets wrote: >> Comments inlined. >> >> On 10.12.2015 12:59, ion.grig...@freescale.com wrote: >>> From: Grigore Ion >>> >>> This patch fixes the following problems: >>> - checksum computation for LE

[lng-odp] [API-NEXT PATCH 1/2] api: barrier: added memory barriers

Added new memory barriers. These follow C11 release / acquire specification and replaces odp_sync_stores(). Used GCC __atomic_thread_fence to implement all three barriers. Signed-off-by: Petri Savolainen --- include/odp/api/barrier.h | 11 -

[lng-odp] [API-NEXT PATCH 2/2] api: sync: removed odp_sync_stores

Removed odp_sync_stores() implementation and replaced usage with odp_mb_full(), to minimize functional changes. Added minimal validation test function for the new memory barriers. Signed-off-by: Petri Savolainen --- platform/linux-generic/include/odp/sync.h | 5

Re: [lng-odp] [API-NEXT PATCH v2 4/5] linux-generic: netmap: add multi queue support

On Wed, Nov 25, 2015 at 03:15:52PM +0200, Matias Elo wrote: > Added multi queue support to netmap pktio. > > Signed-off-by: Matias Elo > --- > platform/linux-generic/include/odp_packet_netmap.h | 34 +- > platform/linux-generic/pktio/netmap.c | 426 >

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

Patch posted to fix the issue in odp_classifier. odp_generator is working but showing the following error message continuously. === ktio/netmap.c:139:netmap_open():nm_open(netmap:lo:1) failed odp_timer.c:641:timer_notify(): 2 ticks overrun on timer pool "timer_pool", timer

Re: [lng-odp] [API-NEXT PATCH v3] api: atomic: added atomic_lock_free_u64

Does your checkpatch warns on spelling? I will fix on apply. WARNING: 'substract' may be misspelled - perhaps 'subtract'? #43: FILE: include/odp/api/atomic.h:403: +uint32_t fetch_sub : 1; /**< Atomic fetch and substract */ WARNING: 'substract' may be misspelled - perhaps 'subtract'?

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

Something else but related to the reliable computation of checksums. If you look how odp_chksum() is used e.g. in the packet generator example (pack_icmp_pkt function), there is a lot of pointer casting and writes to the resulting IPv4 and ICMP structures. Then we call odp_chksum() (which is

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: time: remove posix bleed through on odp_time_t

On 12/11/2015 16:30, Bill Fischofer wrote: On Fri, Dec 11, 2015 at 7:27 AM, Maxim Uvarov > wrote: On 12/11/2015 16:22, Bill Fischofer wrote: The linux-generic implementation of odp_time_t makes use of POSIX APIs

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

Comments inlined -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Friday, December 11, 2015 11:20 AM To: Ilya Maximets ; Grigore Ion-B17953 ; lng-odp@lists.linaro.org Subject: Re: [PATCHv6] helper : Fix UDP

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: time: remove posix bleed through on odp_time_t

On Fri, Dec 11, 2015 at 7:27 AM, Maxim Uvarov wrote: > On 12/11/2015 16:22, Bill Fischofer wrote: > >> The linux-generic implementation of odp_time_t makes use of POSIX >> APIs that are sensitive to the _POSIX_C_SOURCE level. Use an indirection >> mechanism so that these

Re: [lng-odp] [API-NEXT PATCH v2 4/5] linux-generic: netmap: add multi queue support

> -Original Message- > From: EXT Stuart Haslam [mailto:stuart.has...@linaro.org] > Sent: Friday, December 11, 2015 2:25 PM > To: Elo, Matias (Nokia - FI/Espoo) > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH v2 4/5] linux-generic: netmap: add

Re: [lng-odp] [PATCH] api: pktio link status

Wouldn't be the application code more clear if the function is renamed to _link_up()? Return values clearly suggest this. The application has to remember that 1 means link up and 0 means link down. Alex On 11 December 2015 at 14:44, Maxim Uvarov wrote: >

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: time: remove posix bleed through on odp_time_t

On 12/11/2015 16:22, Bill Fischofer wrote: The linux-generic implementation of odp_time_t makes use of POSIX APIs that are sensitive to the _POSIX_C_SOURCE level. Use an indirection mechanism so that these dependencies do not "bleed through" the ODP API. This means that ODP applications can be

Re: [lng-odp] [PATCH] example: classifier: fix add queue param init call

Merged, Maxim. On 12/11/2015 13:03, Stuart Haslam wrote: On Fri, Dec 11, 2015 at 02:46:28PM +0530, Balasubramanian Manoharan wrote: Fixes crash caused by queue param not being initialized. Signed-off-by: Balasubramanian Manoharan That fixed it.. Reviewed-by:

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

On 11 December 2015 at 15:07, Ion Grigore wrote: > Comments inlined > > -Original Message- > From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Friday, December 11, 2015 11:20 AM > To: Ilya Maximets ; Grigore Ion-B17953 < >

[lng-odp] [API-NEXT PATCHv2] linux-generic: time: remove posix bleed through on odp_time_t

The linux-generic implementation of odp_time_t makes use of POSIX APIs that are sensitive to the _POSIX_C_SOURCE level. Use an indirection mechanism so that these dependencies do not "bleed through" the ODP API. This means that ODP applications can be independent of _POSIX_C_SOURCE level.

Re: [lng-odp] [PATCH] api: pktio link status

Mail subject should be: [API-NEXT PATCH] api: pktio: added link status Otherwise OK. Could you update the git log entry before merging: "api: pktio: added link status" Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp

[lng-odp] Deprecation of APIs

I wanted to bring up a point that is going to become increasingly important in 2016 and beyond. To date as we've been polishing up the ODP API we've been somewhat abrupt in removing deprecated APIs. Now that we have key initiatives like OFP using ODP, that needs to change. ODP has had the

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: time: remove posix bleed through on odp_time_t

No, that's what changed in _POSIX_C_SOURCE 200809L. If you wade through all the various levels of indirection in /usr/include/time.h in all cases it uses two signed 64-bit ints. It just calls them either long or long long depending on the environment. On Fri, Dec 11, 2015 at 10:33 AM,

Re: [lng-odp] [PATCH] test/performance: pktio: perform an initial warmup run

ping - needs review. On 28 October 2015 at 18:45, Stuart Haslam wrote: > The results from the initial test run are often worse than would > normally be expected due to there being no warm up phase. As a > simple way to warm up run first test stage twice, ignoring the >

[lng-odp] [PATCHv2] validation: pktio: test batch receive

Modify the tests that currently transmit packets in batches to also receive packets in batches. This adds coverage of odp_queue_deq_multi() and odp_schedule_multi() specifically against a packet input queue, as this doesn't get tested anywhere else in the validation suite. Signed-off-by: Stuart

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

On 11.12.2015 18:28, Ion Grigore wrote: > > Comments inlined > > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Friday, December 11, 2015 5:24 PM > To: Grigore Ion-B17953 ; Maxim Uvarov > ;

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: time: remove posix bleed through on odp_time_t

To me it seems that "ODP timespec" and Linux timespec have still different field sizes when 'long' is 32 bits. Does this work in the 32 bit build? Struct fields in the union do not point to the same locations when field sizes do not match. -Petri Lähettäjä:

Re: [lng-odp] [PATCHv5 2/4] validation: pktio: ability to wait for external network

On Thu, Dec 10, 2015 at 06:32:02PM +0300, Ilya Maximets wrote: > 'ODP_WAIT_FOR_NETWORK' environment variable may be used > to wait some time right after pktio_open(). > > Signed-off-by: Ilya Maximets > --- > > 'ODP_WAIT_FOR_NETWORK' also may be used to remove sleep(1) >

Re: [lng-odp] [PATCHv5 0/4] TAP pktio

On Thu, Dec 10, 2015 at 06:32:00PM +0300, Ilya Maximets wrote: > Creates a new pktio type that allows for creating and > sending/receiving packets through TAP interface. > Detailed description in commit-message of patch > "[PATCHv5 3/4] linux-generic: pktio: add tap pktio type". > > Changelog: >

Re: [lng-odp] [PATCHv3] doc: userguide: add application programming section

The checkpatch warning is not present with the CI like version of Ubuntu [1], I see that on 15.04 it is not a checkpatch issue. [1] https://hub.docker.com/r/roxell/check-odp-ubuntu/ On 11 December 2015 at 10:18, Mike Holmes wrote: > > > On 11 December 2015 at 10:08,

Re: [lng-odp] [PATCHv3] doc: userguide: add application programming section

On 11 December 2015 at 10:08, Bill Fischofer wrote: > The problem is that this is documentation text (pseudocode) not code and > yet some tools insist on trying to treat it as if it's a code patch. > Checkpatch should not apply to documentation this way. > In this

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

On 11.12.2015 18:47, Ion Grigore wrote: > A more precise question. Did you check on a LE platform ? Yes. On my LE i7. > - /* Fold sum to 16 bits: add carrier to result */ > - while (sum >> 16) > - sum = (sum & 0x) + (sum >> 16); > - > +

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

Comments inlined -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Friday, December 11, 2015 5:40 PM To: Grigore Ion-B17953 ; Maxim Uvarov ; lng-odp@lists.linaro.org Subject: Re: [PATCHv6] helper : Fix UDP

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

A more precise question. Did you check on a LE platform ? -Original Message- From: Grigore Ion-B17953 Sent: Friday, December 11, 2015 5:44 PM To: 'Ilya Maximets' ; Maxim Uvarov ; lng-odp@lists.linaro.org Subject: RE: [PATCHv6] helper :

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

On 11.12.2015 17:07, Ion Grigore wrote: > Comments inlined > > -Original Message- > From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Friday, December 11, 2015 11:20 AM > To: Ilya Maximets ; Grigore Ion-B17953 > ;

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

Comments inlined -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Friday, December 11, 2015 5:24 PM To: Grigore Ion-B17953 ; Maxim Uvarov ; lng-odp@lists.linaro.org Subject: Re: [PATCHv6] helper : Fix UDP

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

Ok. I'll check your proposal on BE/LE. -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Friday, December 11, 2015 5:54 PM To: Grigore Ion-B17953 ; Maxim Uvarov ; lng-odp@lists.linaro.org Subject: Re:

Re: [lng-odp] [API-NEXT/PATCH] fix: classification: add null check for pool assigned to CoS

Reviewed-and-Tested-by: Maxim Uvarov On 12/11/2015 11:34, Balasubramanian Manoharan wrote: Fixes a crash caused by pool not assigned to CoS. Signed-off-by: Balasubramanian Manoharan --- platform/linux-generic/pktio/pktio_common.c | 5

[lng-odp] [PATCH] example: classifier: fix add queue param init call

Fixes crash caused by queue param not being initialized. Signed-off-by: Balasubramanian Manoharan --- example/classifier/odp_classifier.c | 1 + 1 file changed, 1 insertion(+) diff --git a/example/classifier/odp_classifier.c b/example/classifier/odp_classifier.c

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

On 12/11/2015 10:39, Ilya Maximets wrote: Comments inlined. On 10.12.2015 12:59, ion.grig...@freescale.com wrote: From: Grigore Ion This patch fixes the following problems: - checksum computation for LE platforms - checksum is computed in the CPU endianness. The

[lng-odp] [API-NEXT/PATCHv2] pktio: linux-generic: add null check for pool assigned to CoS

Fixes a crash caused by pool not assigned to CoS. Signed-off-by: Balasubramanian Manoharan Reviewed-and-Tested-by: Maxim Uvarov --- v2: patch subject updated to ODP format platform/linux-generic/pktio/pktio_common.c | 5 +++-- 1 file

[lng-odp] [PATCH] doc/users-guide: add helpers section

Signed-off-by: Mike Holmes --- doc/users-guide/users-guide.adoc | 161 +++ 1 file changed, 161 insertions(+) diff --git a/doc/users-guide/users-guide.adoc b/doc/users-guide/users-guide.adoc index cf77fa0..d2e1a16 100644 ---

[lng-odp] [PATCHv4] doc: userguide: add application programming section

Complete the reformatting to standard asciidoc style, expand the ODP Application Programming section, and include a reorganized and expanded discussion of ODP queues. Signed-off-by: Bill Fischofer --- doc/users-guide/users-guide.adoc | 450

[lng-odp] [PATCH] api: pktio link status

Signed-off-by: Maxim Uvarov --- v1 was link_state(), now it's link_status(). include/odp/api/packet_io.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h index 443841e..8999b2c 100644 ---

Re: [lng-odp] [PATCHv4] doc: userguide: add application programming section

On 11 December 2015 at 12:23, Bill Fischofer wrote: > Complete the reformatting to standard asciidoc style, expand the > ODP Application Programming section, and include a reorganized and > expanded discussion of ODP queues. > > Signed-off-by: Bill Fischofer

[lng-odp] [API-NEXT/PATCH] fix: classification: add null check for pool assigned to CoS

Fixes a crash caused by pool not assigned to CoS. Signed-off-by: Balasubramanian Manoharan --- platform/linux-generic/pktio/pktio_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/pktio/pktio_common.c