Re: [lng-odp] [PATCH v2] validation: system: add validation tests for odp_cpu_cycles_* calls

2016-01-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Ivan Khoronzhuk > Sent: Friday, January 15, 2016 11:16 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH v2] validation: system: add validation tests for > odp_cpu_cycles_* calls

Re: [lng-odp] [PATCH v4 API-NEXT 00/12] Separate CPU info codes into their platform files

2016-01-15 Thread Maxim Uvarov
Hello Hongbo, changes looks good, please rebase it on top of the latest api-next. Thanks, Maxim. On 01/07/2016 10:38, hongbo.zh...@linaro.org wrote: From: Hongbo Zhang v3->v4 changes: - update patch 9 of platform naming - add new patch 12 to rename cpu_hz to

Re: [lng-odp] [PATCH] test: change l2fwd pool size

2016-01-15 Thread Bill Fischofer
On Thu, Jan 14, 2016 at 11:12 AM, Zoltan Kiss wrote: > The current code looks awkward, it defines pkt.num as 564. Clean that up > and set it to 8k to make sure even several big descriptor rings could be > accomodated. > > Signed-off-by: Zoltan Kiss

Re: [lng-odp] [PATCH v3] Test program to measure crypto operation performance.

2016-01-15 Thread Maxim Uvarov
So I think we can accept that patch and use time api later. Does somebody want to review it? Maxim. On 01/04/2016 18:47, Bill Fischofer wrote: Averages over many iterations will smooth out variances, differences due to cache warming, etc. Additionally, the performance of any API will vary in

Re: [lng-odp] [PATCHv19 9/9] linux-generic: internal ipc_pktio test

2016-01-15 Thread Stuart Haslam
On Mon, Dec 21, 2015 at 01:56:11PM +0300, Maxim Uvarov wrote: > 2 example ipc pktio applications create ipc pktio to each other and do > packet transfer, validation magic numbers and packets sequence counters > inside it. > It looks like there's a race somewhere as I get occasional failures: #2

Re: [lng-odp] [API-NEXT PATCHv4 2/2] doc: update CONTRIBUTING and DEPENDENCIES files for images

2016-01-15 Thread Bill Fischofer
I have no objection to keeping PDF capability, however the question is can PDFs use .svgs? If yes, then we can still use v4 of the patch. If not then given that we'd still need the .eps conversions would this patch series have utility at all? On Fri, Jan 15, 2016 at 4:00 AM, Maxim Uvarov

Re: [lng-odp] [PATCH v2] validation: system: add validation tests for odp_cpu_cycles_* calls

2016-01-15 Thread Ivan Khoronzhuk
On 15.01.16 13:54, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Ivan Khoronzhuk Sent: Friday, January 15, 2016 11:16 AM To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH v2] validation:

Re: [lng-odp] [PATCH] DEPENDENCIES: add librsvg2-bin to HTML

2016-01-15 Thread Maxim Uvarov
Merged. Maxim. On 01/15/2016 01:23, Anders Roxell wrote: Signed-off-by: Anders Roxell --- DEPENDENCIES | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/DEPENDENCIES b/DEPENDENCIES index fec65d2..3563b36 100644 --- a/DEPENDENCIES +++

Re: [lng-odp] [PATCH] example: classifier: use SCN macro to scan uint32_t

2016-01-15 Thread Maxim Uvarov
that was merged, Maxim. On 01/13/2016 14:20, Stuart Haslam wrote: On Wed, Jan 13, 2016 at 02:15:28PM +0300, Maxim Uvarov wrote: SCN produced some buggy scanning here which leads to broken rules set from command line and example did not work as expected. Originally there was SCN and it was

Re: [lng-odp] [PATCHv19 8/9] linux-generic: add ipc pktio support

2016-01-15 Thread Stuart Haslam
On Mon, Dec 21, 2015 at 01:56:10PM +0300, Maxim Uvarov wrote: > Signed-off-by: Maxim Uvarov > --- > platform/linux-generic/Makefile.am | 3 + > .../linux-generic/include/odp_buffer_internal.h| 3 + >

[lng-odp] [PATCH v3] validation: system: add validation tests for odp_cpu_cycles_* calls

2016-01-15 Thread Ivan Khoronzhuk
https://bugs.linaro.org/show_bug.cgi?id=1906 Signed-off-by: Ivan Khoronzhuk --- Since v2: - added c <= max - replaced etalon on tmp - added msg about skip - handled resolution wrap test/validation/system/system.c | 133

[lng-odp] [Bug 1706] odp_term_local() not being called from main thread

2016-01-15 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1706 Bill Fischofer changed: What|Removed |Added CC|

[lng-odp] What to do regarding cahe non coherant systems

2016-01-15 Thread Christophe Milard
On Tuesday's ARCH call, we will be discussing the above topic. Nicolas (Kalray) will try to join, but he is very uncertain at this stage (if he can be there)... ___ lng-odp mailing list lng-odp@lists.linaro.org

[lng-odp] [Bug 1992] New: odp_generator timer tick overruns

2016-01-15 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1992 Bug ID: 1992 Summary: odp_generator timer tick overruns Product: OpenDataPlane - linux- generic reference Version: 1.6 Hardware: Other OS: Linux Status: UNCONFIRMED

Re: [lng-odp] [PATCH v3] validation: system: add validation tests for odp_cpu_cycles_* calls

2016-01-15 Thread Ivan Khoronzhuk
On 15.01.16 15:34, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Friday, January 15, 2016 2:33 PM To: lng-odp@lists.linaro.org Cc: Savolainen, Petri (Nokia - FI/Espoo); Ivan Khoronzhuk Subject:

[lng-odp] [PATCH v4] validation: system: add validation tests for odp_cpu_cycles_* calls

2016-01-15 Thread Ivan Khoronzhuk
https://bugs.linaro.org/show_bug.cgi?id=1906 Signed-off-by: Ivan Khoronzhuk --- Since v3: - modified log "wrap is not detected" - increased try num for diff to match 16 seconds - decreased try num for resolution to match 1 second - allow resolution to be up to max /

Re: [lng-odp] [PATCH] test/performance: pktio: perform an initial warmup run

2016-01-15 Thread Stuart Haslam
ping^2 On 11 December 2015 at 16:54, Stuart Haslam wrote: > ping - needs review. > > On 28 October 2015 at 18:45, Stuart Haslam wrote: >> The results from the initial test run are often worse than would >> normally be expected due to there

[lng-odp] [Bug 1992] odp_generator timer tick overruns

2016-01-15 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1992 Ivan Khoronzhuk changed: What|Removed |Added CC|

[lng-odp] [PATCH v5] validation: system: add validation tests for odp_cpu_cycles_* calls

2016-01-15 Thread Ivan Khoronzhuk
https://bugs.linaro.org/show_bug.cgi?id=1906 Signed-off-by: Ivan Khoronzhuk --- test/validation/system/system.c | 130 test/validation/system/system.h | 4 ++ 2 files changed, 134 insertions(+) diff --git

Re: [lng-odp] [PATCH] validation: pktio: don't continue if packet with > MTU is sent

2016-01-15 Thread Ivan Khoronzhuk
On 15.01.16 17:51, Stuart Haslam wrote: On Wed, Jan 13, 2016 at 06:46:57PM +0200, Ivan Khoronzhuk wrote: If packet with size > MTU is sent the test can crash farther, so better to stop here. Signed-off-by: Ivan Khoronzhuk Signed-off-by: Stuart Haslam

[lng-odp] [API-NEXT PATCH v2 1/3] validation: cls: adopt for supported l3 PMR

2016-01-15 Thread Ivan Khoronzhuk
The classification tests should use supported l3 PMR where it's not important. For validating concrete PMRs the separate test exists. Signed-off-by: Ivan Khoronzhuk --- test/validation/classification/classification.h| 6 +--

[lng-odp] [API-NEXT PATCH v2 3/3] validation: cls: use correct MAC addresses

2016-01-15 Thread Ivan Khoronzhuk
If pktio is in not promisc mode, a packet should contain correct MAC address. Signed-off-by: Ivan Khoronzhuk --- .../classification/odp_classification_test_pmr.c | 57 ++ 1 file changed, 57 insertions(+) diff --git

[lng-odp] [API-NEXT PATCH v2 2/3] validation: cls: assign default CoS before creating chain

2016-01-15 Thread Ivan Khoronzhuk
There is no big difference when to assign default CoS to pktio, but in usual case it's done before creating any chain, if it's needed to be checked it can be done in separate test. Signed-off-by: Ivan Khoronzhuk --- .../classification/odp_classification_test_pmr.c

Re: [lng-odp] [API-NEXT PATCHv4 2/2] doc: update CONTRIBUTING and DEPENDENCIES files for images

2016-01-15 Thread Mike Holmes
On 15 January 2016 at 08:25, Bill Fischofer wrote: > I have no objection to keeping PDF capability, however the question is can > PDFs use .svgs? > No, not for doxygen at least it requires they by rendered as .eps to feed into latex > If yes, then we can still use

[lng-odp] [PATCH] linux-generic: pktio: remove unwanted initialisation

2016-01-15 Thread Stuart Haslam
Remove an unwanted initialisation and fix a bad indentation which crept in during a merge. --- platform/linux-generic/pktio/loop.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/platform/linux-generic/pktio/loop.c b/platform/linux-generic/pktio/loop.c index

Re: [lng-odp] [PATCH] validation: pktio: don't continue if packet with > MTU is sent

2016-01-15 Thread Stuart Haslam
On Fri, Jan 15, 2016 at 05:53:20PM +0200, Ivan Khoronzhuk wrote: > > > On 15.01.16 17:51, Stuart Haslam wrote: > >On Wed, Jan 13, 2016 at 06:46:57PM +0200, Ivan Khoronzhuk wrote: > >>If packet with size > MTU is sent the test can crash farther, > >>so better to stop here. > >> > >>Signed-off-by:

Re: [lng-odp] [PATCH] linux-generic: init: handle local/global init/term cleanly

2016-01-15 Thread Ivan Khoronzhuk
On 14.01.16 23:21, Bill Fischofer wrote: Restructure odp_init_global() and odp_init_local() so that they recover cleanly if initialization fails. At exit any partial initialization is reversed so that system is in the same state as before the failing call was made. This includes adding dummy

Re: [lng-odp] [PATCH] validation: pktio: reduce stdout noise

2016-01-15 Thread Ivan Khoronzhuk
On 15.01.16 18:18, Stuart Haslam wrote: Printing the pktio info every time a pktio is opened generates a load of noise on stdout and makes it difficult to see the status of individual test cases. Signed-off-by: Stuart Haslam Reviewed-by: Ivan Khoronzhuk

[lng-odp] [PATCH] validation: pktio: reduce stdout noise

2016-01-15 Thread Stuart Haslam
Printing the pktio info every time a pktio is opened generates a load of noise on stdout and makes it difficult to see the status of individual test cases. Signed-off-by: Stuart Haslam --- Log goes from this: http://people.linaro.org/~stuart.haslam/pktio1.log To this:

Re: [lng-odp] [PATCH] linux-generic: pktio: remove unwanted initialisation

2016-01-15 Thread Ivan Khoronzhuk
On 15.01.16 17:45, Stuart Haslam wrote: Remove an unwanted initialisation and fix a bad indentation which crept in during a merge. forgot to add signed-off Reviewed-by: Ivan Khoronzhuk --- platform/linux-generic/pktio/loop.c | 3 +-- 1 file changed, 1

Re: [lng-odp] [PATCH] validation: pktio: don't continue if packet with > MTU is sent

2016-01-15 Thread Stuart Haslam
On Wed, Jan 13, 2016 at 06:46:57PM +0200, Ivan Khoronzhuk wrote: > If packet with size > MTU is sent the test can crash farther, > so better to stop here. > > Signed-off-by: Ivan Khoronzhuk Signed-off-by: Stuart Haslam > --- >

Re: [lng-odp] [PATCH v2] doc: process: add by-laws

2016-01-15 Thread Mike Holmes
ping On 12 January 2016 at 13:59, Mike Holmes wrote: > The by-laws were only recorded as part of the website, move them to git > where they can be tracked. > > Signed-off-by: Mike Holmes > --- > v2: >Comments from Maxim > >

Re: [lng-odp] [PATCH] queue: queue_deq: delete atomic fetch and inc

2016-01-15 Thread Bill Fischofer
This patch is incorrect. The atomics are needed since odp_schedule_order_lock() does not lock the queue. On Thursday, January 14, 2016, Zaibo Xu wrote: > As all the queue_deq is locked by queue lock, I think it doesn't need > to atomic opertion here any more. > >

Re: [lng-odp] [API-NEXT PATCH v3 0/6] Multi-queue pktio for poll mode

2016-01-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. This patch set adds missing functionality, is needed for completion of multi-queue pktio API and has waited for review since 22nd Dec. -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Petri Savolainen > Sent: Monday, January

Re: [lng-odp] [API-NEXT PATCH 00/13] atomi api completion

2016-01-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Petri Savolainen > Sent: Friday, January 08, 2016 3:41 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCH 00/13] atomi api completion > > Completed additions to

[lng-odp] [API-NEXT PATCHv4] validation: increase timer expiration wait time

2016-01-15 Thread Maxim Uvarov
Following current test logic validation test should correctly wait for all scheduled timer expirations. Setting that time to 1ms is not correct due to code above schedules timer to 1.1ms and context switch in linux takes 10ms. Problem that odp_timer_pool_destroy() does not disarm all trigered

Re: [lng-odp] [API-NEXT PATCH 4/5] helper: deleted odph_pause

2016-01-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. V2 corrects the issue. -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Savolainen, Petri (Nokia - FI/Espoo) > Sent: Wednesday, January 13, 2016 3:24 PM > To: EXT Maxim Uvarov; lng-odp@lists.linaro.org > Subject: Re: [lng-odp]

[lng-odp] [API-NEXT PATCHv1 1/2] validation: increase timer expiration wait time

2016-01-15 Thread Maxim Uvarov
Following current test logic validation test should correctly wait for all scheduled timer expirations. Setting that time to 1ms is not correct due to code above schedules timer to 1.1ms and context switch in linux takes 10ms. Problem that odp_timer_pool_destroy() does not disarm all trigered

[lng-odp] [API-NEXT PATCHv1 2/2] linux-generic/validation: wait for timer handler completiion after timer deletion

2016-01-15 Thread Maxim Uvarov
Add test case based on previous seg fault code that pool destroy does not fail if there are some timers in fight. Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_timer.c | 15 ++- test/validation/timer/timer.c | 15 +++

Re: [lng-odp] [API-NEXT PATCH 5/5] linux-generic: removed spin_internal

2016-01-15 Thread Maxim Uvarov
Merged! Maxim. On 01/12/2016 15:22, Savolainen, Petri (Nokia - FI/Espoo) wrote: Ping. *From:*EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] *Sent:* Thursday, January 07, 2016 2:30 PM *To:* Savolainen, Petri (Nokia - FI/Espoo) *Cc:* LNG ODP Mailman List *Subject:* Re: [lng-odp]

[lng-odp] [PATCH v2] validation: system: add validation tests for odp_cpu_cycles_* calls

2016-01-15 Thread Ivan Khoronzhuk
https://bugs.linaro.org/show_bug.cgi?id=1906 Signed-off-by: Ivan Khoronzhuk --- test/validation/system/system.c | 118 test/validation/system/system.h | 4 ++ 2 files changed, 122 insertions(+) diff --git

Re: [lng-odp] [API-NEXT PATCHv4] validation: increase timer expiration wait time

2016-01-15 Thread Maxim Uvarov
it has to be v1, please skip it. Resend 2 new patches for that issue. Maxim. On 01/15/2016 11:07, Maxim Uvarov wrote: Following current test logic validation test should correctly wait for all scheduled timer expirations. Setting that time to 1ms is not correct due to code above schedules

Re: [lng-odp] [PATCH v2] validation: system: add validation tests for odp_cpu_cycles_* calls

2016-01-15 Thread Ivan Khoronzhuk
Hi, Petri This patch contains validation tests for API you've recently added. Could you please review it. On 15.01.16 11:16, Ivan Khoronzhuk wrote: https://bugs.linaro.org/show_bug.cgi?id=1906 Signed-off-by: Ivan Khoronzhuk --- test/validation/system/system.c |

[lng-odp] [PATCH v6] example: time: add test of global time API on monotony

2016-01-15 Thread Ivan Khoronzhuk
This test example uses linux helper functions to schedule worker threads in order to check global time monotony between the threads. Each thread receives event from it's own queue, checks global time on correctness, writes in the buffer new current global time, chooses randomly next thread queue,

Re: [lng-odp] [API-NEXT PATCHv4 2/2] doc: update CONTRIBUTING and DEPENDENCIES files for images

2016-01-15 Thread Maxim Uvarov
I might be too late but pdf I think is useful. At least for me. Let's discuss that on meeting. Maxim. On 01/15/2016 03:06, Bill Fischofer wrote: OK v5 sent. Only Delta is removing the PDF stuff in DEPENDENCIES. On Thu, Jan 14, 2016 at 4:32 PM, Mike Holmes

Re: [lng-odp] [PATCH v6] example: time: add test of global time API on monotony

2016-01-15 Thread Maxim Uvarov
Merged, thanks. Maxim. On 01/15/2016 12:59, Ivan Khoronzhuk wrote: This test example uses linux helper functions to schedule worker threads in order to check global time monotony between the threads. Each thread receives event from it's own queue, checks global time on correctness, writes in