I'm happy with that changes. Petri?
small note that it will be much more easy to review if this patch will
be slitted on 2 parts:
1. new functional (abi_begin.h, abi_end.h, makefiles and configure.) 2.
All other files instructed
with begin and end. So I had to apply patch to find proper thing
already have this change, it's already in next and will be merged to
master before next release.
commit 3b409242fdd8516255c980cce4f8d16c1933ca81
Author: Bill Fischofer
Date: Sun Mar 27 11:10:04 2016 -0500
doc: application: add missing .gitignore file for doc output
Signed-off-by: Bi
Hi,
We have changed the cuckoo hash code into the ODP/helper where
we find a table pipeline infrastructure.
We think maybe it is a better idea to make cuckoo hash as one
of alternative table.
> 在 2016年4月18日，下午1:26，Jia Ru 写道：
>
> According to the comments, I modified the following asp
Hi,
Our current LPM code is based on Tree Bitmap as a backend for IP prefixes
management. Before we submit the code, we need first to remove this part of
code as Tree Bitmap is a patent algorithm for Cisco.
If you just want an LPM algorithm for evaluation, we can provide the Tree
Bitmap
On Mon, Apr 18, 2016 at 6:44 PM, Mike Holmes wrote:
> The output dir is generated by doxygen, ignore it.
>
> Signed-off-by: Mike Holmes
>
Reviewed-by: Bill Fischofer
> ---
> doc/application-api-guide/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 doc/application-ap
The output dir is generated by doxygen, ignore it.
Signed-off-by: Mike Holmes
---
doc/application-api-guide/.gitignore | 1 +
1 file changed, 1 insertion(+)
create mode 100644 doc/application-api-guide/.gitignore
diff --git a/doc/application-api-guide/.gitignore
b/doc/application-api-guide/.g
The helper apis are not part of the odp specification, don't publish them in
the application user guide for the odp api.
Signed-off-by: Mike Holmes
---
doc/application-api-guide/doxygen.cfg | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/doc/application-api-guide/doxygen.cf
On Mon, Apr 18, 2016 at 1:06 PM, Mike Holmes wrote:
> I see a fundamental questions that needs answering that might make the
> right patch obvious.
>
>
>- Do we think the ABI is to become part of the ODP specification ?
>
> I think we want the ODP specification to be ABI-enabled.
>
>-
>
v6 sent. It passed make distcheck for me.
On Mon, Apr 18, 2016 at 5:17 PM, Bill Fischofer
wrote:
> Thanks. I'll add that. I suspect the 2nd error is a fallout of the first
> since that it works for me. Will double-check and send a v6.
>
>
>
> On Mon, Apr 18, 2016 at 2:35 PM, Anders Roxell
> w
From: Anders Roxell
Internal functions should not be part of symbols that are visible
outside the library. Using -fvisibility=hidden hides all internal
functions from the public ABI.
Suggested-by: Ricardo Salveti
Signed-off-by: Anders Roxell
Signed-off-by: Bill Fischofer
---
Changes for v6:
-
Thanks. I'll add that. I suspect the 2nd error is a fallout of the first
since that it works for me. Will double-check and send a v6.
On Mon, Apr 18, 2016 at 2:35 PM, Anders Roxell
wrote:
> On 18 April 2016 at 18:47, Bill Fischofer
> wrote:
> > From: Anders Roxell
> >
> > Internal function
On 18 April 2016 at 18:47, Bill Fischofer wrote:
> From: Anders Roxell
>
> Internal functions should not be part of symbols that are visible
> outside the library. Using -fvisibility=hidden hides all internal
> functions from the public ABI.
>
> Suggested-by: Ricardo Salveti
> Signed-off-by: And
I see a fundamental questions that needs answering that might make the
right patch obvious.
- Do we think the ABI is to become part of the ODP specification ?
- Do we want to specify it in words or capture it in the spec header
files along with the API ?
I think we do want to define an
From: Anders Roxell
Internal functions should not be part of symbols that are visible
outside the library. Using -fvisibility=hidden hides all internal
functions from the public ABI.
Suggested-by: Ricardo Salveti
Signed-off-by: Anders Roxell
Signed-off-by: Bill Fischofer
---
include/odp/api/
I've send v5 of this patch that uses the hybrid approach I mentioned
earlier today. I think that should address Petri's concerns while still
making this automatic for all implementations that reference the spec files.
(I mistakenly posted this as v2 earlier, just reposted renamed to be v5)
Bill
From: Anders Roxell
Internal functions should not be part of symbols that are visible
outside the library. Using -fvisibility=hidden hides all internal
functions from the public ABI.
Suggested-by: Ricardo Salveti
Signed-off-by: Anders Roxell
Signed-off-by: Bill Fischofer
---
include/odp/api/
https://bugs.linaro.org/show_bug.cgi?id=2103
Mike Holmes changed:
What|Removed |Added
Version|api-next|1.8
--
You are receiving this mail because:
You
On 18/04/16 15:47, Bill Fischofer wrote:
On Mon, Apr 18, 2016 at 9:25 AM, Zoltan Kiss mailto:zoltan.k...@linaro.org>> wrote:
Hi,
The second parameter of this function is an array pointer for the
events we want to send:
int odp_queue_enq_multi(odp_queue_t queue, const odp_ev
On Mon, Apr 18, 2016 at 9:25 AM, Zoltan Kiss wrote:
> Hi,
>
> The second parameter of this function is an array pointer for the events
> we want to send:
>
> int odp_queue_enq_multi(odp_queue_t queue, const odp_event_t events[], int
> num);
>
> I wonder if that const qualifier makes sense there.
Hi,
The second parameter of this function is an array pointer for the events
we want to send:
int odp_queue_enq_multi(odp_queue_t queue, const odp_event_t events[],
int num);
I wonder if that const qualifier makes sense there. As the description
says, normally the events are consumed by th
Thanks, that makes sense. I'm using the check-odp scripts, but for some
reason they don't install into the specified target dir.
Nilesh, you should run make install on ODP, and then pass the install
path (or not if you install into standard dirs) to ODP.
Regards,
Zoltan
On 18/04/16 14:18, Max
Internal functions should not be part of symbols that are visible
outside the library. Using -fvisibility=hidden hides all internal
functions from the public ABI.
Suggested-by: Ricardo Salveti
Signed-off-by: Anders Roxell
---
platform/Makefile.inc | 1 +
p
On 04/18/16 15:50, Zoltan Kiss wrote:
Hi,
I've tried this out as well, and it fails for me too. I've used the
following configure command:
./configure--with-odp=[installdir] --with-odp-platform=linux-generic
LDFLAGS="$(LDFLAGS) -L$(REPOS)/[installdir]/lib/ -lpcap -lm
The problem is that li
Merged this patch.
Maxim.
On 04/16/16 19:05, Bill Fischofer wrote:
For this part:
On Fri, Apr 15, 2016 at 5:51 AM, Petri Savolainen
mailto:petri.savolai...@nokia.com>> wrote:
Replace reference to buffer pool with packet pool
in documentation.
Signed-off-by: Petri Savolainen mai
From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Sunday, April 17, 2016 1:36 AM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT PATCH v2 3/7] api: packet: add packet concat
and split
On Wed, Apr 13, 2016 at 8:01 AM, Petri S
Hi,
This patch series adds the ability to run tests/ exemples / perf-test
in "process mode" (i.e letting OPD threads being linux processes)
It it hence tackling ODP-171.
This is achieved in 2 main steps:
A]
The 2 pairs of helper functions:
odph_linux_pthread_create(), odph_linux_pthread_join()
a
Hi, Petri
Tests are sorted in the order of API usage, one by one. The monotony test is
placed before others,
because before testing rest time APIs we should be sure in monotony. Now when
you've combined them
the placement of monotony at least for one of the type is not correct. For
instance, t
On 04/15/16 12:36, Petri Savolainen wrote:
Added crypto capability structure and cipher/authentication
algorithm bit masks needed by the structure.
Signed-off-by: Petri Savolainen
---
include/odp/api/spec/crypto.h | 88 +++
1 file changed, 88 insertion
Hi,
I've tried this out as well, and it fails for me too. I've used the
following configure command:
./configure--with-odp=[installdir] --with-odp-platform=linux-generic
LDFLAGS="$(LDFLAGS) -L$(REPOS)/[installdir]/lib/ -lpcap -lm
The problem is that libodp.a is in /lib/.libs, not in a direc
+
+/**
+ * Copy data from another packet
+ *
+ * Copy 'len' bytes of data from 'src' packet to 'dst' packet. Copy starts from
+ * the specified source and destination packet offsets. Maximum number of bytes
+ * to copy is the minimum of destination packet data length minus destination
+ * offset an
Merged,
parts.
Maxim.
On 04/18/16 14:54, Bill Fischofer wrote:
I included the reviewed parts of the API changes in my
implemementation/test patch so either merge that one or cherry pick
the APIs from Petri's patch and omit them from my implementation/test
patch. Either works. This is on the a
On 04/18/16 14:54, Bill Fischofer wrote:
I included the reviewed parts of the API changes in my
implemementation/test patch so either merge that one or cherry pick
the APIs from Petri's patch and omit them from my implementation/test
patch. Either works. This is on the agenda for today's ARCH c
Merged,
Maxim.
On 04/15/16 18:25, Bill Fischofer wrote:
On Tue, Feb 16, 2016 at 8:02 AM, Ivan Khoronzhuk
mailto:ivan.khoronz...@linaro.org>> wrote:
When test for single thread is finished the following test for
many threads can be started, and for some implementations can
happen
https://bugs.linaro.org/show_bug.cgi?id=2136
Krishna Garapati changed:
What|Removed |Added
Status|IN_PROGRESS |RESOLVED
Resolution|---
I included the reviewed parts of the API changes in my
implemementation/test patch so either merge that one or cherry pick the
APIs from Petri's patch and omit them from my implementation/test patch.
Either works. This is on the agenda for today's ARCH call so we can decide
then.
On Mon, Apr 18, 2
Reviewed-by: Balakrishna Garapati
/Krishna
On 18 April 2016 at 10:14, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia.com> wrote:
>
>
>
>
> *From:* EXT Krishna Garapati [mailto:balakrishna.garap...@linaro.org]
> *Sent:* Friday, April 15, 2016 5:13 PM
> *To:* Savolainen, Petri (Nok
From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Saturday, April 16, 2016 7:11 PM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT PATCH 2/2] api: packet: rename and add copy
functions
On Fri, Apr 15, 2016 at 5:51 AM, Petri
From: EXT Krishna Garapati [mailto:balakrishna.garap...@linaro.org]
Sent: Friday, April 15, 2016 5:13 PM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto capability
+
+/**
+ * Query crypto capabilities
+ *
+ * Ou
Anders,
Have you tried to move pragmas out of the spec file?
I think this (plat header file) is the correct place for the pragmas since
those are part of the build system and build systems are implementation
specific. ODP API _spec_ does not dictate any build system or compiler, and
thus shoul
patch 3 still has note. I can try to merge what is ready.
Maxim.
On 04/15/16 10:59, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Maxim,
Now that my entire patch set (all 6 patches) has reviewed-bys, could
you merge those. Bill would then rebase his implementation on top of
that and no patche
40 matches
Mail list logo
