Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Christophe Milard
Cannot see them here when doing normal builds. you must be more accurate on what you do. Moreover, these warnings seems to relate to helper tests, which this serie doesn't touch. confused. /C On 15 July 2016 at 05:21, Christophe Milard wrote: > Hi Maxim, > Warning

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Christophe Milard
Hi Maxim, Warning when doing what? On 14 July 2016 at 22:31, Maxim Uvarov wrote: > I see that warnings: > > helper/test/Makefile.am:27: warning: variable 'dist_chksum_SOURCES' is > defined but no program or > helper/test/Makefile.am:27: library has 'chksum' as canonical

[lng-odp] [Bug 2429] New: validation thread_main fails process mode

2016-07-14 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2429 Bug ID: 2429 Summary: validation thread_main fails process mode Product: OpenDataPlane - linux- generic reference Version: v1.10.1 Hardware: Other OS: Linux Status:

[lng-odp] [PATCHv2] helper: fixing helper prefix in chksum.c

2016-07-14 Thread Khalil Blaiech
Add odph_ prefix to udp_or_tcp_hdr_t and rename structure odph_l4_hdr_t. Signed-off-by: Khalil Blaiech --- helper/chksum.c | 51 +-- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/helper/chksum.c

[lng-odp] [PATCHv2 3/3] example/ipsec: scope ipsec examples

2016-07-14 Thread Anders Roxell
Signed-off-by: Anders Roxell --- example/ipsec/Makefile.am | 18 +- example/ipsec/{run_ah_in => odp_ipsec_run_ah_in} | 0 example/ipsec/{run_ah_out => odp_ipsec_run_ah_out} | 0 example/ipsec/{run_both_in =>

[lng-odp] [PATCHv2 2/3] example/time/Makefile: remove incorrect postfix _test

2016-07-14 Thread Anders Roxell
Signed-off-by: Anders Roxell --- example/time/.gitignore | 2 +- example/time/Makefile.am | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/example/time/.gitignore b/example/time/.gitignore index 3106aea..938c1aa 100644 ---

[lng-odp] [PATCHv2 1/3] helper/test/Makefile: don't install tests

2016-07-14 Thread Anders Roxell
Signed-off-by: Anders Roxell --- helper/test/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helper/test/Makefile.am b/helper/test/Makefile.am index e9e8785..545db73 100644 --- a/helper/test/Makefile.am +++ b/helper/test/Makefile.am @@

[lng-odp] [PATCHv2 0/3] cleanups

2016-07-14 Thread Anders Roxell
This is preparation cleanup so installed executables are scoped and helpers are removed as unhelpful for the final installation. v2, fixes a issue that Maxim reported with: helper/test/Makefile.am:27: warning: variable 'dist_chksum_SOURCES' is defined but no program or

Re: [lng-odp] [PATCH] linux-generic: pktio: remove doxygen for unused socket_id parameter

2016-07-14 Thread Maxim Uvarov
Merged, Maxim. On 07/14/16 03:23, Bill Fischofer wrote: The ODP version of the _ring_create() routine does not use a socket_id parameter, so remove the doxygen that refers to it to resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2413 Signed-off-by: Bill Fischofer

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Maxim Uvarov
I see that warnings: helper/test/Makefile.am:27: warning: variable 'dist_chksum_SOURCES' is defined but no program or helper/test/Makefile.am:27: library has 'chksum' as canonical name (possible typo) helper/test/Makefile.am:28: warning: variable 'dist_odpthreads_SOURCES' is defined but no

[lng-odp] [PATCHv2] example: remove reference from linux-generic internal envs

2016-07-14 Thread Maxim Uvarov
Make print for example more platform independent and move prints about pktio states in platform initialization code. Signed-off-by: Maxim Uvarov Reviewed-by: Bill Fischofer --- v2: - for netmap did not add pktio_init_global to functions

[lng-odp] ./scripts/build-pktio-dpdk looks like broken

2016-07-14 Thread Maxim Uvarov
Hello, Can somebody else confirm that ./scripts/build-pktio-dpdk script is broken? I.e. now I see that script compiles dpdk and odp but it does not compile dpdk pktio for odp for some reason. config.log says that there is no -ldpdk. But ./configure passes to the end and returns 0. Maxim.

Re: [lng-odp] [PATCH] linux-generic: tm: odp_tm_enq wrong return value

2016-07-14 Thread Bill Fischofer
Thanks, Oriol. Good catch. On Thu, Jul 14, 2016 at 9:39 AM, Oriol Arcas wrote: > The API states that the return values of odp_tm_enq() and > odp_tm_enq_with_cnt() are different (the former returns 0 on success), > but the implementations of both were identical. > >

Re: [lng-odp] [PATCH] test: linux-gen: add pcap playback test

2016-07-14 Thread Bill Fischofer
I think general pcap file support is likely to prove useful in all sorts of ways. Validation testing (especially for error cases) is certainly one area. Flow routing should be another since packets may only partially touch cores so how do we test that an IPSec packet can be input and received by a

Re: [lng-odp] [PATCH] test: linux-gen: add pcap playback test

2016-07-14 Thread Bala Manoharan
This approach of using a pcap file might be useful to recreate an error scenario but IMO it will be difficult to maintain different pcap file for test cases. Is this method proposed for validation testing or for flow testing? Regards, Bala On 14 July 2016 at 18:42, Bill Fischofer

[lng-odp] [PATCH] linux-generic: tm: odp_tm_enq wrong return value

2016-07-14 Thread Oriol Arcas
The API states that the return values of odp_tm_enq() and odp_tm_enq_with_cnt() are different (the former returns 0 on success), but the implementations of both were identical. Signed-off-by: Oriol Arcas --- platform/linux-generic/odp_traffic_mngr.c | 7 ++- 1

Re: [lng-odp] [PATCH] test: linux-gen: add pcap playback test

2016-07-14 Thread Mike Holmes
In many cases it is becasue the scripts do not add the current directory containing the executables to the path, I just fixed that in crypto examples and will send when Anders patches make it in On 14 July 2016 at 09:08, Bill Fischofer wrote: > Ok, make followed by

Re: [lng-odp] [PATCH] test: linux-gen: add pcap playback test

2016-07-14 Thread Bill Fischofer
Ok, make followed by make check looks like it works: make check-TESTS make[4]: Entering directory '/home/bill/linaro/maxim/test/platform/linux-generic' make[5]: Entering directory '/home/bill/linaro/maxim/test/platform/linux-generic' PASS: pktio/pktio_run.sh SKIP: pktio/pktio_run_tap.sh PASS:

[lng-odp] [Bug 2212] Valgrind failure running traffic manager test

2016-07-14 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2212 Mike Holmes changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

Re: [lng-odp] [PATCH] test: linux-gen: add pcap playback test

2016-07-14 Thread Maxim Uvarov
On 07/14/16 14:50, Bill Fischofer wrote: On Thu, Jul 14, 2016 at 3:29 AM, Maxim Uvarov > wrote: On 07/13/16 22:32, Bill Fischofer wrote: This applies and compiles fine, but I'm not sure how I'm supposed to run it.

[lng-odp] [Bug 2410] linux-generic/odp_traffic_mngr.c contains todo items

2016-07-14 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2410 Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[lng-odp] [Bug 2412] linux-generic/odp_name_table.c contains todo items

2016-07-14 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2412 Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[lng-odp] [Bug 2415] api/spec/traffic_mngr.h contains todo items

2016-07-14 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2415 Mike Holmes changed: What|Removed |Added Resolution|--- |FIXED

[lng-odp] [Bug 2425] CID 164654: Insecure data handling odp_sysinfo_parse.c

2016-07-14 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2425 --- Comment #1 from Mike Holmes --- Is this worth adding an ODP_ASSERT that runs in debug mode to test the procfs values ? -- You are receiving this mail because: You are the assignee for the bug.

[lng-odp] [Bug 2426] CID 164653: (INTEGER_OVERFLOW) traffic_mngr.c

2016-07-14 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2426 --- Comment #2 from Mike Holmes --- Can strncmp be used to limit the bytes to be compared -- You are receiving this mail because: You are on the CC list for the bug.

[lng-odp] [Bug 2427] odph_cuckoo_table_create fails in CI

2016-07-14 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2427 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1

[lng-odp] [Bug 2366] odp_scheduling_run.sh fails regularly in CI

2016-07-14 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2366 Mike Holmes changed: What|Removed |Added Priority|High|Highest --- Comment #5

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Mike Holmes
For this series: Reviewd-by: Mike Holmes On 14 July 2016 at 01:18, Yi He wrote: > For this series: > > Reviewed-and-tested-by: Yi He > > Best Regards, Yi > > On 14 July 2016 at 03:52, Bill Fischofer >

Re: [lng-odp] [PATCH] test: linux-gen: add pcap playback test

2016-07-14 Thread Bill Fischofer
On Thu, Jul 14, 2016 at 3:29 AM, Maxim Uvarov wrote: > On 07/13/16 22:32, Bill Fischofer wrote: > >> This applies and compiles fine, but I'm not sure how I'm supposed to run >> it. Does this require sudo? Neither with or without seems to work for me: >> >> I do not see

Re: [lng-odp] [PATCH] test: linux-gen: add pcap playback test

2016-07-14 Thread Mike Holmes
On 14 July 2016 at 04:29, Maxim Uvarov wrote: > On 07/13/16 22:32, Bill Fischofer wrote: > >> This applies and compiles fine, but I'm not sure how I'm supposed to run >> it. Does this require sudo? Neither with or without seems to work for me: >> >> I do not see in

Re: [lng-odp] [PATCHv3 1/3] api: tm: resolve todo

2016-07-14 Thread Maxim Uvarov
Merged, patches 2 and 3 to master. Patch 1/3 to api-next, then to next. Maxim. On 07/13/16 19:59, Bill Fischofer wrote: From: Barry Spinney This todo just asks a question which is no longer important. Signed-off-by: Barry Spinney Signed-off-by:

Re: [lng-odp] [PATCH] test: linux-gen: add pcap playback test

2016-07-14 Thread Maxim Uvarov
On 07/13/16 22:32, Bill Fischofer wrote: This applies and compiles fine, but I'm not sure how I'm supposed to run it. Does this require sudo? Neither with or without seems to work for me: I do not see in your output that pcap pktio was compiled in (no open for it). In that case code should