Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

2016-08-02 Thread Forrest Shi
Hi, this is the coverage report of call the function by l3fwd. thanks, Forrest On 3 August 2016 at 09:57, Forrest Shi wrote: > Hi Maxim & Bala, > > It is a reverse function of the odph_eth_addr_parse(...). > > It could be used by l2fwd-simple, ipsec or other example

Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

2016-08-02 Thread Forrest Shi
Hi Maxim & Bala, It is a reverse function of the odph_eth_addr_parse(...). It could be used by l2fwd-simple, ipsec or other example like l3fwd to avoid duplicate or similar code. thanks, Forrest On 2 August 2016 at 23:50, Maxim Uvarov wrote: > On 08/02/16 18:21,

[lng-odp] [Bug 2453] PRIu64 is causing problems for odp-dpdk

2016-08-02 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2453 Bill Fischofer changed: What|Removed |Added CC|

[lng-odp] [PATCH 5/6] linux-generic: internal odp_cpu_cycles()

2016-08-02 Thread Brian Brooks
Lift the definition of odp_cpu_cycles() out of the arch specific directory into the common odp_cpu.c which then calls the internal arch specific definition. Signed-off-by: Brian Brooks --- platform/linux-generic/Makefile.am | 1 +

[lng-odp] [PATCH 4/6] linux-generic: lift odp_cpu_cycles_max/resolution()

2016-08-02 Thread Brian Brooks
Define odp_cpu_cycles_max() and odp_cpu_cycles_resolution() in the include API directory. These do not point to an internal value in arch because they are common across all archs. Signed-off-by: Brian Brooks --- platform/linux-generic/arch/default/odp_cpu_arch.c | 10

[lng-odp] [PATCH 6/6] linux-generic: internal odp_cpu_hz_current()

2016-08-02 Thread Brian Brooks
Prefix odp_cpu_hz_current with '_' to be consistent with other internal cpu definitions in arch directory. Signed-off-by: Brian Brooks --- platform/linux-generic/arch/default/odp_sysinfo_parse.c | 3 ++- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 3 ++-

[lng-odp] [PATCH 3/6] linux-generic: move cpu_arch.h up two directories

2016-08-02 Thread Brian Brooks
Signed-off-by: Brian Brooks --- platform/Makefile.inc| 8 platform/linux-generic/Makefile.am | 2 +- platform/linux-generic/arch/default/{odp/api => }/cpu_arch.h | 0

[lng-odp] [PATCH 2/6] linux-generic: use source files instead of symbolic links

2016-08-02 Thread Brian Brooks
Use source files in arch/default for undetected archs. This alleviates the need to use symlinks in the source code directory structure. Signed-off-by: Brian Brooks --- configure.ac | 13 +- platform/Makefile.inc

[lng-odp] [PATCH 1/6] linux-generic: internal odp_cpu_pause()

2016-08-02 Thread Brian Brooks
Signed-off-by: Brian Brooks --- platform/linux-generic/arch/default/odp/api/cpu_arch.h | 2 +- platform/linux-generic/arch/mips64/odp/api/cpu_arch.h | 2 +- platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h | 2 +- platform/linux-generic/arch/x86/odp/api/cpu_arch.h

Re: [lng-odp] [MONARCH_LTS PATCHv2] changelog: update for v1.11.0.0

2016-08-02 Thread Bill Fischofer
I just checked and these links all work in the formatted document. If you click on them in the patch the browser is confused by the asciidoc syntax, but they are correct. On Tue, Aug 2, 2016 at 3:50 PM, Bill Fischofer wrote: > Those bugs are closed. Perhaps a bugzilla

[lng-odp] [Bug 2453] New: PRIu64 is causing problems for odp-dpdk

2016-08-02 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2453 Bug ID: 2453 Summary: PRIu64 is causing problems for odp-dpdk Product: OpenDataPlane - linux- generic reference Version: v1.10.1 Hardware: Other OS: Linux Status:

Re: [lng-odp] [MONARCH_LTS PATCHv2] changelog: update for v1.11.0.0

2016-08-02 Thread Bill Fischofer
Those bugs are closed. Perhaps a bugzilla restriction? On Tuesday, August 2, 2016, Anders Roxell wrote: > On 2 August 2016 at 20:53, Bill Fischofer > wrote: > > Signed-off-by: Bill Fischofer

Re: [lng-odp] [MONARCH_LTS PATCHv2] changelog: update for v1.11.0.0

2016-08-02 Thread Anders Roxell
On 2 August 2016 at 20:53, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > --- > CHANGELOG | 114 > ++ > 1 file changed, 114 insertions(+) > > diff --git a/CHANGELOG

Re: [lng-odp] [MONARCH_LTS PATCHv3] changelog: update for v1.11.0.0

2016-08-02 Thread Maxim Uvarov
Merged with short description change to: changelog: update for v1.11.0.0-monarch_lts Maxim. On 08/02/16 22:21, Mike Holmes wrote: On 2 August 2016 at 15:19, Bill Fischofer wrote: Signed-off-by: Bill Fischofer Reviewd-by: Mike Holmes

Re: [lng-odp] [MONARCH_LTS PATCHv3] changelog: update for v1.11.0.0

2016-08-02 Thread Mike Holmes
On 2 August 2016 at 15:19, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > Reviewd-by: Mike Holmes > --- > CHANGELOG | 122 > ++ > 1 file

[lng-odp] [MONARCH_LTS PATCHv3] changelog: update for v1.11.0.0

2016-08-02 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- CHANGELOG | 122 ++ 1 file changed, 122 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index d8230cd..1d652a8 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,125 @@ +==

[lng-odp] [MONARCH_LTS PATCHv2] changelog: update for v1.11.0.0

2016-08-02 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- CHANGELOG | 114 ++ 1 file changed, 114 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index d8230cd..94f6e96 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,117 @@ +==

Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

2016-08-02 Thread Maxim Uvarov
On 08/02/16 18:21, Bala Manoharan wrote: one minor question: Is this API mainly for debugging or is there any other use case? Apart from this that is good point. We need code coverage to merge this function. Please add some simple test for helpers tests also. Maxim. Reviewed-by:

Re: [lng-odp] [PATCH] helper/hashtable: use static to hide private functions

2016-08-02 Thread Mike Holmes
On 2 August 2016 at 04:44, Maxim Uvarov wrote: > On 08/02/16 10:54, Anders Roxell wrote: > >> Signed-off-by: Anders Roxell >> --- >> helper/hashtable.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git

Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

2016-08-02 Thread Bala Manoharan
one minor question: Is this API mainly for debugging or is there any other use case? Apart from this Reviewed-by: Balasubramanian Manoharan Regards, Bala On 2 August 2016 at 14:20, wrote: > From: Xuelin Shi > >

Re: [lng-odp] [PATCH] example: odp_traffic_mgmt: remove unused includes

2016-08-02 Thread Maxim Uvarov
Merged, Maxim. On 08/01/16 23:58, Bill Fischofer wrote: On Mon, Aug 1, 2016 at 2:32 PM, Mike Holmes wrote: Clean up call to internal header and remove unused system headers Fixes: https://bugs.linaro.org/show_bug.cgi?id=2435 Signed-off-by: Mike Holmes

Re: [lng-odp] [PATCHv2] helper: fixing helper prefix in chksum.c

2016-08-02 Thread Maxim Uvarov
Merged, Maxim. On 07/15/16 01:01, Khalil Blaiech wrote: Add odph_ prefix to udp_or_tcp_hdr_t and rename structure odph_l4_hdr_t. Signed-off-by: Khalil Blaiech --- helper/chksum.c | 51 +-- 1 file changed, 29

[lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

2016-08-02 Thread forrest.shi
From: Xuelin Shi generate mac string representation (XX:XX:XX:XX:XX:XX) of odph_ethaddr_t Signed-off-by: Xuelin Shi --- v2: fix style issue. helper/eth.c| 11 +++ helper/include/odp/helper/eth.h | 14 ++

Re: [lng-odp] [PATCH] helper/hashtable: use static to hide private functions

2016-08-02 Thread Maxim Uvarov
On 08/02/16 10:54, Anders Roxell wrote: Signed-off-by: Anders Roxell --- helper/hashtable.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/helper/hashtable.c b/helper/hashtable.c index 8bb1ae5..f17b80f 100644 --- a/helper/hashtable.c +++

[lng-odp] [PATCH] helper/hashtable: use static to hide private functions

2016-08-02 Thread Anders Roxell
Signed-off-by: Anders Roxell --- helper/hashtable.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/helper/hashtable.c b/helper/hashtable.c index 8bb1ae5..f17b80f 100644 --- a/helper/hashtable.c +++ b/helper/hashtable.c @@ -164,7 +164,7 @@