Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

On 21 December 2016 at 23:45, Bill Fischofer wrote: > On Wed, Dec 21, 2016 at 9:26 AM, Maxim Uvarov > wrote: > > On debian jessie gcc unable to compile current code > > with error: > > odp_packet.c: In function 'odp_packet_trunc_head': > >

Re: [lng-odp] [PATCHv2, 1/1] validation: pktio: fix invalid mac addr

Regards, Bala On 8 December 2016 at 21:03, Josep Puigdemont wrote: > On Thu, Nov 10, 2016 at 07:58:39PM +0530, Bala Manoharan wrote: >> Fixes https://bugs.linaro.org/show_bug.cgi?id=2496 >> >> Signed-off-by: Balasubramanian Manoharan >>

Re: [lng-odp] [API-NEXT PATCH] linux-gen: schedule_sp: use ring as priority queue

Yi He had previously given his review for this patch. The subsequent side-discussion don't constitute a NAK so this should be good to merge. On Mon, Dec 19, 2016 at 4:37 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Ping. > >> -Original Message-

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

On Wed, Dec 21, 2016 at 9:26 AM, Maxim Uvarov wrote: > On debian jessie gcc unable to compile current code > with error: > odp_packet.c: In function 'odp_packet_trunc_head': > odp_packet.c:314:46: error: array subscript is above array bounds > [-Werror=array-bounds] >

[lng-odp] [Bug 2789] increasing CONFIG_PACKET_MAX_SEGS leads to segfault

https://bugs.linaro.org/show_bug.cgi?id=2789 Bill Fischofer changed: What|Removed |Added Ever confirmed|0 |1

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

I posted a patch to fix Bug 2789 but it's orthogonal to this issue. We should still see if we can come up with a compile-time-only circumvention. On Wed, Dec 21, 2016 at 12:30 PM, Maxim Uvarov wrote: > On 12/21/16 19:07, Bill Fischofer wrote: >> On Wed, Dec 21, 2016 at

[lng-odp] [API-NEXT PATCH] linux-generic: packet: set correct tailroom on trim of multi-seg pkts

Fix Bug https://bugs.linaro.org/show_bug.cgi?id=2789 by calculating tailroom correctly when trimming multi-segment packets. Also handle head/tail push/pull operations that result in a zero-length packet correctly. Signed-off-by: Bill Fischofer ---

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

On 12/21/16 19:07, Bill Fischofer wrote: > On Wed, Dec 21, 2016 at 9:58 AM, Mike Holmes wrote: >> On 21 December 2016 at 10:49, Maxim Uvarov wrote: >> >>> On 12/21/16 18:31, Mike Holmes wrote: On 21 December 2016 at 10:26, Maxim

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

On Wed, Dec 21, 2016 at 9:58 AM, Mike Holmes wrote: > On 21 December 2016 at 10:49, Maxim Uvarov wrote: > >> On 12/21/16 18:31, Mike Holmes wrote: >> > >> > >> > On 21 December 2016 at 10:26, Maxim Uvarov > >

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

On 21 December 2016 at 10:49, Maxim Uvarov wrote: > On 12/21/16 18:31, Mike Holmes wrote: > > > > > > On 21 December 2016 at 10:26, Maxim Uvarov > > wrote: > > > > On debian jessie gcc unable to compile

Re: [lng-odp] [PATCH] linux-gen: use odp_queue_t for the internal queue interface

Hi Mike， Yes.I noticed that and this patch is rejected by Bill and Petri for some performance concern. I will use the Linaro account in the next patch after fix their concern Thanks for your remind! Kevin Get Outlook for iOS From: Mike

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

On 12/21/16 18:31, Mike Holmes wrote: > > > On 21 December 2016 at 10:26, Maxim Uvarov > wrote: > > On debian jessie gcc unable to compile current code > with error: > odp_packet.c: In function 'odp_packet_trunc_head': >

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

On 21 December 2016 at 10:26, Maxim Uvarov wrote: > On debian jessie gcc unable to compile current code > with error: > odp_packet.c: In function 'odp_packet_trunc_head': > odp_packet.c:314:46: error: array subscript is above array bounds > [-Werror=array-bounds] >

Re: [lng-odp] [PATCH] linux-gen: use odp_queue_t for the internal queue interface

Hi Kevin This came from your ARM address, does it need to be via your Linaro address for legal reasons ? Mike On 18 December 2016 at 20:58, Kevin Wang wrote: > From: "kevin.wang" > > To make the queue component to be modulized, the other >

[lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

On debian jessie gcc unable to compile current code with error: odp_packet.c: In function 'odp_packet_trunc_head': odp_packet.c:314:46: error: array subscript is above array bounds [-Werror=array-bounds] to->buf_hdr.seg[i].len = from->buf_hdr.seg[num + i].len; The problem is that it breaks

[lng-odp] [Bug 2790] New: CID 173382: Memory - illegal accesses /test/common_plat/performance/odp_l2fwd.c

https://bugs.linaro.org/show_bug.cgi?id=2790 Bug ID: 2790 Summary: CID 173382: Memory - illegal accesses /test/common_plat/performance/odp_l2fwd.c Product: OpenDataPlane - linux- generic reference Version: v1.12.0.0

[lng-odp] [Bug 2789] New: increasing CONFIG_PACKET_MAX_SEGS leads to segfault

https://bugs.linaro.org/show_bug.cgi?id=2789 Bug ID: 2789 Summary: increasing CONFIG_PACKET_MAX_SEGS leads to segfault Product: OpenDataPlane - linux- generic reference Version: api-next Hardware: Other OS: Linux

Re: [lng-odp] [PATCH] test: tm: queue id can be not updated

On 21 December 2016 at 08:38, Maxim Uvarov wrote: > get_unique_id() function on error do not update it's second and > third arguments (unique_id and is_ipv4). gcc -O3 finds that > and traps compilation. > > Signed-off-by: Maxim Uvarov >

[lng-odp] Change in syssw/odp[odp-devel]: odp: add zero-copy support for netmap

Alan Winkowski has uploaded a new change for review. http://vgitil04.il.marvell.com:8080/34865 Change subject: odp: add zero-copy support for netmap .. odp: add zero-copy support for netmap Change-Id:

[lng-odp] Change in syssw/odp[odp-devel]: odp: add support for busy-wait use ioctl instead of poll Sig...

Alan Winkowski has uploaded a new change for review. http://vgitil04.il.marvell.com:8080/34864 Change subject: odp: add support for busy-wait use ioctl instead of poll Signed-off-by: Alan Winkowski ..

[lng-odp] Change in syssw/odp[odp-devel]: odp: netmap_slot_t: add support for mvpp2x-data_offs field

Alan Winkowski has uploaded a new change for review. http://vgitil04.il.marvell.com:8080/34863 Change subject: odp: netmap_slot_t: add support for mvpp2x-data_offs field .. odp: netmap_slot_t: add support for mvpp2x-data_offs

[lng-odp] Change in syssw/odp[odp-devel]: odp: odp_packet_print: add dump for payload

Alan Winkowski has uploaded a new change for review. http://vgitil04.il.marvell.com:8080/34861 Change subject: odp: odp_packet_print: add dump for payload .. odp: odp_packet_print: add dump for payload Change-Id:

[lng-odp] Change in syssw/odp[odp-devel]: odp: increase burst size to 256

Alan Winkowski has uploaded a new change for review. http://vgitil04.il.marvell.com:8080/34859 Change subject: odp: increase burst size to 256 .. odp: increase burst size to 256 Change-Id:

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

On Wed, Dec 21, 2016 at 6:42 AM, Bala Manoharan wrote: > Regards, > Bala > > > On 20 December 2016 at 22:35, Bill Fischofer > wrote: >> On Tue, Dec 20, 2016 at 8:26 AM, Bala Manoharan >> wrote: >>> On 20 December

[lng-odp] [PATCH] test: tm: queue id can be not updated

get_unique_id() function on error do not update it's second and third arguments (unique_id and is_ipv4). gcc -O3 finds that and traps compilation. Signed-off-by: Maxim Uvarov --- test/common_plat/validation/api/traffic_mngr/traffic_mngr.c | 4 ++-- 1 file changed, 2

Re: [lng-odp] Merge API-NEXT to NEXT

I'd like to get this to api-next and after that to next/master. linux-gen: schedule_sp: use ringas priority queue -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Tuesday, December 20, 2016 6:57 PM >

[lng-odp] [API-NEXT PATCHv2] linux-gen: _ishm: fixing typos

Fixing a set of iritating typos. just in comments. Signed-off-by: Christophe Milard --- Since V1: another typo found by Bill platform/linux-generic/_ishm.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

Regards, Bala On 20 December 2016 at 22:35, Bill Fischofer wrote: > On Tue, Dec 20, 2016 at 8:26 AM, Bala Manoharan > wrote: >> On 20 December 2016 at 18:26, Bill Fischofer >> wrote: >>> On Tue, Dec 20, 2016 at

Re: [lng-odp] [API-NEXT PATCH] linux-gen: _ishm: fixing typos

On Wed, Dec 21, 2016 at 5:16 AM, Christophe Milard wrote: > Fixing a set of iritating typos. just in comments. > > Signed-off-by: Christophe Milard > --- > platform/linux-generic/_ishm.c | 24 > 1 file changed,

Re: [lng-odp] [API-NEXT PATCH v2] validation: test creating pool and timer pool with no name

On Wed, Dec 21, 2016 at 5:27 AM, Matias Elo wrote: > Signed-off-by: Matias Elo > --- > > Reviewed-by: Petri Savolainen Reviewed-by: Bill Fischofer > >

[lng-odp] [API-NEXT PATCH v2] validation: test creating pool and timer pool with no name

Signed-off-by: Matias Elo --- Reviewed-by: Petri Savolainen test/common_plat/validation/api/pool/pool.c | 7 +-- test/common_plat/validation/api/timer/timer.c | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH v2 1/2] api: unify ODP_*_NAME_LEN specifications

Unify name length definitions to always include terminating null character. Signed-off-by: Matias Elo --- Reviewed-by: Petri Savolainen Reviewed-by: Bill Fischofer include/odp/api/spec/classification.h | 2 +-

[lng-odp] [API-NEXT PATCH v2 2/2] api: move ODP_*_NAME_LEN definitions from API to implementation

Enables the implementations to choose the define values. Signed-off-by: Matias Elo --- Reviewed-by: Petri Savolainen Reviewed-by: Bill Fischofer include/odp/api/spec/pool.h | 6

Re: [lng-odp] [API-NEXT PATCH 1/3] api: unify ODP_*_NAME_LEN specifications

> For Parts 1 and 2: > > Reviewed-by: Bill Fischofer > > As noted in Part 3, that also looks fine but should be a separate > patch since it doesn't seem to be related to the purpose of Parts 1 > and 2. OK, I'll fix this. -Matias

[lng-odp] [API-NEXT PATCH 5/5] test: drv: shm: adding small allocation stress tests

stress tests added for allocation of small memory units using odpdrv_shm_sreserve() and odpdrv_shm_sfree(). Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 164 +

[lng-odp] [API-NEXT PATCH 4/5] test: drv: shm: adding small allocation tests

Tests for odpdrv_shm_sreserve() and odpdrv_shm_sfree are added, testing the ishm small memory unit allocator. Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 77 ++

[lng-odp] [API-NEXT PATCH 3/5] linux-gen: drv: shm: adding buddy allocator

A pool for buddy allocation of small memory sizes is created at boot time and functions to reserve/free memory from this pool added (using the _ishm equivalent, of course). Memory allocated from this pool is sharable between ODP threads, (which malloc() would not guarantee in the odptreads as

[lng-odp] [API-NEXT PATCH 1/5] linux-gen: _ishm: adding buddy allocation

_ishm now provides a function to create a pool for buddy memory allocation, as well as functions to allocated/release memory from the created pool. Signed-off-by: Christophe Milard --- platform/linux-generic/Makefile.am | 2 +

[lng-odp] [API-NEXT PATCH 2/5] drv: adding odpdrv_shm_sreserve and odpdrv_shm_sfree()

The two functions are meant to be used fo small amount of memory allocation. They are quicker, lighter and have a smaller granularity than the odpdrv_shm_reserve() / odpdrv_shm_free_*() sets of function, but also lacks some of their functionality (lookup, export, flags). Signed-off-by: Christophe

[lng-odp] [API-NEXT PATCH 0/5] small memory amount allocator for drv shm

This patch series aims at giving the ability for units using the ODP drv (south) interface to allocate small unit of memory (hence going lower than the page size, which is the lower limit for odp_drvshm_reserve). The interface now provides two functions (whose usage is very similar to malloc/free,

[lng-odp] [API-NEXT PATCH] linux-gen: _ishm: fixing typos

Fixing a set of iritating typos. just in comments. Signed-off-by: Christophe Milard --- platform/linux-generic/_ishm.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/platform/linux-generic/_ishm.c

[lng-odp] [API-NEXT PATCH 2/2] test: shm: checking exported vs imported block length

Checking that the block size returned by odp_shm_info() matches the exported block length. Signed-off-by: Christophe Milard --- test/linux-generic/validation/api/shmem/shmem_odp2.c | 8 1 file changed, 8 insertions(+) diff --git

[lng-odp] [API-NEXT PATCH 1/2] linux-gen: _ishm: exporting/importing user len and flags

The size of the shared memory and its user flag set, as given at reserve time, are exported and imported so that odp_shm_info() return proper values on imported blocks Signed-off-by: Christophe Milard --- platform/linux-generic/_ishm.c | 38

Re: [lng-odp] Suspected SPAM - [API-NEXT PATCH 1/3] api: unify ODP_*_NAME_LEN specifications

For the entire patch set: Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Matias Elo > Sent: Tuesday, December 20, 2016 3:45 PM > To: lng-odp@lists.linaro.org > Subject: Suspected