Re: [lng-odp] [API-NEXT PATCH 1/7] api: packet: src and dst packet must not be the same

> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, December 22, 2016 6:59 PM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com> > Cc: lng-odp-forward > Subject: Re: [lng-odp] [API-NEXT PATCH 1/7] api: packet: src and dst > packet must not

[lng-odp] [Bug 2464] strict priority schedule is not tested under CI

https://bugs.linaro.org/show_bug.cgi?id=2464 --- Comment #4 from Yi He --- v1 conflict with http://patches.opendataplane.org/patch/7600/ v2 rebased and sent to the mailing list: http://patches.opendataplane.org/patch/7707/ -- You are receiving this mail because: You are on the CC list for the b

[lng-odp] [API-NEXT PATCHv2] linux-gen: sched: fix SP scheduler hang in process mode

SP scheduler hangs in process mode performance test due to global data structure were not created in shared memory region. Signed-off-by: Yi He --- since v1: rebased upon Petri's linux-gen: schedule_sp: use ring as priority queue platform/linux-generic/odp_schedule_sp.c | 100 +

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

On Thu, Dec 22, 2016 at 9:07 AM, Bala Manoharan wrote: > On 21 December 2016 at 19:45, Bill Fischofer > wrote: >> On Wed, Dec 21, 2016 at 6:42 AM, Bala Manoharan >> wrote: >>> Regards, >>> Bala >>> >>> >>> On 20 December 2016 at 22:35, Bill Fischofer >>> wrote: On Tue, Dec 20, 2016 at 8:

Re: [lng-odp] [API-NEXT PATCHv5 1/5] drv: adding driver registration interface (stub)

On 12/19/16 13:50, Christophe Milard wrote: > The enumerator class, enumerator instance, devio and driver registration > functions prototypes (and a draft of their parameters) are > defined, the goal being to define the registration framework only. > > Signed-off-by: Christophe Milard > --- > in

Re: [lng-odp] [API-NEXT PATCHv5 3/5] linux-gen: init: adding configuration file parsing

On 12/19/16 13:50, Christophe Milard wrote: > The parsing of the odp.conf configuration file is added. > The file is searched first in the local directory (.) and > then is the $prefix/etc directory. > This requires libconfig (sudo apt-get install libconfig-dev) > > Signed-off-by: Christophe Milar

Re: [lng-odp] [API-NEXT PATCH v2 2/2] api: move ODP_*_NAME_LEN definitions from API to implementation

Merged. On 12/21/16 14:27, Matias Elo wrote: > Enables the implementations to choose the define values. > > Signed-off-by: Matias Elo > --- > > Reviewed-by: Petri Savolainen > Reviewed-by: Bill Fischofer > it's better to add review to commit log. In that case I do not need to copy-paste the

Re: [lng-odp] [API-NEXT PATCH 0/7] optimize packet concat

On Thu, Dec 22, 2016 at 12:32 PM, Maxim Uvarov wrote: > checked that code compiles on that broken compiler. So it will be nice > to merge once approved. Good to know. I think the changes are good and will enable further optimization, but I'd like clarification about the proposed semantics changes

Re: [lng-odp] [API-NEXT PATCH 0/7] optimize packet concat

checked that code compiles on that broken compiler. So it will be nice to merge once approved. Maxim. On 12/22/16 17:33, Petri Savolainen wrote: > Optimized concat operation to avoid packet copy when destination > packet has room to link source packet segments. Extend tail/head was > also modif

Re: [lng-odp] [API-NEXT PATCH 1/7] api: packet: src and dst packet must not be the same

On Thu, Dec 22, 2016 at 8:33 AM, Petri Savolainen wrote: > Concat and copy_from_pkt operations must be called with src and > dst packet handles which refer to the same packet. > > Signed-off-by: Petri Savolainen > --- > include/odp/api/spec/packet.h | 6 +- > 1 file changed, 5 insertions(+),

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

On 21 December 2016 at 19:45, Bill Fischofer wrote: > On Wed, Dec 21, 2016 at 6:42 AM, Bala Manoharan > wrote: >> Regards, >> Bala >> >> >> On 20 December 2016 at 22:35, Bill Fischofer >> wrote: >>> On Tue, Dec 20, 2016 at 8:26 AM, Bala Manoharan >>> wrote: On 20 December 2016 at 18:26, B

Re: [lng-odp] [API-NEXT PATCH] linux-gen: schedule_sp: use ring as priority queue

Merged, Maxim. On 12/14/16 10:58, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] >> Sent: Tuesday, December 13, 2016 4:06 PM >> To: Savolainen, Petri (Nokia - FI/Espoo) > labs.com>; lng-odp@lists.linaro.org >>

Re: [lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler error

Le 12/22/2016 à 02:49 PM, Maxim Uvarov a écrit : > On debian jessie gcc unable to compile current code > with error: > odp_packet.c: In function 'odp_packet_trunc_head': > odp_packet.c:314:46: error: array subscript is above array bounds > [-Werror=array-bounds] > to->buf_hdr.seg[i].len = from->

[lng-odp] [Bug 2407] test odp_l2fwd_run.sh contains todo items

https://bugs.linaro.org/show_bug.cgi?id=2407 --- Comment #4 from Mike Holmes --- Should set core limit rather than saturate the machine -- You are receiving this mail because: You are the assignee for the bug.

Re: [lng-odp] [PATCHv2, 1/1] validation: pktio: fix invalid mac addr

On Thu, Dec 22, 2016 at 08:03:07PM +0530, Bala Manoharan wrote: > Regards, > Bala > > > On 22 December 2016 at 19:22, Josep Puigdemont > wrote: > > On Thu, Dec 22, 2016 at 12:22:50PM +0530, Bala Manoharan wrote: > >> Regards, > >> Bala > >> > >> > >> On 8 December 2016 at 21:03, Josep Puigdemont

Re: [lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler error

Something updated in CI and we are again green: https://ci.linaro.org/job/odp-api-check/ Maxim. On 12/22/16 17:39, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] >> Sent: Thursday, December 22, 2016 4:20

[lng-odp] [Bug 2494] Extend odp_pktio_capability_t to include minimal pool size required by pktio implementation.

https://bugs.linaro.org/show_bug.cgi?id=2494 Mike Holmes changed: What|Removed |Added Status|CONFIRMED |IN_PROGRESS --- Comment #12 from Mike Holmes --

[lng-odp] [Bug 2685] l2fwd test does not switch output event queues correctly

https://bugs.linaro.org/show_bug.cgi?id=2685 Mike Holmes changed: What|Removed |Added Resolution|--- |FIXED Status|IN_PROGRESS

[lng-odp] [Bug 2733] Allocated hugepages are not released after 'make check'

https://bugs.linaro.org/show_bug.cgi?id=2733 Mike Holmes changed: What|Removed |Added Resolution|--- |FIXED Status|IN_PROGRESS

Re: [lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler error

> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, December 22, 2016 4:20 PM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com> > Cc: Mike Holmes ; Maxim Uvarov > ; lng-odp > Subject: Re: [lng-odp] [PATCHv2] linux-generic: packet: fix bugg

[lng-odp] [API-NEXT PATCH 6/7] validation: packet: add new concat and extend tests

Added new tests for better packet concat and extend test coverage. Both small and large data length are needed to create various segmentation scenarios. Signed-off-by: Petri Savolainen --- test/common_plat/validation/api/packet/packet.c | 490 test/common_plat/validation

[lng-odp] [API-NEXT PATCH 5/7] linux-gen: packet: optimize concat

Optimized concat operation to avoid packet copy when destination packet has room to link source packet segments. Since concat uses extend tail it was also modified to handle variable segment sizes. Signed-off-by: Petri Savolainen --- .../linux-generic/include/odp_buffer_internal.h| 2 +- p

[lng-odp] [API-NEXT PATCH 4/7] validation: packet: concat-split test bug fix

Successful concat return values are 0 and >0. Signed-off-by: Petri Savolainen --- test/common_plat/validation/api/packet/packet.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/common_plat/validation/api/packet/packet.c b/test/common_plat/validation/api/pack

[lng-odp] [API-NEXT PATCH 2/7] linux-gen: packet: fix bug in tailroom calculation

Tailroom is calculated from the end of the last segment, not from the first. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_packet.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/

[lng-odp] [API-NEXT PATCH 1/7] api: packet: src and dst packet must not be the same

Concat and copy_from_pkt operations must be called with src and dst packet handles which refer to the same packet. Signed-off-by: Petri Savolainen --- include/odp/api/spec/packet.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/odp/api/spec/packet.h b/include/od

[lng-odp] [API-NEXT PATCH 3/7] linux-gen: packet: improve packet print

Added segmentation and head-/tailroom information to packet print out. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_packet.c | 20 1 file changed, 20 insertions(+) diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c inde

Re: [lng-odp] [PATCHv2, 1/1] validation: pktio: fix invalid mac addr

Regards, Bala On 22 December 2016 at 19:22, Josep Puigdemont wrote: > On Thu, Dec 22, 2016 at 12:22:50PM +0530, Bala Manoharan wrote: >> Regards, >> Bala >> >> >> On 8 December 2016 at 21:03, Josep Puigdemont >> wrote: >> > On Thu, Nov 10, 2016 at 07:58:39PM +0530, Bala Manoharan wrote: >> >> F

[lng-odp] [API-NEXT PATCH 0/7] optimize packet concat

Optimized concat operation to avoid packet copy when destination packet has room to link source packet segments. Extend tail/head was also modified to handle variable sized segments. New validation tests were added to improve test coverage of various segmentation scenarios. Also couple of bugs

[lng-odp] [API-NEXT PATCH 7/7] linux-gen: config: increase max num of segments

Higher segment count enables optimizations (no data copy) on operations that modifying packet length. Signed-off-by: Petri Savolainen --- platform/linux-generic/include/odp_config_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/include/odp_co

[lng-odp] [Bug 2557] API random.h contains doxygen todo

https://bugs.linaro.org/show_bug.cgi?id=2557 Bill Fischofer changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|---

Re: [lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler error

On Thu, Dec 22, 2016 at 8:13 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike >> Holmes >> Sent: Thursday, December 22, 2016 4:08 PM >> To: Maxim Uvarov >> Cc: lng-odp >> Subject: Re: [l

Re: [lng-odp] [PATCHv2, 1/1] validation: pktio: fix invalid mac addr

On Thu, Dec 22, 2016 at 7:52 AM, Josep Puigdemont wrote: > On Thu, Dec 22, 2016 at 12:22:50PM +0530, Bala Manoharan wrote: >> Regards, >> Bala >> >> >> On 8 December 2016 at 21:03, Josep Puigdemont >> wrote: >> > On Thu, Nov 10, 2016 at 07:58:39PM +0530, Bala Manoharan wrote: >> >> Fixes https://

Re: [lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler error

On 22 December 2016 at 17:13, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Mike > > Holmes > > Sent: Thursday, December 22, 2016 4:08 PM > > To: Maxi

Re: [lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler error

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Thursday, December 22, 2016 4:08 PM > To: Maxim Uvarov > Cc: lng-odp > Subject: Re: [lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler > error > > On 22 December

Re: [lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler error

On 22 December 2016 at 08:49, Maxim Uvarov wrote: > On debian jessie gcc unable to compile current code > with error: > odp_packet.c: In function 'odp_packet_trunc_head': > odp_packet.c:314:46: error: array subscript is above array bounds > [-Werror=array-bounds] > to->buf_hdr.seg[i].len = from->

Re: [lng-odp] [PATCH] test: tm: queue id can be not updated

Merged, Maxim. On 12/21/16 17:40, Mike Holmes wrote: > > > On 21 December 2016 at 08:38, Maxim Uvarov > wrote: > > get_unique_id() function on error do not update it's second and > third arguments (unique_id and is_ipv4). gcc -O3 finds that > and tra

Re: [lng-odp] [PATCHv2, 1/1] validation: pktio: fix invalid mac addr

On Thu, Dec 22, 2016 at 12:22:50PM +0530, Bala Manoharan wrote: > Regards, > Bala > > > On 8 December 2016 at 21:03, Josep Puigdemont > wrote: > > On Thu, Nov 10, 2016 at 07:58:39PM +0530, Bala Manoharan wrote: > >> Fixes https://bugs.linaro.org/show_bug.cgi?id=2496 > >> > >> Signed-off-by: Bala

[lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler error

On debian jessie gcc unable to compile current code with error: odp_packet.c: In function 'odp_packet_trunc_head': odp_packet.c:314:46: error: array subscript is above array bounds [-Werror=array-bounds] to->buf_hdr.seg[i].len = from->buf_hdr.seg[num + i].len; The problem is that it breaks compil

Re: [lng-odp] [PATCH v3 1/2] test: perf: add new ordered pktio application

Ping > On 1 Dec 2016, at 15:01, Matias Elo wrote: > > Add new test application for ordered queue functionality and performance > validation. The application sets sequence numbers to incoming packets using > ordered pktin queues and ordered context locks. After being tagged packets > are enqueue

Re: [lng-odp] api for small buffer allocations

On 22 December 2016 at 13:49, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > HTML mail ... otherwise looks reasonable. See some comments under (for the > future API spec for the same feature). Sorry for that, Obviously google feels it should revert to HTML from time to time. > > > > From: Chri

Re: [lng-odp] [API-NEXT PATCHv2] linux-gen: _ishm: unlinking files asap for cleaner termination

Merged, Maxim. On 12/20/16 19:43, Christophe Milard wrote: > Ping. > I think this patch would ease cleaning up the Huge pages. If reviewed, > it is candidate for "next" and master. > Christophe. > > On 6 December 2016 at 18:25, Christophe Milard > mailto:christophe.mil...@linaro.org>> wrote: > >

[lng-odp] [Bug 2790] CID 173382: Memory - illegal accesses /test/common_plat/performance/odp_l2fwd.c

https://bugs.linaro.org/show_bug.cgi?id=2790 Bill Fischofer changed: What|Removed |Added Status|UNCONFIRMED |IN_PROGRESS Ever confirmed|0

Re: [lng-odp] api for small buffer allocations

HTML mail ... otherwise looks reasonable. See some comments under (for the future API spec for the same feature). From: Christophe Milard [mailto:christophe.mil...@linaro.org] Sent: Thursday, December 22, 2016 11:24 AM To: Savolainen, Petri (Nokia - FI/Espoo) ; Mike Holmes ; Bill Fischofer

[lng-odp] [PATCH] test: perf: add assert since src_idx cannot be negative

Address Bug https://bugs.linaro.org/show_bug.cgi?id=2790 by adding an assert. odp_packet_input_index() only returns a negative value if the packet did not originate on an I/O interface, which is known to be false here. Signed-off-by: Bill Fischofer --- test/common_plat/performance/odp_l2fwd.c |

[lng-odp] api for small buffer allocations

Hi, I am trying to sum up what was said at the arch call yesterday, regarding memory allocation to figure out how to rewrite my "buddy allocator for drv interface" patch series. - Some voices seemed to say that a single allocation would be best, regardless of the size being allocated (mostly at t