[lng-odp] [Bug 2798] ODP random and other crypto functions (possibly) not thread safe?

2017-01-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2798 Bill Fischofer changed: What|Removed |Added Ever confirmed|0 |1 Severity|enhancement

[lng-odp] [API-NEXT PATCH] linux-generic: init: add openssl locking support for thread safety

2017-01-05 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2798 by adding OpenSSL callbacks for locking that use ticketlocks to provide thread-safety for OpenSSL calls made by ODP components such as random number generation. Signed-off-by: Bill Fischofer --- platform/linux-generic/include/odp_internal.

[lng-odp] Internal component modularization

2017-01-05 Thread Honnappa Nagarahalli
Hi, As we had discussed earlier, the queue internal data structure members are being accessed by other components. Modularizing the queue component will make it easy to introduce different implementations of queue. I have written a small document generalizing the methods/conventions we want to

[lng-odp] [API-NEXT PATCHv6 5/5] doc: userguide: add user documentation for packet references

2017-01-05 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- doc/users-guide/users-guide-packet.adoc | 239 +++- 1 file changed, 238 insertions(+), 1 deletion(-) diff --git a/doc/users-guide/users-guide-packet.adoc b/doc/users-guide/users-guide-packet.adoc index e3be23c..aecdca2 100644 --- a/d

[lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-05 Thread Bill Fischofer
Implement the APIs: - odp_packet_ref_static() - odp_packet_ref() - odp_packet_ref_pkt() - odp_packet_is_ref() - odp_packet_unshared_len() This also involves functional upgrades to the existing packet manipulation APIs to work with packet references as input arguments. Signed-off-by: Bill Fischofe

[lng-odp] [API-NEXT PATCHv6 3/5] validation: packet: add packet reference tests

2017-01-05 Thread Bill Fischofer
Add validation tests for the new packet reference APIs: - odp_packet_ref_static() - odp_packet_ref() - odp_packet_ref_pkt() - odp_packet_is_ref() - odp_packet_unshared_len() Signed-off-by: Bill Fischofer --- test/common_plat/validation/api/packet/packet.c | 368 +++- test/com

[lng-odp] [API-NEXT PATCHv6 1/5] api: packet: add support for packet references

2017-01-05 Thread Bill Fischofer
Introduce three new APIs that support efficient sharing of portions of packets. odp_packet_ref_static() creates an alias for a base packet odp_packet_ref() creates a reference to a base packet odp_packet_ref_pkt() creates a reference to a base packet from a supplied header packet In addition, t

[lng-odp] [Bug 2494] Extend odp_pktio_capability_t to include minimal pool size required by pktio implementation.

2017-01-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2494 --- Comment #13 from Bala Manoharan --- I have proposed an implementation change by which the API modification is not required. Waiting for reply from Maceij -- You are receiving this mail because: You are on the CC list for the bug.

[lng-odp] [PATCHv3 1/1] validation: pktio: fix invalid mac addr

2017-01-05 Thread Balasubramanian Manoharan
Fixes https://bugs.linaro.org/show_bug.cgi?id=2496 Signed-off-by: Balasubramanian Manoharan --- v3: Review comment incorporation test/common_plat/validation/api/pktio/pktio.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/test/common_plat/validation/api/pktio/pktio

Re: [lng-odp] [API-NEXT PATCHv2] linux-gen: _ishm: fixing typos

2017-01-05 Thread Bill Fischofer
On Wed, Dec 21, 2016 at 6:55 AM, Christophe Milard wrote: > Fixing a set of iritating typos. just in comments. > > Signed-off-by: Christophe Milard Reviewed-by: Bill Fischofer > --- > > Since V1: > another typo found by Bill > > platform/linux-generic/_ishm.c | 24

Re: [lng-odp] register_notifier

2017-01-05 Thread Christophe Milard
ok for me On 5 January 2017 at 13:19, Francois Ozog wrote: > Monday is my busiest day (last call ends 10pm) but we can do a morning > call: 11amCET? > > On 5 January 2017 at 12:28, Christophe Milard < > christophe.mil...@linaro.org> wrote: > >> Hi Francois, >> >> Can we have a HO on monday ( I u

Re: [lng-odp] register_notifier

2017-01-05 Thread Francois Ozog
Monday is my busiest day (last call ends 10pm) but we can do a morning call: 11amCET? On 5 January 2017 at 12:28, Christophe Milard wrote: > Hi Francois, > > Can we have a HO on monday ( I understood today was busy for you, FF and I > tomorrow is a swedish national holiday). If not, we can of co

Re: [lng-odp] [API-NEXT PATCHv2] linux-gen: _ishm: fixing typos

2017-01-05 Thread Christophe Milard
Ping. Should be easy to review :-) On 21 December 2016 at 13:55, Christophe Milard wrote: > Fixing a set of iritating typos. just in comments. > > Signed-off-by: Christophe Milard > --- > > Since V1: > another typo found by Bill > > platform/linux-generic/_ishm.c | 24 --

Re: [lng-odp] register_notifier

2017-01-05 Thread Christophe Milard
Hi Francois, Can we have a HO on monday ( I understood today was busy for you, FF and I tomorrow is a swedish national holiday). If not, we can of course take in on tuesday. The topics I'd like to discuss are: 1) change of interface: pass a struct _param_t at register time and get a handle as a

Re: [lng-odp] register_notifier

2017-01-05 Thread Francois Ozog
Hi Christophe, event are not just "new device" (in that case I would agree with you). Events can be: - "attention" (before "poweroff") for a specific device to orderly shutdown before poweroff (or remove if virtio-net device in a VM). - SFP insertion/removal of a specific port - Error condition (a

Re: [lng-odp] [API-NEXT PATCHv2 3/4] linux-gen: add generic bitmaps and iterators

2017-01-05 Thread Yi He
O, missing this mail Hi, Maxim, for the error and warnings it seems the checkpatch.pl cannot recognize function pointers usage in macro definition, but it is a must in this generic programming practice. For those checks are only one space or parenthesize, trying to make code looks more clear and e

Re: [lng-odp] [API-NEXT PATCHv9 1/5] drv: adding driver registration interface (stub)

2017-01-05 Thread Yi He
I've read and run tests again and my review still stands for this v9 series: Reviewed-and-tested-by: Yi He Best Regards, Yi On 3 January 2017 at 00:09, Christophe Milard wrote: > The enumerator class, enumerator instance, devio and driver registration > functions prototypes (and a draft of th

[lng-odp] register_notifier

2017-01-05 Thread Christophe Milard
Hi Francois, Following your suggestion, the driver API contains: /** Register event notifier function for hotplug events: */ int (*register_notifier)(void (*event_handler) (void)); But I an now wondering: Why this double callback? Wouldn't it be simpler to have the function