Re: [lng-odp] [API-NEXTv5 1/6] linux-gen: _ishm: adding buddy and slab allocation

2017-01-11 Thread Yi He
Hi, Christophe, Q1: this patchset name seems a little problem: API-NEXTv5 -> API-NEXT PATCHv5 Q2: the 1/6 patch cannot be applied to the api-next, I've tried to fix to continue the test but did not work, need to re-base and I'll test then. For the patchset code looks OK to me and below

Re: [lng-odp] [API-NEXT PATCHv3] linux-generic: crypto: add openssl locking support for thread safety

2017-01-11 Thread Christophe Milard
Hi Bill, On 11 January 2017 at 13:25, Bill Fischofer wrote: > On Wed, Jan 11, 2017 at 3:35 AM, Christophe Milard > wrote: >> On 2017-01-09 09:24, Bill Fischofer wrote: >>> Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2798 by adding

Re: [lng-odp] [API-NEXT PATCH 1/4] validation: crypto: fix hw cipher/auth algorithm check

2017-01-11 Thread Krishna Garapati
for this series, Reviewed-by: Balakrishna Garapati /Krishna On 10 January 2017 at 13:09, Matias Elo wrote: > Some algorithms may be implemented using hardware and some using software. > All supported algorithms should be set in

Re: [lng-odp] [API-NEXT PATCHv3 3/4] linux-gen: add generic bitmaps and iterators

2017-01-11 Thread Yi He
Yes, ARRAY_SIZE is a kernel macro, I looked into the checkpatch.pl and see no flag to enable/disable this check, shall we comment it out or remove that piece of code? Best Regards, Yi On 12 January 2017 at 07:40, Bill Fischofer wrote: > On Wed, Jan 11, 2017 at 1:50

[lng-odp] [Bug 2765] Pool fixed memory overhead is excessive

2017-01-11 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2765 Bill Fischofer changed: What|Removed |Added Resolution|--- |FIXED

Re: [lng-odp] [API-NEXT PATCHv3 1/4] linux-gen: sched: solve ordered context inversion

2017-01-11 Thread Bill Fischofer
For this series: Reviewed-and-tested-by: Bill Fischofer On Wed, Jan 11, 2017 at 1:50 AM, Yi He wrote: > For ordered queue, a thread consumes events (dequeue) and > acquires its unique sequential context in two steps, non > atomic and preemptable. >

Re: [lng-odp] [API-NEXT PATCHv3 3/4] linux-gen: add generic bitmaps and iterators

2017-01-11 Thread Bill Fischofer
On Wed, Jan 11, 2017 at 1:50 AM, Yi He wrote: > Add C++ template alike bitmap to allow > instantiate bitmap data structure of any size, > and provide iterators to help walking through > the bitmap objects. > > Signed-off-by: Yi He > --- >

[lng-odp] ODP and Ingress Flow Control

2017-01-11 Thread Bill Fischofer
We discussed this briefly during today's ARCH call so I wanted to raise this as a topic to explore here as well as possibly discuss as part of the ODP Design Summit at BUD17. Background When packets are received via PktIO, they become odp_packet_t objects that are stored in an

Re: [lng-odp] [API-NEXT PATCH v2 0/5] Packet header optimizations

2017-01-11 Thread Maxim Uvarov
On 01/10/17 22:42, Bill Fischofer wrote: > For this series: > > Reviewed-and-tested-by: Bill Fischofer > Merged! > On Tue, Jan 10, 2017 at 3:19 AM, Petri Savolainen > wrote: >> Packet and buffer header structure sizes are optimized.

Re: [lng-odp] [API-NEXT PATCHv4] linux-generic: pool: defer ring allocation until pool creation

2017-01-11 Thread Maxim Uvarov
Merged, Maxim. On 01/11/17 16:50, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Reviewed-by: Petri Savolainen > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill >> Fischofer >> Sent: Tuesday, January 10,

[lng-odp] [PATCH v5 1/2] test: perf: add new ordered pktio application

2017-01-11 Thread Matias Elo
Add new test application for ordered queue functionality and performance validation. The application sets sequence numbers to incoming packets using ordered pktin queues and ordered context locks. After being tagged packets are enqueued to atomic queues based on flow hash (IPv4 5-tuple). In atomic

[lng-odp] [PATCH v5 2/2] test: pktio_ordered: add test script

2017-01-11 Thread Matias Elo
Enable application testing using pcap pktio. Signed-off-by: Matias Elo --- v5: - Loop pcap input file LOOPS times to better test application throughput (Maxim) test/common_plat/performance/Makefile.am | 1 + .../performance/odp_pktio_ordered_run.sh |

Re: [lng-odp] [API-NEXT PATCHv4] linux-generic: pool: defer ring allocation until pool creation

2017-01-11 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: Tuesday, January 10, 2017 6:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCHv4]

Re: [lng-odp] [PATCH] test: perf: add assert since src_idx cannot be negative

2017-01-11 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 22 December 2016 at 18:13, Bill Fischofer wrote: > Address Bug https://bugs.linaro.org/show_bug.cgi?id=2790 by adding an > assert. odp_packet_input_index() only returns a negative value if the >

Re: [lng-odp] [API-NEXT PATCHv3 0/4] Add iquery scheduler

2017-01-11 Thread Yi He
Hi, Mike and Maxim It seems the patchwork missed the latest one, I resend and wish it can reach the patchwork soon. Thanks for the review and test. Best Regards On 11 January 2017 at 21:06, Mike Holmes wrote: > > > On 11 January 2017 at 08:04, Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCHv3 0/4] Add iquery scheduler

2017-01-11 Thread Mike Holmes
Wow, long delay it has showed up just now. On 11 January 2017 at 08:06, Mike Holmes wrote: > > > On 11 January 2017 at 08:04, Maxim Uvarov wrote: > >> On 01/11/17 16:00, Mike Holmes wrote: >> > Hi Yi >> > >> > Am I missing a prerequisite patch ?

[lng-odp] [API-NEXT PATCHv3 4/4] linux-gen: add interests query (iquery) scheduler

2017-01-11 Thread Yi He
Add this interests query (iquery) scheduler as an alternate choice of ODP-linux scheduler component for performance optimization especially in lower queue counts use cases. It includes a new core algorithm, but adopted the ring-based pktio poll algorithm from default scheduler, and still uses the

Re: [lng-odp] [API-NEXT PATCHv3 0/4] Add iquery scheduler

2017-01-11 Thread Mike Holmes
On 11 January 2017 at 08:04, Maxim Uvarov wrote: > On 01/11/17 16:00, Mike Holmes wrote: > > Hi Yi > > > > Am I missing a prerequisite patch ? > > > > I see in ML 4 patches. > You were directly mailed in the original post, I think the list did not get number 4 > > >

Re: [lng-odp] [API-NEXT PATCHv3 0/4] Add iquery scheduler

2017-01-11 Thread Maxim Uvarov
On 01/11/17 16:00, Mike Holmes wrote: > Hi Yi > > Am I missing a prerequisite patch ? > I see in ML 4 patches. > http://patches.opendataplane.org/project/lng-odp/list/ > Looks like some bug on that link. > Shows only three of the 4 patches, same in my mailbox > > > On branch api-next >

Re: [lng-odp] [API-NEXT PATCHv3 0/4] Add iquery scheduler

2017-01-11 Thread Mike Holmes
Hi Yi Am I missing a prerequisite patch ? http://patches.opendataplane.org/project/lng-odp/list/ Shows only three of the 4 patches, same in my mailbox On branch api-next Your branch is ahead of 'origin/api-next' by 3 commits. (use "git push" to publish your local commits) nothing to commit,

Re: [lng-odp] Pktio Queue scheduling configuration

2017-01-11 Thread Bill Fischofer
Good question. I've added this to today's ARCH call agenda so we can discuss. Thanks. On Wed, Jan 11, 2017 at 6:14 AM, Nikhil Agarwal wrote: > Hi, > > In the current ODP API ODP_PKTIN_QUEUE_CONFIG, to configure input queues to > Pktio, there is only one set of input

[lng-odp] Pktio Queue scheduling configuration

2017-01-11 Thread Nikhil Agarwal
Hi, In the current ODP API ODP_PKTIN_QUEUE_CONFIG, to configure input queues to Pktio, there is only one set of input queue_param in structure odp_pktin_queue_param_t while num_queues can be more than 1. If I want to attach different queues of a pktio to different scheduler groups, I did not

Re: [lng-odp] [API-NEXT PATCHv3] linux-generic: crypto: add openssl locking support for thread safety

2017-01-11 Thread Christophe Milard
On 2017-01-09 09:24, Bill Fischofer wrote: > Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2798 by adding > OpenSSL callbacks for locking that use ticketlocks to provide > thread-safety for OpenSSL calls made by ODP components such as random > number generation. > > Signed-off-by: Bill