Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

2017-01-30 Thread Ola Liljedahl
On 30 January 2017 at 23:50, Bill Fischofer wrote: > Checkpatch still has some issues with this: > > ill@Ubuntu15:~/linaro/review$ ./scripts/checkpatch.pl > 0001-example-add-IPv4-fragmentation-reassembly-example.patch > WARNING: 'DONT' may be misspelled - perhaps

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

2017-01-30 Thread Bill Fischofer
Checkpatch still has some issues with this: ill@Ubuntu15:~/linaro/review$ ./scripts/checkpatch.pl 0001-example-add-IPv4-fragmentation-reassembly-example.patch WARNING: 'DONT' may be misspelled - perhaps 'DON'T'? #1056: FILE: example/ipfragreass/odp_ipfragreass_ip.h:20: +#define IP_FRAG_DONT

[lng-odp] [API-NEXT PATCH] doc: userguide: add section on application portability

2017-01-30 Thread Bill Fischofer
Add a section to the ODP User Guide discussing application portability considerations and the use of source and binary portability options provided by ODP. Signed-off-by: Bill Fischofer --- doc/users-guide/users-guide.adoc | 120 +++

Re: [lng-odp] [PATCH 2/2] validation: classification: add test case for ipv6 src and dst addr

2017-01-30 Thread Bill Fischofer
On Mon, Jan 30, 2017 at 6:56 AM, Balasubramanian Manoharan wrote: > Adds test case for ipv6 source and destination address matching > > Signed-off-by: Balasubramanian Manoharan > --- > .../validation/api/classification/classification.h | 21

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

2017-01-30 Thread Maxim Uvarov
On 01/30/17 15:27, Ola Liljedahl wrote: > > > On 30 January 2017 at 02:28, Bill Fischofer > wrote: > > As the maintainer of the ODP git repo, Maxim has final say on style > questions for what is accepted into it, so I

Re: [lng-odp] [PATCH] travis: several tries to download cunit

2017-01-30 Thread Mike Holmes
On 30 January 2017 at 10:11, Maxim Uvarov wrote: > On 01/30/17 17:57, Mike Holmes wrote: > > > > > > On 30 January 2017 at 09:47, Maxim Uvarov > > wrote: > > > > On 01/30/17 17:38, Bill Fischofer wrote: > >

Re: [lng-odp] [PATCH] travis: several tries to download cunit

2017-01-30 Thread Maxim Uvarov
On 01/30/17 17:57, Mike Holmes wrote: > > > On 30 January 2017 at 09:47, Maxim Uvarov > wrote: > > On 01/30/17 17:38, Bill Fischofer wrote: > > On Mon, Jan 30, 2017 at 8:30 AM, Mike Holmes

Re: [lng-odp] [PATCH] travis: several tries to download cunit

2017-01-30 Thread Mike Holmes
On 30 January 2017 at 09:47, Maxim Uvarov wrote: > On 01/30/17 17:38, Bill Fischofer wrote: > > On Mon, Jan 30, 2017 at 8:30 AM, Mike Holmes > wrote: > >> Currently we have forked the repo and we pull from that copy, that copy > is > >> on Anders

Re: [lng-odp] [PATCH] travis: several tries to download cunit

2017-01-30 Thread Maxim Uvarov
On 01/30/17 17:38, Bill Fischofer wrote: > On Mon, Jan 30, 2017 at 8:30 AM, Mike Holmes wrote: >> Currently we have forked the repo and we pull from that copy, that copy is >> on Anders poeple.linaro.org for the internal Jenkins CI >> >> Maybe we add cunit fork to the lng

Re: [lng-odp] [PATCH] travis: several tries to download cunit

2017-01-30 Thread Maxim Uvarov
On 01/30/17 01:03, Bill Fischofer wrote: > On Fri, Jan 27, 2017 at 1:21 PM, Maxim Uvarov wrote: >> some time curl fails to download cunit from sf.net or it's >> mirrors. Try 10 times with 1 second delay. >> >> Signed-off-by: Maxim Uvarov >> ---

Re: [lng-odp] [PATCH] travis: several tries to download cunit

2017-01-30 Thread Bill Fischofer
On Mon, Jan 30, 2017 at 8:30 AM, Mike Holmes wrote: > Currently we have forked the repo and we pull from that copy, that copy is > on Anders poeple.linaro.org for the internal Jenkins CI > > Maybe we add cunit fork to the lng offical repo location so that we can do > this

[lng-odp] [PATCH] helper: iplookuptable: avoid potential null pointer dereferences

2017-01-30 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2862 by checking pointer validity before dereferencing. Signed-off-by: Bill Fischofer --- helper/iplookuptable.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

Re: [lng-odp] [PATCH] travis: several tries to download cunit

2017-01-30 Thread Mike Holmes
Currently we have forked the repo and we pull from that copy, that copy is on Anders poeple.linaro.org for the internal Jenkins CI Maybe we add cunit fork to the lng offical repo location so that we can do this from github also and not have to point at a personal location ? Mike On 29 January

[lng-odp] [PATCH 2/2] validation: classification: add test case for ipv6 src and dst addr

2017-01-30 Thread Balasubramanian Manoharan
Adds test case for ipv6 source and destination address matching Signed-off-by: Balasubramanian Manoharan --- .../validation/api/classification/classification.h | 21 ++ .../api/classification/odp_classification_common.c | 149 ++-

[lng-odp] [PATCH 1/2] linux-generic: classification: implement ipv6 packet matching rule

2017-01-30 Thread Balasubramanian Manoharan
Implements IPV6 src and dst address packet matching rule Signed-off-by: Balasubramanian Manoharan --- .../include/odp_classification_datamodel.h | 11 +- .../include/odp_classification_inlines.h | 44 ++

Re: [lng-odp] schedule_multi returning tasks from multiple queues

2017-01-30 Thread Bill Fischofer
On Mon, Jan 30, 2017 at 6:40 AM, Ola Liljedahl wrote: > On 30 January 2017 at 05:18, Honnappa Nagarahalli > wrote: >> On 26 January 2017 at 15:10, Bill Fischofer >> wrote: >>> On Wed, Jan 25, 2017 at 11:13

Re: [lng-odp] schedule_multi returning tasks from multiple queues

2017-01-30 Thread Ola Liljedahl
On 30 January 2017 at 05:18, Honnappa Nagarahalli wrote: > On 26 January 2017 at 15:10, Bill Fischofer wrote: >> On Wed, Jan 25, 2017 at 11:13 PM, Honnappa Nagarahalli >> wrote: >>> I agree, it needs

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

2017-01-30 Thread Ola Liljedahl
On 30 January 2017 at 02:28, Bill Fischofer wrote: > As the maintainer of the ODP git repo, Maxim has final say on style > questions for what is accepted into it, so I recommend deferring to > him on this. This is true of all open source projects, so there's > nothing

[lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

2017-01-30 Thread Joe Savage
Add an example application implementing lock-free IPv4 fragmentation and reassembly functionality using ODP's packet "concat" and "split". Signed-off-by: Joe Savage --- (This code contribution is provided under the terms of agreement LES-LTM-21309)