Re: [lng-odp] [API-NEXT PATCH v2 3/4] Revert "linux-generic: packet: implement reference apis"

2017-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Wednesday, February 15, 2017 6:19 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH v2 3/4] Revert "linux-generic: > packet: implement reference

Re: [lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

2017-02-15 Thread Bogdan Pricope
Hi, >From my point of view, at the end of review process this series (+ the patch related to stats logging message) should be added at least in odp-dpdk. Bogdan On 15 February 2017 at 18:55, Mike Holmes wrote: > So this is a request to add this to Monarch LTS then ? > >

Re: [lng-odp] [API-NEXT PATCHv4 1/4] api: timer: add odp_timer_capability() api

2017-02-15 Thread Yi He
For this patch series: Reviewed-and-tested-by: Yi He On 8 February 2017 at 10:37, Kevin Wang wrote: > Currently, user needs to decide the timer resolution before creating > a timer pool. But sometimes it will cause timer overrun as the system > can't

[lng-odp] [Bug 2862] CID 177251 et al: Unsafe pointer dereferences in iplookuptable() helper

2017-02-15 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2862 Bill Fischofer changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

[lng-odp] [Bug 2829] CID 168965: Unused value in helper iptablelookup

2017-02-15 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2829 Bill Fischofer changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

[lng-odp] [Bug 2830] CID 168956: Storage leak in cuckoo.c

2017-02-15 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2830 Bill Fischofer changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

[lng-odp] [Bug 2865] odp helper table APIs are not documented

2017-02-15 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2865 Bill Fischofer changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

Re: [lng-odp] [PATCH v3 0/8] First ABI files

2017-02-15 Thread Bill Fischofer
On Wed, Feb 15, 2017 at 12:53 PM, Brian Brooks wrote: > On Wed, Feb 15, 2017 at 5:14 AM, Savolainen, Petri (Nokia - FI/Espoo) > wrote: >> >> >> From: Yi He [mailto:yi...@linaro.org] >> Sent: Tuesday, February 14, 2017 3:59 AM >> To:

Re: [lng-odp] [PATCH 3/5] travis: catch doxygen errors

2017-02-15 Thread Maxim Uvarov
On 02/15/17 20:56, Mike Holmes wrote: > > > On 14 February 2017 at 15:32, Maxim Uvarov > wrote: > > make doxygen-doc does not return negative code on > errors. Do it manually. > > Signed-off-by: Maxim Uvarov

Re: [lng-odp] [PATCH 5/5] travis: check odp license agreement

2017-02-15 Thread Maxim Uvarov
On 02/15/17 20:49, Mike Holmes wrote: > > > On 14 February 2017 at 15:32, Maxim Uvarov > wrote: > > Signed-off-by: Maxim Uvarov > > --- > .travis.yml | 5 +

Re: [lng-odp] [PATCH v3 0/8] First ABI files

2017-02-15 Thread Brian Brooks
On Wed, Feb 15, 2017 at 5:14 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > From: Yi He [mailto:yi...@linaro.org] > Sent: Tuesday, February 14, 2017 3:59 AM > To: Savolainen, Petri (Nokia - FI/Espoo) > > Cc:

Re: [lng-odp] Merging crypto validation suite fixes to master

2017-02-15 Thread Maxim Uvarov
cherry-picked that patches from next. Maxim. On 15 February 2017 at 18:34, Bill Fischofer wrote: > Looks like Krishna gave it his review so it should be good to merge. > Maxim is out today but I suspect he'll get to it either tonight or > tomorrow. > > On Wed, Feb

[lng-odp] [PATCH 1/2] linux-gen: packet: remove unnecessary packet reparsing

2017-02-15 Thread Matias Elo
Previously the highest already parsed layer was unnecessarily reparsed on the following packet_parse_common() calls. Signed-off-by: Matias Elo --- platform/linux-generic/odp_packet.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git

[lng-odp] [PATCH 2/2] linux-gen: packet: reset packet parse level after offset change

2017-02-15 Thread Matias Elo
Reset packet parse level after odp_packet_*_offset_set() call. Otherwise the following odp_packet_has_error() would fail as the upper layer offsets are not valid anymore. Signed-off-by: Matias Elo --- platform/linux-generic/odp_packet.c | 11 +++ 1 file changed, 7

[lng-odp] [Linaro/odp] 981b77: validation: crypto: check auth options support bef...

2017-02-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 981b778400a726121400dd4535f3cc2006d4ac67 https://github.com/Linaro/odp/commit/981b778400a726121400dd4535f3cc2006d4ac67 Author: Matias Elo Date: 2017-02-15 (Wed, 15 Feb 2017) Changed

[lng-odp] [Linaro/odp] 8acb1d: validation: crypto: check cipher options support b...

2017-02-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 8acb1d0a0c97d6902ad1b9f975facfc9c88f47b5 https://github.com/Linaro/odp/commit/8acb1d0a0c97d6902ad1b9f975facfc9c88f47b5 Author: Matias Elo Date: 2017-02-15 (Wed, 15 Feb 2017) Changed

[lng-odp] [Linaro/odp] af2c8f: validation: crypto: check cipher/auth algorithm su...

2017-02-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: af2c8ff31853d005aaa13247e3a19e5be7138c97 https://github.com/Linaro/odp/commit/af2c8ff31853d005aaa13247e3a19e5be7138c97 Author: Matias Elo Date: 2017-02-15 (Wed, 15 Feb 2017) Changed

[lng-odp] [Linaro/odp] 3f9e9b: validation: crypto: fix hw cipher/auth algorithm c...

2017-02-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 3f9e9b3f17627e35843eef7e3846a75298259b69 https://github.com/Linaro/odp/commit/3f9e9b3f17627e35843eef7e3846a75298259b69 Author: Matias Elo Date: 2017-02-15 (Wed, 15 Feb 2017) Changed

Re: [lng-odp] Merging crypto validation suite fixes to master

2017-02-15 Thread Bill Fischofer
Looks like Krishna gave it his review so it should be good to merge. Maxim is out today but I suspect he'll get to it either tonight or tomorrow. On Wed, Feb 15, 2017 at 9:32 AM, Elo, Matias (Nokia - FI/Espoo) wrote: > This patch set

Re: [lng-odp] [API-NEXT PATCH v2 4/4] linux-gen: packet: implement references as copy

2017-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Wednesday, February 15, 2017 4:29 PM > To: Petri Savolainen > Cc: lng-odp-forward > Subject: Re: [lng-odp] [API-NEXT PATCH v2 4/4] linux-gen:

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Packet references as copy

2017-02-15 Thread Bill Fischofer
For Parts 1 and 2 only: Reviewed-and-tested-by: Bill Fischofer On Wed, Feb 15, 2017 at 6:29 AM, Petri Savolainen wrote: > Change packet references API specification to enable implementation as packet > copy. Remove validation test cases

Re: [lng-odp] [API-NEXT PATCH v2 4/4] linux-gen: packet: implement references as copy

2017-02-15 Thread Bill Fischofer
I'd still like to see this posted/used for odp-dpdk to give it basic functional parity with odp-linux in this area. On Wed, Feb 15, 2017 at 6:29 AM, Petri Savolainen wrote: > Implement packet references API as packet copy. This is the > simplest way to support the

[lng-odp] [PATCH v2] validation: A wrapper script to run test isolated.

2017-02-15 Thread Ravineet Singh
The wrapper script; odp_run_app_isolated.sh can be used to run ODP testcases in a isolated environment. Background noise can also be generated. Signed-off-by: Ravineet Singh v2: moved task-isolation dir to odp/scripts, requested my Maxim Uvarov ---

[lng-odp] [API-NEXT PATCH v2 3/4] Revert "linux-generic: packet: implement reference apis"

2017-02-15 Thread Petri Savolainen
This reverts commit 22b3986fea090986625f3255d57b64de35bbc475. --- .../linux-generic/include/odp_packet_internal.h| 85 +--- platform/linux-generic/odp_packet.c| 536 - 2 files changed, 107 insertions(+), 514 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH v2 2/4] validation: packet: remove non compatible tests

2017-02-15 Thread Petri Savolainen
Tests for bad inputs are not compatible to the spec. Out-of-range values cause undefined results and must not be tested in validation suite. Remove reference checks that do not comply anymore to the new odp_packet_has_ref() specification. Signed-off-by: Petri Savolainen

[lng-odp] [API-NEXT PATCH v2 0/4] Packet references as copy

2017-02-15 Thread Petri Savolainen
Change packet references API specification to enable implementation as packet copy. Remove validation test cases which test for out-of-range inputs. Generally, results are undefined for bad or out-of-range inputs. Update validation tests with the API change. Greatly simplify packet reference

[lng-odp] [API-NEXT PATCH v2 1/4] api: packet: references may be implemented as copy

2017-02-15 Thread Petri Savolainen
Some implementations may implement new references as packet copy. odp_packet_has_ref() will return 0 for copies, since those are unique packets. Signed-off-by: Petri Savolainen --- include/odp/api/spec/packet.h | 21 ++--- 1 file changed, 14

[lng-odp] [API-NEXT PATCH v2 4/4] linux-gen: packet: implement references as copy

2017-02-15 Thread Petri Savolainen
Implement packet references API as packet copy. This is the simplest way to support the API, as other packet functions are not affected at all. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_packet.c | 74 + 1 file

Re: [lng-odp] measuring time and/or cycles

2017-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> That is why CPU ISAs provide a timer that increments at a constant rate > (fixed frequency). It is not bound to the core's clock frequency. If the > core's frequency adjusts dynamically you can no longer use cycle counter > to measure time. If the core's frequency is fixed, it's still not >

Re: [lng-odp] [PATCH v3 0/8] First ABI files

2017-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Yi He [mailto:yi...@linaro.org] Sent: Tuesday, February 14, 2017 3:59 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: Brian Brooks ; lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH v3 0/8] First ABI files Hi, Petri

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Wednesday, February 15, 2017 11:40 AM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com> > Cc: Mike Holmes ; lng-odp

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-15 Thread Christophe Milard
On 15 February 2017 at 09:34, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Christophe Milard [mailto:christophe.mil...@linaro.org] >> Sent: Monday, February 13, 2017 5:41 PM >> To: Savolainen, Petri (Nokia - FI/Espoo)

Re: [lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

2017-02-15 Thread Bogdan Pricope
Hi, There were multiple small “fixes” required to make the packet valid. They should go in together and in all branches. Br, Bogdan On 14 February 2017 at 16:38, Nicolas Morey-Chaisemartin wrote: > > > Le 02/13/2017 à 01:49 PM, Bogdan Pricope a écrit : >> Signed-off-by:

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Monday, February 13, 2017 5:41 PM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com> > Cc: Mike Holmes ; lng-odp o...@lists.linaro.org>

Re: [lng-odp] Ask a few questions about odp

2017-02-15 Thread Christophe Milard
On 15 February 2017 at 04:32, ice wrote: > HI: > > I am from a network security company in China, We intend to use odp to > complete a bottom forwarding engine and data channel. > What I am concerned about before is that in the case of multithreading, the > crash of the thread