[lng-odp] [API-NEXT PATCHv6 3/4] validation/example: call odp_timer_capability() before creating timer pool

Use odp_timer_capability() to determine the max timer resolution Signed-off-by: Kevin Wang --- example/generator/odp_generator.c | 8 +++- example/timer/odp_timer_simple.c | 9 - example/timer/odp_timer_test.c| 8

[lng-odp] [API-NEXT PATCHv6 4/4] doc: userguide: add odp_timer_capability() section to user guide

Signed-off-by: Kevin Wang --- doc/users-guide/users-guide-timer.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/users-guide/users-guide-timer.adoc b/doc/users-guide/users-guide-timer.adoc index 9cd30de..4a8bad7 100644 ---

[lng-odp] [API-NEXT PATCHv6 2/4] linux-generic: timer: implement odp_timer_capability()

Implement a new internal function timer_res_init() to detect the max timer resolution without overrun at the ODP init stage. It will check timer resolution from 1ms to 100us, 10us...1ns until the timer is overrun. Signed-off-by: Kevin Wang ---

[lng-odp] [API-NEXT PATCHv6 1/4] api: timer: add odp_timer_capability() api

Currently, user needs to decide the timer resolution before creating a timer pool. But sometimes it will cause timer overrun as the system can't support such high resolution. So a new API is required to expose the timer capability to the user. Signed-off-by: Kevin Wang ---

Re: [lng-odp] Platform configurations for ODP-Cloud

Here is the link to Google Doc version: https://docs.google.com/a/linaro.org/document/d/1CXqN3pZay7Ni1Z7xhxW8_tmcIaKyuU8v-l5mshZ2RGk/edit?usp=sharing Thank you, Honnappa On 12 July 2017 at 15:49, Honnappa Nagarahalli wrote: > I tried briefly. The document

Re: [lng-odp] Platform configurations for ODP-Cloud

I tried briefly. The document converts easily. Main problem is the pictures. The pictures need to be redrawn. May be I will convert the document and will draw the pictures later tonight. Thanks, Honnappa On 12 July 2017 at 15:14, Bill Fischofer wrote: > Can you post

[lng-odp] [Bug 2857] Bus error on not enough hdd space (Ubuntu VM, aarch64)

https://bugs.linaro.org/show_bug.cgi?id=2857 --- Comment #6 from Maxim Uvarov --- yes that can be fixed. Other issue is docker has limitation of 64MB for /dev/shm and some our tests allocate pool more then 64MB (like helper tests). I opened separate bug for that. --

[lng-odp] [Bug 3126] IPC pktio test fails with taskset -c 1-2

https://bugs.linaro.org/show_bug.cgi?id=3126 --- Comment #1 from Maxim Uvarov --- Hm. I did not have isolcpus= in kernel but just with taskset it always pass for me. -- You are receiving this mail because: You are on the CC list for the bug.

Re: [lng-odp] Here it is as promised.

Not sure if the attachment made it to the ODP mailing list. Including the text here: Barry SpinneyJuly 12,2017 Combined Cipher and MAC operations The three Encrypt/MAC Operation Kinds are: ENCRYPT_THEN_MAC: Encrypt

Re: [lng-odp] Here it is as promised.

Thanks, Barry. Copying some interested parties as well as the ODP mailing list so the discussion can move there. Regards, Bill On Wed, Jul 12, 2017 at 2:46 PM, Barry Spinney wrote: > See attached ascii text file describing the THREE cases (whereas ODP and > maybe DPDK

Re: [lng-odp] Platform configurations for ODP-Cloud

Can you post a Google doc version of this to permit shared commenting? I can do that if you'd like, but you should probably be the doc owner. On Wed, Jul 12, 2017 at 3:05 PM, Honnappa Nagarahalli wrote: > Hi, >The discussion about what are the different

[lng-odp] Platform configurations for ODP-Cloud

Hi, The discussion about what are the different configurations of the platform that ODP-Cloud needs to support has come up now and then. I thought it is good to have a consensus, on the configurations we have to support for now, to help us guide in our future discussions. I created a word

[lng-odp] [Bug 3128] shm in docker fails

https://bugs.linaro.org/show_bug.cgi?id=3128 Maxim Uvarov changed: What|Removed |Added Assignee|christophe.mil...@linaro.or

[lng-odp] [Bug 3128] New: shm in docker fails

https://bugs.linaro.org/show_bug.cgi?id=3128 Bug ID: 3128 Summary: shm in docker fails Product: OpenDataPlane - linux- generic reference Version: master Hardware: Other OS: Linux Status: UNCONFIRMED

Re: [lng-odp] DPDK integration under DDF

Hi Francois, I will add this topic to tomorrow's ODP-Cloud call. Thank you, Honnappa On 12 July 2017 at 04:51, Francois Ozog wrote: > I'd like we sync up on key elements of the document at the arch call today. > > I'd like to restate a few things: > > - ODP Cloud

Re: [lng-odp] Regarding odp_pktin_rcv() packets

On Wed, Jul 12, 2017 at 8:50 PM, Bill Fischofer wrote: > On Wed, Jul 12, 2017 at 7:35 AM, shally verma > wrote: >> I have a question on odp_pktin_recv(odp_pktin_queue_t, odp_packet_t [], int). >> >> Once app receives packets associated to

Re: [lng-odp] API behavior of unsupported mode

On Wed, Jul 12, 2017 at 8:37 PM, Bill Fischofer wrote: > ODP_UNUSED is useful scaffolding. The alternative is to make a null > reference to unused parameters to avoid compile-time warnings. For > example: > > int odp_xxx(uint32_t x, uint32_t y) > { > (void)y;

Re: [lng-odp] API behavior of unsupported mode

ODP_UNUSED is useful scaffolding. The alternative is to make a null reference to unused parameters to avoid compile-time warnings. For example: int odp_xxx(uint32_t x, uint32_t y) { (void)y; /* avoid unused parameter warning for y */ ...do something useful with x } ODP in

[lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API

From: Dmitry Eremin-Solenikov It was decided that it would be benefitable to live with both API types at this point, as odp_crypto_compl_t was available for some time. So undeprecate odp_crypto_compl_t and related functionality. Validation tests also provide

[lng-odp] [PATCH API-NEXT v2 2/4] doc: move PREDEFINED to common place

From: Dmitry Eremin-Solenikov It is easy to update PREDEFINED definitions in one Doxyfile, while forgetting about the others, as happened e.g. with ODP_DEPRECATE(x) definition. Move PREDEFINED definitions into Doxyfile_common, so that it is included by the rest

[lng-odp] [PATCH API-NEXT v2 3/4] api: crypto: replace redundant packet_ prefixes from definitions

From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 74 (lumag:crypto-packet) ** https://github.com/Linaro/odp/pull/74 ** Patch:

[lng-odp] [PATCH API-NEXT v2 0/4] Crypto API updates

Updates for crypto API as suggested by @psavol github /** Email created from pull request 74 (lumag:crypto-packet) ** https://github.com/Linaro/odp/pull/74 ** Patch: https://github.com/Linaro/odp/pull/74.patch ** Base sha:

[lng-odp] [PATCH API-NEXT v2 1/4] validation: crypto: fix unitialized variable error

From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 74 (lumag:crypto-packet) ** https://github.com/Linaro/odp/pull/74 ** Patch:

[lng-odp] [API-NEXT PATCH v3 3/9] api: ipsec: direction specific SA params

Move direction (inboud/outbound) specific SA parameters into separate structures. Specification is more clear between common and direction specific SA parameters. Signed-off-by: Petri Savolainen Signed-off-by: Bogdan Pricope ---

[lng-odp] [API-NEXT PATCH v3 6/9] api: ipsec: split operation result status bits

Split error bits into error and warning bits. Move flags into separate type and field. This way, all exceptions (rare but important events) can be checked and maintained separately from operation flags, which may be set for almost every packet. Signed-off-by: Petri Savolainen

[lng-odp] [API-NEXT PATCH v3 8/9] api: ipsec: outer header pointer as const

Outer headers are read-only data for an implementation. Signed-off-by: Petri Savolainen Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[lng-odp] [API-NEXT PATCH v3 7/9] api: ipsec: flexible soft lifetime reporting

Allow implementation to decide how many times a soft lifetime expiration is reported. Application does not require strict synchronization of soft lifetimes. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 4 +++- 1 file changed, 3 insertions(+), 1

[lng-odp] [API-NEXT PATCH v3 5/9] api: ipsec: ignore aad capability

AAD lengths are needed in crypto API but not in IPSEC API. So, application should ignore AAD capability values in IPSEC API. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[lng-odp] [API-NEXT PATCH v3 2/9] api: ipsec: add max queues capability

Added capability to specify maximum number of different queues that can be used with IPsec. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 4 1 file changed, 4 insertions(+) diff --git a/include/odp/api/spec/ipsec.h

[lng-odp] [API-NEXT PATCH v3 1/9] api: ipsec: add salt parameter

Added a parameter for passing salt/nonce for algorithms that need it. Currently, only AES GCM needs it with 4 bytes of salt. Later on, other cipher (or auth) algorithms may need also salt/nonce data. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h |

[lng-odp] [API-NEXT PATCH v3 9/9] api: ipsec: remove initial sequence number parameter

Application should not need to control initial sequence number value as implementation is able to manage that internally. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [lng-odp] [API-NEXT PATCH v2 1/9] api: ipsec: add salt parameter

On 12.07.2017 15:56, Petri Savolainen wrote: > Added a parameter for passing salt/nonce for algorithms that > need it. Currently, only AES GCM needs it with 4 bytes of > salt. Later on, other cipher or auth algorithms may need > also salt/nonce data. > > Signed-off-by: Petri Savolainen

Re: [lng-odp] [PATCH API-NEXT v1 0/3] Crypto API updates

Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Wednesday, July 12, 2017 3:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v1 0/3]

[lng-odp] [PATCH v2 3/3] travis: add clang cross-compilation checks

From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 73 (lumag:cross-2) ** https://github.com/Linaro/odp/pull/73 ** Patch: https://github.com/Linaro/odp/pull/73.patch

[lng-odp] [PATCH v2 2/3] travis: simplify cross-compilation setup

From: Dmitry Eremin-Solenikov Following Maxim's idea use apt-get to download and install cross-packages. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 73 (lumag:cross-2) **

[lng-odp] [PATCH v2 0/3] Cross-compilation test updates

Per @muvarov's suggestion use apt-get instead of dpkg-cross to install cross-packages Add cross-compilation tests using clang github /** Email created from pull request 73 (lumag:cross-2) ** https://github.com/Linaro/odp/pull/73 ** Patch:

[lng-odp] [PATCH v2 1/3] example: ipfragaddress: fix compilation with clang

From: Dmitry Eremin-Solenikov Clang 3.8 is stricter than GCC wrt register allocation vs 128-bit variables. Sometimes it can not understand using 128-bit var in place of 64-bit register resulting in the following errors: /odp_ipfragreass_atomics_arm.h:18:51:

Re: [lng-odp] [API-NEXT PATCH 1/9] api: ipsec: add salt parameter

> -Original Message- > From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] > Sent: Wednesday, July 12, 2017 11:53 AM > To: Petri Savolainen ; lng- > o...@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 1/9] api: ipsec: add salt

[lng-odp] [API-NEXT PATCH v2 6/9] api: ipsec: split operation result status bits

Split error bits into error and warning bits. Move flags into separate type and field. This way, all exceptions (rare but important events) can be checked and maintained separately from operation flags, which may be set for almost every packet. Signed-off-by: Petri Savolainen

[lng-odp] [API-NEXT PATCH v2 3/9] api: ipsec: direction specific SA params

Move direction (inboud/outbound) specific SA parameters into separate structures. Specification is more clear between common and direction specific SA parameters. Signed-off-by: Petri Savolainen Signed-off-by: Bogdan Pricope ---

[lng-odp] [API-NEXT PATCH v2 8/9] api: ipsec: outer header pointer as const

Outer headers are read-only data for an implementation. Signed-off-by: Petri Savolainen Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[lng-odp] [API-NEXT PATCH v2 4/9] api: ipsec: remove time based SA lifetime

Application may track time based SA lifetime expiration efficiently and in many ways: e.g. ODP timers may be used, wall clock time may be polled, control plane may send notifications, etc. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 26

[lng-odp] [API-NEXT PATCH v2 1/9] api: ipsec: add salt parameter

Added a parameter for passing salt/nonce for algorithms that need it. Currently, only AES GCM needs it with 4 bytes of salt. Later on, other cipher or auth algorithms may need also salt/nonce data. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h |

[lng-odp] [API-NEXT PATCH v2 5/9] api: ipsec: ignore aad capability

AAD lengths are needed in crypto API but not in IPSEC API. So, application should ignore AAD capability values in IPSEC API. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[lng-odp] [API-NEXT PATCH v2 7/9] api: ipsec: flexible soft lifetime reporting

Allow implementation to decide how many times a soft lifetime expiration is reported. Application does not require strict synchronization of soft lifetimes. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 4 +++- 1 file changed, 3 insertions(+), 1

[lng-odp] [API-NEXT PATCH v2 2/9] api: ipsec: add max queues capability

Added capability to specify maximum number of different queues that can be used with IPsec. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 4 1 file changed, 4 insertions(+) diff --git a/include/odp/api/spec/ipsec.h

[lng-odp] [API-NEXT PATCH v2 9/9] api: ipsec: remove initial sequence number parameter

Application should not need to control initial sequence number value as implementation is able to manage that internally. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 3 --- 1 file changed, 3 deletions(-) diff --git

[lng-odp] API behavior of unsupported mode

Hi If any implementation does not support specific mode of operation , say , it only support sync but not async then is it legal to mark async API params as ODP_UNUSED? As in such case API may simply return with failure code, thus references to params is not actually exercised which results in to

[lng-odp] Regarding odp_pktin_rcv() packets

I have a question on odp_pktin_recv(odp_pktin_queue_t, odp_packet_t [], int). Once app receives packets associated to the queue, what happens to packets buffers passed to application? Does implementation always assume that packets will be freed by caller and re-allocates fresh packets to queue?

Re: [lng-odp] [PATCH API-NEXT v8 3/10] api: crypto: drop async mode support

On 11 July 2017 at 18:24, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > > Github ODP bot > > Sent: Wednesday, July 05, 2017 5:00 PM > > To:

[lng-odp] [PATCH API-NEXT v5 2/2] test: validation: add IPsec API testsuite

From: Dmitry Eremin-Solenikov Add several basic tests for IPsec API. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 70 (lumag:ipsec-testsuite-2) ** https://github.com/Linaro/odp/pull/70 **

[lng-odp] [PATCH API-NEXT v1 3/3] api: crypto: replace redundant packet_ prefixes from definitions

From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 74 (lumag:crypto-packet) ** https://github.com/Linaro/odp/pull/74 ** Patch:

[lng-odp] [PATCH API-NEXT v5 1/2] api: ipsec: pass OUT_INLINE outer headers as const

From: Dmitry Eremin-Solenikov Pass outer headers for outbound inline packets as const pointers. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 70 (lumag:ipsec-testsuite-2) **

[lng-odp] [PATCH API-NEXT v5 0/2] test: validation: add IPsec API testsuite

Add several basic tests for IPsec API. This PR incorporates #69 and event subtypes implementation on which it depends. github /** Email created from pull request 70 (lumag:ipsec-testsuite-2) ** https://github.com/Linaro/odp/pull/70 ** Patch:

[lng-odp] [PATCH v1 3/3] travis: add clang cross-compilation checks

From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 73 (lumag:cross-2) ** https://github.com/Linaro/odp/pull/73 ** Patch: https://github.com/Linaro/odp/pull/73.patch

[lng-odp] [PATCH API-NEXT v1 0/3] Crypto API updates

Updates for crypto API as suggested by @psavol github /** Email created from pull request 74 (lumag:crypto-packet) ** https://github.com/Linaro/odp/pull/74 ** Patch: https://github.com/Linaro/odp/pull/74.patch ** Base sha:

[lng-odp] [PATCH v1 2/3] travis: simplify cross-compilation setup

From: Dmitry Eremin-Solenikov Following Maxim's idea use apt-get to download and install cross-packages. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 73 (lumag:cross-2) **

[lng-odp] [PATCH API-NEXT v1 1/3] validation: crypto: fix unitialized variable error

From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 74 (lumag:crypto-packet) ** https://github.com/Linaro/odp/pull/74 ** Patch:

[lng-odp] [PATCH v1 0/3] Cross-compilation test updates

Per @muvarov's suggestion use apt-get instead of dpkg-cross to install cross-packages Add cross-compilation tests using clang github /** Email created from pull request 73 (lumag:cross-2) ** https://github.com/Linaro/odp/pull/73 ** Patch:

[lng-odp] [PATCH v1 1/3] example: ipfragaddress: fix compilation with clang

From: Dmitry Eremin-Solenikov Clang 3.8 is stricter than GCC wrt register allocation vs 128-bit variables. Sometimes it can not understand using 128-bit var in place of 64-bit register resulting in the following errors: /odp_ipfragreass_atomics_arm.h:18:51:

[lng-odp] [PATCH API-NEXT v1 2/3] doc: move PREDEFINED to common place

From: Dmitry Eremin-Solenikov It is easy to update PREDEFINED definitions in one Doxyfile, while forgetting about the others, as happened e.g. with ODP_DEPRECATE(x) definition. Move PREDEFINED definitions into Doxyfile_common, so that it is included by the rest

[lng-odp] [Bug 3126] New: IPC pktio test fails with taskset -c 1-2

https://bugs.linaro.org/show_bug.cgi?id=3126 Bug ID: 3126 Summary: IPC pktio test fails with taskset -c 1-2 Product: OpenDataPlane - linux- generic reference Version: master Hardware: Other OS: Linux Status:

Re: [lng-odp] DPDK integration under DDF

I'd like we sync up on key elements of the document at the arch call today. I'd like to restate a few things: - ODP Cloud single binary should support multiple hardware environments through DDF - ODP and ODP applications should accommodate how HW uses memory on the receive side, not the oppsoite

Re: [lng-odp] [API-NEXT PATCH 1/9] api: ipsec: add salt parameter

Dmitry Eremin-Solenikov wrote: > On 11.07.2017 15:31, Petri Savolainen wrote: > > Added a parameter for passing salt for AES GCM. Currently, > > only option for length is 4 bytes, but later on other algorithms > > may need more/less salt data. > > > > Signed-off-by: Petri Savolainen

[lng-odp] [PATCH API-NEXT v3 1/1] linux-gen: pktio: loop: reset packet subtype on loopback

From: Dmitry Eremin-Solenikov loop interface can get any kind of packets, but should output only basic packets. Reset packet subtype on loopback. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request

[lng-odp] [PATCH API-NEXT v3 0/1] linux-gen: pktio: loop: reset packet subtype on loopback

loop interface can get any kind of packets, but should output only basic packets. Reset packet subtype on loopback. Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org github /** Email created from pull request 68 (lumag:packet-loop)

Re: [lng-odp] [API-NEXT PATCH 1/9] api: ipsec: add salt parameter

On 11.07.2017 15:31, Petri Savolainen wrote: > Added a parameter for passing salt for AES GCM. Currently, > only option for length is 4 bytes, but later on other algorithms > may need more/less salt data. > > Signed-off-by: Petri Savolainen Except the suggestion for

Re: [lng-odp] [API-NEXT PATCHv4 0/4] a new API to support timer capability

Patch is rebased. Please help to review. Thanks Kevin 2017-07-11 18:00 GMT+08:00 Yi He : > Yes, thanks, Maxim, and Petri please wait for Kevin to rebase and work out > a new patch series. > > Best Regards, Yi > > On 11 July 2017 at 17:53, Maxim Uvarov

[lng-odp] [API-NEXT PATCHv5 4/4] doc: userguide: add odp_timer_capability() section to user guide

Signed-off-by: Kevin Wang --- doc/users-guide/users-guide-timer.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/users-guide/users-guide-timer.adoc b/doc/users-guide/users-guide-timer.adoc index 9cd30de..4a8bad7 100644 ---

[lng-odp] [API-NEXT PATCHv5 2/4] linux-generic: timer: implement odp_timer_capability()

Implement a new internal function timer_res_init() to detect the max timer resolution without overrun at the ODP init stage. It will check timer resolution from 1ms to 100us, 10us...1ns until the timer is overrun. Signed-off-by: Kevin Wang ---

[lng-odp] [API-NEXT PATCHv5 1/4] api: timer: add odp_timer_capability() api

Currently, user needs to decide the timer resolution before creating a timer pool. But sometimes it will cause timer overrun as the system can't support such high resolution. So a new API is required to expose the timer capability to the user. Signed-off-by: Kevin Wang ---

Re: [lng-odp] [API-NEXT PATCH 1/9] api: ipsec: add salt parameter

On 11.07.2017 15:31, Petri Savolainen wrote: > Added a parameter for passing salt for AES GCM. Currently, > only option for length is 4 bytes, but later on other algorithms > may need more/less salt data. > > Signed-off-by: Petri Savolainen > --- >

Re: [lng-odp] [API-NEXT PATCH 3/9] api: ipsec: direction specific SA params

Fine with me. BR, Bogdan On 11 July 2017 at 15:31, Petri Savolainen wrote: > Move direction (inboud/outbound) specific SA parameters > into separate structures. Specification is more clear > between common and direction specific SA parameters. > > Signed-off-by: