Re: [lng-odp] [API-NEXT PATCH v3 1/9] api: ipsec: add salt parameter

For the series: Reviewed-by: Nikhil Agarwal -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri Savolainen Sent: Wednesday, July 12, 2017 7:25 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT PATCH v3 1/9]

[lng-odp] [PATCH API-NEXT v7 1/1] test: validation: add IPsec API testsuite

From: Dmitry Eremin-Solenikov Add several basic tests for IPsec API. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 70 (lumag:ipsec-testsuite-2) ** https://github.com/Linaro/odp/pull/70 **

[lng-odp] [PATCH API-NEXT v7 0/1] test: validation: add IPsec API testsuite

Add several basic tests for IPsec API. This PR incorporates #69 and event subtypes implementation on which it depends. github /** Email created from pull request 70 (lumag:ipsec-testsuite-2) ** https://github.com/Linaro/odp/pull/70 ** Patch:

[lng-odp] [PATCH v1 1/1] example: ipsec: fix build with OpenSSL located in non-standard path

From: Dmitry Eremin-Solenikov IPsec example uses OpenSSL directly to generate packages stream. Thus use $(OPENSSL_CPPFLAGS) and $(OPENSSL_LIBS) to let compiler find OpenSSL if it is present in non-standard location. Signed-off-by: Dmitry Eremin-Solenikov

[lng-odp] [PATCH v1 0/1] example: ipsec: fix build with OpenSSL located in non-standard path

IPsec example uses OpenSSL directly to generate packages stream. Thus use $(OPENSSL_CPPFLAGS) and $(OPENSSL_LIBS) to let compiler find OpenSSL if it is present in non-standard location. Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org

Re: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API

On Thu, Jul 13, 2017 at 4:32 PM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > On 13.07.2017 21:20, Bill Fischofer wrote: > > On Thu, Jul 13, 2017 at 12:58 PM, Bala Manoharan > > wrote: > >> On 13 July 2017 at 16:25, Savolainen, Petri (Nokia -

[lng-odp] [PATCH API-NEXT v6 1/1] test: validation: add IPsec API testsuite

From: Dmitry Eremin-Solenikov Add several basic tests for IPsec API. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 70 (lumag:ipsec-testsuite-2) ** https://github.com/Linaro/odp/pull/70 **

[lng-odp] [PATCH API-NEXT v6 0/1] test: validation: add IPsec API testsuite

Add several basic tests for IPsec API. This PR incorporates #69 and event subtypes implementation on which it depends. github /** Email created from pull request 70 (lumag:ipsec-testsuite-2) ** https://github.com/Linaro/odp/pull/70 ** Patch:

[lng-odp] [PATCH API-NEXT v3 4/4] api: crypto: revert deprecation of crypto completion API

From: Dmitry Eremin-Solenikov It was decided that it would be benefitable to live with both API types at this point, as odp_crypto_compl_t was available for some time. So undeprecate odp_crypto_compl_t and related functionality. Validation tests also provide

[lng-odp] [PATCH API-NEXT v3 3/4] api: crypto: replace redundant packet_ prefixes from definitions

From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 74 (lumag:crypto-packet) ** https://github.com/Linaro/odp/pull/74 ** Patch:

Re: [lng-odp] [PATCH API-NEXT v2 0/4] Crypto API updates

On 13.07.2017 23:51, Maxim Uvarov wrote: > On 07/13/17 13:59, Savolainen, Petri (Nokia - FI/Espoo) wrote: >> Dmitry, Maxim, >> >> I think it's OK to merge v1 of this ASAP since it fixes e.g. api-next build >> break. I did send my review yesterday. V2 just adds 4/4 patch on top. >> >> -Petri >> >>

[lng-odp] [Bug 3126] IPC pktio test fails with taskset -c 1-2

https://bugs.linaro.org/show_bug.cgi?id=3126 --- Comment #5 from Maxim Uvarov --- I reproduced it with: taskset -c 7,8 ./test/linux-generic/pktio_ipc/pktio_ipc_run.sh looking... -- You are receiving this mail because: You are on the CC list for the bug.

[lng-odp] [Bug 3126] IPC pktio test fails with taskset -c 1-2

https://bugs.linaro.org/show_bug.cgi?id=3126 --- Comment #4 from Maxim Uvarov --- Does increasing timeout inside pktio_ipc_run.sh helps? -- You are receiving this mail because: You are on the CC list for the bug.

[lng-odp] [Bug 3126] IPC pktio test fails with taskset -c 1-2

https://bugs.linaro.org/show_bug.cgi?id=3126 --- Comment #3 from Maxim Uvarov --- I found that Travis uses machines with different cpu numbers while porting travis file to monarch (pktio perf failed due to not enough cores to run). That is why it fails only some times.

Re: [lng-odp] [PATCH API-NEXT v2 0/4] Crypto API updates

On 07/13/17 13:59, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Dmitry, Maxim, > > I think it's OK to merge v1 of this ASAP since it fixes e.g. api-next build > break. I did send my review yesterday. V2 just adds 4/4 patch on top. > > -Petri > > I'm ok to merge. checkpatch needs to be fixed

Re: [lng-odp] [PATCH v2 1/3] linux-gen: buffer: change buffer handle to pointer

Merged with review from v1. Maxim. On 07/13/17 15:58, Petri Savolainen wrote: > Changed buffer, event and timeout handles to be pointers. > Packet handles are already pointers. This enabled code > optimization as some conversions may be removed and remaining > once are just type casts. > >

Re: [lng-odp] [API-NEXT PATCH v3 1/9] api: ipsec: add salt parameter

Merged. On 07/13/17 17:30, Bala Manoharan wrote: > For the series: > Reviewed-by: Balasubramanian Manoharan > > > On 12 July 2017 at 19:24, Petri Savolainen > wrote: > >> Added a parameter for passing salt/nonce for algorithms that >>

[lng-odp] [Linaro/odp] 6879ec: api: ipsec: add salt parameter

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: 6879ecd2d136508e59cf8d9b8f15c6475ba74c99 https://github.com/Linaro/odp/commit/6879ecd2d136508e59cf8d9b8f15c6475ba74c99 Author: Petri Savolainen Date: 2017-07-13 (Thu, 13 Jul

Re: [lng-odp] [PATCH v1 1/1] pktio APIs to modify the MAC address or the MTU size of the given packet IO handler.

I remember that we previously added mac addr change. Then removed as supported on many systems. Since we have capability there it make reasonable now to add this api. Please send patch thought github pull request. It will do bunch of automatic tests. Thanks, Maxim. On 07/13/17 15:10,

[lng-odp] [Linaro/odp] 698d82: api: ipsec: add retain header capability

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: 698d82ce41a3f6ca08c6f218784d3eea6ac81e42 https://github.com/Linaro/odp/commit/698d82ce41a3f6ca08c6f218784d3eea6ac81e42 Author: Nikhil Agarwal Date: 2017-07-13 (Thu, 13 Jul 2017)

Re: [lng-odp] [PATCH API-NEXT v4 1/1] api: ipsec: add retain header capability

Merged. Maxim. On 07/13/17 12:58, Dmitry Eremin-Solenikov wrote: > On 13.07.2017 12:00, Github ODP bot wrote: >> From: Nikhil Agarwal >> >> Signed-off-by: Nikhil Agarwal > > Reviewed-by: Dmitry Eremin-Solenikov > >> --- >> /** Email

[lng-odp] [Linaro/odp] cd0974: test: l2fwd: list not used features

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: cd097450cbf9d7bb6cd24654f8d43ceade5b114a https://github.com/Linaro/odp/commit/cd097450cbf9d7bb6cd24654f8d43ceade5b114a Author: Petri Savolainen Date: 2017-07-13 (Thu, 13 Jul

[lng-odp] [Linaro/odp] 490f4b: linux-gen: pool: avoid extra conversions

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 490f4bf22129638899ce71c99a8847e8ba849692 https://github.com/Linaro/odp/commit/490f4bf22129638899ce71c99a8847e8ba849692 Author: Petri Savolainen Date: 2017-07-13 (Thu, 13 Jul

[lng-odp] [Linaro/odp] 77f1b6: linux-gen: queue: avoid extra conversions

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 77f1b6743f97c6265e18cd47d0f597b44f71be2d https://github.com/Linaro/odp/commit/77f1b6743f97c6265e18cd47d0f597b44f71be2d Author: Petri Savolainen Date: 2017-07-13 (Thu, 13 Jul

[lng-odp] [Linaro/odp] dcea50: linux-gen: buffer: change buffer handle to pointer

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: dcea50f7ad1f5473d74797e58eac5ba4abb939d1 https://github.com/Linaro/odp/commit/dcea50f7ad1f5473d74797e58eac5ba4abb939d1 Author: Petri Savolainen Date: 2017-07-13 (Thu, 13 Jul

Re: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API

On Thu, Jul 13, 2017 at 12:58 PM, Bala Manoharan wrote: > On 13 July 2017 at 16:25, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolai...@nokia.com> wrote: > >> >> >> > -Original Message- >> > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf

Re: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API

On 13 July 2017 at 16:25, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > > Github ODP bot > > Sent: Wednesday, July 12, 2017 5:00 PM > > To:

Re: [lng-odp] [API-NEXT PATCHv6 2/4] linux-generic: timer: implement odp_timer_capability()

I don't think to add/multiply the result from clock_getres() is a better solution here because clock_getres() always return 1ns on most platform. This solution did the basic measurement on the target platform.It should be more reliable than a constant value. But I agree that the value should be

Re: [lng-odp] [API-NEXT PATCH v3 1/9] api: ipsec: add salt parameter

For the series: Reviewed-by: Balasubramanian Manoharan On 12 July 2017 at 19:24, Petri Savolainen wrote: > Added a parameter for passing salt/nonce for algorithms that > need it. Currently, only AES GCM needs it with 4 bytes of > salt.

Re: [lng-odp] [PATCH 0/3] Change buffer handle to pointer

> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, July 13, 2017 3:18 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: Maxim Uvarov ; lng-odp@lists.linaro.org > Subject: Re: [lng-odp]

[lng-odp] [PATCH v2 1/3] linux-gen: buffer: change buffer handle to pointer

Changed buffer, event and timeout handles to be pointers. Packet handles are already pointers. This enabled code optimization as some conversions may be removed and remaining once are just type casts. Signed-off-by: Petri Savolainen ---

[lng-odp] [PATCH v2 2/3] linux-gen: queue: avoid extra conversions

Conversions are not needed as event handles are buffer header pointers. Signed-off-by: Petri Savolainen --- .../linux-generic/include/odp_buffer_inlines.h | 5 -- platform/linux-generic/odp_queue.c | 74 +++--- 2 files changed,

Re: [lng-odp] [PATCH 0/3] Change buffer handle to pointer

Sorry, reposting my previous review: For this series: Reviewed-and-tested-by: Bill Fischofer Thanks, Petri. IPC has a known issue[1] that is causing it to do duplicate buffer frees. The zero-copy packet refs code exposes this because of the introduction of explicit

Re: [lng-odp] [PATCH v1 1/1] pktio APIs to modify the MAC address or the MTU size of the given packet IO handler.

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Vamsi > Attunuru > Sent: Thursday, July 13, 2017 11:54 AM > To: lng-odp@lists.linaro.org > Cc: macha...@cavium.com; pathr...@cavium.com; vattun...@cavium.com; > sve...@cavium.com > Subject:

Re: [lng-odp] [API-NEXT PATCH v3 1/9] api: ipsec: add salt parameter

On 12.07.2017 16:54, Petri Savolainen wrote: > Added a parameter for passing salt/nonce for algorithms that > need it. Currently, only AES GCM needs it with 4 bytes of > salt. Later on, other cipher (or auth) algorithms may need > also salt/nonce data. > > Signed-off-by: Petri Savolainen

Re: [lng-odp] [API-NEXT PATCH] test: l2fwd: list not used features

On Mon, Jun 26, 2017 at 5:24 AM, Petri Savolainen wrote: > List not used features so that performance may be optimized > on some platforms. E.g. on odp-linux implementation, timer > polling causes high overhead, which is disabled when timers > are not used. > >

Re: [lng-odp] [PATCH v1 1/1] pktio APIs to modify the MAC address or the MTU size of the given packet IO handler.

HI, Vamsi, 1. Please subscribe to the ODP mailing list if you'd like to make posts, otherwise there will be delays as each post requires manual approval. 2. If you are from Cavium, please post this from your Cavium e-mail address. Otherwise you'll need to submit a separate contributor's

[lng-odp] [PATCH v1 1/1] pktio APIs to modify the MAC address or the MTU size of the given packet IO handler.

--- include/odp/api/spec/packet_io.h | 29 + 1 file changed, 29 insertions(+) diff --git a/include/odp/api/spec/packet_io.h b/include/odp/api/spec/packet_io.h index c7373fd..a950267 100644 --- a/include/odp/api/spec/packet_io.h +++ b/include/odp/api/spec/packet_io.h

Re: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API

On 13.07.2017 14:14, Bill Fischofer wrote: > On Thu, Jul 13, 2017 at 5:55 AM, Savolainen, Petri (Nokia - FI/Espoo) > wrote: >> >> >>> -Original Message- >>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >>> Github ODP bot >>> Sent:

Re: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API

On Thu, Jul 13, 2017 at 5:55 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >> Github ODP bot >> Sent: Wednesday, July 12, 2017 5:00 PM >> To:

Re: [lng-odp] [PATCH API-NEXT v2 0/4] Crypto API updates

Dmitry, Maxim, I think it's OK to merge v1 of this ASAP since it fixes e.g. api-next build break. I did send my review yesterday. V2 just adds 4/4 patch on top. -Petri

Re: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Wednesday, July 12, 2017 5:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation > of crypto completion API >

Re: [lng-odp] [API-NEXT PATCHv6 2/4] linux-generic: timer: implement odp_timer_capability()

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Kevin > Wang > Sent: Thursday, July 13, 2017 8:47 AM > To: lng-odp@lists.linaro.org > Cc: Kevin Wang > Subject: [lng-odp] [API-NEXT PATCHv6 2/4] linux-generic: timer:

Re: [lng-odp] [API-NEXT PATCHv6 1/4] api: timer: add odp_timer_capability() api

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Kevin > Wang > Sent: Thursday, July 13, 2017 8:47 AM > To: lng-odp@lists.linaro.org > Cc: Kevin Wang > Subject: [lng-odp] [API-NEXT PATCHv6 1/4] api: timer: add >

Re: [lng-odp] [PATCH API-NEXT v4 1/1] api: ipsec: add retain header capability

On 13.07.2017 12:00, Github ODP bot wrote: > From: Nikhil Agarwal > > Signed-off-by: Nikhil Agarwal Reviewed-by: Dmitry Eremin-Solenikov > --- > /** Email created from pull request 75 (NikhilA-Linaro:ipsec_api) > **

Re: [lng-odp] [PATCH API-NEXT v4 1/1] api: ipsec: add retain header capability

Reviewed-by: Balasubramanian Manoharan On 13 July 2017 at 15:13, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Reviewed-by: Petri Savolainen > > > -Original Message- > > From: lng-odp

Re: [lng-odp] [PATCH API-NEXT v4 1/1] api: ipsec: add retain header capability

Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Thursday, July 13, 2017 12:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v4 1/1]

[lng-odp] [PATCH API-NEXT v4 1/1] api: ipsec: add retain header capability

From: Nikhil Agarwal Signed-off-by: Nikhil Agarwal --- /** Email created from pull request 75 (NikhilA-Linaro:ipsec_api) ** https://github.com/Linaro/odp/pull/75 ** Patch: https://github.com/Linaro/odp/pull/75.patch ** Base sha:

[lng-odp] [PATCH API-NEXT v4 0/1] Adding additional capability options to IPSEC APIs.

Signed-off-by: Nikhil Agarwal nikhil.agar...@linaro.org github /** Email created from pull request 75 (NikhilA-Linaro:ipsec_api) ** https://github.com/Linaro/odp/pull/75 ** Patch: https://github.com/Linaro/odp/pull/75.patch ** Base sha:

Re: [lng-odp] Regarding odp_pktin_rcv() packets

> -Original Message- > From: shally verma [mailto:shallyvermacav...@gmail.com] > Sent: Thursday, July 13, 2017 11:43 AM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: lng-odp-forward ; Shally Verma > > Subject:

Re: [lng-odp] [API-NEXT PATCH] test: l2fwd: list not used features

Ping. I think it's better to modify only this application now, and update other apps once the new API is released into master. Otherwise, we would increase diff between api-next vs master. Most apps do odp_init_global(, NULL, NULL) today, so there's no performance difference. This change

Re: [lng-odp] Regarding odp_pktin_rcv() packets

On Thu, Jul 13, 2017 at 2:05 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >> shally verma >> Sent: Wednesday, July 12, 2017 3:36 PM >> To: lng-odp-forward

Re: [lng-odp] [PATCH 0/3] Change buffer handle to pointer

Ping. It seems that Bill review didn't make it to the list. IPC test problems I did found out during the development are now confirmed on current master, and thus are not related to this set. > -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent:

Re: [lng-odp] Regarding odp_pktin_rcv() packets

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > shally verma > Sent: Wednesday, July 12, 2017 3:36 PM > To: lng-odp-forward ; Shally Verma > > Subject: [lng-odp] Regarding odp_pktin_rcv() packets

Re: [lng-odp] Regarding odp_pktin_rcv() packets

On Wed, Jul 12, 2017 at 10:59 PM, Bill Fischofer wrote: > On Wed, Jul 12, 2017 at 11:16 AM, shally verma > wrote: >> On Wed, Jul 12, 2017 at 8:50 PM, Bill Fischofer >> wrote: >>> On Wed, Jul 12, 2017 at 7:35 AM,

Re: [lng-odp] API behavior of unsupported mode

Ok. That clarifies my doubt. Only concern was we shouldn't end up misusing directive. Thanks for inputs. Shally On Wed, Jul 12, 2017 at 11:16 PM, Bill Fischofer wrote: > On Wed, Jul 12, 2017 at 10:33 AM, shally verma > wrote: >> On Wed,

[lng-odp] [Bug 3126] IPC pktio test fails with taskset -c 1-2

https://bugs.linaro.org/show_bug.cgi?id=3126 --- Comment #2 from Petri Savolainen --- I verified that it's actually isolation vs no isolation. My system has cpu 0-1 and 14-15 not isolated, and all others isolated. Test fails as soon as one isolated cpu is used. Test

Re: [lng-odp] [PATCH API-NEXT v1 1/1] Adding additonal capability options to IPSEC APIs.

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Thursday, July 13, 2017 10:00 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v1 1/1] Adding additonal capability > options to IPSEC APIs. Typo:

[lng-odp] [PATCH API-NEXT v1 0/1] example:ipsec_offload: Adding ipsec_offload example

Signed-off-by: Nikhil Agarwal nikhil.agar...@linaro.org github /** Email created from pull request 12 (NikhilA-Linaro:api-next) ** https://github.com/Linaro/odp/pull/12 ** Patch: https://github.com/Linaro/odp/pull/12.patch ** Base sha:

[lng-odp] [PATCH API-NEXT v1 1/1] Adding additonal capability options to IPSEC APIs.

From: Nikhil Agarwal Signed-off-by: Nikhil Agarwal --- /** Email created from pull request 75 (NikhilA-Linaro:ipsec_api) ** https://github.com/Linaro/odp/pull/75 ** Patch: https://github.com/Linaro/odp/pull/75.patch ** Base sha:

[lng-odp] [PATCH API-NEXT v1 1/1] Adding additonal capability options to IPSEC APIs.

From: Nikhil Agarwal Signed-off-by: Nikhil Agarwal --- /** Email created from pull request 12 (NikhilA-Linaro:api-next) ** https://github.com/Linaro/odp/pull/12 ** Patch: https://github.com/Linaro/odp/pull/12.patch ** Base sha:

[lng-odp] [PATCH API-NEXT v1 0/1] Adding additonal capability options to IPSEC APIs.

Signed-off-by: Nikhil Agarwal nikhil.agar...@linaro.org github /** Email created from pull request 75 (NikhilA-Linaro:ipsec_api) ** https://github.com/Linaro/odp/pull/75 ** Patch: https://github.com/Linaro/odp/pull/75.patch ** Base sha: