Re: [lng-odp] [EXT] Re: ODP1.15 with gcc-linaro-5.3.1

2017-10-25 Thread Liron Himi
Hi Bill, I also checked it with GCC7.1.1(latest release) with no problem. I noticed that in this version the libatomic.la is not there anymore. The problem is with the GCC5.3.1’s libatomic.la where the setting of LIBDIR is to some weird location. To overcome this issue

Re: [lng-odp] [PATCH 2.0 v2] Remove duplicate pktio_ops subsystem implementation

2017-10-25 Thread Github ODP bot
nagarahalli replied on github web page: platform/linux-generic/pktio/subsystem.c line 42 @@ -44,15 +54,23 @@ ODP_SUBSYSTEM_CONSTRUCTOR(pktio_ops) #ifdef ODP_PKTIO_DPDK enable_link_dpdk_pktio_ops = 1; #endif +#ifdef ODP_PKTIO_IPC enable_link_ipc_pktio_ops = 1; +#endif

Re: [lng-odp] [EXT] Re: ODP1.15 with gcc-linaro-5.3.1

2017-10-25 Thread Bill Fischofer
Hi Liron, Can you try this against the master or api-next branches of odp.git? I know we are currently doing cross-compile testing for aarch64 in Travis and aren't seeing this problem. If that's the case then this problem should resolve itself in the next tagged release, which should be out

Re: [lng-odp] Ingress Metering/Policing

2017-10-25 Thread Bill Fischofer
There are no immediate plans for this feature. As an open source project, ODP moves in the direction of its contributors. If this is of importance to you, please consider submitting patches to add it. On Wed, Oct 25, 2017 at 11:54 AM, Liron Himi wrote: > Hi, > > Is there any

Re: [lng-odp] [EXT] Re: ODP1.15 with gcc-linaro-5.3.1

2017-10-25 Thread Liron Himi
Hi, The GCC5.3.1 is a Linaro's GCC, maybe it is more of a question to Linaro as this crosstools version doesn't compile well with the linux-generic implementation in ODP1.15 due to the need for libatomic. Liron -Original Message- From: Brian Brooks [mailto:brian.bro...@linaro.org]

[lng-odp] Ingress Metering/Policing

2017-10-25 Thread Liron Himi
Hi, Is there any intention to add support for Ingress Metering/Policing (RFC 2697, RFC2698) in future releases? Regards, Liron

Re: [lng-odp] API-next branch

2017-10-25 Thread Bill Fischofer
I'm all for using topic branches, especially since we've switched to GitHub and most contributors are now familiar with it and using pull requests rather than raw patches sent to the mailing list. The whole reason for api-next was to separate in-progress API changes from regular maintenance

[lng-odp] API-next branch

2017-10-25 Thread Dmitry Eremin-Solenikov
Hello, I tried to actually check, which patches are sitting in the api-next. And actually I failed to do that in a timely manner. git cherry produces a list of patches, that contains a lot of patches, which already landed to the master. Quick proposal would be to stop using api-next as a

Re: [lng-odp] [PATCH v1] Netmap pktio fixes

2017-10-25 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: platform/linux-generic/pktio/netmap.c line 14 @@ -388,13 +389,22 @@ static int netmap_open(odp_pktio_t id ODP_UNUSED, pktio_entry_t *pktio_entry, if (pkt_nm->is_virtual) { static unsigned mac; +

Re: [lng-odp] [Linaro/odp] [PATCH API-NEXT v1] api: packet: print data (#258)

2017-10-25 Thread Savolainen, Petri (Nokia - FI/Espoo)
that has to be odp helper, not need for that in odp api — Helper is not API, in general all applications cannot rely that. Out validation/example/etc apps can rely on helpers, but not all. This solves a very common debug need for data plane application - print a received packet on the screen.

Re: [lng-odp] [Linaro/odp] [PATCH API-NEXT v1] api: packet: print data (#258)

2017-10-25 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi Petri there's no check on snprintf regarding the returned len. Is there any possibility in this code that the final buffer will be bigger than max_len? — I calculate max string len from number of bytes to print: int num_rows = (byte_len + bytes_per_row - 1) / bytes_per_row; int max_len =

[lng-odp] [PATCH API-NEXT v1 1/3] api: packet: print packet data

2017-10-25 Thread Github ODP bot
From: Petri Savolainen Added debug print function which includes packet payload bytes. Printing starts from offset, so it's easy to e.g. limit print to IPv4 header bytes only: odp_packet_print_data(pkt, l3_offset(pkt), 20) Signed-off-by: Petri Savolainen

[lng-odp] [PATCH API-NEXT v1 0/3] api: packet: print data

2017-10-25 Thread Github ODP bot
Added debug print function which includes packet payload bytes. Printing starts from an offset, so it's easy to e.g. limit print to IPv4 header bytes only: odp_packet_print_data(pkt, l3_offset(pkt), 20) github /** Email created from pull request 258

[lng-odp] [PATCH API-NEXT v1 2/3] linux-gen: packet: implement odp_packet_data_print

2017-10-25 Thread Github ODP bot
From: Petri Savolainen Implemented the new packet payload print function using ODP_PRINT macro. Removed an extra space from the print macro as well as extra null char and line feed from odp_packet_print. Signed-off-by: Petri Savolainen

[lng-odp] [PATCH API-NEXT v1 3/3] validation: packet: add packet_print_data test

2017-10-25 Thread Github ODP bot
From: Petri Savolainen Test the new packet payload print function with couple of lengths and offsets. Added line feeds to separate packet print output from CUnit prints. Signed-off-by: Petri Savolainen --- /** Email created from pull

[lng-odp] [PATCH API-NEXT v12 2/2] linux-generic: classification: implement random early detection and back pressure

2017-10-25 Thread Github ODP bot
From: Balasubramanian Manoharan Implements Random early detection and Back pressure Signed-off-by: Balasubramanian Manoharan --- /** Email created from pull request 172 (bala-manoharan:random_early_discard) **

[lng-odp] [PATCH API-NEXT v12 0/2] api: classification: add random early detection

2017-10-25 Thread Github ODP bot
Adds random early discard and back pressure feature configurable per CoS Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org github /** Email created from pull request 172 (bala-manoharan:random_early_discard) **

[lng-odp] [PATCH API-NEXT v12 1/2] api: classification: add random early detection and back pressure

2017-10-25 Thread Github ODP bot
From: Balasubramanian Manoharan Adds random early detection and Back pressure feature to CoS Signed-off-by: Balasubramanian Manoharan --- /** Email created from pull request 172 (bala-manoharan:random_early_discard) **

[lng-odp] [Bug 3289] [PKTIO] 'num_queues' isn't ignored when ''classifier_enable' is enabled

2017-10-25 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=3289 --- Comment #3 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/dd0498bb104c7319e2ec56b61e4d585167ea6c53 refs/heads/api-next 2017-10-25T09:52:58+03:00 Maxim Uvarov maxim.uva...@linaro.org linux-gen: pktio: ignore

[lng-odp] [Linaro/odp] 74d880: travis: fix doxygen error capture

2017-10-25 Thread GitHub
Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: 74d880d7e20ab4825868bd2013b164d4bc90eb45 https://github.com/Linaro/odp/commit/74d880d7e20ab4825868bd2013b164d4bc90eb45 Author: Maxim Uvarov Date: 2017-10-24 (Tue, 24 Oct 2017)

[lng-odp] [PATCH API-NEXT v3 11/11] validation: ipsec: add support for PIPELINE_CLS testing

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 243 (lumag:ipsec-packet-impl-3) ** https://github.com/Linaro/odp/pull/243 ** Patch:

[lng-odp] [PATCH API-NEXT v3 10/11] linux-gen: ipsec: support pipelining to cos_t

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 243 (lumag:ipsec-packet-impl-3) ** https://github.com/Linaro/odp/pull/243 ** Patch:

[lng-odp] [PATCH API-NEXT v3 9/11] linux-gen: classification: split cls_pkt_get_queue() function

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Separate function returning destination queue from cos_t instance. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 243 (lumag:ipsec-packet-impl-3) **

[lng-odp] [PATCH API-NEXT v3 7/11] validation: ipsec: add replay window checks

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 243 (lumag:ipsec-packet-impl-3) ** https://github.com/Linaro/odp/pull/243 ** Patch:

[lng-odp] [PATCH API-NEXT v3 8/11] linux-gen: classification: provide _odp_cos_get_entry() function

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Provide function mapping from odp_cos_t to internal cos_t type. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 243 (lumag:ipsec-packet-impl-3) **

[lng-odp] [PATCH API-NEXT v3 5/11] linux-gen: ipsec: add replay window support to SAD

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 243 (lumag:ipsec-packet-impl-3) ** https://github.com/Linaro/odp/pull/243 ** Patch:

[lng-odp] [PATCH API-NEXT v3 6/11] linux-gen: ipsec: support replay window checks

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 243 (lumag:ipsec-packet-impl-3) ** https://github.com/Linaro/odp/pull/243 ** Patch:

[lng-odp] [PATCH API-NEXT v3 3/11] validation: ipsec: verify odp_ipsec_sa_context

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 243 (lumag:ipsec-packet-impl-3) ** https://github.com/Linaro/odp/pull/243 ** Patch:

[lng-odp] [PATCH API-NEXT v3 4/11] linux-gen: ipsec: fix soft/hard limits check

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Split count expiration check into two phases: - optional precheck, run before crypto, which fails only if hard limit is already breached - update, run after crypto in INBOUND case, so that limits will not be updated for

[lng-odp] [PATCH API-NEXT v3 2/11] validation: ipsec: drop unused file

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 243 (lumag:ipsec-packet-impl-3) ** https://github.com/Linaro/odp/pull/243 ** Patch:

[lng-odp] [PATCH API-NEXT v3 1/11] linux-gen: ipsec: use counter instead of random IV for GCM

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Reusing IV block with GCM results in disastrous consequences. Use counter instead of random-generated IV to remove possibility for IV reuse. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email

[lng-odp] [PATCH API-NEXT v3 0/11] IPsec implementation updates

2017-10-25 Thread Github ODP bot
security fix for GCM mode: proper IV generation implementation of 32-bit replay window support implementation of PIPELINE_CLS support github /** Email created from pull request 243 (lumag:ipsec-packet-impl-3) ** https://github.com/Linaro/odp/pull/243 **

[lng-odp] [PATCH API-NEXT v4 3/3] linux-gen: implement odp_ipsec_sa_disable() changes

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 256 (lumag:ipsec_sa_disable_v2) ** https://github.com/Linaro/odp/pull/256 ** Patch:

[lng-odp] [PATCH API-NEXT v4 1/3] api: ipsec: rework ODP_IPSEC_SA_DISABLE into packet error

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov According to the discussion on mailing list, most of implementations will not be able to support odp_ipsec_sa_disable() status event directly. Instead they will submit a dummy packet to that SA. Then after receiving this packet

[lng-odp] [PATCH API-NEXT v4 2/3] validation: ipsec: adapt to odp_ipsec_sa_disable() change

2017-10-25 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 256 (lumag:ipsec_sa_disable_v2) ** https://github.com/Linaro/odp/pull/256 ** Patch:

[lng-odp] [PATCH API-NEXT v4 0/3] IPsec SA_DISABLE implementation

2017-10-25 Thread Github ODP bot
An implementaion of odp_ipsec_sa_disable() semantic changes. Use dummy packet to report sa_disable event completion. github /** Email created from pull request 256 (lumag:ipsec_sa_disable_v2) ** https://github.com/Linaro/odp/pull/256 ** Patch:

Re: [lng-odp] [PATCH API-NEXT v2 1/3] api: ipsec: rework ODP_IPSEC_SA_DISABLE into packet error

2017-10-25 Thread Dmitry Eremin-Solenikov
> delete "either" and reflow comment. done

Re: [lng-odp] [PATCH v1] Netmap pktio fixes

2017-10-25 Thread Github ODP bot
Matias Elo(matiaselo) replied on github web page: platform/linux-generic/pktio/netmap.c line 14 @@ -388,13 +389,22 @@ static int netmap_open(odp_pktio_t id ODP_UNUSED, pktio_entry_t *pktio_entry, if (pkt_nm->is_virtual) { static unsigned mac; + uint32_t

[lng-odp] [Linaro/odp] c0aeac: linux-gen: dpdk: create missing dpdk mempools in z...

2017-10-25 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: c0aeacf23dddfb7feae47fef6e4d10d6bdb9c812 https://github.com/Linaro/odp/commit/c0aeacf23dddfb7feae47fef6e4d10d6bdb9c812 Author: Matias Elo Date: 2017-10-25 (Wed, 25 Oct 2017) Changed

[lng-odp] [Linaro/odp] dd0498: linux-gen: pktio: ignore num_queues parameter if c...

2017-10-25 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: dd0498bb104c7319e2ec56b61e4d585167ea6c53 https://github.com/Linaro/odp/commit/dd0498bb104c7319e2ec56b61e4d585167ea6c53 Author: Maxim Uvarov Date: 2017-10-25 (Wed, 25 Oct 2017)

[lng-odp] [Bug 3289] [PKTIO] 'num_queues' isn't ignored when ''classifier_enable' is enabled

2017-10-25 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=3289 --- Comment #2 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/dd0498bb104c7319e2ec56b61e4d585167ea6c53 refs/heads/master 2017-10-25T09:52:58+03:00 Maxim Uvarov maxim.uva...@linaro.org linux-gen: pktio: ignore

Re: [lng-odp] [PATCH v2] linux-gen: dpdk: bump dpdk version to 17.08

2017-10-25 Thread Github ODP bot
Matias Elo(matiaselo) replied on github web page: DEPENDENCIES @@ -159,14 +159,18 @@ Prerequisites for building the OpenDataPlane (ODP) API 3.4 DPDK packet I/O support (optional) Use DPDK for ODP packet I/O. + Comment: Fixed > muvarov wrote > trailing whitespaces here.

[lng-odp] [PATCH v2 2/2] linux-gen: dpdk: bump target dpdk version to 17.08

2017-10-25 Thread Github ODP bot
From: Matias Elo Changes: - Function rte_set_log_level() is now deprecated. Replace it with rte_log_set_global_level(). - New dependency added to libnuma. - Pcap-based virtual devices are renamed to net_pcap. - DPDK pktio devices cannot be restarted after calling

[lng-odp] [PATCH v2 1/2] linux-gen: dpdk: create missing dpdk mempools in zero-copy mode

2017-10-25 Thread Github ODP bot
From: Matias Elo In zero-copy dpdk pktio mode a matching dpdk mempool is required for each odp packet pool from which packets are sent using dpdk pktio. This is required for all packet pools, even for those which are not passed directly to pktio devices as odp_pktio_open()

[lng-odp] [PATCH v2 0/2] linux-gen: dpdk: bump dpdk version to 17.08

2017-10-25 Thread Github ODP bot
Add missing DPDK mempool initialization zero-copy DKDK pktio and bumb target DPDK version to 17.08. github /** Email created from pull request 252 (matiaselo:dev/bump_dpdk_version) ** https://github.com/Linaro/odp/pull/252 ** Patch: