https://bugs.linaro.org/show_bug.cgi?id=3517
--- Comment #7 from Dmitry Eremin-Solenikov
---
Note, it also occurs in Travis, so it is not limited to Shippable (ThunderX).
--
You are receiving this mail because:
You are the assignee for the bug.
You are on
github
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch: https://github.com/Linaro/odp/pull/441.patch
** Base sha: b95ccd3db6eeb7358a877541747e06354429acdd
** Merge commit sha:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
From: Dmitry Eremin-Solenikov
Use `make check -k' to run testsuite, so that all tests have a chance to
be executed, not stopping after first failure.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull
From: Dmitry Eremin-Solenikov
According to the documentation post_ci is executed only if ci finished
successfully. Move test result reporting to separate script and call it
from on_success and on_failure steps.
Signed-off-by: Dmitry Eremin-Solenikov
./configure --help
for linux-generic and linux-dpdk platforms.
Maxim.
On 31 January 2018 at 22:41, gyanesh patra wrote:
> Hi,
> I am curious if there are any specific flags available for ODP for release
> builds or performance evaluation?
>
> Also where can i find
From: Dmitry Eremin-Solenikov
gcc-built DPDK is not fully compatible with clang (see
https://travis-ci.org/lumag/odp/jobs/335324053 for example). Use clang
to compile DPDK if selected compiler is clang.
Signed-off-by: Dmitry Eremin-Solenikov
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
From: Dmitry Eremin-Solenikov
Use `make check -k' to run testsuite, so that all tests have a chance to
be executed, not stopping after first failure.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull
gcc-built DPDK is not fully compatible with clang (see
https://travis-ci.org/lumag/odp/jobs/335324053 for example). Use clang
to compile DPDK if selected compiler is clang.
Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org
github
/**
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
From: Dmitry Eremin-Solenikov
According to the documentation post_ci is executed only if ci finished
successfully. Move test result reporting to separate script and call it
from on_success and on_failure steps.
Signed-off-by: Dmitry Eremin-Solenikov
github
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch: https://github.com/Linaro/odp/pull/441.patch
** Base sha: b95ccd3db6eeb7358a877541747e06354429acdd
** Merge commit sha:
Hi,
I am curious if there are any specific flags available for ODP for release
builds or performance evaluation?
Also where can i find the list of features i can disable by passing to
configure scripts? I found couple of options in odp-thunderx project such
as "-DODP_DISABLE_CLASSIFICATION and
Dmitry Eremin-Solenikov(lumag) replied on github web page:
include/odp/api/spec/ipsec.h
line 167
@@ -1226,12 +1226,23 @@ typedef struct odp_ipsec_status_t {
* e.g. RFC 4302 and 4303). Resulting packets are well formed, reconstructed
* original IP packets, with IPSEC headers removed and valid
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
github
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch: https://github.com/Linaro/odp/pull/441.patch
** Base sha: b95ccd3db6eeb7358a877541747e06354429acdd
** Merge commit sha:
From: Dmitry Eremin-Solenikov
Use `make check -k' to run testsuite, so that all tests have a chance to
be executed, not stopping after first failure.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
From: Dmitry Eremin-Solenikov
According to the documentation post_ci is executed only if ci finished
successfully. Move test result reporting to separate script and call it
from on_success and on_failure steps.
Signed-off-by: Dmitry Eremin-Solenikov
Dmitry Eremin-Solenikov(lumag) replied on github web page:
test/validation/api/pktio/pktio.c
line 16
@@ -1195,10 +1195,8 @@ void pktio_test_index(void)
ndx = odp_pktio_index(pktio);
CU_ASSERT(ndx >= 0);
- CU_ASSERT(odp_pktio_index(pktio_inval) < 0);
Dmitry Eremin-Solenikov(lumag) replied on github web page:
test/validation/api/pktio/pktio.c
line 16
@@ -1195,10 +1195,8 @@ void pktio_test_index(void)
ndx = odp_pktio_index(pktio);
CU_ASSERT(ndx >= 0);
- CU_ASSERT(odp_pktio_index(pktio_inval) < 0);
Dmitry Eremin-Solenikov(lumag) replied on github web page:
platform/linux-generic/odp_packet.c
line 28
@@ -49,15 +49,14 @@ const _odp_packet_inline_offset_t ODP_ALIGNED_CACHE
_odp_packet_inline = {
#include
-static inline odp_buffer_t buffer_handle(odp_packet_hdr_t *pkt_hdr)
-{
-
Dmitry Eremin-Solenikov(lumag) replied on github web page:
platform/linux-generic/odp_packet.c
line 72
@@ -334,6 +334,54 @@ void *_odp_packet_map(void *pkt_ptr, uint32_t offset,
uint32_t *seg_len,
return packet_map(pkt_ptr, offset, seg_len, seg_idx);
}
+int
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
platform/linux-generic/odp_packet.c
line 28
@@ -49,15 +49,14 @@ const _odp_packet_inline_offset_t ODP_ALIGNED_CACHE
_odp_packet_inline = {
#include
-static inline odp_buffer_t buffer_handle(odp_packet_hdr_t *pkt_hdr)
-{
-
From: Dmitry Eremin-Solenikov
Use `make check -k' to run testsuite, so that all tests have a chance to
be executed, not stopping after first failure.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
From: Dmitry Eremin-Solenikov
According to the documentation post_ci is executed only if ci finished
successfully. Move test result reporting to separate script and call it
from on_success and on_failure steps.
Signed-off-by: Dmitry Eremin-Solenikov
github
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch: https://github.com/Linaro/odp/pull/441.patch
** Base sha: b95ccd3db6eeb7358a877541747e06354429acdd
** Merge commit sha:
Petri Savolainen(psavol) replied on github web page:
platform/linux-generic/odp_packet.c
line 28
@@ -49,15 +49,14 @@ const _odp_packet_inline_offset_t ODP_ALIGNED_CACHE
_odp_packet_inline = {
#include
-static inline odp_buffer_t buffer_handle(odp_packet_hdr_t *pkt_hdr)
-{
- return
From: Petri Savolainen
Specify how application can request TFC padding and dummy
packet creation at output. Application can use
odp_ipsec_out_opt_t options to reguest addition of TFC
padding, or creation of a TFC dummy packet
(next header = 59). IP parameter override
From: Petri Savolainen
Add inbound inner packet checksum check capability. When
e.g. L4 checksum checking is not implemented in HW, it may
be better to leave checking for application, as it would
check only those packets that need the check.
Signed-off-by: Petri
From: Petri Savolainen
Add flags to select which options application uses. Currently,
there's no ambiguity, but as soon as there are multiple options
implementation needs to know which options are used and which
are ignored.
Signed-off-by: Petri Savolainen
From: Petri Savolainen
Specify how application can recognize TFC padding and dummy
packets at input. Packet metadata for L3/L4 protocol type
indicate if the original packet was an IP or a TFC dummy packet.
When packet length is larger than protocol fields indicate,
From: Petri Savolainen
Add enumerations for L3 and L4 protocol types, and functions
to request those.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 403 (psavol:next-ipsec-tfc)
**
From: Petri Savolainen
Rename outbound operation fragmentation options to frag_mode.
Frag_mode is used elsewhere in the API and "mode" is too generic
term for it (not future proof).
Signed-off-by: Petri Savolainen
---
/** Email created
From: Petri Savolainen
Create IP header parameter types, so that those can be used
also outside of SA parameter struct.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 403 (psavol:next-ipsec-tfc)
**
Specify how application can recognize and create TFC padding and dummy packets,
both in inbound and outbound directions.
github
/** Email created from pull request 403 (psavol:next-ipsec-tfc)
** https://github.com/Linaro/odp/pull/403
** Patch:
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
platform/linux-generic/odp_packet.c
line 28
@@ -49,15 +49,14 @@ const _odp_packet_inline_offset_t ODP_ALIGNED_CACHE
_odp_packet_inline = {
#include
-static inline odp_buffer_t buffer_handle(odp_packet_hdr_t *pkt_hdr)
-{
-
Petri Savolainen(psavol) replied on github web page:
platform/linux-generic/odp_packet.c
line 28
@@ -49,15 +49,14 @@ const _odp_packet_inline_offset_t ODP_ALIGNED_CACHE
_odp_packet_inline = {
#include
-static inline odp_buffer_t buffer_handle(odp_packet_hdr_t *pkt_hdr)
-{
- return
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
platform/linux-generic/odp_packet.c
line 169
@@ -1352,16 +1352,14 @@ void odp_packet_flow_hash_set(odp_packet_t pkt,
uint32_t flow_hash)
{
odp_packet_hdr_t *pkt_hdr = packet_hdr(pkt);
- pkt_hdr->flow_hash =
Specify how application can recognize and create TFC padding and dummy packets,
both in inbound and outbound directions.
github
/** Email created from pull request 403 (psavol:next-ipsec-tfc)
** https://github.com/Linaro/odp/pull/403
** Patch:
From: Petri Savolainen
Fast path functions cannot be expected to always check against
invalid handles. Also a handle that has been closed (or destroyed)
must not be passed to any API function.
Signed-off-by: Petri Savolainen
---
/**
From: Petri Savolainen
Inline commonly used packet to/from memory copy functions.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 437 (psavol:master-packet-optim)
** https://github.com/Linaro/odp/pull/437
**
From: Bogdan Pricope
Describe configuration and requirements of code instrumentation
library.
Signed-off-by: Bogdan Pricope
---
/** Email created from pull request 406 (bogdanPricope:cat_benchmark_pr)
**
From: Petri Savolainen
Use multi versions of packet / event conversion functions.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 437 (psavol:master-packet-optim)
** https://github.com/Linaro/odp/pull/437
**
From: Petri Savolainen
Specify how application can request TFC padding and dummy
packet creation at output. Application can use
odp_ipsec_out_opt_t options to reguest addition of TFC
padding, or creation of a TFC dummy packet
(next header = 59). IP parameter override
From: Bogdan Pricope
Add configure time option to trim API set to be instrumented.
Signed-off-by: Bogdan Pricope
---
/** Email created from pull request 406 (bogdanPricope:cat_benchmark_pr)
** https://github.com/Linaro/odp/pull/406
**
From: Petri Savolainen
Inline packet IO interface handle to index conversion function
which may be used frequently.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 437 (psavol:master-packet-optim)
**
ODP API instrumentation with PAPI (Performance API) library
(http://icl.cs.utk.edu/papi)
"instrum" example is using library preload, symbols overloading and PAPI to
obtain performance counters (like data cache miss or conditional branch count)
for execution of ODP API calls. Performance
From: Bogdan Pricope
Add instrumentation library as odp example.
Signed-off-by: Bogdan Pricope
---
/** Email created from pull request 406 (bogdanPricope:cat_benchmark_pr)
** https://github.com/Linaro/odp/pull/406
** Patch:
From: Bogdan Pricope
Add configuration options to enable code instrumentation and set
PAPI installation folder.
Signed-off-by: Bogdan Pricope
---
/** Email created from pull request 406 (bogdanPricope:cat_benchmark_pr)
**
From: Petri Savolainen
Use always inlined versions of packet to/from memory copy
functions.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 437 (psavol:master-packet-optim)
**
From: Petri Savolainen
Specify how application can recognize TFC padding and dummy
packets at input. Packet metadata for L3/L4 protocol type
indicate if the original packet was an IP or a TFC dummy packet.
When packet length is larger than protocol fields indicate,
From: Petri Savolainen
Rename outbound operation fragmentation options to frag_mode.
Frag_mode is used elsewhere in the API and "mode" is too generic
term for it (not future proof).
Signed-off-by: Petri Savolainen
---
/** Email created
From: Petri Savolainen
Create IP header parameter types, so that those can be used
also outside of SA parameter struct.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 403 (psavol:next-ipsec-tfc)
**
From: Petri Savolainen
Add enumerations for L3 and L4 protocol types, and functions
to request those.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 403 (psavol:next-ipsec-tfc)
**
From: Bogdan Pricope
Add test to validate ODP build with papi library.
Signed-off-by: Bogdan Pricope
---
/** Email created from pull request 406 (bogdanPricope:cat_benchmark_pr)
** https://github.com/Linaro/odp/pull/406
** Patch:
From: Bogdan Pricope
Configure the set of papi counters to be acquired via an
environment variable.
Signed-off-by: Bogdan Pricope
---
/** Email created from pull request 406 (bogdanPricope:cat_benchmark_pr)
**
From: Bogdan Pricope
Use low level PAPI API to get performance counters.
Exemplify on some ODP APIs.
Signed-off-by: Bogdan Pricope
---
/** Email created from pull request 406 (bogdanPricope:cat_benchmark_pr)
**
From: Petri Savolainen
Inline packet input interface index function which may
be used frequently.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 437 (psavol:master-packet-optim)
**
From: Petri Savolainen
Inline implementation of packet_from_event and packet_to_event
functions.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 437 (psavol:master-packet-optim)
**
From: Petri Savolainen
Use only one function (packet_hdr) in handle to header pointer
conversion. odp_packet_hdr is bad name for an implementation
internal function as API function prefix is odp_packet_.
Signed-off-by: Petri Savolainen
From: Petri Savolainen
For minimal code complexity and negative impact, prefetch
only when the requested address is in the first segment and
prefetch only one cache line.
Signed-off-by: Petri Savolainen
---
/** Email created from pull
From: Petri Savolainen
Use @cond tag to hide internal functions from Doxygen.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 437 (psavol:master-packet-optim)
** https://github.com/Linaro/odp/pull/437
** Patch:
Continue inlining of commonly used small packet and pktio API functions. These
improve few percents packet rate of L2fwd (both direct/scheduled mode) and OFP
burst test. Especially, in non-ABI compat mode and with copying pktios (test
with DPDK).
github
From: Petri Savolainen
Use inlined version of flow hash set function. Also changed API
to use inlined timestamp function, so that the same function is
not implemented twice.
Signed-off-by: Petri Savolainen
---
/** Email created from
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 440 (lumag:build-fixes)
** https://github.com/Linaro/odp/pull/440
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 440 (lumag:build-fixes)
** https://github.com/Linaro/odp/pull/440
** Patch:
From: Dmitry Eremin-Solenikov
gcc-built DPDK is not fully compatible with clang (see
https://travis-ci.org/lumag/odp/jobs/335324053 for example). Use clang
to compile DPDK if selected compiler is clang.
Signed-off-by: Dmitry Eremin-Solenikov
gcc-built DPDK is not fully compatible with clang (see
https://travis-ci.org/lumag/odp/jobs/335324053 for example). Use clang
to compile DPDK if selected compiler is clang.
Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org
github
/**
From: Dmitry Eremin-Solenikov
${with_platform} in doc/platform-api-guide/Makefile.am will add to
distro platform docs only for currently selected platform. Move this to
platform/Makefile.inc, so that every platform doc file gets included
into distro.
From: Dmitry Eremin-Solenikov
platform m4/configure.m4 file might want to change compiler flags. So let's
set them before calling into platform file.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 440 (lumag:build-fixes)
** https://github.com/Linaro/odp/pull/440
** Patch:
From: Dmitry Eremin-Solenikov
platform m4/configure.m4 file can make use of ODP_ABI_COMPAT. So let's
set it before calling into platform file.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request
Few updates to make implementation life easier.
github
/** Email created from pull request 440 (lumag:build-fixes)
** https://github.com/Linaro/odp/pull/440
** Patch: https://github.com/Linaro/odp/pull/440.patch
** Base sha:
Dmitry Eremin-Solenikov(lumag) replied on github web page:
.travis.yml
line 60
@@ -193,6 +200,7 @@ install:
sed -i -e 's/40900/40800/g'
lib/librte_eal/common/include/arch/arm/rte_vect.h
sed -i -e 's/!(/!(defined(__arm__) \&\& defined(__clang__) || /g'
Dmitry Eremin-Solenikov(lumag) replied on github web page:
.travis.yml
line 15
@@ -158,33 +158,40 @@ install:
if [ "${CACHED_DPDK_VERS}" != "${DPDK_VERS}" ]; then
rm -rf dpdk
fi
+- if [ "${CC#clang}" != "${CC}" ] ;
+ then
+
Ilias Apalodimas(apalos) replied on github web page:
platform/linux-generic/odp_packet_io.c
line 237
@@ -89,6 +96,274 @@ int odp_pktio_init_local(void)
return odp_pktio_ops_init_local(true);
}
+static int write_pcapng_hdr(pktio_entry_t *entry, int qidx)
+{
+ size_t len;
+
bogdanPricope replied on github web page:
example/m4/configure.m4
line 18
@@ -7,6 +7,16 @@ AC_ARG_ENABLE([test-example],
[test_example=yes])
AM_CONDITIONAL([test_example], [test x$test_example = xyes ])
+PAPI_PATH=""
+code_instrumentation=no
+AC_ARG_WITH([papi-path],
Petri Savolainen(psavol) replied on github web page:
platform/linux-generic/odp_packet.c
line 169
@@ -1352,16 +1352,14 @@ void odp_packet_flow_hash_set(odp_packet_t pkt,
uint32_t flow_hash)
{
odp_packet_hdr_t *pkt_hdr = packet_hdr(pkt);
- pkt_hdr->flow_hash = flow_hash;
-
Petri Savolainen(psavol) replied on github web page:
platform/linux-generic/odp_packet.c
line 28
@@ -49,15 +49,14 @@ const _odp_packet_inline_offset_t ODP_ALIGNED_CACHE
_odp_packet_inline = {
#include
-static inline odp_buffer_t buffer_handle(odp_packet_hdr_t *pkt_hdr)
-{
- return
84 matches
Mail list logo