From: Dmitry Eremin-Solenikov
Make Automake stop on all warnings it encounters when creating
Makefile.in's
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 460 (lumag:build-fixes)
**
Make Automake stop on all warnings it encounters when creating
Makefile.in's
Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org
github
/** Email created from pull request 460 (lumag:build-fixes)
**
From: Dmitry Eremin-Solenikov
Correct visibility regexp to allow symbols like _deprecated_odp_*.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 460 (lumag:build-fixes)
**
From: Dmitry Eremin-Solenikov
For ABI-compat case provide version script declaring all public symbols
(and their versions). For now all symbols are reset to version 1.17
(latest public release). API and ABI checking will be set up to ease
maintaining of version
First patch is required, so that libodp-linux does not export unnecessary
symbols linked in through DPDK.
Second patch (to be discussed) adds version script, binding symbols to library
version (for ABI-compat case only).
github
/** Email created from pull
Make Automake stop on all warnings it encounters when creating
Makefile.in's
Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org
github
/** Email created from pull request 460 (lumag:build-fixes)
**
From: Dmitry Eremin-Solenikov
Make Automake stop on all warnings it encounters when creating
Makefile.in's
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 460 (lumag:build-fixes)
**
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
From: Dmitry Eremin-Solenikov
Use `make check -k' to run testsuite, so that all tests have a chance to
be executed, not stopping after first failure.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull
From: Dmitry Eremin-Solenikov
According to the documentation post_ci is executed only if ci finished
successfully. Move test result reporting to separate script and call it
from on_success and on_failure steps.
Signed-off-by: Dmitry Eremin-Solenikov
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch:
github
/** Email created from pull request 441 (lumag:shippable-ci)
** https://github.com/Linaro/odp/pull/441
** Patch: https://github.com/Linaro/odp/pull/441.patch
** Base sha: 257b08b35ceea41bad5a7f1c626496cf111e657a
** Merge commit sha:
First patch is required, so that libodp-linux does not export unnecessary
symbols linked in through DPDK.
Second patch (to be discussed) adds version script, binding symbols to library
version (for ABI-compat case only).
github
/** Email created from pull
From: Dmitry Eremin-Solenikov
For ABI-compat case provide version script declaring all public symbols
(and their versions). For now all symbols are reset to version 1.17
(latest public release). API and ABI checking will be set up to ease
maintaining of version
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 459 (lumag:packet-types-2)
** https://github.com/Linaro/odp/pull/459
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 459 (lumag:packet-types-2)
** https://github.com/Linaro/odp/pull/459
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 459 (lumag:packet-types-2)
** https://github.com/Linaro/odp/pull/459
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 459 (lumag:packet-types-2)
** https://github.com/Linaro/odp/pull/459
** Patch:
Implement new packet API.
While we are at it, should we add L2 packet type (only ETH for now) for
completeness?
github
/** Email created from pull request 459 (lumag:packet-types-2)
** https://github.com/Linaro/odp/pull/459
** Patch:
Gather macros needed for upcoming mediated devices in one location.
Fix signed vs. unsigned comparisons caused by incorrect MIN / MAX usage.
Signed-off-by: Mykyta Iziumtsev mykyta.iziumt...@linaro.org
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
From: Mykyta Iziumtsev
Gather macros needed for upcoming mediated devices in one location.
Fix signed vs. unsigned comparisons caused by incorrect MIN / MAX usage.
Signed-off-by: Mykyta Iziumtsev
Reviewed-by: Bill Fischofer
Configure DPDK NIC RX rings to automatically drop packets if no free
descriptors are available. Without this option being set, some NICs (e.g.
82599, X540) will stop receiving packets from all RX queues if any of the
RX queues is not emptied fast enough.
Fixes:
From: Matias Elo
Configure DPDK NIC RX rings to automatically drop packets if no free
descriptors are available. Without this option being set, some NICs (e.g.
82599, X540) will stop receiving packets from all RX queues if any of the
RX queues is not emptied fast enough.
Did you try with the latest netmap master branch code? That seemed to work for
me.
-Matias
On 7 Feb 2018, at 17.32, gyanesh patra
> wrote:
Is it possible to fix for netmap too in similar fashion?
P Gyanesh Kumar Patra
On Wed, Feb 7,
netmap is not detaching the driver the way DPDK does.
I am guessing you'll have to edit the kernel driver if that config
option is not available in sysfs/ethtool
Regards
Ilias
On 7 February 2018 at 17:31, gyanesh patra wrote:
> Is it possible to fix for netmap too in
Is it possible to fix for netmap too in similar fashion?
P Gyanesh Kumar Patra
On Wed, Feb 7, 2018 at 1:19 PM, Elo, Matias (Nokia - FI/Espoo) <
matias@nokia.com> wrote:
> The PR is now available: https://github.com/Linaro/odp/pull/458
>
> -Matias
>
> > On 7 Feb 2018, at 15:31, gyanesh patra
The PR is now available: https://github.com/Linaro/odp/pull/458
-Matias
> On 7 Feb 2018, at 15:31, gyanesh patra wrote:
>
> This patch works on Intel X540-AT2 NICs too.
>
> P Gyanesh Kumar Patra
>
> On Wed, Feb 7, 2018 at 11:28 AM, Bill Fischofer
https://bugs.linaro.org/show_bug.cgi?id=3618
Bug ID: 3618
Summary: DPDK pktio stops receiving packets if all configured
RX queues are not used
Product: OpenDataPlane - linux- generic reference
Version: master
Hardware: All
This patch works on Intel X540-AT2 NICs too.
P Gyanesh Kumar Patra
On Wed, Feb 7, 2018 at 11:28 AM, Bill Fischofer
wrote:
> Thanks, Matias. Please open a bug for this and reference it in the fix.
>
> On Wed, Feb 7, 2018 at 6:36 AM, Elo, Matias (Nokia - FI/Espoo) <
>
Branch: refs/heads/api-next
Home: https://github.com/Linaro/odp
Commit: dffd44a745bfb4761d9d3faba41aa8259a903f6b
https://github.com/Linaro/odp/commit/dffd44a745bfb4761d9d3faba41aa8259a903f6b
Author: Balasubramanian Manoharan
Date: 2018-02-07 (Wed,
Thanks, Matias. Please open a bug for this and reference it in the fix.
On Wed, Feb 7, 2018 at 6:36 AM, Elo, Matias (Nokia - FI/Espoo) <
matias@nokia.com> wrote:
> Hi,
>
> I actually just figured out the problem. For e.g. Niantic NICs the
> rte_eth_rxconf.rx_drop_en has to be enabled for the
Branch: refs/heads/api-next
Home: https://github.com/Linaro/odp
Commit: 189fc5df9551dd998a1091de863843edd6f98b78
https://github.com/Linaro/odp/commit/189fc5df9551dd998a1091de863843edd6f98b78
Author: Petri Savolainen
Date: 2018-02-07 (Wed, 07 Feb
Implement new packet API. For simplicity add setting functions for L3/L4 packet
types.
While we are at it, should we add L2 packet type (only ETH for now) for
completeness?
github
/** Email created from pull request 457 (lumag:packet-types)
**
From: Dmitry Eremin-Solenikov
Use odp_packet_l4_type_set() instead of calling odp_packet_has_*_set().
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
**
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Add API calls to set packet L3/L4 types.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
**
From: Dmitry Eremin-Solenikov
Use odp_packet_l3_type_set() instead of calling
odp_packet_has_ipv4_set() or odp_packet_has_ipv6_set().
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Use odp_packet_l4_type_set() instead of calling odp_packet_has_*_set().
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
**
From: Dmitry Eremin-Solenikov
Use odp_packet_l3_type_set() instead of calling
odp_packet_has_ipv4_set() or odp_packet_has_ipv6_set().
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457
From: Dmitry Eremin-Solenikov
Use odp_packet_l3_type_set() instead of calling
odp_packet_has_ipv4_set() or odp_packet_has_ipv6_set().
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Use odp_packet_l4_type_set() instead of calling odp_packet_has_*_set().
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
**
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
Hi,
I actually just figured out the problem. For e.g. Niantic NICs the
rte_eth_rxconf.rx_drop_en has to be enabled for the NIC to continue working
properly when all RX queues are not emptied. The following patch fixes the
problem for me:
diff --git a/platform/linux-generic/pktio/dpdk.c
Mykyta Iziumtsev(MykytaI) replied on github web page:
platform/linux-generic/odp_packet_io.c
line 105
@@ -89,6 +96,274 @@ int odp_pktio_init_local(void)
return odp_pktio_ops_init_local(true);
}
+static int write_pcapng_hdr(pktio_entry_t *entry, int qidx)
+{
+ size_t len;
+
Mykyta Iziumtsev(MykytaI) replied on github web page:
platform/linux-generic/include/odp_pcapng.h
line 23
@@ -0,0 +1,56 @@
+/* Copyright (c) 2018, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+#include
+#include
+#include
+#include
+#include
Mykyta Iziumtsev(MykytaI) replied on github web page:
platform/linux-generic/include/odp_pcapng.h
line 24
@@ -0,0 +1,56 @@
+/* Copyright (c) 2018, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+#include
+#include
+#include
+#include
+#include
Ilias Apalodimas(apalos) replied on github web page:
platform/linux-generic/include/odp_packet_io_internal.h
line 18
@@ -97,6 +97,20 @@ struct pktio_entry {
odp_queue_tqueue;
odp_pktout_queue_t pktout;
} out_queue[PKTIO_MAX_QUEUES];
+
+ /**<
Ilias Apalodimas(apalos) replied on github web page:
platform/linux-generic/include/odp_pcapng.h
line 24
@@ -0,0 +1,56 @@
+/* Copyright (c) 2018, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+#include
+#include
+#include
+#include
+#include
Mykyta Iziumtsev(MykytaI) replied on github web page:
platform/linux-generic/include/odp_pcapng.h
line 45
@@ -0,0 +1,56 @@
+/* Copyright (c) 2018, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+#include
+#include
+#include
+#include
+#include
Ilias Apalodimas(apalos) replied on github web page:
platform/linux-generic/include/odp_pcapng.h
line 45
@@ -0,0 +1,56 @@
+/* Copyright (c) 2018, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+#include
+#include
+#include
+#include
+#include
Mykyta Iziumtsev(MykytaI) replied on github web page:
platform/linux-generic/include/odp_pcapng.h
line 24
@@ -0,0 +1,56 @@
+/* Copyright (c) 2018, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+#include
+#include
+#include
+#include
+#include
Petri Savolainen(psavol) replied on github web page:
platform/linux-generic/_ishm.c
line 23
@@ -1436,15 +1436,23 @@ int _odp_ishm_cleanup_files(const char *dirpath)
return 0;
}
-int _odp_ishm_init_global(void)
+int _odp_ishm_init_global(const odp_init_t *init)
{
void *addr;
Mykyta Iziumtsev(MykytaI) replied on github web page:
platform/linux-generic/include/odp_pcapng.h
line 14
@@ -0,0 +1,56 @@
+/* Copyright (c) 2018, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+#include
+#include
+#include
+#include
+#include
Mykyta Iziumtsev(MykytaI) replied on github web page:
platform/linux-generic/include/odp_pcapng.h
line 1
@@ -0,0 +1,56 @@
+/* Copyright (c) 2018, Linaro Limited
Comment:
Is there any reason to put all of this into separate header file ? From what I
see only one .c file is using it, so why not
Mykyta Iziumtsev(MykytaI) replied on github web page:
platform/linux-generic/include/odp_packet_io_internal.h
line 18
@@ -97,6 +97,20 @@ struct pktio_entry {
odp_queue_tqueue;
odp_pktout_queue_t pktout;
} out_queue[PKTIO_MAX_QUEUES];
+
+ /**<
Petri Savolainen(psavol) replied on github web page:
platform/linux-generic/_ishm.c
line 23
@@ -1436,15 +1436,23 @@ int _odp_ishm_cleanup_files(const char *dirpath)
return 0;
}
-int _odp_ishm_init_global(void)
+int _odp_ishm_init_global(const odp_init_t *init)
{
void *addr;
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
platform/linux-generic/pktio/loop.c
@@ -155,7 +155,7 @@ static int loopback_recv(pktio_entry_t *pktio_entry, int
index ODP_UNUSED,
/* Try IPsec inline processing */
if
muvarov replied on github web page:
platform/linux-generic/_ishm.c
line 23
@@ -1436,15 +1436,23 @@ int _odp_ishm_cleanup_files(const char *dirpath)
return 0;
}
-int _odp_ishm_init_global(void)
+int _odp_ishm_init_global(const odp_init_t *init)
{
void *addr;
void
I'm currently trying to figure out what's happening. I'll report back when I
find out something.
-Matias
> On 7 Feb 2018, at 13:44, gyanesh patra wrote:
>
> Do you have any theory for the issue in 82599 (Niantic) NIC and why it might
> be working in Intel XL710
Do you have any theory for the issue in 82599 (Niantic) NIC and why it
might be working in Intel XL710 (Fortville)? Can i identify a new hardware
without this issue by looking at their datasheet/specs?
Thanks for the insight.
P Gyanesh Kumar Patra
On Wed, Feb 7, 2018 at 9:12 AM, Elo, Matias
I was unable to reproduce this with Intel XL710 (Fortville) but with 82599
(Niantic) l2fwd operates as you have described. This may be a NIC HW limitation
since the same issue is also observed with netmap pktio.
-Matias
> On 7 Feb 2018, at 11:14, gyanesh patra
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Use odp_packet_l4_type_set() instead of calling odp_packet_has_*_set().
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
**
From: Dmitry Eremin-Solenikov
Use odp_packet_l4_type_set() instead of calling odp_packet_has_*_set().
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
**
From: Dmitry Eremin-Solenikov
Use odp_packet_l3_type_set() instead of calling
odp_packet_has_ipv4_set() or odp_packet_has_ipv6_set().
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457
From: Dmitry Eremin-Solenikov
Use odp_packet_l3_type_set() instead of calling
odp_packet_has_ipv4_set() or odp_packet_has_ipv6_set().
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Use odp_packet_l3_type_set() instead of calling
odp_packet_has_ipv4_set() or odp_packet_has_ipv6_set().
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457
From: Dmitry Eremin-Solenikov
Add API calls to set packet L3/L4 types.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
**
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 457 (lumag:packet-types)
** https://github.com/Linaro/odp/pull/457
** Patch:
Implement new packet API. For simplicity add setting functions for L3/L4 packet
types.
While we are at it, should we add L2 packet type (only ETH for now) for
completeness?
github
/** Email created from pull request 457 (lumag:packet-types)
**
Thanks for the info. I verified this with both odp 1.16 and odp 1.17 with
same behavior.
The traffic consists of diff Mac and ip addresses.
Without the busy loop, I could see that all the threads were receiving
packets. So i think packet distribution is not an issue. In our case, we
are sending
83 matches
Mail list logo