Re: [lng-odp] [EXT] Re: ODP1.15 with gcc-linaro-5.3.1

2017-10-18 Thread Brian Brooks
Hi Brian, > > I attached full configure output. > > Liron > > -Original Message- > From: Brian Brooks [mailto:brian.bro...@linaro.org] > Sent: Wednesday, October 18, 2017 18:50 > To: Liron Himi <lir...@marvell.com> > Cc: lng-odp@lists.linaro.org > Subj

Re: [lng-odp] ODP1.15 with gcc-linaro-5.3.1

2017-10-18 Thread Brian Brooks
Hi Liron, Can you paste a full copy of the ./configure output? Brian On Wed, Oct 18, 2017 at 9:58 AM, Liron Himi wrote: > Hi, > > We are using 'gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu' as our > tool-chain. > When I compile ODP1.15 with it I get a lot of: >

Re: [lng-odp] Moving scalable scheduler to master

2017-10-12 Thread Brian Brooks
This code is primarily contained within its own files, so I don't see how this mitigates any issues (merge conflicts) with merging it to master. On Wed, Oct 11, 2017 at 6:14 PM, Bill Fischofer wrote: > I've looked over the code and the biggest issue surrounds the use

Re: [lng-odp] generic core + HW specific drivers

2017-10-03 Thread Brian Brooks
The approach taken by Vulkan project: https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/blob/master/loader/LoaderAndLayerInterface.md On Tue, Oct 3, 2017 at 6:52 PM, Dmitry Eremin-Solenikov wrote: > On 03/10/17 11:12, Savolainen, Petri (Nokia -

Re: [lng-odp] Future of per-arch-platform ABI spec files

2017-09-20 Thread Brian Brooks
On 09/19 12:03:20, Dmitry Eremin-Solenikov wrote: > Hello, > > I have been poking around per-arch-platform ABI spec files. > Currently all architectures just include default specs. Do we have any > particular use case for these separate files? Otherwise I'd suggest to > drop them completely and

Re: [lng-odp] Compiler Barrier API

2017-09-11 Thread Brian Brooks
them from ODP API) since they are not Control / Data Plane objects and are implemented using atomic primitives (which are an abstraction layer provided by the compiler). Perhaps they should be moved to a odp-helper-sync library that depends on an odp-helper-atomic library. > On Sun, Sep 10, 2017 at 10:28

Re: [lng-odp] Compiler Barrier API

2017-09-10 Thread Brian Brooks
inux-generic/arch/arm/odp_atomic.h?h=api-next#n56 How about a #define for compiler barrier in odp_compiler_internal.h? > Andriy > > > On 05.09.2017 17:06, Brian Brooks wrote: >> >> I don't see a compiler barrier in the odp.git repo. Perhaps 'nop', but >> this acts as more

Re: [lng-odp] Supporting ODP_PKTIO_OP_MT_SAFE

2017-09-10 Thread Brian Brooks
Honnappa, Could your proposal be simplified to: MT-safe pktio should be deprecated because it is not a common use case. Applications will either use MT-unsafe pktio or the MT-safe scheduler. > 1) Polling method - in which one pkt I/O will be created for each receive > worker thread. In this

Re: [lng-odp] [PATCH] linux-gen: barrier: Use correct memory ordering

2017-09-06 Thread Brian Brooks
ping On Sat, Aug 26, 2017 at 9:52 AM, Bill Fischofer <bill.fischo...@linaro.org> wrote: > On Sat, Aug 26, 2017 at 12:40 AM, Brian Brooks <brian.bro...@arm.com> wrote: > >> Memory accesses that happen-before, in program order, a call to >> odp_barrier_wait() cannot

Re: [lng-odp] Compiler Barrier API

2017-09-05 Thread Brian Brooks
I don't see a compiler barrier in the odp.git repo. Perhaps 'nop', but this acts as more than a pure compiler barrier? On Tue, Sep 5, 2017 at 8:23 AM, Andriy Berestovskyy wrote: > Hey Petri, > > On 05.09.2017 14:17, Savolainen, Petri (Nokia - FI/Espoo)

[lng-odp] [PATCH] linux-gen: barrier: Use correct memory ordering

2017-08-25 Thread Brian Brooks
. The measurable performance difference is negligible on weakly ordered architectures such as ARM, so the highlight of this change is correctness. Signed-off-by: Brian Brooks <brian.bro...@arm.com> --- platform/linux-generic/odp_barrier.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [lng-odp] merge master to api-next

2017-07-27 Thread Brian Brooks
c5c810, Signed-off-by: Brian Brooks <brian.bro...@arm.com> > Maxim. > > > > On 26 July 2017 at 22:33, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > > > Updated pull request. Let's see what test will show. > > > > Maxim. > > > > O

Re: [lng-odp] merge master to api-next

2017-07-26 Thread Brian Brooks
On 07/26 10:29:41, Dmitry Eremin-Solenikov wrote: > On 26/07/17 01:00, Maxim Uvarov wrote: > > Merge request is: > > > > https://github.com/Linaro/odp/pull/71 > > > > 2 arm build fails with errors. > > Both are due to scalable scheduler code. Neither are due to scalable scheduler. They are

Re: [lng-odp] [API-NEXT PATCHv7 1/4] api: timer: add odp_timer_capability() api

2017-07-24 Thread Brian Brooks
Reviewed-by: Brian Brooks <brian.bro...@arm.com> On Wed, Jul 19, 2017 at 10:43 PM, Kevin Wang <kevin.w...@arm.com> wrote: > Currently, user needs to decide the timer resolution before creating > a timer pool. But sometimes it will cause timer overrun as the system > ca

Re: [lng-odp] [PATCH v2 1/3] example: ipfragaddress: fix compilation with clang

2017-07-14 Thread Brian Brooks
On 07/12 16:00:04, Github ODP bot wrote: > From: Dmitry Eremin-Solenikov > > Clang 3.8 is stricter than GCC wrt register allocation vs 128-bit > variables. Sometimes it can not understand using 128-bit var in place of > 64-bit register resulting in the

Re: [lng-odp] questions about buffer allocation in linux-generic

2017-07-11 Thread Brian Brooks
On 07/07 19:23:10, Bill Fischofer wrote: > On Fri, Jul 7, 2017 at 4:55 PM, Brian Brooks <brian.bro...@linaro.org> wrote: > > Why is a buffer's "user area" not adjacent (virtually) to the buffer > > header itself? > > If by design, then a simpler way

[lng-odp] questions about buffer allocation in linux-generic

2017-07-07 Thread Brian Brooks
Why is a buffer's "user area" not adjacent (virtually) to the buffer header itself? If by design, then a simpler way is to let the user manage that memory and pass a pointer that gets associated with the buffer (context, usr_ptr, cookie, ...). Why are the sizes here round up to nearest cache

Re: [lng-odp] [PATCH] doc: userguide: add portability and usage info for odp time apis

2017-06-29 Thread Brian Brooks
On 06/29 16:21:47, Maxim Uvarov wrote: > Hello Bill, > > patch is good. Please see my notes bellow which I think reasonable. > > > On 02/14/17 01:47, Bill Fischofer wrote: > > Clarify and expand on portability and performance considerations > > regarding the use of the ODP time APIs in

Re: [lng-odp] [PATCHv2] linux-gen: scheduler: modular scheduler interface

2017-06-29 Thread Brian Brooks
On 06/29 12:08:49, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > -Original Message- > > From: Brian Brooks [mailto:brian.bro...@arm.com] > > Sent: Wednesday, June 28, 2017 5:17 PM > > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia

Re: [lng-odp] [PATCHv2] linux-gen: scheduler: modular scheduler interface

2017-06-28 Thread Brian Brooks
queue. It needs to be cleaned out. The pktio/queue related > functions should be moved to pktio/queue internal header file. > > Signed-off-by: Joyce Kong <joyce.k...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> > --- > platform/linux-generic/include/odp_p

Re: [lng-odp] [PATCHv2] linux-gen: scheduler: modular scheduler interface

2017-06-28 Thread Brian Brooks
On 06/28 07:24:08, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Joyce > > Kong > > Sent: Wednesday, June 28, 2017 5:14 AM > > To: lng-odp@lists.linaro.org > > Cc: Joyce Kong

[lng-odp] [PATCH] build: fix 64-bit atomics detection

2017-06-27 Thread Brian Brooks
Use uint64_t instead of int type. This resolves ipfragreass build breakage with clang on 32-bit systems. Signed-off-by: Brian Brooks <brian.bro...@arm.com> --- platform/linux-generic/m4/configure.m4 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/platform/linux-g

Re: [lng-odp] [PATCH] linux-gen: time: use true hz

2017-06-27 Thread Brian Brooks
On 06/27 07:43:19, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Brian > > Brooks > > Sent: Monday, June 26, 2017 9:21 PM > > To: lng-odp@lists.lina

[lng-odp] [API-NEXT PATCH v10 5/6] linux-gen: sched scalable: add scalable scheduler

2017-06-23 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Signed-off-by: Kevin Wang <kevin.w...@arm.com> Signed-off-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> --- platform/linux-generic/Makefile.am

[lng-odp] [API-NEXT PATCH v10 2/6] linux-gen: sched scalable: add arch files

2017-06-23 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> --- platform/linux-generic/Makefile.am | 17 ++ platform/linux-generic/arch/arm/odp_

[lng-odp] [API-NEXT PATCH v10 4/6] linux-gen: sched scalable: add a concurrent queue

2017-06-23 Thread Brian Brooks
Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/include/odp_llqueue.h | 311 +++ 2 files changed, 312 insertions(+) create

[lng-odp] [API-NEXT PATCH v10 3/6] linux-gen: sched scalable: add a bitset

2017-06-23 Thread Brian Brooks
Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/include/

[lng-odp] [API-NEXT PATCH v10 6/6] travis: add scalable scheduler in CI

2017-06-23 Thread Brian Brooks
From: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> Added running tests with scalable scheduler to CI Signed-off-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> --- .travis.yml | 1 + 1 file changed, 1 insert

[lng-odp] [API-NEXT PATCH v10 0/6] A scalable software scheduler

2017-06-23 Thread Brian Brooks
Mv8 issues and other fixes into separate patches - Abstract away some #ifdefs - Fix some checkpatch.pl warnings Brian Brooks (5): test: odp_pktio_ordered: add queue size linux-gen: sched scalable: add arch files linux-gen: sched scalable: add a bitset linux-gen: sched scalable: add a concurr

Re: [lng-odp] [PATCH v4] example: add IPv4 fragmentation/reassembly example

2017-06-23 Thread Brian Brooks
cx16 > >>>>> flag. > >>>>> > >>>>> Maxim. > >>>> > >>>> Hey Maxim, > >>>> > >>>> As we discussed previously, from my end the example should work perfectly > >>>> with clang, it

Re: [lng-odp] [PATCH v2] build: fix conditional compilation of sources

2017-06-22 Thread Brian Brooks
Hi Maxim, Can you please land this in api-next as well as master since we need to rebase the scalable scheduler patch series against this patch? Thanks, Brian On 06/22 17:05:38, Brian Brooks wrote: > Explicitly add all arch//* files to respective _SOURCES > variables instead of using @AR

[lng-odp] [PATCH v2] build: fix conditional compilation of sources

2017-06-22 Thread Brian Brooks
tps://lists.linaro.org/pipermail/lng-odp/2017-June/031598.html [3] https://www.gnu.org/software/automake/manual/html_node/Conditional-Sources.html Signed-off-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Kevin Wang <kevin.w...@arm.com> Reviewed-by: Yi He <yi...@arm.com>

Re: [lng-odp] [PATCH] build: fix conditional compilation of sources

2017-06-22 Thread Brian Brooks
On 06/22 19:44:45, Maxim Uvarov wrote: > On 06/22/17 19:19, Brian Brooks wrote: > > On 06/22 19:06:01, Maxim Uvarov wrote: > >> On 06/22/17 17:17, Brian Brooks wrote: > >>> On 06/22 11:13:57, Maxim Uvarov wrote: > >>>> On 22 June 2017 at 06:

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

2017-06-22 Thread Brian Brooks
> > > The first is built only for ARM and the second for the rest. Would there > > >be a way to build both always ? > > For ARMv7a and ARMv8a, you could build both versions. You really want to > > use the LL/SC version on these architectures. > > > > For architectures without double-word LL/SC,

Re: [lng-odp] [PATCH] build: fix conditional compilation of sources

2017-06-22 Thread Brian Brooks
On 06/22 19:06:01, Maxim Uvarov wrote: > On 06/22/17 17:17, Brian Brooks wrote: > > On 06/22 11:13:57, Maxim Uvarov wrote: > >> On 22 June 2017 at 06:24, Brian Brooks <brian.bro...@arm.com> wrote: > >> > >>> Explicitly add all arch//* files to respect

Re: [lng-odp] [API-NEXT PATCH v4] timer: allow timer processing to run on worker cores

2017-06-22 Thread Brian Brooks
On 06/22 18:30:47, Maxim Uvarov wrote: > On 06/22/17 17:55, Brian Brooks wrote: > > On 06/22 10:27:01, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> I was asking to make sure that performance impact has been checked also > >> when timers are not used, e.g. l2fwd p

Re: [lng-odp] [API-NEXT PATCH v4] timer: allow timer processing to run on worker cores

2017-06-22 Thread Brian Brooks
On 06/22 10:27:01, Savolainen, Petri (Nokia - FI/Espoo) wrote: > I was asking to make sure that performance impact has been checked also when > timers are not used, e.g. l2fwd performance before and after the change. It > would be also appropriate to test impact in the worst case: l2fwd type >

Re: [lng-odp] [PATCH] build: fix conditional compilation of sources

2017-06-22 Thread Brian Brooks
On 06/22 11:13:57, Maxim Uvarov wrote: > On 22 June 2017 at 06:24, Brian Brooks <brian.bro...@arm.com> wrote: > > > Explicitly add all arch//* files to respective _SOURCES > > variables instead of using @ARCH_DIR@ substitution. > > > > This patch fixes the

Re: [lng-odp] [PATCH API-NEXT v1 1/1] linux-generic: crypto: adapt HMAC code to OpenSSL 1.1.x

2017-06-22 Thread Brian Brooks
nSSL 1.1.x on some machines. Reviewed-and-tested-by: Brian Brooks <brian.bro...@arm.com> > Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> > --- > /** Email created from pull request 51 (lumag:hmac-1.1.x) > ** https://github.com/Linaro/odp/pull/51 >

[lng-odp] [PATCH] build: fix conditional compilation of sources

2017-06-21 Thread Brian Brooks
tps://lists.linaro.org/pipermail/lng-odp/2017-June/031598.html [3] https://www.gnu.org/software/automake/manual/html_node/Conditional-Sources.html Signed-off-by: Brian Brooks <brian.bro...@arm.com> --- configure.ac | 3 +++ platform/linux-generic/Makefil

Re: [lng-odp] [PATCH] linux-gen: time: fix ARM compile for GCC 4.8

2017-06-21 Thread Brian Brooks
#if -> #ifdef On Wed, Jun 21, 2017 at 3:27 PM, Maxim Uvarov wrote: > odp check with ARCH=arm fails after this patch: > > CC arch/arm/odp_cpu_arch.lo > arch/arm/odp_cpu_arch.c: In function 'cpu_global_time': > arch/arm/odp_cpu_arch.c:71:5: error: "__aarch64__" is

Re: [lng-odp] [API-NEXT PATCH v9 0/6] A scalable software scheduler

2017-06-21 Thread Brian Brooks
for target 'dist' failed > > make: *** [dist] Error 2 > > > > On Mon, Jun 19, 2017 at 6:11 PM, Bill Fischofer > > <bill.fischo...@linaro.org> wrote: > >> For the v9 series: > >> > >> Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.

Re: [lng-odp] [PATCH] linux-gen: time: fix ARM compile for GCC 4.8

2017-06-21 Thread Brian Brooks
Reviewed-by: Brian Brooks <brian.bro...@arm.com> ACLE [1] was added to GCC 4.9. GCC 4.8 does define __aarch64__ so this change should be safe. [1] http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053c/IHI0053C_acle_2_0.pdf On 06/21 14:48:36, Petri Savolainen wrote: > Use __

[lng-odp] [API-NEXT PATCH v9 5/6] linux-gen: sched scalable: add scalable scheduler

2017-06-19 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Signed-off-by: Kevin Wang <kevin.w...@arm.com> Signed-off-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> --- platform/linux-generic/Makefile.am

[lng-odp] [API-NEXT PATCH v9 2/6] linux-gen: sched scalable: add arch files

2017-06-19 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> --- configure.ac | 1 + platform/linux-generic/Makefile.am

[lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

2017-06-19 Thread Brian Brooks
Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/include/odp_llqueue.h | 309 +++ 2 files changed, 310 insertions(+) create

[lng-odp] [API-NEXT PATCH v9 3/6] linux-gen: sched scalable: add a bitset

2017-06-19 Thread Brian Brooks
Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/include/

[lng-odp] [API-NEXT PATCH v9 6/6] travis: add scalable scheduler in CI

2017-06-19 Thread Brian Brooks
From: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> Added running tests with scalable scheduler to CI Signed-off-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> --- .travis.yml | 1 + 1 file changed, 1 insert

[lng-odp] [API-NEXT PATCH v9 0/6] A scalable software scheduler

2017-06-19 Thread Brian Brooks
tly to the list v2: - Move ARMv8 issues and other fixes into separate patches - Abstract away some #ifdefs - Fix some checkpatch.pl warnings Brian Brooks (5): test: odp_pktio_ordered: add queue size linux-gen: sched scalable: add arch files linux-gen: sched scalable: add a bitset linux-

[lng-odp] [API-NEXT PATCH v9 1/6] test: odp_pktio_ordered: add queue size

2017-06-19 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> --- test/common_plat/performance/odp_pktio_ordered.c | 4 1 file changed, 4 insertions(+) diff --git a/test/common_plat/performance/odp_pktio_ordered.c b/test/common_plat/performance/odp_pktio_ordered.c index 4bb0bef9..50bfef51

[lng-odp] [API-NEXT PATCH v8 5/5] linux-gen: sched scalable: add scalable scheduler

2017-06-18 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Signed-off-by: Kevin Wang <kevin.w...@arm.com> Signed-off-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> --- platform/linux-generic/Makefile.am

[lng-odp] [API-NEXT PATCH v8 2/5] linux-gen: sched scalable: add arch files

2017-06-18 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> --- platform/linux-generic/Makefile.am | 2 + platform/linux-generic/arch/arm/odp_

[lng-odp] [API-NEXT PATCH v8 4/5] linux-gen: sched scalable: add a concurrent queue

2017-06-18 Thread Brian Brooks
Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/include/odp_llqueue.h | 309 +++ 2 files changed, 310 insertions(+) create

[lng-odp] [API-NEXT PATCH v8 3/5] linux-gen: sched scalable: add a bitset

2017-06-18 Thread Brian Brooks
Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> --- platform/linux-generic/include/odp_bitset.h | 210 1 file changed, 210 insertio

[lng-odp] [API-NEXT PATCH v8 1/5] test: odp_pktio_ordered: add queue size

2017-06-18 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> --- test/common_plat/performance/odp_pktio_ordered.c | 4 1 file changed, 4 insertions(+) diff --git a/test/common_plat/performance/odp_pktio_ordered.c b/test/common_plat/performance/odp_pktio_ordered.c index 4bb0bef9..50bfef51

[lng-odp] [API-NEXT PATCH v8 0/5] A scalable software scheduler

2017-06-18 Thread Brian Brooks
way some #ifdefs - Fix some checkpatch.pl warnings Brian Brooks (5): test: odp_pktio_ordered: add queue size Add arch/ files Add a bitset Add a concurrent queue Add scalable scheduler platform/linux-generic/Makefile.am | 10 + platform/linux-generic/arch/arm/odp_atomi

Re: [lng-odp] [API-NEXT PATCH v7 0/5] A scalable software scheduler

2017-06-18 Thread Brian Brooks
On 06/16 22:42:04, Maxim Uvarov wrote: > On 06/14/17 04:21, Brian Brooks wrote: > > Brian Brooks (5): > > test: odp_pktio_ordered: add queue size > > Add arch/ files > > Add a bitset > > Add a concurrent queue > > Add scalable scheduler > >

[lng-odp] [API-NEXT PATCH v4] timer: allow timer processing to run on worker cores

2017-06-14 Thread Brian Brooks
/edit?usp=sharing Signed-off-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> --- ** There is a false positive checkpatch.pl warning ** v4: - Rebase against Bill's feat

[lng-odp] [API-NEXT PATCH v7 5/5] Add scalable scheduler

2017-06-13 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Signed-off-by: Kevin Wang <kevin.w...@arm.com> Signed-off-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> --- platform/linux-generic/Makefile.am

[lng-odp] [API-NEXT PATCH v7 2/5] Add arch/ files

2017-06-13 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> --- platform/linux-generic/Makefile.am | 2 + platform/linux-generic/arch/arm/odp_

[lng-odp] [API-NEXT PATCH v7 4/5] Add a concurrent queue

2017-06-13 Thread Brian Brooks
Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/include/odp_llqueue.h | 309 +++ 2 files changed, 310 insertions(+) create

[lng-odp] [API-NEXT PATCH v7 3/5] Add a bitset

2017-06-13 Thread Brian Brooks
Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> --- platform/linux-generic/include/odp_bitset.h | 210 1 file changed, 210 insertio

[lng-odp] [API-NEXT PATCH v7 0/5] A scalable software scheduler

2017-06-13 Thread Brian Brooks
ome checkpatch.pl warnings Brian Brooks (5): test: odp_pktio_ordered: add queue size Add arch/ files Add a bitset Add a concurrent queue Add scalable scheduler platform/linux-generic/Makefile.am | 10 + platform/linux-generic/arch/arm/odp_atomic.h | 210 +++ platf

[lng-odp] [API-NEXT PATCH v7 1/5] test: odp_pktio_ordered: add queue size

2017-06-13 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> --- test/common_plat/performance/odp_pktio_ordered.c | 4 1 file changed, 4 insertions(+) diff --git a/test/common_plat/performance/odp_pktio_ordered.c b/test/common_plat/performance/odp_pktio_ordered.c index 4bb0bef9..50bfef51

[lng-odp] [PATCH v5 1/2] build: GCC 7 fixes

2017-06-08 Thread Brian Brooks
The GCC 7 series introduces changes that expose ODP compilation issues. These include case statement fall through warnings, and stricter checks on potential string overflows and other semantic analysis. Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027 Signed-off-by: Brian Brooks <brian.

[lng-odp] [PATCH v5 0/2] GCC 7 fixes

2017-06-08 Thread Brian Brooks
Bug id to commit message (Bill) Brian Brooks (2): build: GCC 7 fixes pktio: GCC 7 fixes DEPENDENCIES | 5 +-- configure.ac | 13 pkgconfig/libodp-linux.pc.in | 2 +- platform/linux-generic/Makefile.am

[lng-odp] [PATCH v5 2/2] pktio: GCC 7 fixes

2017-06-08 Thread Brian Brooks
The GCC 7 series introduces changes that expose ODP compilation issues. These include case statement fall through warnings, and stricter checks on potential string overflows and other semantic analysis. Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027 Signed-off-by: Brian Brooks <brian.

[lng-odp] [API-NEXT v3 2/2] timer: allow timer processing to run on worker cores

2017-06-08 Thread Brian Brooks
/edit?usp=sharing Signed-off-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> --- v3: - Add rate limiting by scheduling rounds v2: - Reword 'worker_timers' to 'use_schedule

[lng-odp] [API-NEXT v3 1/2] timer: organize #include

2017-06-08 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Kevin Wang <kevin.w...@arm.com> --- platform/linux-generic/odp_timer.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --gi

Re: [lng-odp] [API-NEXT v2 2/2] timer: allow timer processing to run on worker cores

2017-06-08 Thread Brian Brooks
istics or level of determinism of traffic or link utilization of boxes in the field? > -Petri > > > > -Original Message- > > From: Bogdan Pricope [mailto:bogdan.pric...@linaro.org] > > Sent: Thursday, June 08, 2017 9:22 AM > > To: Brian Brooks <brian.bro...@ar

Re: [lng-odp] [API-NEXT v2 2/2] timer: allow timer processing to run on worker cores

2017-06-08 Thread Brian Brooks
ld config (no #ifdefs !!) and the compiler will optimize out the code if _timer_run() should be called every scheduler internal loop. So, best of both worlds without any penalty if not using rate limiting by scheduler internal loops. > On 7 June 2017 at 20:02, Brian Brooks <brian.bro...@arm.com> wrote:

Re: [lng-odp] [PATCH v4 1/2] build: GCC 7 fixes

2017-06-08 Thread Brian Brooks
On 06/08 16:00:21, Dmitry Eremin-Solenikov wrote: > On 08.06.2017 06:40, Brian Brooks wrote: > > The GCC 7 series introduces changes that expose ODP compilation > > issues. These include case statement fall through warnings, and > > stricter checks on potential string overflo

[lng-odp] [PATCH] arch: arm: add CPU global time

2017-06-07 Thread Brian Brooks
Expose ARMv8 Generic Timer through internal CPU global time functions. Signed-off-by: Brian Brooks <brian.bro...@arm.com> --- v2: - Add text to explain the usage of the ARM architected timer (Petri) platform/linux-generic/arch/arm/odp_cpu_arch.c | 38 +-

[lng-odp] [PATCH v4 0/2] GCC 7 fixes

2017-06-07 Thread Brian Brooks
The GCC 7 series introduces changes that expose ODP compilation issues. These include case statement fall through warnings, and stricter checks on potential string overflows and other semantic analysis. Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027 Brian Brooks (2): build: GCC 7 fixes

[lng-odp] [PATCH v4 1/2] build: GCC 7 fixes

2017-06-07 Thread Brian Brooks
The GCC 7 series introduces changes that expose ODP compilation issues. These include case statement fall through warnings, and stricter checks on potential string overflows and other semantic analysis. Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027 Signed-off-by: Brian Brooks <brian.

[lng-odp] [PATCH v4 2/2] pktio: GCC 7 fixes

2017-06-07 Thread Brian Brooks
The GCC 7 series introduces changes that expose ODP compilation issues. These include case statement fall through warnings, and stricter checks on potential string overflows and other semantic analysis. Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027 Signed-off-by: Brian Brooks <brian.

Re: [lng-odp] [API-NEXT v2 0/2] inline timers

2017-06-07 Thread Brian Brooks
46 to add > the odp_feature_t type and its usage in odp_init_global. > > On Tue, Jun 6, 2017 at 2:09 PM, Brian Brooks <brian.bro...@arm.com> wrote: >> Run timer pool processing on worker cores if the application hints >> that the scheduler will be used. This reduces th

Re: [lng-odp] [PATCHv2] linux-gen: improve conversion between buf_hdr_t and packet_t

2017-06-07 Thread Brian Brooks
On 06/07 15:19:08, Joyce Kong wrote: > Signed-off-by: Joyce Kong <joyce.k...@arm.com> Reviewed-by: Brian Brooks <brian.bro...@arm.com> > --- > platform/linux-generic/include/odp_packet_internal.h | 10 ++ > platform/linux-generic/odp_packet_io.c |

Re: [lng-odp] [PATCH v3 0/2] GCC 7 fixes

2017-06-07 Thread Brian Brooks
ecify CC=gcc-7 on ./configure. Correcting that allows everything to > > compile cleanly. > > > > For this series: > > > > Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> > > > > On Mon, Jun 5, 2017 at 10:36 PM, Brian Brooks <brian.bro...@arm

Re: [lng-odp] [API-NEXT v2 2/2] timer: allow timer processing to run on worker cores

2017-06-07 Thread Brian Brooks
On 06/07 17:39:16, Bogdan Pricope wrote: > In OFP we have this use case: N-1 cores are doing packet processing in > direct pktin mode; core 0 is doing odp_schedule() to process timers > (ARP entries expiration) and maybe other events. > > To take from this: > - If scheduler + timers are

[lng-odp] [API-NEXT v2 2/2] timer: allow timer processing to run on worker cores

2017-06-06 Thread Brian Brooks
/edit?usp=sharing Signed-off-by: Brian Brooks <brian.bro...@arm.com> --- include/odp/api/spec/init.h| 5 ++ platform/linux-generic/include/odp_internal.h | 1 + .../linux-generic/include/odp_timer_internal.h | 5 ++ platform/linux-generic/odp_

[lng-odp] [API-NEXT v2 0/2] inline timers

2017-06-06 Thread Brian Brooks
/edit?usp=sharing Signed-off-by: Brian Brooks <brian.bro...@arm.com> v2: - Reword 'worker_timers' to 'use_scheduler' - Use ODP Time instead of ticks Brian Brooks (2): timer: organize #include timer: allow timer processing to run on worker cores include/odp/api/spec/

[lng-odp] [API-NEXT v2 1/2] timer: organize #include

2017-06-06 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Kevin Wang <kevin.w...@arm.com> --- platform/linux-generic/odp_timer.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --gi

[lng-odp] [API-NEXT] arch: arm: add CPU global time

2017-06-06 Thread Brian Brooks
Expose ARMv8 Generic Timer through internal CPU global time functions. Signed-off-by: Brian Brooks <brian.bro...@arm.com> --- platform/linux-generic/arch/arm/odp_cpu_arch.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/platform/linux-generi

Re: [lng-odp] [PATCH v3 0/2] GCC 7 fixes

2017-06-05 Thread Brian Brooks
On 06/05 22:29:22, Bill Fischofer wrote: > On Mon, Jun 5, 2017 at 9:32 PM, Brian Brooks <brian.bro...@arm.com> wrote: > > On 06/05 18:40:02, Bill Fischofer wrote: > >> After installing a copy of GCC 7, It looks like this patch is an > >> incomplete fix. With t

Re: [lng-odp] [PATCH v3 0/2] GCC 7 fixes

2017-06-05 Thread Brian Brooks
On 06/05 18:40:02, Bill Fischofer wrote: > After installing a copy of GCC 7, It looks like this patch is an > incomplete fix. With this patch applied older GCC 6.3.0 continues to > work fine, but GCC 7.0.1 generates the following errors: > > Making all in platform/linux-generic > make[1]:

[lng-odp] [PATCH v3 1/2] build: GCC 7 fixes

2017-06-05 Thread Brian Brooks
The GCC 7 series introduces changes that expose ODP compilation issues. These include case statement fall through warnings, and stricter checks on potential string overflows and other semantic analysis. Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027 Signed-off-by: Brian Brooks <brian.

[lng-odp] [PATCH v3 0/2] GCC 7 fixes

2017-06-05 Thread Brian Brooks
The GCC 7 series introduces changes that expose ODP compilation issues. These include case statement fall through warnings, and stricter checks on potential string overflows and other semantic analysis. Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027 Brian Brooks (2): build: GCC 7 fixes

[lng-odp] [PATCH v3 2/2] pktio: GCC 7 fixes

2017-06-05 Thread Brian Brooks
The GCC 7 series introduces changes that expose ODP compilation issues. These include case statement fall through warnings, and stricter checks on potential string overflows and other semantic analysis. Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027 Signed-off-by: Brian Brooks <brian.

Re: [lng-odp] [PATCH] Fixes for GCC 7

2017-06-05 Thread Brian Brooks
On 06/02 20:34:21, Dmitry Eremin-Solenikov wrote: > Or just > > AC_LINK_IFELSE([AC_LANG_CALL([], [your_atomic_func])], [ATOMIC_LIBS=""], >[AC_CHECK_LIB([atomic], [your_atomic_func], [ATOMIC_LIBS="-latomic"], > [AC_MSG_FAILURE([your_atomic_func is not available])])]) >

Re: [lng-odp] [PATCH] Fixes for GCC 7

2017-06-05 Thread Brian Brooks
On 06/02 20:09:54, Dmitry Eremin-Solenikov wrote: > On 02.06.2017 18:34, Brian Brooks wrote: > > On 06/02 10:39:18, Dmitry Eremin-Solenikov wrote: > >> On 01.06.2017 22:05, Brian Brooks wrote: > >>> Signed-off-by: Brian Brooks <brian.bro...@arm.com> > >

Re: [lng-odp] [PATCH] Fixes for GCC 7

2017-06-05 Thread Brian Brooks
On 06/02 23:27:08, Maxim Uvarov wrote: > On 06/02/17 18:36, Brian Brooks wrote: > > On 06/02 15:07:48, Maxim Uvarov wrote: > >> I think this patch has to be spit on several patches. Having patch which > >> correct unrelated things is strange and make i

[lng-odp] [PATCH v2] Fixes for GCC 7

2017-06-02 Thread Brian Brooks
The GCC 7 series introduces changes that expose ODP compilation issues. These include case statement fall through warnings, and stricter checks on potential string overflows and other semantic analysis. Fixes: https://bugs.linaro.org/show_bug.cgi?id=3027 Signed-off-by: Brian Brooks <brian.

Re: [lng-odp] [PATCH] Fixes for GCC 7

2017-06-02 Thread Brian Brooks
On 06/01 22:30:16, Bill Fischofer wrote: > On Thu, Jun 1, 2017 at 9:48 PM, Brian Brooks <brian.bro...@arm.com> wrote: > > On 06/01 15:00:28, Bill Fischofer wrote: > >> If this is a bug fix it should reference a Bug that describes in more > >> detail what is being

Re: [lng-odp] [PATCH] Fixes for GCC 7

2017-06-02 Thread Brian Brooks
On 06/02 15:07:48, Maxim Uvarov wrote: > I think this patch has to be spit on several patches. Having patch which > correct unrelated things is strange and make it hard to merge/cherry-pick. They are all related to things that break the build with GCC 7. It's unnecessary and extra complexity to

Re: [lng-odp] [PATCH] Fixes for GCC 7

2017-06-02 Thread Brian Brooks
On 06/02 10:39:18, Dmitry Eremin-Solenikov wrote: > On 01.06.2017 22:05, Brian Brooks wrote: > > Signed-off-by: Brian Brooks <brian.bro...@arm.com> > > Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha..

[lng-odp] [PATCH] Fixes for GCC 7

2017-06-01 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> --- configure.ac | 5 + platform/linux-generic/m4/configure.m4

[lng-odp] [API-NEXT PATCH 6/6] timer: allow timer processing to run on worker cores

2017-05-28 Thread Brian Brooks
/1sY7rOxqCNu-bMqjBiT5_keAIohrX1ZW-eL0oGLAQ4OM/edit?usp=sharing Signed-off-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> --- include/odp/api/spec/init.h| 8 ++ .../linux-generic/include/odp_timer_internal.h | 7 ++ pl

[lng-odp] [API-NEXT PATCH 4/6] timer: organize #include

2017-05-28 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Kevin Wang <kevin.w...@arm.com> --- platform/linux-generic/odp_timer.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --gi

[lng-odp] [API-NEXT PATCH 5/6] api: timer: add odp_timer_pool_res()

2017-05-28 Thread Brian Brooks
Signed-off-by: Brian Brooks <brian.bro...@arm.com> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> Reviewed-by: Kevin Wang <kevin.w...@arm.com> --- include/odp/api/spec/timer.h | 9 + platform/linux-generic/odp_timer.c| 5 + test/comm

  1   2   3   4   >