[lng-odp] My last day at linaro/LNG

2017-03-31 Thread Christophe Milard
Hi all, As most of you know, my assignment for linaro/LNG is ending today. I was really willing to join connect in Budapest as this would have given me an opportunity to see you a last time face to face but this did not happen, sadly. I wish to thank all of you that helped me growing in this open

[lng-odp] [API-NEXT PATCHv2 23/23] test: drv: test for setting and retrieving driver's data

2017-03-22 Thread Christophe Milard
trivial tests for function odpdrv_device_set_data() and odpdrv_device_get_data(). Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- test/common_plat/validation/drv/drvdriver/drvdriver_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/common_plat/vali

[lng-odp] [API-NEXT PATCHv2 21/23] drv: driver: adding functions to attach driver's data to the device

2017-03-22 Thread Christophe Milard
Driver will need to attach their data to devices when bound. The patch introduce a data setter and a data getter function to do so. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/drv/spec/driver.h | 21 + 1 file changed, 21 insertions(+)

[lng-odp] [API-NEXT PATCHv2 22/23] linux-gen: adding functions to attach driver's data to the device

2017-03-22 Thread Christophe Milard
Implementation of the functions to set/retrieve driver's data to/from a bound device. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/drv_driver.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/platform/linux-g

[lng-odp] [API-NEXT PATCHv2 14/23] drv: driver: adding a probe and remove callback for devio

2017-03-22 Thread Christophe Milard
Needed to delete the resources needed for the devio. That is possibly the memory allocated for its "ops" part if it was allocated. May be NULL if nothing needs to be done at devio deletion time. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/d

[lng-odp] [API-NEXT PATCHv2 13/23] test: drv: device creation and destruction

2017-03-22 Thread Christophe Milard
Testing that devices can be created and removed from ODP. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- .../validation/drv/drvdriver/.gitignore| 1 + .../validation/drv/drvdriver/Makefile.am | 11 ++ .../validation/drv/drvdriver/drvdriver_de

[lng-odp] [API-NEXT PATCHv2 20/23] test: drv: driver registration and probing

2017-03-22 Thread Christophe Milard
Register driver, devios, enumerators, create devices, and check that probing occurs correctely. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- .../validation/drv/drvdriver/.gitignore| 1 + .../validation/drv/drvdriver/Makefile.am

[lng-odp] [API-NEXT PATCHv2 19/23] linux-gen: driver registration and probing

2017-03-22 Thread Christophe Milard
Driver registration and probing is implemented for linux-gen ODP. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/drv_driver.c | 349 ++-- 1 file changed, 336 insertions(+), 13 deletions(-) diff --git a/platform

[lng-odp] [API-NEXT PATCHv2 18/23] drv: complement parameters to the driver probe() function

2017-03-22 Thread Christophe Milard
to know. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/drv/spec/driver.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/include/odp/drv/spec/driver.h b/include/odp/drv/spec/driver.h index 394aa92..ad2b8db 100644 --- a/include/o

[lng-odp] [API-NEXT PATCHv2 17/23] drv: adding driver remove function

2017-03-22 Thread Christophe Milard
The remove function, as for other driver items (such as enumerators...) is called before the driver is to be removed, i.e. after all devices have been been unbound from the driver. remove() should release any resource held by the driver. Signed-off-by: Christophe Milard <christophe.

[lng-odp] [API-NEXT PATCHv2 16/23] test: drv: devio creation and destruction

2017-03-22 Thread Christophe Milard
Testing that devios can be registered and removed in/from ODP. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- .../validation/drv/drvdriver/.gitignore| 1 + .../validation/drv/drvdriver/Makefile.am | 11 ++ .../validation/drv/drv

[lng-odp] [API-NEXT PATCHv2 15/23] linux-gen: drv: devio registration

2017-03-22 Thread Christophe Milard
of a given type (i.e. registred enumerator(s) enumerating devices of the same kind (e.g. PCI)). This patch just implements the devio registration method provided by the driver API. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/drv_driver.c

[lng-odp] [API-NEXT PATCHv2 12/23] linux-gen: drv: driver: adding device querry function

2017-03-22 Thread Christophe Milard
Implementation of the device query function for the linux-gen ODP. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/drv_driver.c | 37 + 1 file changed, 37 insertions(+) diff --git a/platform/linux-g

[lng-odp] [API-NEXT PATCHv2 10/23] linux-gen: drv: device creation and deletion

2017-03-22 Thread Christophe Milard
Functions to create and remove devices are populated to do more proper things. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/drv_driver.c | 181 ++-- 1 file changed, 173 insertions(+), 8 deletions(-) diff

[lng-odp] [API-NEXT PATCHv2 11/23] drv: driver: adding device query function

2017-03-22 Thread Christophe Milard
Adding a function for querying a list of devices: this function may be used by enumerators to query for the list of their registered devices or for a subset of them. Note that this function returns a malloc'd list of devices which is to be freed by the caller. Signed-off-by: Christophe Milard

[lng-odp] [API-NEXT PATCHv2 08/23] drv: driver: change drv unbind function name and pass correct parameter

2017-03-22 Thread Christophe Milard
The driver removal function expects a device, of course... Also unbind seems a better name to disconnect from a device since remove has been used for removing the object itself for enumerators. Some extra parameters to allow for graceful unbinding are also added. Signed-off-by: Christophe Milard

[lng-odp] [API-NEXT PATCHv2 09/23] drv: driver: add callback function for device destruction

2017-03-22 Thread Christophe Milard
-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/drv/spec/driver.h | 31 +++ platform/linux-generic/drv_driver.c | 9 - 2 files changed, 35 insertions(+), 5 deletions(-) diff --git a/include/odp/drv/spec/driver.h b/include/odp/drv/spec/dr

[lng-odp] [API-NEXT PATCHv2 07/23] test: drv: enumerator registration tests

2017-03-22 Thread Christophe Milard
making sure that enumerators are probed. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- .../validation/drv/drvdriver/.gitignore| 1 + .../validation/drv/drvdriver/Makefile.am | 11 + .../validation/drv/drvdriver/drvdriver_enumr.c

[lng-odp] [API-NEXT PATCHv2 06/23] linux-gen: drv: enumerator registration

2017-03-22 Thread Christophe Milard
The enumerator registration functions for the linux-gen ODP implementation. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/drv_driver.c | 139 +++- 1 file changed, 136 insertions(+), 3 deletions(-) diff --git a/pl

[lng-odp] [API-NEXT PATCHv2 05/23] test: drv: enumerator_class registration tests

2017-03-22 Thread Christophe Milard
Testing that enumerators classes can register properly. Saddly restricted to statically linked enumerators classes, as testing with modules in autotools seems to be an issue so far. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- test/common_plat/m4/config

[lng-odp] [API-NEXT PATCHv2 04/23] linux-gen: drv: enumerator_class registration

2017-03-22 Thread Christophe Milard
The functions to register and probe enumerator classes are added. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/_modules.c | 4 + platform/linux-generic/drv_dr

[lng-odp] [API-NEXT PATCHv2 03/23] drv: making parameter strings dynamically computable

2017-03-22 Thread Christophe Milard
. This change is made to allow this. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/drv/spec/driver.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/odp/drv/spec/driver.h b/include/odp/drv/spec/driver.h index d83e907..b

[lng-odp] [API-NEXT PATCHv2 02/23] linux-gen: adding compiler hints in the driver interface

2017-03-22 Thread Christophe Milard
Just including the spec file from the linux-generic side, as usual. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp_drv.h | 1 + platform/linux-generic/include/odp/drv/hints.h | 34 ++ 2 files chang

[lng-odp] [API-NEXT PATCHv2 00/23] driver items registration and probing

2017-03-22 Thread Christophe Milard
. Christophe Milard (23): drv: adding compiler hints in the driver interface linux-gen: adding compiler hints in the driver interface drv: making parameter strings dynamically computable linux-gen: drv: enumerator_class registration test: drv: enumerator_class registration tests linux-gen: drv

[lng-odp] [API-NEXT PATCHv2 01/23] drv: adding compiler hints in the driver interface

2017-03-22 Thread Christophe Milard
Largely inspired from its north api counterpart, the drv/spec/hint.h file is added. Also includes the __constructor__ attributes that many driver interface items will need. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/drv/spec/hints.h

Re: [lng-odp] [API-NEXT PATCH 16/21] drv: complement parameters to the driver probe() function

2017-02-27 Thread Christophe Milard
On 23 February 2017 at 00:00, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> >> Of course, when probing a driver, the latter should be given the devi

Re: [lng-odp] [API-NEXT PATCH 15/21] drv: adding driver remove function

2017-02-27 Thread Christophe Milard
On 22 February 2017 at 23:56, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> >> The remove function, as for other driver items (such as enumeratos..

Re: [lng-odp] [API-NEXT PATCH 13/21] linux-gen: drv: devio registration

2017-02-27 Thread Christophe Milard
On 22 February 2017 at 23:54, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> >> devios (dev IO) provide a interface for drivers to access a device: >

Re: [lng-odp] [API-NEXT PATCH 11/21] test: drv: device creation and destruction

2017-02-27 Thread Christophe Milard
On 22 February 2017 at 23:40, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> >> Testing that devices can be created and removed from ODP. >> >>

Re: [lng-odp] [API-NEXT PATCH 10/21] linux-gen: drv: driver: adding device querry function

2017-02-27 Thread Christophe Milard
:55 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> >> Implementation of the device query function for the linux-gen ODP. >> >> Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> >> --- >> platform/linux-generic/drv_driv

Re: [lng-odp] [API-NEXT PATCH 08/21] linux-gen: drv: device creation and deletion

2017-02-27 Thread Christophe Milard
On 22 February 2017 at 23:28, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> >> Functions to create and remove devices are populated to do >> more prop

Re: [lng-odp] [API-NEXT PATCH 07/21] drv: driver: add callback function for device destruction

2017-02-27 Thread Christophe Milard
On 22 February 2017 at 23:20, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> >> When a device is destroyed by an enumerator, odpdrv_device_destroy() is >&g

Re: [lng-odp] [API-NEXT PATCH 06/21] drv: driver: change drv unbind function name and pass correct parameter

2017-02-27 Thread Christophe Milard
On 22 February 2017 at 23:14, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> >> The driver removal function expects a device, of course... >> Also unb

Re: [lng-odp] [API-NEXT PATCH 05/21] test: drv: enumerator registration tests

2017-02-27 Thread Christophe Milard
will fix all these in V2, Christophe. On 22 February 2017 at 22:52, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> >> making sure that enumerators are pro

Re: [lng-odp] [API-NEXT PATCH 04/21] linux-gen: drv: enumerator registration

2017-02-27 Thread Christophe Milard
On 22 February 2017 at 22:46, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> >> The enumerator registration functions for the linux-gen ODP >> imple

Re: [lng-odp] [API-NEXT PATCH 03/21] test: drv: enumerator_class registration tests

2017-02-27 Thread Christophe Milard
On 22 February 2017 at 22:13, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> >> Testing that enumerators classes can register properly. >> Saddly r

Re: [lng-odp] [API-NEXT PATCH 00/21] driver items registration and probing

2017-02-27 Thread Christophe Milard
2017 at 4:16 AM, Yi He <yi...@linaro.org> wrote: >> > >> > >> > >> > > In patchwork for this series I saw 14, 16, 21 are missing, do you >> > see >> > >> > > the >> > >> > > same problem? >> > >&

[lng-odp] [API-NEXT PATCH 21/21] test: drv: test for setting and retrieving driver's data

2017-02-22 Thread Christophe Milard
trivial tests for function odpdrv_device_set_data() and odpdrv_device_get_data(). Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- test/common_plat/validation/drv/drvdriver/drvdriver_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/common_plat/vali

[lng-odp] [API-NEXT PATCH 19/21] drv: driver: adding functions to attach driver's data to the device

2017-02-22 Thread Christophe Milard
Driver will need to attach their data to devices when bound. The patch introduce a data setter and a data getter function to do so. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/drv/spec/driver.h | 21 + 1 file changed, 21 insertions(+)

[lng-odp] [API-NEXT PATCH 18/21] test: drv: driver registration and probing

2017-02-22 Thread Christophe Milard
Register driver, devios, enumerators, create devices, and check that probing occurs correctely. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- .../validation/drv/drvdriver/.gitignore| 1 + .../validation/drv/drvdriver/Makefile.am

[lng-odp] [API-NEXT PATCH 17/21] linux-gen: driver registration and probing

2017-02-22 Thread Christophe Milard
Driver registration and probing is implemented for linux-gen ODP. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/drv_driver.c | 348 ++-- 1 file changed, 335 insertions(+), 13 deletions(-) diff --git a/platform

[lng-odp] [API-NEXT PATCH 13/21] linux-gen: drv: devio registration

2017-02-22 Thread Christophe Milard
of a given type (i.e. registred enumerator(s) enumerating devices of the same kind (e.g. PCI)). This patch just implements the devio registration method provided by the driver API. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/drv_driver.c

[lng-odp] [API-NEXT PATCH 15/21] drv: adding driver remove function

2017-02-22 Thread Christophe Milard
The remove function, as for other driver items (such as enumeratos...) is called before the driver is to be removed, i.e. after all devices have been been unboud from the driver. remove() should release any resource held by the driver. Signed-off-by: Christophe Milard <christophe.

[lng-odp] [API-NEXT PATCH 12/21] drv: driver: adding a probe and remove callback for devio

2017-02-22 Thread Christophe Milard
Needed to delete the resources needed for the devio. That is possibly the memory allocated for its "ops" part if it was allocated. May be NULL if nothing needs to be done at devio deletion time. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/d

[lng-odp] [API-NEXT PATCH 11/21] test: drv: device creation and destruction

2017-02-22 Thread Christophe Milard
Testing that devices can be created and removed from ODP. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- .../validation/drv/drvdriver/.gitignore| 1 + .../validation/drv/drvdriver/Makefile.am | 11 ++ .../validation/drv/drvdriver/drvdriver_de

[lng-odp] [API-NEXT PATCH 10/21] linux-gen: drv: driver: adding device querry function

2017-02-22 Thread Christophe Milard
Implementation of the device query function for the linux-gen ODP. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/drv_driver.c | 37 + 1 file changed, 37 insertions(+) diff --git a/platform/linux-g

[lng-odp] [API-NEXT PATCH 08/21] linux-gen: drv: device creation and deletion

2017-02-22 Thread Christophe Milard
Functions to create and remove devices are populated to do more proper things. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/drv_driver.c | 172 ++-- 1 file changed, 164 insertions(+), 8 deletions(-) diff

[lng-odp] [API-NEXT PATCH 09/21] drv: driver: adding device query function

2017-02-22 Thread Christophe Milard
Adding a function for querying a list of devices: this function may be used by enumerators to query for the list of their registered devices or for a subset of them. Note that this function returns a malloc'd list of devices which is to be freed by the caller. Signed-off-by: Christophe Milard

[lng-odp] [API-NEXT PATCH 05/21] test: drv: enumerator registration tests

2017-02-22 Thread Christophe Milard
making sure that enumerators are probed. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- .../validation/drv/drvdriver/.gitignore| 1 + .../validation/drv/drvdriver/Makefile.am | 11 + .../validation/drv/drvdriver/drvdriver_enumr.c

[lng-odp] [API-NEXT PATCH 07/21] drv: driver: add callback function for device destruction

2017-02-22 Thread Christophe Milard
-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/drv/spec/driver.h | 31 +++ platform/linux-generic/drv_driver.c | 9 - 2 files changed, 35 insertions(+), 5 deletions(-) diff --git a/include/odp/drv/spec/driver.h b/include/odp/drv/spec/dr

[lng-odp] [API-NEXT PATCH 06/21] drv: driver: change drv unbind function name and pass correct parameter

2017-02-22 Thread Christophe Milard
The driver removal function expects a device, of course... Also unbind seems a better name to disconnect from a device since remove has been used for removing the object itself for enumerators. Some extra parameters to allow for graceful unbinding are also added. Signed-off-by: Christophe Milard

[lng-odp] [API-NEXT PATCH 04/21] linux-gen: drv: enumerator registration

2017-02-22 Thread Christophe Milard
The enumerator registration functions for the linux-gen ODP implementation. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/drv_driver.c | 135 +++- 1 file changed, 132 insertions(+), 3 deletions(-) diff --git a/pl

[lng-odp] [API-NEXT PATCH 03/21] test: drv: enumerator_class registration tests

2017-02-22 Thread Christophe Milard
Testing that enumerators classes can register properly. Saddly restricted to statically linked enumerators classes, as testing with modules in autotools seems to be an issue so far. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- test/common_plat/m4/config

[lng-odp] [API-NEXT PATCH 02/21] linux-gen: drv: enumerator_class registration

2017-02-22 Thread Christophe Milard
The functions to register and probe enumerator classes are added. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/_modules.c | 4 + platform/linux-generic/drv_dr

[lng-odp] [API-NEXT PATCH 01/21] drv: making parameter strings dynamically computable

2017-02-22 Thread Christophe Milard
. This change is made to allow this. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/drv/spec/driver.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/odp/drv/spec/driver.h b/include/odp/drv/spec/driver.h index d83e907..b

[lng-odp] [API-NEXT PATCH 00/21] driver items registration and probing

2017-02-22 Thread Christophe Milard
elements (pci enumerators, drivers...) will likely be written in a much more stand-alone way. Christophe Milard (21): drv: making parameter strings dynamically computable linux-gen: drv: enumerator_class registration test: drv: enumerator_class registration tests linux-gen: drv: enumerator

Re: [lng-odp] [PATCHv2] configure: libatomic check

2017-02-20 Thread Christophe Milard
n x86. For some version of gcc both -latomic and -mcx16 > needs to be provided in that case. For clang only -mcx16. That > options are set internally for platform but do not set for examples. > This patch unhides setting this options, make them common and printed > on configure log. Rev

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-15 Thread Christophe Milard
On 15 February 2017 at 09:34, Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> wrote: > > >> -Original Message- >> From: Christophe Milard [mailto:christophe.mil...@linaro.org] >> Sent: Monday, February 13, 2017 5:41 PM >> To:

Re: [lng-odp] Ask a few questions about odp

2017-02-15 Thread Christophe Milard
is true, ODP is more general as it targets both embedded systems and the VM world. But my knowledge of the open event machine is too weak to comment more :-) Maybe some other on the list have comments, there. Regards, Christophe. > > thank you! > > > > > > > At 2017-0

Re: [lng-odp] Why do not odp use a multi-process model?

2017-02-14 Thread Christophe Milard
Hi, I am not sure about who you are, what you are trying to do, and how you are trying to do it. I am not even sure I understand fully your concerns. ODP itself does not specify what concurrency model is used. Some ODP implementations may use pthreads, some others processes, or whatever they

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-13 Thread Christophe Milard
This is getting very confusing now: why helper/? do we have odp/?: shouldn't these be symetric? My view is getting clearer and clearer: On the test side, was have made tests for {OS, HW}= {linux/PC} and given the possibility to diverge from these (for any reason, e.g. difference of HW or OS)

[lng-odp] what is a platform?

2017-02-11 Thread Christophe Milard
Hi, I am afraid I got very confused after Petri's last helper patch series, and I think we do need to agree on definition of things. If we cannot agree via this thread, I think the topic should be raised at BUD17. 1) Platform = ODP implementation, i.e. a couple {OS, HW}? This definition would

[lng-odp] driver probe time...

2017-02-10 Thread Christophe Milard
Hi, I am facing a issue: When should driver elements (enumerators-classes, enumerators, drivers) be probed at startup: My initial idea was to perform probing at init global time, so that a starting app would have a chance to see the present interfaces at startup: This turns out to be a problem as

Re: [lng-odp] [API-NEXT PATCH 15/15] linux-gen: support older libconfig version

2017-02-09 Thread Christophe Milard
..@linaro.org> Reviewed-by: Christophe Milard <christophe.mil...@linaro.org> > --- > platform/linux-generic/odp_init.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/platform/linux-generic/odp_init.c > b/platform/linux-generic/odp_init.c >

Re: [lng-odp] [API-NEXT PATCH 15/15] linux-gen: support older libconfig version

2017-02-09 Thread Christophe Milard
Could apply it on current API next, today. I am fine with this patch (15/15) On 1 February 2017 at 18:46, Christophe Milard <christophe.mil...@linaro.org> wrote: > needs rebase, I think: > erachmi@erachmi-ericsson:~/linaro/ODP/odp$ git am > ~/incoming/lng-odp_API-NEXT_PATCH_* &g

[lng-odp] drv API issue

2017-02-06 Thread Christophe Milard
Hi, I am trying to implement to API we agreed on, and I am facing a small issue which is preceeding larger problems, I am afraid: The small issue is: We defined: odpdrv_enumr_t odpdrv_enumr_register(odpdrv_enumr_param_t *param); to register a enumerator and : odpdrv_device_t

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-03 Thread Christophe Milard
On 3 February 2017 at 14:11, Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> wrote: > > >> -Original Message- >> From: Christophe Milard [mailto:christophe.mil...@linaro.org] >> Sent: Friday, February 03, 2017 2:29 PM >>

Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to linux helpers

2017-02-03 Thread Christophe Milard
On 3 February 2017 at 12:23, Petri Savolainen wrote: > There's no platform specific helpers. Helpers may depend on > Linux and make it easier to do common series of Linux system > calls. These kind of helpers are grouped into helper/linux > directory. This is getting

Re: [lng-odp] [PATCH 1/2] linux-gen: dpdk: improve pmd driver linking

2017-02-01 Thread Christophe Milard
hmmm... that sound promising. thanks for the update. may I ask which libtool version you tried with (latest)? Thanks anyway! Christophe. On 2 February 2017 at 08:22, Elo, Matias (Nokia - FI/Espoo) <matias@nokia-bell-labs.com> wrote: > >> On 1 Feb 2017, at 16:01, Ch

Re: [lng-odp] [API-NEXT PATCH 15/15] linux-gen: support older libconfig version

2017-02-01 Thread Christophe Milard
needs rebase, I think: erachmi@erachmi-ericsson:~/linaro/ODP/odp$ git am ~/incoming/lng-odp_API-NEXT_PATCH_* Applying: merge fix: platform/linux-generic/Makefile.am error: patch failed: platform/linux-generic/Makefile.am:20 error: platform/linux-generic/Makefile.am: patch does not apply Patch

Re: [lng-odp] [PATCH 1/2] linux-gen: dpdk: improve pmd driver linking

2017-02-01 Thread Christophe Milard
No, saddly. I got stuck on this. I summed up the situation here: https://lists.linaro.org/pipermail/lng-odp/2016-October/026120.html ... But if you get it to go, it is a good new: Just make sure that works on the latest libtool/autotools: Going forward is OK. If it does not work on latest, then,

Re: [lng-odp] [PATCH 1/2] linux-gen: dpdk: improve pmd driver linking

2017-02-01 Thread Christophe Milard
On 1 February 2017 at 13:47, Matias Elo wrote: > Previously each dpdk pmd driver had to be individually referred in the odp > code to ensure proper gcc constructor linking. Using the -—whole-archive > option when linking the drivers removes this need. After this patch new >

Re: [lng-odp] [PATCH 0/4] introduce odph_api.h and clean up public helper API

2017-01-25 Thread Christophe Milard
For the series: Reviewed-by: Christophe Milard <christophe.mil...@linaro.org> On 23 January 2017 at 20:46, Mike Holmes <mike.hol...@linaro.org> wrote: > Greatly reduce the proliferation of helper includes that every app needs > Make the public helper API very obvious >

Re: [lng-odp] [PATCH 2/4] helper: use odph_api.h for test include for unexported files

2017-01-25 Thread Christophe Milard
es. I understand. using <> will confuse CPP if we have filename matching the standart linux names. I remember having issues with errno.h in the past. I cannot remember how I fixed it :-). Anyway not really part of this patchset. > > On 25 January 2017 at 09:09, Christophe Milard > <

Re: [lng-odp] [PATCH 0/4] introduce odph_api.h and clean up public helper API

2017-01-25 Thread Christophe Milard
On 24 January 2017 at 16:51, Mike Holmes wrote: > On 24 January 2017 at 03:23, Savolainen, Petri (Nokia - FI/Espoo) > wrote: >> >> >>> -Original Message- >>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of

Re: [lng-odp] [PATCH 2/4] helper: use odph_api.h for test include for unexported files

2017-01-25 Thread Christophe Milard
On 23 January 2017 at 20:46, Mike Holmes wrote: > Adding the previously missing table functions to the public helper api > allows the tests to use just odph_api.h > > Signed-off-by: Mike Holmes > --- > helper/Makefile.am

[lng-odp] Christophe OOO 26-31 january

2017-01-24 Thread Christophe Milard
I'll miss you all :-) Christophe.

[lng-odp] [API-NEXT PATCHv11 4/5] test: preventing odp.conf loading for tests

2017-01-24 Thread Christophe Milard
(not using make check) may be affected by configuration files. Setting ODP_SYSCONFIG_FILE to an appropriate value (possibly "none") may be required. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- test/Makefile.inc | 4 +++- 1 file changed, 3 insertions(+), 1 dele

[lng-odp] [API-NEXT PATCHv11 5/5] linux-gen: modules: adding initial file to load modules

2017-01-24 Thread Christophe Milard
The shared objects listed in the ODP configuration files are loaded at init time. The odp configuration file lists the shared objects to be loaded as shown in the following example: module = { modules = ["enumerator1.so", "driver1.so"]; }; Signed-off-by: Christophe Mi

[lng-odp] [API-NEXT PATCHv11 3/5] linux-gen: init: adding configuration file parsing

2017-01-24 Thread Christophe Milard
prefix/etc directory. This requires libconfig (sudo apt-get install libconfig-dev) Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- .travis.yml | 2 +- DEPENDENCIES | 8 +-- platform/linux-gen

[lng-odp] [API-NEXT PATCHv11 2/5] linux-gen: adding enum, devio and driver registration interface (stub)

2017-01-24 Thread Christophe Milard
The linux implementation for the enumerator class registration function, enumerator instance registration function, devio and driver registration functions (stub) Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp_drv.h

[lng-odp] [API-NEXT PATCHv11 1/5] drv: adding driver registration interface (stub)

2017-01-24 Thread Christophe Milard
The enumerator class, enumerator instance, devio and driver registration functions prototypes (and a draft of their parameters) are defined, the goal being to define the registration framework only. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/drv/spec/dr

[lng-odp] [API-NEXT PATCHv11 0/5] driver initialisation framework

2017-01-24 Thread Christophe Milard
module init function (declared as __constructor__) calls the ODP odp_*_register() intialialisation function which, at this stage does nothing (just print an error message). odp_*_register() is of course part of the driver interface (south). Christophe Milard (5): drv: adding driver registration interf

Re: [lng-odp] [PATCHv2] linux-gen: _ishm: fix normal page fallback

2017-01-23 Thread Christophe Milard
17 at 17:28, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > On 01/23/17 11:47, Christophe Milard wrote: >> Fixing failure due to lack of huge pages. >> Fixes: https://bugs.linaro.org/show_bug.cgi?id=2842 >> >> Signed-off-by: Christophe Milard <christophe.mil...

[lng-odp] [PATCH] linux-gen: _ishmphy: fix possible race with malloc

2017-01-23 Thread Christophe Milard
guard when the proper maping is done. Fixes https://bugs.linaro.org/show_bug.cgi?id=2834 (but very hard to trigger i.e. to prove) Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/_ishmphy.c | 42 +-- 1 file change

[lng-odp] [PATCHv2] linux-gen: _ishm: fix normal page fallback

2017-01-22 Thread Christophe Milard
Fixing failure due to lack of huge pages. Fixes: https://bugs.linaro.org/show_bug.cgi?id=2842 Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/_ishm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/_

[lng-odp] [PATCHv2] linux-gen: _ishm: checking fstat return value.

2017-01-22 Thread Christophe Milard
Hence fixing CID 174663 (Fixes https://bugs.linaro.org/show_bug.cgi?id=2827) Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- since V1: -print strerror(errno) and sets __odp_errno (Maxim) -ref to bugzilla bug ID (Mike, Bill) platform/linux-generic/_ishm

Re: [lng-odp] [PATCH] linux-gen: _ishm: fix normal page fallback

2017-01-22 Thread Christophe Milard
; so one should be opened for this. > > On Fri, Jan 20, 2017 at 3:19 AM, Christophe Milard > <christophe.mil...@linaro.org> wrote: >> Fixing failure due to lack of huge pages. >> >> Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> > > Revie

[lng-odp] [PATCH] linux-gen: _ishm: fix normal page fallback

2017-01-20 Thread Christophe Milard
Fixing failure due to lack of huge pages. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/_ishm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/_ishm.c b/platform/linux-generic/_ishm.c index f

Re: [lng-odp] memory allocation issues

2017-01-19 Thread Christophe Milard
uary 2017 at 11:18, Steve Capper <steve.cap...@linaro.org> wrote: >> On 19 January 2017 at 13:04, Christophe Milard >> <christophe.mil...@linaro.org> wrote: >>> Hi Steve, >> >> Hey Christophe, >> >>> >>> Maybe you remember me as

Re: [lng-odp] [PATCH v3 0/4] remove Linux specifics and dependence on test dir

2017-01-19 Thread Christophe Milard
For the series: Reviewed-by: Christophe Milard <christophe.mil...@linaro.org> On 18 January 2017 at 23:01, Mike Holmes <mike.hol...@linaro.org> wrote: > Starting with some clean up, rename the Linux specific files and then move > them > to a platform specific directory. A

[lng-odp] [PATCHv2] travis: better comments to generate token in the travis file

2017-01-19 Thread Christophe Milard
Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- .travis.yml | 12 1 file changed, 12 insertions(+) diff --git a/.travis.yml b/.travis.yml index 03e61b1..cfa6c3d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,6 +11,18 @@ env:

[lng-odp] [API-NEXT PATCHv10 5/5] linux-gen: modules: adding initial file to load modules

2017-01-19 Thread Christophe Milard
The shared objects listed in the ODP configuration files are loaded at init time. The odp configuration file lists the shared objects to be loaded as shown in the following example: module = { modules = ["enumerator1.so", "driver1.so"]; }; Signed-off-by: Christophe Mi

[lng-odp] [API-NEXT PATCHv10 4/5] test: preventing odp.conf loading for tests

2017-01-19 Thread Christophe Milard
(not using make check) may be affected by configuration files. Setting ODP_SYSCONFIG_FILE to an appropriate value (possibly "none") may be required. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- test/Makefile.inc | 4 +++- 1 file changed, 3 insertions(+), 1 dele

[lng-odp] [API-NEXT PATCHv10 3/5] linux-gen: init: adding configuration file parsing

2017-01-19 Thread Christophe Milard
prefix/etc directory. This requires libconfig (sudo apt-get install libconfig-dev) Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- .travis.yml | 2 +- DEPENDENCIES | 8 +-- platform/linux-gen

[lng-odp] [API-NEXT PATCHv10 2/5] linux-gen: adding enum, devio and driver registration interface (stub)

2017-01-19 Thread Christophe Milard
The linux implementation for the enumerator class registration function, enumerator instance registration function, devio and driver registration functions (stub) Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp_drv.h

[lng-odp] [API-NEXT PATCHv10 1/5] drv: adding driver registration interface (stub)

2017-01-19 Thread Christophe Milard
The enumerator class, enumerator instance, devio and driver registration functions prototypes (and a draft of their parameters) are defined, the goal being to define the registration framework only. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- include/odp/drv/spec/dr

[lng-odp] [API-NEXT PATCHv10 0/5] driver initialisation framework

2017-01-19 Thread Christophe Milard
structor__) calls the ODP odp_*_register() intialialisation function which, at this stage does nothing (just print an error message). odp_*_register() is of course part of the driver interface (south). Christophe Milard (5): drv: adding driver registration interface (stub) linux-gen: adding enum,

Re: [lng-odp] [PATCH] travis: better comments to generate token in the travis file

2017-01-19 Thread Christophe Milard
Easier way exists. This patch should be dropped. On 18 January 2017 at 13:34, Christophe Milard <christophe.mil...@linaro.org> wrote: > On 18 January 2017 at 13:26, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >> On 01/18/17 16:14, Christophe Milard wrote: >>> Si

[lng-odp] [API-NEXT PATCH] linux-gen: _ishm: fix normal page fallback

2017-01-19 Thread Christophe Milard
Fixing failure due to lack of huge pages. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --- platform/linux-generic/_ishm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/_ishm.c b/platform/linux-generic/_ishm.c index 4

  1   2   3   4   5   6   7   8   9   10   >