Re: [lng-odp] [API-NEXT/PATCHv5] validation: classification: added additional suite to test individual PMRs

2015-10-15 Thread Ivan Khoronzhuk
tsuites.h +++ b/test/validation/classification/odp_classification_testsuites.h @@ -13,11 +13,24 @@ extern CU_TestInfo classification_suite[]; extern CU_TestInfo classification_suite_basic[]; +extern CU_TestInfo classification_suite_pmr[]; int classification_suite_init(void); int classification_suite_term(void

Re: [lng-odp] pktio statistic counters

2015-10-15 Thread Ivan Khoronzhuk
http://www.linaro.org/>***│ *Open source software for ARM SoCs __ ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp -- Regards, Ivan Khoronzhuk ___

[lng-odp] [API-NEXT PATCH v4 5/5] test/example: avoid "cycle" word usage

2015-10-15 Thread Ivan Khoronzhuk
The word "cycle" is left from old API time names. The "cycle" is ambiguous word, especially when it can be used for other purposes. So better to use "tick" or "time" word or just "t" symbol. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz.

Re: [lng-odp] [API-NEXT/PATCHv5] validation: classification: added additional suite to test individual PMRs

2015-10-15 Thread Ivan Khoronzhuk
On 15.10.15 16:39, Bala Manoharan wrote: Hi Ivan, Thanks for pointing out the issues. Since this patch is merged I will create a bug and add the missing points. Pls provide your inputs on the comments. On 15 October 2015 at 16:53, Ivan Khoronzhuk <ivan.khoronz...@linaro.org> wrote: Hi

Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

2015-10-15 Thread Ivan Khoronzhuk
It shouldn't depend on catalog the project is built. On 15.10.15 18:10, Ivan Khoronzhuk wrote: This reverts commit a9cc0fc700a4a8b9589404a18136b01974ca4aa3. This revert helps me to revert messages like: "fatal: No names found, cannot describe anything." in case if I build ODP outside

Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

2015-10-15 Thread Ivan Khoronzhuk
inaro.org> Reviewed-and-tested-by: Mike Holmes <mike.hol...@linaro.org> Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> Call to git_hash now adds a path to top_srcdir and handles non git dir On 10/15/2015 05:10 PM, Ivan Khoronzhuk wro

[lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

2015-10-15 Thread Ivan Khoronzhuk
This reverts commit a9cc0fc700a4a8b9589404a18136b01974ca4aa3. This revert helps me to revert messages like: "fatal: No names found, cannot describe anything." in case if I build ODP outside of source catalog by: ../../odp/configure --enable-test-perf --enable-test-vald make Seems it's connected

Re: [lng-odp] [PATCH] scripts/git_hash: fix out of tree build

2015-10-15 Thread Ivan Khoronzhuk
if git --git-dir=${ROOTDIR}/.git diff-index --name-only HEAD &>/dev/null ; then dirty=-dirty fi -- Regards, Ivan Khoronzhuk ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] pktio statistic counters

2015-10-15 Thread Ivan Khoronzhuk
On 15.10.15 19:51, Ivan Khoronzhuk wrote: On 15.10.15 19:31, Mike Holmes wrote: On 15 October 2015 at 14:04, Ivan Khoronzhuk <ivan.khoronz...@linaro.org <mailto:ivan.khoronz...@linaro.org>> wrote: Please, no Camel casemaybe we can duplicate the struct with na

Re: [lng-odp] pktio statistic counters

2015-10-15 Thread Ivan Khoronzhuk
On 15.10.15 19:31, Mike Holmes wrote: On 15 October 2015 at 14:04, Ivan Khoronzhuk <ivan.khoronz...@linaro.org <mailto:ivan.khoronz...@linaro.org>> wrote: Please, no Camel casemaybe we can duplicate the struct with names and use convenient one. So we adop

[lng-odp] [API-NEXT PATCH 2/2] linux-generic: cpu: fix cycle lost while cycle counter overflow

2015-10-05 Thread Ivan Khoronzhuk
When counter reaches it's counter value, the next clock cycle will cause it to roll over to zero. As result the counter spends 1 additional cycle to switch from UINT64_MAX to 0, it should be taken into account with diff function. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.

[lng-odp] [API-NEXT PATCH 1/2] linux-generic: use cycles_diff for time API also

2015-10-05 Thread Ivan Khoronzhuk
Currently, time API reuses cpu API to get ticks, but uses it's own function to count diff but it can differ from cpu diff function. So, better to use the same function in order to eliminate possible difference in counting. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- pl

[lng-odp] [API-NEXT PATCH 0/2] linux-generic: cpu: fix cycle lost while cycle counter overflow

2015-10-05 Thread Ivan Khoronzhuk
This series fixes cycle lost while counter overflow. First patch move diff function in one place. Second corrects diff function. Based on api-next as it corrects new cpu cycle api. Ivan Khoronzhuk (2): linux-generic: use cycles_diff for time API also linux-generic: cpu: fix cycle lost while

Re: [lng-odp] [NEXT PATCHv3] api: define pktio statistics api

2015-09-22 Thread Ivan Khoronzhuk
/platform/linux-generic/include/odp/packet_io.h b/platform/linux-generic/include/odp/packet_io.h index 1d690f5..18f8e78 100644 --- a/platform/linux-generic/include/odp/packet_io.h +++ b/platform/linux-generic/include/odp/packet_io.h @@ -33,6 +33,7 @@ extern "C" {

[lng-odp] [PATCH v3 4/5] performance: odp_pktio_perf: fix potential overflow for send_duration

2015-09-17 Thread Ivan Khoronzhuk
The direct comparing of "cur_cycles" and "end_cycles" is not valid, as "end_cycles" can be overflowed and comparison will give wrong result. So use odp_time_diff_cycles() for that, as it takes in account cycles overflow. Signed-off-by: Ivan Khoronzhuk <iva

[lng-odp] [PATCH v3 2/5] example: ipsec: avoid mixing of scheduler wait time and time API time

2015-09-17 Thread Ivan Khoronzhuk
add any functional changes. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- example/ipsec/odp_ipsec.c | 57 +-- 1 file changed, 20 insertions(+), 37 deletions(-) diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c

[lng-odp] [PATCH v3 3/5] linux-generic: odp_time: reutrn 0 if t2 = t1 for diff

2015-09-17 Thread Ivan Khoronzhuk
When times are equal the difference should be 0. Currently it's equal to UINT64_MAX and doesn't allow to compare ranges beginning from start time. The validation test to check it will be added later. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- platform/linux-g

[lng-odp] [PATCH v3 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-17 Thread Ivan Khoronzhuk
The direct comparing of "cur_cycles" and "next_tx_cycles" is not valid, as "next_tx_cycles" can be overflowed and comparison will give wrong result. So use odp_time_diff_cycles() for that, as it takes into account ticks overflow. Signed-off-by: Ivan Khoronzh

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-17 Thread Ivan Khoronzhuk
On 16.09.15 12:16, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Wednesday, September 16, 2015 11:19 AM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp

[lng-odp] [PATCH v3 0/5] preparation series before updating odp time API

2015-09-17 Thread Ivan Khoronzhuk
- included as new patch Based on master. CC: stuart.has...@linaro.org ola.liljed...@linaro.org petri.savolai...@nokia.com Ivan Khoronzhuk (5): example: timer: print timer ticks/ns table instead of cycles/ns example: ipsec: avoid mixing of scheduler wait time and time API time linux-generic

[lng-odp] [PATCH v3 1/5] example: timer: print timer ticks/ns table instead of cycles/ns

2015-09-17 Thread Ivan Khoronzhuk
The timer API can have nothing common with CPU cycles or time API. Thus timer test shouldn't print conversion cycles/ns table. More correct to print conversion table for timer ticks/ns. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- example/timer/odp_timer_test.

Re: [lng-odp] [API-NEXT PATCHv2] api: rename odp_cpumask_def to _default

2015-09-17 Thread Ivan Khoronzhuk
On 14.09.15 16:35, Maxim Uvarov wrote: Use full default word in api to make function name more clear. https://bugs.linaro.org/show_bug.cgi?id=1745 Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> Reviewed-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- v2: - merge 1

Re: [lng-odp] [PATCH v2 0/2] Fix ODP_SCHED_NO_WAIT case for odp_schedule_wait_time

2015-09-16 Thread Ivan Khoronzhuk
Maxim, On 16.09.15 11:05, Maxim Uvarov wrote: On 09/15/15 18:03, Ivan Khoronzhuk wrote: ping are you planning v3 with removed CU_ASSERT(wait_time > 0) ? Maxim. Not here. It will be removed along with ODP-190 implementation. On 10.09.15 19:18, Ivan Khoronzhuk wrote: These patc

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-16 Thread Ivan Khoronzhuk
Petri, On 16.09.15 10:02, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 5:07 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-16 Thread Ivan Khoronzhuk
On 16.09.15 10:02, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 5:07 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-16 Thread Ivan Khoronzhuk
On 16.09.15 10:52, Ivan Khoronzhuk wrote: On 16.09.15 10:02, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 5:07 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp

Re: [lng-odp] [PATCH v2 3/5] linux-generic: odp_time: reutrn 0 if t2 = t1 instead of MAX for diff

2015-09-16 Thread Ivan Khoronzhuk
Petri, What about this fix? It's similar to to CPU API. On 11.09.15 13:04, Ivan Khoronzhuk wrote: It's better to describe by example: cur = 15; start = 15; diff = 2; while (odp_time_cycles_diff(start, cur) < diff) { cur = odp_time_cycles(); } This example has to work. It's possi

Re: [lng-odp] [PATCH v2 3/5] linux-generic: odp_time: reutrn 0 if t2 = t1 instead of MAX for diff

2015-09-16 Thread Ivan Khoronzhuk
On 16.09.15 14:39, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Wednesday, September 16, 2015 1:47 PM To: lng-odp@lists.linaro.org; Savolainen, Petri (Nokia - FI/Espoo) Subject: Re: [lng-odp

Re: [lng-odp] [PATCH v2 3/5] linux-generic: odp_time: reutrn 0 if t2 = t1 instead of MAX for diff

2015-09-16 Thread Ivan Khoronzhuk
On 16.09.15 13:23, Ivan Khoronzhuk wrote: Petri, What about this fix? It's similar to to CPU API. On 11.09.15 13:04, Ivan Khoronzhuk wrote: It's better to describe by example: cur = 15; start = 15; diff = 2; while (odp_time_cycles_diff(start, cur) < diff) { cur = odp_time_cyc

Re: [lng-odp] [PATCH v2 2/5] example: ipsec: avoid mixing scheduler wait time and wall time

2015-09-15 Thread Ivan Khoronzhuk
Petri, Could you please review this patch? This patch fixes bad ipsec example we were talked about some time ago. On 11.09.15 13:04, Ivan Khoronzhuk wrote: It's not correct to mix wall time and scheduler wait time, used timers can have different rates. As in this example scheduler is used

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-15 Thread Ivan Khoronzhuk
On 15.09.15 14:42, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Ivan Khoronzhuk Sent: Friday, September 11, 2015 1:05 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH v2 5/5

Re: [lng-odp] [PATCH v2 0/2] Fix ODP_SCHED_NO_WAIT case for odp_schedule_wait_time

2015-09-15 Thread Ivan Khoronzhuk
ping On 10.09.15 19:18, Ivan Khoronzhuk wrote: These patches corrects ODP_SCHED_NO_WAIT corner case when scheduler time has resolution more then 1ns. Since v2: - linux-generic: odp_schedule: fix odp_schdule_wait_time Correct commit message - validation: schedule: don't check schedule

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-15 Thread Ivan Khoronzhuk
Petri, On 15.09.15 16:01, Ivan Khoronzhuk wrote: On 15.09.15 15:54, Ivan Khoronzhuk wrote: On 15.09.15 15:45, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 3:08 PM

Re: [lng-odp] [API NEXT PATCH v5 03/17] api: sysinfo: move CPU model API to cpu.h

2015-09-15 Thread Ivan Khoronzhuk
fo.page_size; } -const char *odp_sys_cpu_model_str(void) +const char *odp_cpu_model_str(void) { return odp_global_data.system_info.model_str[0]; } -- Regards, Ivan Khoronzhuk ___ lng-odp mailing list lng-odp@lists.linaro.org https://list

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-15 Thread Ivan Khoronzhuk
On 15.09.15 15:45, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 3:08 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-15 Thread Ivan Khoronzhuk
On 15.09.15 15:54, Ivan Khoronzhuk wrote: On 15.09.15 15:45, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 3:08 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp

Re: [lng-odp] [PATCH v2 4/5] performance: odp_pktio_perf: fix potential overflow for send_duration

2015-09-15 Thread Ivan Khoronzhuk
Stuart, Could you please review this patch. It uses start_cycles as it was proposed. On 11.09.15 13:04, Ivan Khoronzhuk wrote: The direct comparing of "cur_cycles" and "end_cycles" is not valid, as "end_cycles" can be overflowed and comparison

Re: [lng-odp] [API-NEXT PATCH v2 1/5] api: cpu: added cpu cycle count API

2015-09-11 Thread Ivan Khoronzhuk
Petri, On 11.09.15 12:47, Savolainen, Petri (Nokia - FI/Espoo) wrote: Ping. It be good schedule some task to update/add validation test for cpu API. -Original Message- From: ext Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 08, 2015 1:04 PM

[lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-11 Thread Ivan Khoronzhuk
The direct comparing of "cur_cycles" and "next_tx_cycles" is not valid, as "next_tx_cycles" can be overflowed and comparison will give wrong result. So use odp_time_diff_cycles() for that, as it takes in account ticks overflow. Signed-off-by: Ivan Khoronzhuk <ivan

Re: [lng-odp] [PATCH v2 2/2] validation: schedule: don't check schedule time on 0

2015-09-11 Thread Ivan Khoronzhuk
to review it. On 10.09.15 19:18, Ivan Khoronzhuk wrote: The ODP_SCHED_NO_WAIT now corresponds to 0, not 1. So no need to check it anymore. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- test/validation/scheduler/scheduler.c | 2 -- 1 file changed, 2 deletions(-) diff

[lng-odp] [PATCH v2 1/5] example: timer: print timer ticks/ns table instead of cycles/ns

2015-09-11 Thread Ivan Khoronzhuk
The timer API can have nothing common with CPU cycles or time API. Thus timer test shouldn't print here conversion cycles/ns table. More correct to print here conversion table for timer ticks/ns. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- example/timer/odp_timer_test.

[lng-odp] [PATCH v2 3/5] linux-generic: odp_time: reutrn 0 if t2 = t1 instead of MAX for diff

2015-09-11 Thread Ivan Khoronzhuk
It's better to describe by example: cur = 15; start = 15; diff = 2; while (odp_time_cycles_diff(start, cur) < diff) { cur = odp_time_cycles(); } This example has to work. It's possible only when t2 - t1 = 0 if t2 = t1. The validation test on it will be added later. Signed-off-by: I

[lng-odp] [PATCH v2 2/5] example: ipsec: avoid mixing scheduler wait time and wall time

2015-09-11 Thread Ivan Khoronzhuk
functional changes. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- example/ipsec/odp_ipsec.c | 57 +-- 1 file changed, 20 insertions(+), 37 deletions(-) diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c index 9

[lng-odp] [PATCH v2 4/5] performance: odp_pktio_perf: fix potential overflow for send_duration

2015-09-11 Thread Ivan Khoronzhuk
The direct comparing of "cur_cycles" and "end_cycles" is not valid, as "end_cycles" can be overflowed and comparison will give wrong result. So use odp_time_diff_cycles() for that, as it takes in account cycles overflow. Signed-off-by: Ivan Khoronzhuk <ivan

[lng-odp] [PATCH v2 0/5] preparation series before updating odp time API

2015-09-11 Thread Ivan Khoronzhuk
s://lists.linaro.org/pipermail/lng-odp/2015-August/014850.html Since v1: - included new patch "example: timer: print timer ticks/ns table instead of cycles/ns" Based on master. CC: stuart.haslam at linaro.org ola.liljed...@linaro.org petri.savolai...@nokia.com Ivan Khoronzhuk (5):

Re: [lng-odp] [RFC Patch] example: timer: move cycles/ns table to validation tests

2015-09-11 Thread Ivan Khoronzhuk
Ola, The patch with your corrections is included in the series that I sent recently: "[lng-odp] [PATCH v2 0/5] preparation series before updating odp time API" On 07.09.15 14:55, Ivan Khoronzhuk wrote: Ola, On 07.09.15 14:45, Ola Liljedahl wrote: On 7 September 2015 at 11:45, Ivan

Re: [lng-odp] [PATCH v2 2/5] example: ipsec: avoid mixing scheduler wait time and wall time

2015-09-11 Thread Ivan Khoronzhuk
On 11.09.15 13:04, Ivan Khoronzhuk wrote: It's not correct to mix wall time and scheduler wait time, It's not wall time, rather time from time API. Should be corrected. used timers can have different rates. As in this example scheduler is used only for poll purposes, using wait time

[lng-odp] [Patch 2/2] validation: schedule: don't check schedule time on 0

2015-09-10 Thread Ivan Khoronzhuk
The ODP_SCHED_NO_WAIT now corresponds to 0, not 1. So no need to check it anymore. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- test/validation/scheduler/scheduler.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/validation/scheduler/scheduler.c b/test/vali

Re: [lng-odp] [Patch] linux-generic: odp_schedule: fix odp_schdule_wait_time

2015-09-10 Thread Ivan Khoronzhuk
Nicolas, On 09.09.15 16:38, Ivan Khoronzhuk wrote: On 09.09.15 16:27, Ivan Khoronzhuk wrote: On 09.09.15 15:44, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Wednesday, September 09, 2015 3:35

[lng-odp] [Patch 0/2] Fix ODP_SCHED_NO_WAIT case for odp_schedule_wait_time

2015-09-10 Thread Ivan Khoronzhuk
15093.html Ivan Khoronzhuk (2): linux-generic: odp_schedule: fix odp_schdule_wait_time validation: schedule: don't check schedule time on 0 platform/linux-generic/include/odp/plat/schedule_types.h | 4 ++-- platform/linux-generic/odp_schedule.c| 3 --- test/validation

[lng-odp] [Patch 1/2] linux-generic: odp_schedule: fix odp_schdule_wait_time

2015-09-10 Thread Ivan Khoronzhuk
at all. Also ODP_SCHED_NO_WAIT corresponds to 1 tick, it's rarely but can wait a little, when shced time has slower rate. It should correspond to schedule only once. So, change ODP_SCHED_NO_WAIT to 0 and ODP_SCHED_NO_WAIT to UINT64_MAX. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.

Re: [lng-odp] [Patch 2/2] validation: schedule: don't check schedule time on 0

2015-09-10 Thread Ivan Khoronzhuk
On 10.09.15 15:21, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Thursday, September 10, 2015 12:49 PM To: lng-odp@lists.linaro.org; Savolainen, Petri (Nokia - FI/Espoo); nmo...@kalray.eu Cc: Ivan

Re: [lng-odp] [Patch 1/2] linux-generic: odp_schedule: fix odp_schdule_wait_time

2015-09-10 Thread Ivan Khoronzhuk
On 10.09.15 16:03, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Thursday, September 10, 2015 3:34 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org; nmo...@kalray.eu Subject: Re

Re: [lng-odp] [Patch 1/2] linux-generic: odp_schedule: fix odp_schdule_wait_time

2015-09-10 Thread Ivan Khoronzhuk
Petri, Are you OK with this change? On 10.09.15 12:48, Ivan Khoronzhuk wrote: The resolution of schedule time can be more than 1ns. As result can happen that 1ns corresponds 0 ticks of timer counter, but if passed 1ns it's obvious that user wanted to schedule at least once. Currently it can

Re: [lng-odp] [API-NEXT PATCH] api: packet reference count support

2015-09-10 Thread Ivan Khoronzhuk
_ lng-odp mailing list lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> https://lists.linaro.org/mailman/listinfo/lng-odp _______ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/l

Re: [lng-odp] [Patch 1/2] linux-generic: odp_schedule: fix odp_schdule_wait_time

2015-09-10 Thread Ivan Khoronzhuk
ing 1/2. I prefer to hold the same numbering within series. But, next time I will bear it in mind. The log entry could be clarified a bit, see under. -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Thursday, September 10, 2015 12:49 PM T

Re: [lng-odp] [Patch 2/2] validation: schedule: don't check schedule time on 0

2015-09-10 Thread Ivan Khoronzhuk
Petri, On 10.09.15 17:35, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Thursday, September 10, 2015 5:13 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org; nmo...@kalray.eu

Re: [lng-odp] [Patch 2/2] validation: schedule: don't check schedule time on 0

2015-09-10 Thread Ivan Khoronzhuk
All, On 10.09.15 16:15, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Thursday, September 10, 2015 4:00 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org; nmo...@kalray.eu Subject

[lng-odp] [PATCH v2 0/2] Fix ODP_SCHED_NO_WAIT case for odp_schedule_wait_time

2015-09-10 Thread Ivan Khoronzhuk
= odp_schedule_wait_time(1); Ivan Khoronzhuk (2): linux-generic: odp_schedule: fix odp_schdule_wait_time validation: schedule: don't check schedule time on 0 platform/linux-generic/include/odp/plat/schedule_types.h | 4 ++-- platform/linux-generic/odp_schedule.c| 3 --- test

[lng-odp] [PATCH v2 1/2] linux-generic: odp_schedule: fix odp_schdule_wait_time

2015-09-10 Thread Ivan Khoronzhuk
to schedule only once. So, change ODP_SCHED_NO_WAIT to 0 and ODP_SCHED_NO_WAIT to UINT64_MAX. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- platform/linux-generic/include/odp/plat/schedule_types.h | 4 ++-- platform/linux-generic/odp_schedule.c| 3

[lng-odp] [PATCH v2 2/2] validation: schedule: don't check schedule time on 0

2015-09-10 Thread Ivan Khoronzhuk
The ODP_SCHED_NO_WAIT now corresponds to 0, not 1. So no need to check it anymore. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- test/validation/scheduler/scheduler.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/validation/scheduler/scheduler.c b/test/vali

Re: [lng-odp] [Patch 2/2] validation: schedule: don't check schedule time on 0

2015-09-10 Thread Ivan Khoronzhuk
On 10.09.15 21:08, Ivan Khoronzhuk wrote: Petri, On 10.09.15 18:16, Ivan Khoronzhuk wrote: Petri, On 10.09.15 17:35, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Thursday, September 10, 2015 5

Re: [lng-odp] [Patch 2/2] validation: schedule: don't check schedule time on 0

2015-09-10 Thread Ivan Khoronzhuk
Petri, On 10.09.15 18:16, Ivan Khoronzhuk wrote: Petri, On 10.09.15 17:35, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Thursday, September 10, 2015 5:13 PM To: Savolainen, Petri (Nokia - FI/Espoo

Re: [lng-odp] [Patch] linux-generic: odp_schedule: fix odp_schdule_wait_time

2015-09-09 Thread Ivan Khoronzhuk
On 09.09.15 15:34, Ivan Khoronzhuk wrote: On 09.09.15 15:00, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext Ivan Khoronzhuk Sent: Monday, September 07, 2015 11:51 AM To: lng-odp

Re: [lng-odp] [Patch] linux-generic: odp_schedule: fix odp_schdule_wait_time

2015-09-09 Thread Ivan Khoronzhuk
On 09.09.15 15:00, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext Ivan Khoronzhuk Sent: Monday, September 07, 2015 11:51 AM To: lng-odp@lists.linaro.org Subject: [lng-odp] [Patch] linux-generic

Re: [lng-odp] [Patch] validation: scheduler: increase time check

2015-09-09 Thread Ivan Khoronzhuk
(which don’t produce events), or driving back ground processing (started only when app is idling). -Petri ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp -- Regards, Iva

Re: [lng-odp] [Patch] linux-generic: odp_schedule: fix odp_schdule_wait_time

2015-09-09 Thread Ivan Khoronzhuk
On 09.09.15 15:44, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Wednesday, September 09, 2015 3:35 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp

Re: [lng-odp] [Patch] linux-generic: odp_schedule: fix odp_schdule_wait_time

2015-09-09 Thread Ivan Khoronzhuk
On 09.09.15 16:27, Ivan Khoronzhuk wrote: On 09.09.15 15:44, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Wednesday, September 09, 2015 3:35 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp

Re: [lng-odp] [API-NEXT PATCH 3/5] linux-generic: cpu: rename time_cycles to cpu_cycles

2015-09-08 Thread Ivan Khoronzhuk
nt64_t odp_time_cycles(void) +{ + return odp_cpu_cycles(); +} + uint64_t odp_time_diff_cycles(uint64_t t1, uint64_t t2) { if (odp_likely(t2 > t1)) -- Regards, Ivan Khoronzhuk ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.l

Re: [lng-odp] [API-NEXT PATCH 3/5] linux-generic: cpu: rename time_cycles to cpu_cycles

2015-09-08 Thread Ivan Khoronzhuk
On 08.09.15 12:37, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: ext Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 08, 2015 12:20 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API

Re: [lng-odp] [API-NEXT PATCH 3/5] linux-generic: cpu: rename time_cycles to cpu_cycles

2015-09-08 Thread Ivan Khoronzhuk
On 08.09.15 11:35, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: ext Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 08, 2015 10:26 AM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API

Re: [lng-odp] [API-NEXT PATCH v2 4/5] linux-generic: cpu: implementation for cycle count API

2015-09-08 Thread Ivan Khoronzhuk
On 08.09.15 11:31, Petri Savolainen wrote: Added implementation for CPU cycle diff, max and resolution. Signed-off-by: Petri Savolainen <petri.savolai...@nokia.com> Reviewed-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- platform/linux-generic/Makefile.am

Re: [lng-odp] [API-NEXT PATCH 1/4] api: rename odp_cpumask_def to _default

2015-09-08 Thread Ivan Khoronzhuk
On 08.09.15 14:03, Maxim Uvarov wrote: On 09/08/15 13:55, Ivan Khoronzhuk wrote: Maxim, Could you please clarify. I expect that after patch adding some implementation should build. If you adding new API it doesn't have impact. But if API is modified, probably that project has build problem

Re: [lng-odp] [API-NEXT PATCH 1/4] api: rename odp_cpumask_def to _default

2015-09-08 Thread Ivan Khoronzhuk
UNUSED) { odp_cpumask_zero(mask); /* By default all control threads on CPU 0 */ -- Regards, Ivan Khoronzhuk ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [API-NEXT PATCH v2 2/5] linux-generic: cpu: created arch depedent cpu_cycles files

2015-09-08 Thread Ivan Khoronzhuk
On 08.09.15 11:31, Petri Savolainen wrote: Renamed time_cycles files to cpu_cycles, since those files implement cpu cycle counter read needed by cpu API but not needed by new time API. Signed-off-by: Petri Savolainen <petri.savolai...@nokia.com> Reviewed-by: Ivan Khoronzhuk <iva

[lng-odp] [Patch] linux-generic: odp_schedule: fix odp_schdule_wait_time

2015-09-07 Thread Ivan Khoronzhuk
at all. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- Prerequisit for this patch was taken from: "[lng-odp] [Patch] validation: scheduler: increase time check" https://lists.linaro.org/pipermail/lng-odp/2015-August/014738.html platform/linux-generic/od

Re: [lng-odp] [RFC Patch] example: timer: move cycles/ns table to validation tests

2015-09-07 Thread Ivan Khoronzhuk
something common with timer API, but that's not true. Maybe it can be deleted at all, just want to leave it somewhere. On 03.09.15 11:50, Ivan Khoronzhuk wrote: The linux-generic implements timers supposing that timers are based on CPU cycle counter. It's not always true and timer API can have nothing

Re: [lng-odp] [API-NEXT PATCH v4 05/10] linux-generic: sysinfo: clarify the API for max CPU frequency

2015-09-07 Thread Ivan Khoronzhuk
On 07.09.15 14:08, Hongbo Zhang wrote: On 3 September 2015 at 22:47, Ivan Khoronzhuk <ivan.khoronz...@linaro.org> wrote: Hi, Hongbo On 11.08.15 10:33, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang <hongbo.zh...@linaro.org> Currently the API to get CPU frequency is vag

Re: [lng-odp] [API-NEXT PATCH 5/5] performance: sched: update scheduling test to use cycle counts

2015-09-07 Thread Ivan Khoronzhuk
c1 = odp_cpu_cycles(); .... -- Regards, Ivan Khoronzhuk ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [API-NEXT PATCH 5/5] performance: sched: update scheduling test to use cycle counts

2015-09-07 Thread Ivan Khoronzhuk
version: %s\n",odp_version_api_str()); printf("CPU model: %s\n",odp_sys_cpu_model_str()); - printf("CPU freq (hz): %"PRIu64"\n", odp_sys_cpu_hz()); + printf("CPU freq (hz): %" PRIu64 "\n", odp_sys_cpu_hz

Re: [lng-odp] [API-NEXT PATCH 1/5] api: cpu: added cpu cycle count API

2015-09-07 Thread Ivan Khoronzhuk
s + * resolution of odp_cpu_cycles() in CPU cycles. + * + * @return CPU cycle count resolution in CPU cycles + */ +uint64_t odp_cpu_cycles_resolution(void); + +/** * @} */ -- Regards, Ivan Khoronzhuk ___ lng-odp mailing list lng-odp@lists.

Re: [lng-odp] [Patch] validation: scheduler: increase time check

2015-09-04 Thread Ivan Khoronzhuk
; !cycle) cycle = 1; ODP_SCHED_NO_WAIT (1) like check once, so if we passed ~ 1ns we wanted to schedule at least once. Currently it can lead to wait forever ODP_SCHED_WAIT (0). On Thu, Sep 3, 2015 at 1:28 AM, Ivan Khoronzhuk <ivan.khoronz...@linaro.org <mailto:ivan.khoronz...@lina

Re: [lng-odp] [odp-lng] [Patch v3 1/3] api: time: unbind CPU cycles from time API

2015-09-04 Thread Ivan Khoronzhuk
Petri, On 04.09.15 12:14, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: ext Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Thursday, September 03, 2015 6:26 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp

Re: [lng-odp] RFC: New time API

2015-09-04 Thread Ivan Khoronzhuk
ectly? Check it's 32 bit or 64 in application? Check time wrap period? It's not very friendly on my opinion. Always use only for ranges is more correct variant. -Petri -- Regards, Ivan Khoronzhuk ___ lng-odp mailing list lng-odp@lists.linaro.org https://lis

Re: [lng-odp] [PATCHv2 8/8] validation: schedule: add coverage for new scheduler APIs

2015-09-04 Thread Ivan Khoronzhuk
odp_queue_lookup(name); if (q == ODP_QUEUE_INVALID) return -1; + qctx = odp_queue_context(q); + if (qctx) + odp_buffer_free(qctx->ctx_handle); return odp_queue_destroy(q); } @@ -952,6 +1083,9 @@ static int destroy_queues(void)

Re: [lng-odp] [API-NEXT PATCH v4 05/10] linux-generic: sysinfo: clarify the API for max CPU frequency

2015-09-03 Thread Ivan Khoronzhuk
z_max(); CU_ASSERT(0 < hz); } @@ -90,7 +90,7 @@ CU_TestInfo system_suite[] = { {"odp_cpu_model_str", system_test_odp_cpu_model_str}, {"odp_sys_page_size", system_test_odp_sys_page_size}, {"odp_sys_huge_page_size",

Re: [lng-odp] [odp-lng] [Patch v3 1/3] api: time: unbind CPU cycles from time API

2015-09-03 Thread Ivan Khoronzhuk
Petri, On 03.09.15 16:13, Ivan Khoronzhuk wrote: On 03.09.15 15:29, Savolainen, Petri (Nokia - FI/Espoo) wrote: There are many example apps that actually want to measure execution time in CPU cycles, not in nsec. Time API and CPU (cycle) API updates are linked together. Real CPU cycle

Re: [lng-odp] [API-NEXT PATCH v4 08/10] linux-generic: sysinfo: add API to get current CPU frequency

2015-09-03 Thread Ivan Khoronzhuk
u_id_hz_max(int id) return -1; } +uint64_t odp_cpu_hz(void) +{ + int id = sched_getcpu(); + + return arch_cpu_hz_current(id); +} + +uint64_t odp_cpu_id_hz(int id) +{ + return arch_cpu_hz_current(id); +} + uint64_t odp_sys_huge_page_size(void) { return od

Re: [lng-odp] [API-NEXT PATCH v4 10/10] validation: add test for new per_CPU system APIs

2015-09-03 Thread Ivan Khoronzhuk
); void system_test_odp_cpu_hz_max(void); +void system_test_odp_cpu_id_hz_max(void); +void system_test_odp_cpu_hz(void); +void system_test_odp_cpu_id_hz(void); /* test arrays: */ extern CU_TestInfo system_suite[]; -- Regards, Ivan Khoronzhuk ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [API-NEXT PATCH v4 10/10] validation: add test for new per_CPU system APIs

2015-09-03 Thread Ivan Khoronzhuk
e_page_size(void); void system_test_odp_cpu_hz_max(void); +void system_test_odp_cpu_id_hz_max(void); +void system_test_odp_cpu_hz(void); +void system_test_odp_cpu_id_hz(void); /* test arrays: */ extern CU_TestInfo system_suite[]; -- Regards, Ivan Khoronzhuk ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [Patch] validation: scheduler: increase time check

2015-09-03 Thread Ivan Khoronzhuk
On 03.09.15 09:20, Nicolas Morey-Chaisemartin wrote: On 09/02/2015 11:16 PM, Ivan Khoronzhuk wrote: On 02.09.15 12:42, Nicolas Morey-Chaisemartin wrote: On 08/26/2015 05:47 PM, Ivan Khoronzhuk wrote: On 26.08.15 18:22, Stuart Haslam wrote: On Wed, Aug 26, 2015 at 06:11:13PM +0300

[lng-odp] [RFC Patch] example: timer: move cycles/ns table to validation tests

2015-09-03 Thread Ivan Khoronzhuk
The linux-generic implements timers supposing that timers are based on CPU cycle counter. It's not always true and timer API can have nothing common with CPU cycles. Thus timer test shouldn't print here conversion cycles/ns table for time API. Signed-off-by: Ivan Khoronzhuk <ivan.khor

Re: [lng-odp] RFC: New time API

2015-09-03 Thread Ivan Khoronzhuk
One correction, that also makes me worry a little. On 03.09.15 01:29, Ivan Khoronzhuk wrote: Hi, Petri We have to look at it proceeding from performance, platform portability and simplicity If you want to split on hi-res time and low-res they must have separate functions and be not under

[lng-odp] [odp-lng] [Patch v3 1/3] api: time: unbind CPU cycles from time API

2015-09-02 Thread Ivan Khoronzhuk
ed instead of odp_time_from_ns(0) for comparison and initialization. This patch only changes used time API, it doesn't change used var names for simplicity. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- example/timer/odp_timer_test.c| 22 +++ includ

[lng-odp] [odp-lng] [Patch v3 0/3] api: time: unbind CPU cycles from time API

2015-09-02 Thread Ivan Khoronzhuk
ng-odp/2015-August/014850.html v2: api: time: change API to use ticks instead of cycles https://lists.linaro.org/pipermail/lng-odp/2015-August/014198.html Since v1: - changed series name a little bit - added opaque type odp_time_t - added missed spaces in printf - removed legacy "count"

Re: [lng-odp] [Patch] validation: scheduler: increase time check

2015-09-02 Thread Ivan Khoronzhuk
On 02.09.15 12:42, Nicolas Morey-Chaisemartin wrote: On 08/26/2015 05:47 PM, Ivan Khoronzhuk wrote: On 26.08.15 18:22, Stuart Haslam wrote: On Wed, Aug 26, 2015 at 06:11:13PM +0300, Ivan Khoronzhuk wrote: It's needed because time resolution can be a little more than 1ns and in this case

[lng-odp] [odp-lng] [Patch v3 3/3] linux-generic: align implementation with new time API

2015-09-02 Thread Ivan Khoronzhuk
lign linux-generic implementation with new time API. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- platform/linux-generic/Makefile.am | 1 + .../linux-generic/arch/linux/odp_time_cycles.c | 4 +- .../linux-generic/arch/mips64/odp_time_cycles.c| 4 +-

Re: [lng-odp] [PATCH] validation: pktio: revert wait time to msec

2015-09-02 Thread Ivan Khoronzhuk
ich causes the test to take nearly 2 minutes. Signed-off-by: Nicolas Morey-Chaisemartin <nmo...@kalray.eu> Cc: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> --- Reviewed-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> test/validation/pktio/pktio.c | 2 +- 1 file changed, 1 inser

Re: [lng-odp] [PATCH] validation: pktio: don't mix scheduler wait time and ns in start_stop test

2015-09-02 Thread Ivan Khoronzhuk
On 02.09.15 12:35, Nicolas Morey-Chaisemartin wrote: The odp_scheduler() requires time value in its own ticks, so pass scheduler wait time instead of ns. Signed-off-by: Nicolas Morey-Chaisemartin <nmo...@kalray.eu> --- Reviewed-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org&

[lng-odp] [odp-lng] [Patch v3 2/3] test/example: avoid "cycle" word usage

2015-09-02 Thread Ivan Khoronzhuk
The word "cycle" is left from old API time names. The "cycle" is ambiguous word, especially when it can be used for other purposes. So better to use "tick" or "time" word or just "t" symbol. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz.

<    1   2   3   4   5   6   7   >