[lng-odp] dpdk 17.08 backward compatibility issues with odp crypto

2017-11-28 Thread Krishna Garapati
Hi, I am working on moving odp-dpdk from dpdk 17.02 to 17.08. But due to updates in dpdk crypto which are not backward compatible, makes it difficult to implement changes in odp-dpdk. One major update is moving "AES_GCM & AES_CCM" algorithms to a separate enum called "rte_crypto_aead_algorithm".

Re: [lng-odp] [PATCH 7/7] linux-gen: dpdk: enable zero-copy operation

2017-07-11 Thread Krishna Garapati
On 10 July 2017 at 15:11, Elo, Matias (Nokia - FI/Espoo) < matias@nokia.com> wrote: > > > On 10 Jul 2017, at 12:17, Krishna Garapati <balakrishna.garapati@linaro. > org> wrote: > > > > > > > > On 10 July 2017 at 10:13, Elo, Matias (N

Re: [lng-odp] [PATCH 7/7] linux-gen: dpdk: enable zero-copy operation

2017-07-10 Thread Krishna Garapati
On 10 July 2017 at 10:13, Elo, Matias (Nokia - FI/Espoo) < matias@nokia.com> wrote: > > > + pkt_pool = mbuf_pool_create(pkt_dpdk->pool_name, > > + pool_entry->num, > cache, > > + > pool_entry->max_seg_len + > > + >

Re: [lng-odp] [PATCH 7/7] linux-gen: dpdk: enable zero-copy operation

2017-07-07 Thread Krishna Garapati
On 3 July 2017 at 14:01, Matias Elo wrote: > Implements experimental zero-copy mode for DPDK pktio. This can be enabled > with additional '--enable-dpdk-zero-copy' configure flag. > > This feature has been put behind an extra configure flag as it doesn't > entirely adhere

[lng-odp] discussion thread on pool create & rte_mbuf support in odp-cloud

2017-05-23 Thread Krishna Garapati
Fallowing are the open issues that requires discussion in odp-cloud implementation, - Currently in odp, pkt pool creation has no knowledge of pktio type as it would need in case of odp-cloud if it wants to use the platform specific API's (ex: dpdk) to create the pool through DDF (Driver

Re: [lng-odp] [API-NEXT PATCHv3] api: crypto: change iv_len field to feature min-max len

2017-05-18 Thread Krishna Garapati
On 17 May 2017 at 22:29, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > Balakrishna, > > On 17.05.2017 13:49, Balakrishna Garapati wrote: > > dpdk pmd's require to minatain min, max, inc fields for all > > crypto capabilitites. By making iv_len to feature like dpdk pmd's >

Re: [lng-odp] [API-NEXT PATCH] api: crypto: change iv_len field to feature min-max len

2017-05-17 Thread Krishna Garapati
On 16 May 2017 at 17:46, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > On 16.05.2017 10:43, Krishna Garapati wrote: > > > > > > On 15 May 2017 at 19:38, Dmitry Eremin-Solenikov > > <dmitry.ereminsoleni...@linaro.org > > <mai

Re: [lng-odp] [API-NEXT PATCH] api: crypto: change iv_len field to feature min-max len

2017-05-16 Thread Krishna Garapati
On 15 May 2017 at 19:38, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > On 15.05.2017 15:42, Balakrishna Garapati wrote: > > This change is needed to support dpdk crypto pmd's > > Could you please be more specific, what are you trying to express. If > you need, you can

Re: [lng-odp] [PATCHv2] abi: packet: restore abi compatibility for odp_packet_seg_t type

2017-04-13 Thread Krishna Garapati
mode and provide these variant > definitions to enable proper ABI compatibility while still supporting an > optimized typedef for non-ABI mode. > > This resolves Bug https://bugs.linaro.org/show_bug.cgi?id=2940 > > Reported-by: Krishna Garapati <balakrishna.garap...@linaro.org> >

Re: [lng-odp] [PATCH] abi: packet: restore abi compatibility for odp_packet_seg_t type

2017-04-13 Thread Krishna Garapati
On 13 April 2017 at 00:06, Bill Fischofer wrote: > When running in --enable-abi-compat=yes mode, all ODP types need to be > of pointer width in the default ABI definition. The optimization of the > odp_packet_seg_t type to uint8_t can only be supported when running in

Re: [lng-odp] [PATCH v5 1/3] validation: packet: increase test pool size

2017-04-06 Thread Krishna Garapati
for this patch series, Reviewed-by: Balakrishna Garapati /Krishna On 31 March 2017 at 14:18, Matias Elo wrote: > Previously packet_test_concatsplit() could fail on some pool > implementations as the pool ran out of buffers. Increase

Re: [lng-odp] [PATCH] linux-generic: decouple odp_errno define from odp-linux

2017-04-04 Thread Krishna Garapati
ping On 30 March 2017 at 15:31, Balakrishna Garapati < balakrishna.garap...@linaro.org> wrote: > makes it easy to define odp_errno to dpdk rteerrno and fixes > linking issues. > > Signed-off-by: Balakrishna Garapati > --- > platform/linux-generic/Makefile.am

Re: [lng-odp] [PATCH] test: performance: lower the MAX_PKT_SIZE to 1518

2017-03-30 Thread Krishna Garapati
ping On 24 March 2017 at 14:40, Balakrishna Garapati < balakrishna.garap...@linaro.org> wrote: > "bench_packet_tailroom" test fails on odp-dpdk with the pkt size 2048 > leaving no space for tailroom. > > Signed-off-by: Balakrishna Garapati > --- >

Re: [lng-odp] [API-NEXT PATCH v2 1/2] validation: packet: increase test pool size

2017-03-29 Thread Krishna Garapati
On 29 March 2017 at 12:51, Elo, Matias (Nokia - FI/Espoo) < matias@nokia-bell-labs.com> wrote: > > > On 28 Mar 2017, at 17:21, Krishna Garapati <balakrishna.garapati@linaro. > org> wrote: > > > > This pool size is not enough with odp-dpdk. It runs out of

Re: [lng-odp] [API-NEXT PATCH v2 1/2] validation: packet: increase test pool size

2017-03-28 Thread Krishna Garapati
On 27 February 2017 at 13:18, Matias Elo wrote: > Previously packet_test_concatsplit() could fail on some pool > implementations as the pool ran out of buffers. Increase default pools size > and use capability to make sure the value is valid. > > Signed-off-by: Matias Elo

Re: [lng-odp] [PATCHv3] validation: packet: do not require a max packet length

2017-03-24 Thread Krishna Garapati
Reviewed-by: Balakrishna Garapati /Krishna On 23 March 2017 at 22:56, Bill Fischofer wrote: > Address bug https://bugs.linaro.org/show_bug.cgi?id=2908 by adding > appropriate pool capability checks to the packet, pktio, and crypto

Re: [lng-odp] [PATCHv2] validation: packet: do not require a max packet length

2017-03-17 Thread Krishna Garapati
Reviewed-by: Balakrishna Garapati /Krishna On 14 March 2017 at 14:55, Bill Fischofer wrote: > Address bug https://bugs.linaro.org/show_bug.cgi?id=2908 by adding > appropriate pool capability checks to the packet and crypto tests > to

Re: [lng-odp] [PATCH] validation: packet: do not require a max packet length

2017-03-13 Thread Krishna Garapati
On 13 March 2017 at 15:02, Bill Fischofer wrote: > Address bug https://bugs.linaro.org/show_bug.cgi?id=2908 by checking > the pool capability max packet length and modifying the test in > test_extend_ref() to account for implementations that do not limit > packet

Re: [lng-odp] [API-NEXT PATCH 1/4] validation: crypto: fix hw cipher/auth algorithm check

2017-01-11 Thread Krishna Garapati
for this series, Reviewed-by: Balakrishna Garapati /Krishna On 10 January 2017 at 13:09, Matias Elo wrote: > Some algorithms may be implemented using hardware and some using software. > All supported algorithms should be set in

Re: [lng-odp] [PATCHv3] example: hello: set cpu affinity from cgroup

2017-01-10 Thread Krishna Garapati
On 10 January 2017 at 16:46, Mike Holmes wrote: > On 10 January 2017 at 10:30, Maxim Uvarov wrote: > > > On 01/10/17 18:08, Mike Holmes wrote: > > > > > > > > > On 10 January 2017 at 10:02, Maxim Uvarov > >

Re: [lng-odp] [PATCHv3] platform: linux-generic: reading cpu affinity from cpuset

2016-12-06 Thread Krishna Garapati
On 2 December 2016 at 04:20, Yi He wrote: > The original code reads whole system cpuset, and provides no command line > parameters to specify cpuset resources while launching ODP application. > Thus can be an obstacle for the coexisting of multiple ODP applications. > > New

Re: [lng-odp] [PATCHv3] platform: linux-generic: reading cpu affinity from cpuset

2016-12-01 Thread Krishna Garapati
ping /Krishna On 28 November 2016 at 15:34, Balakrishna Garapati < balakrishna.garap...@linaro.org> wrote: > With this new proposal cpu affinity is read correctly especially > when using cgroups otherwise wrong cpu mask is set. > > Fixes bug: https://bugs.linaro.org/show_bug.cgi?id=2472 > >

Re: [lng-odp] [PATCHv2] linux-gen: crypto: fix aes gcm decryption

2016-11-04 Thread Krishna Garapati
Reviewed-by: Balakrishna Garapati /Krishna On 31 October 2016 at 15:53, Maxim Uvarov wrote: > On 31 October 2016 at 17:51, Maxim Uvarov wrote: > > > We should first initialize, then set up decryption > > and

Re: [lng-odp] [PATCHv3] linux-generic: configure: add conditional shared library support

2016-09-07 Thread Krishna Garapati
Reviewed-by: Balakrishna Garapati /Krishna On 6 September 2016 at 17:46, Mike Holmes wrote: > Ping - any reviews for this so that we can have step one ABI compatibility > by LAS16 ? > > On 30 August 2016 at 21:37, Bill Fischofer

[lng-odp] issue with odp_crypto validation suite

2016-09-06 Thread Krishna Garapati
>From odp crypto validation suite I see that the application is setting "auth_cipher_text" flag from odp_crypto_session_params to "false" all ways (Irrespective of ENCODE or DECODE). What this means from my understanding is application wants to do "cipher first and then authentication". And in

Re: [lng-odp] [PATCH] test: performance: return when pkt alloc fails

2016-05-04 Thread Krishna Garapati
Thanks mike, I missed the comment received. my bad. /Krishna On 3 May 2016 at 23:33, Mike Holmes wrote: > merged > > Krishna, I made Maxims update and added his reviewed by for you > > On 25 April 2016 at 09:15, Maxim Uvarov wrote: > >> On

Re: [lng-odp] [PATCH] helper: remove unused odph_linux_process_fork API

2016-05-02 Thread Krishna Garapati
On 2 May 2016 at 13:47, Mike Holmes wrote: > odph_linux_process_fork is not used by any ODP example or test, it is also > untested by the helper test suite. > Just for the note, we use this api currently in our nginx_ofp app. > > odph_linux_process_fork is a wrapper for

Re: [lng-odp] [API-NEXT PATCH] validation: crypto: verify odp crypto capability

2016-04-22 Thread Krishna Garapati
On 22 April 2016 at 17:43, Christophe Milard wrote: > > > On 22 April 2016 at 16:14, Balakrishna Garapati < > balakrishna.garap...@linaro.org> wrote: > >> test update to verify the crypto capability fucntionality >> >> Signed-off-by: Balakrishna Garapati

Re: [lng-odp] [PATCH] test: performance: return when pkt alloc fails

2016-04-21 Thread Krishna Garapati
ping /Krishna On 11 April 2016 at 11:11, Balakrishna Garapati < balakrishna.garap...@linaro.org> wrote: > Resolving https://bugs.linaro.org/show_bug.cgi?id=2135 by return > over packet allocation failure. > > Signed-off-by: Balakrishna Garapati > --- >

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto capability

2016-04-20 Thread Krishna Garapati
ping. Maxim, are you still waiting for any response for the comments on this patch other than petri's explanation provided yesterday ? /Krishna On 18 April 2016 at 14:52, Maxim Uvarov wrote: > On 04/15/16 12:36, Petri Savolainen wrote: > >> Added crypto capability

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto capability

2016-04-15 Thread Krishna Garapati
On 15 April 2016 at 11:36, Petri Savolainen wrote: > Added crypto capability structure and cipher/authentication > algorithm bit masks needed by the structure. > > Signed-off-by: Petri Savolainen > --- > include/odp/api/spec/crypto.h | 88

Re: [lng-odp] [RFC] api: crypto capability support

2016-04-14 Thread Krishna Garapati
Thanks Petri, now it is clear what you have in mind. BTW, it looks like a patch that can be proposed. So, please send it as patch version for review /Krishna On 14 April 2016 at 10:50, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Hi, > > See under my proposal on

Re: [lng-odp] [PATCHv3] linux-generic:release memory during session destory

2016-03-23 Thread Krishna Garapati
It is referenced in the message. Fallowing is the commit id: f4404beac33ba8fab6edeb6587067c366cb8d4b1 /Krishna On 22 March 2016 at 18:48, Mike Holmes wrote: > The bug needs to be referenced in the git message, assume it is > https://bugs.linaro.org/show_bug.cgi?id=2127

Re: [lng-odp] Does ODP support DPDK flow director feature APIs?

2015-12-14 Thread Krishna Garapati
including odp team. /Krishna On 13 December 2015 at 20:40, Dapeng Liu wrote: > Hi Wenxian, > > I checked the API document but failed to find a exact matching function. > Just share my understanding with you. > > ODP has an event distribution model working as below: > 1)

Re: [lng-odp] [PATCHv4] example:generator:move verbose from worker to control

2015-08-20 Thread Krishna Garapati
+static void print_global_stats(int num_workers) +{ + uint64_t start, now, diff; + uint64_t pkts, pkts_prev = 0, pps, maximum_pps = 0; + int verbose_interval = 20, worker_count; + odp_thrmask_t thrd_mask; + + start = odp_time_cycles(); + while (1) { + now = odp_time_cycles();

Re: [lng-odp] [PATCHv7] example:generator:option to supply core mask

2015-08-19 Thread Krishna Garapati
Fixed all the comments in PATCHv8. On 19 August 2015 at 11:49, Stuart Haslam stuart.has...@linaro.org wrote: On Wed, Aug 12, 2015 at 10:55:12AM +0200, Balakrishna.Garapati wrote: Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- validate cpumask from parse_args and

Re: [lng-odp] [PATCHv5] example:generator:option to supply core mask

2015-08-18 Thread Krishna Garapati
Stuart, you have reviewed the old patch. please look at the PATCHv7 http://patches.opendataplane.org/patch/2723/; On 18 August 2015 at 16:45, Stuart Haslam stuart.has...@linaro.org wrote: On Mon, Aug 10, 2015 at 02:27:46PM +0200, Balakrishna.Garapati wrote: Signed-off-by:

Re: [lng-odp] [PATCHv4] example:generator:move verbose from worker to control

2015-08-13 Thread Krishna Garapati
Stuart, does this patch look ok ? On 7 August 2015 at 15:37, Maxim Uvarov maxim.uva...@linaro.org wrote: On 08/07/15 15:23, Krishna Garapati wrote: I will look into the API replacement. If I understood your comment correctly, I am already reusing the initial calculated num_workers

Re: [lng-odp] [PATCHv6] example:generator:option to supply core mask

2015-08-11 Thread Krishna Garapati
I will look at the suggestions and make the necessary changes. Thank you for the comments. On 11 August 2015 at 16:01, Maxim Uvarov maxim.uva...@linaro.org wrote: Hello Balakrishna, after some more thinking I think we not exactly right here. In parse: + case 'c': +

Re: [lng-odp] [PATCHv4] example:generator:option to supply core mask

2015-08-10 Thread Krishna Garapati
I will make another patch v5 with the changes. On 7 August 2015 at 16:24, Maxim Uvarov maxim.uva...@linaro.org wrote: Balakrishna, please also update usage() how to use thread mask here. And please find one commend inside. Best regards, Maxim. On 08/05/15 21:09, Balakrishna.Garapati

Re: [lng-odp] [PATCHv2] example:generator:move verbose from worker to control

2015-08-06 Thread Krishna Garapati
made changes and pushed new version v3. On 5 August 2015 at 18:39, Stuart Haslam stuart.has...@linaro.org wrote: On Tue, Aug 04, 2015 at 11:07:57AM +0200, Balakrishna.Garapati wrote: Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- Added packet rate stats

Re: [lng-odp] [PATCHv3] example:generator:option to supply core mask

2015-08-05 Thread Krishna Garapati
Fixed the comments in the new version. On 5 August 2015 at 19:13, Stuart Haslam stuart.has...@linaro.org wrote: On Thu, Jul 30, 2015 at 01:24:01PM +0200, Balakrishna.Garapati wrote: Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- changed the command line argument

Re: [lng-odp] [PATCH] example:generator:option to supply core mask

2015-07-30 Thread Krishna Garapati
just for the info, This patch only enables and sets the cpu masks correctly. Still working on the patch to fix the PING mode to run on the supplied cpu mask instead of hard coded cpu0. On 30 July 2015 at 10:02, Balakrishna.Garapati balakrishna.garap...@linaro.org wrote: Signed-off-by:

Re: [lng-odp] [PATCHv1] example:generator:option to supply core mask

2015-07-30 Thread Krishna Garapati
Ignore this patch. Pushing another one with PATCHv2. On 30 July 2015 at 12:54, Balakrishna.Garapati balakrishna.garap...@linaro.org wrote: Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- Fixed cpu_mask for PING mode. The mask is set to what is actually supplied.

Re: [lng-odp] [PATCH] example:generator:option to supply core mask

2015-07-30 Thread Krishna Garapati
I agree. I can make the changes. On 30 July 2015 at 12:58, Stuart Haslam stuart.has...@linaro.org wrote: On Thu, Jul 30, 2015 at 10:02:46AM +0200, Balakrishna.Garapati wrote: Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- This patch also includes changes to

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-29 Thread Krishna Garapati
May be we can create an other task for this?. Steve mentioned that this verbose is kind of urgent for the multi-node LAVA environment. Let me know your views. /Krishna On 29 July 2015 at 16:40, Stuart Haslam stuart.has...@linaro.org wrote: On Wed, Jul 29, 2015 at 05:13:40PM +0300, Maxim Uvarov

Re: [lng-odp] ODP timer behavior

2015-07-27 Thread Krishna Garapati
] total send: %ju\n, thr, odp_atomic_load_u64(counters.seq)); } All the variables are 64 bit types. /Krishna On 27 July 2015 at 19:06, Krishna Garapati balakrishna.garap...@linaro.org wrote: I am using x86_64 bit Arch. /Krishna On 27 July

Re: [lng-odp] ODP timer behavior

2015-07-27 Thread Krishna Garapati
I am using x86_64 bit Arch. /Krishna On 27 July 2015 at 18:50, Christophe Milard christophe.mil...@linaro.org wrote: I wild guess you are using a 32 bit value and 10*ODP_TIME_SEC does not fit. (please confirm) Christophe On 27 July 2015 at 18:46, Krishna Garapati balakrishna.garap

[lng-odp] ODP timer behavior

2015-07-27 Thread Krishna Garapati
Hi, As part odp_generator verbose update, I am trying to use 10*ODP_TIME_SEC ( Second in nsec - api/time.h ) to keep the generator update stats for every 10 secs. When I try to test this scenario, seems like it's not actually considering this as actual 10 sec instead as 1 sec. Just wondering if

[lng-odp] Will be on vacation fr 22/07 - 27/07

2015-07-21 Thread Krishna Garapati
Hi, I will be on vacation this week starting from tomorrow. Will be back on Monday 27th. /Krishna ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCHV1] example:generator:print correct appl_mode

2015-07-09 Thread Krishna Garapati
Wrong version. Sent an other patch with correct version v2. Ignore this patch. /Krishna On 9 July 2015 at 16:00, Balakrishna.Garapati balakrishna.garap...@linaro.org wrote: Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- example/generator/odp_generator.c | 6 --

Re: [lng-odp] [PATCH] example:printing correct appl_mode

2015-07-09 Thread Krishna Garapati
PRINT_APPL_MODE prints #mode (string) mode (0,1 or 2). if we pass appl_args-mode, it prints this as a string instead of ex: APPL_MODE_PING. On 9 July 2015 at 15:48, Maxim Uvarov maxim.uva...@linaro.org wrote: On 07/09/15 16:43, Mike Holmes wrote: Subject should localize to the specific

Re: [lng-odp] Requirement specs to update the odp generator

2015-07-03 Thread Krishna Garapati
like Wireshark sample captures https://wiki.wireshark.org/SampleCaptures and send them to a DUT for validation testing. On Thu, Jul 2, 2015 at 7:25 AM, Krishna Garapati balakrishna.garap...@linaro.org wrote: Hi, I like to start the discussion thread here to gather the the requirements

[lng-odp] Requirement specs to update the odp generator

2015-07-02 Thread Krishna Garapati
Hi, I like to start the discussion thread here to gather the the requirements to test the odp scheduling capabilities. That would be the input for updating odp generator for demo purpose. Some of the proposed requirements I heard are, 1) using multiple flows of simple traffic 2) IPSec traffic