Re: [lng-odp] [PATCH] travis: linux-gen: add dpdk pktio

On 11/18/16 22:29, Anders Roxell wrote: On 18 November 2016 at 14:05, Maxim Uvarov <maxim.uva...@linaro.org> wrote: On 11/18/16 12:06, Anders Roxell wrote: On 7 November 2016 at 16:49, Maxim Uvarov <maxim.uva...@linaro.org> wrote: Turn on linux-generic dpdk and

[lng-odp] [PATCH] test: tm: do lookup first then open

First tests will open pktio and all others will look up handle by name. Change order of open/lookup to not call fail opens. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- .../validation/api/traffic_mngr/traffic_mngr.c| 15 --- 1 file changed, 8 insertions

Re: [lng-odp] [PATCH v2] travis.yml: add coverity support

On 11/18/16 21:34, Mike Holmes wrote: Enables static analysis when pushing to a branch coverity_scan on github See https://scan.coverity.com/travis_ci Signed-off-by: Mike Holmes --- v2: Include all the executables in the scan (Maxim) .travis.yml | 20

Re: [lng-odp] [PATCH] travis: linux-gen: add dpdk pktio

Merged. On 11/17/16 22:56, Mike Holmes wrote: On 7 November 2016 at 10:49, Maxim Uvarov <maxim.uva...@linaro.org> wrote: Turn on linux-generic dpdk and pcap pktios with their validation tests. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> Reviewed-by: Mike Holm

Re: [lng-odp] [PATCH] test: linux-gen: mmap_vlan_ins change bin to test programs

Merged, Maxim. On 11/18/16 19:49, Mike Holmes wrote: On 17 November 2016 at 10:44, Maxim Uvarov <maxim.uva...@linaro.org> wrote: Generated binaries should be marked as test programs to be installed by autotools in test directory. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org&g

Re: [lng-odp] [PATCH] changelog: summary of changes for odp v1.10.2.0

I think Monarch branch with his changelog changes has to be merged in master. Then this changes will update version to v1.11.0.0 And after that current changelog updates version to v1.11.1.0 Please see structure here: https://git.linaro.org/people/maxim.uvarov/odp.git/log/ (gitk or git log

Re: [lng-odp] [PATCH] test: linux-gen: mmap_vlan_ins change bin to test programs

ping, please review. Maxim. On 11/17/16 18:44, Maxim Uvarov wrote: Generated binaries should be marked as test programs to be installed by autotools in test directory. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- test/linux-generic/mmap_vlan_ins/Makefile.am | 2 +-

[lng-odp] [PATCH] test: linux-gen: mmap_vlan_ins change bin to test programs

Generated binaries should be marked as test programs to be installed by autotools in test directory. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- test/linux-generic/mmap_vlan_ins/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/linux-g

Re: [lng-odp] [API-NEXT PATCH v3 00/19] pool optimization

sometimes, most times not. It happens both at the tip of the master and api-next. -Petri -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Wednesday, November 16, 2016 10:03 PM To: Bill Fischofer <bill.fischo...@linaro.org>; Savolainen, Petri (Nokia - FI

Re: [lng-odp] [API-NEXT PATCH v3 00/19] pool optimization

our case 'pktio_main' binary rolls in infinite loop. So I would say it's different issues. Maxim. -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Wednesday, November 16, 2016 10:03 PM To: Bill Fischofer <bill.fischo...@linaro.org>; Savolainen, Petri (No

Re: [lng-odp] [API-NEXT PATCH 0/5] name argument definitions in *_create() functions

Merged, Maxim. On 11/16/16 13:43, Elo, Matias (Nokia - FI/Espoo) wrote: Ping. This patch set has been reviewed and tested. Reviewed-and-tested-by: Bill Fischofer > Reviewed-by: Petri Savolainen

[lng-odp] mail list issues

Hello, we have some mailing list issues. If your did not get response on some email please check that email appeared in archive: https://lists.linaro.org/pipermail/lng-odp/ If not, please send it again. I hope it will be fixed very soon. Maxim.

Re: [lng-odp] [API-NEXT PATCH v3 17/19] api: packet: added limits for packet len on alloc

On 11/11/16 13:50, Savolainen, Petri (Nokia - FI/Espoo) wrote: + /** Maximum packet length that will be allocated from + the pool. The maximum value is defined by pool + capability pkt.max_len. Use 0 for default (the +

Re: [lng-odp] [PATCH 1/2] api: crypto: Adding crypto authentication algorithm

patch has to be prefixed with API-NEXT PATCH On 11 November 2016 at 11:27, Balakrishna Garapati < balakrishna.garap...@linaro.org> wrote: > Signed-off-by: Balakrishna Garapati > --- > include/odp/api/spec/crypto.h | 5 + > 1 file changed, 5 insertions(+) >

Re: [lng-odp] [API-NEXT PATCH 1/3] drv: shm: function to query for physical addresses

On 11/10/16 20:21, Christophe Milard wrote: The capability "can_getphy" is introduced and tells whether physical address queries are available. The function odpdrv_getphy() is added to query for physical address (from virtual address) Signed-off-by: Christophe Milard

Re: [lng-odp] [API-NEXT PATCH v3 17/19] api: packet: added limits for packet len on alloc

On 11/10/16 14:07, Petri Savolainen wrote: There's no use case for application to allocate zero length packets. Application should always have some knowledge about the new packet data length before allocation. Also implementations are more efficient when a check for zero length is avoided. Also

Re: [lng-odp] [PATCHv4] linux-generic: add vlan insertion test

Merged, Maxim. On 11/08/16 21:45, Mike Holmes wrote: On 8 November 2016 at 09:55, Maxim Uvarov <maxim.uva...@linaro.org <mailto:maxim.uva...@linaro.org>> wrote: linux-generic packet mmap has separate function to put back vlan tags which stripped out by linux kerne

[lng-odp] [PATCHv4] linux-generic: add vlan insertion test

linux-generic packet mmap has separate function to put back vlan tags which stripped out by linux kernel. This test is to add code coverage for this function with receiving vlan traffic from veth device. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- v4: add check for root

Re: [lng-odp] [API-NEXT PATCHv2 4/5] linux-gen: implementation of odp_load_driver function

On 11/08/16 17:15, Christophe Milard wrote: On 8 November 2016 at 15:06, Maxim Uvarov <maxim.uva...@linaro.org> wrote: are there any system for linux-generic platform where dlopen is not supported? I think that we don't need ifdefs. Are you saying we should limit us to plain linux? inc

Re: [lng-odp] [API-NEXT PATCHv2 3/5] api: init: driver load function added

On 11/08/16 17:09, Christophe Milard wrote: On 8 November 2016 at 14:56, Maxim Uvarov <maxim.uva...@linaro.org> wrote: On 11/07/16 14:15, Christophe Milard wrote: Function added on the north API to load drivers. Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> --

Re: [lng-odp] [API-NEXT PATCHv2 5/5] test: adding test for driver load function

On 11/07/16 14:15, Christophe Milard wrote: Trying to fix a proper structure for driver tests in the hard world of autotools: Staticaly linked drivers fails with autotools as the linker would need the "--whole-archive" option which autotools cannot handle. Trying to used ltdl lib does not seem

Re: [lng-odp] [API-NEXT PATCHv2 4/5] linux-gen: implementation of odp_load_driver function

are there any system for linux-generic platform where dlopen is not supported? I think that we don't need ifdefs. Maxim. On 11/07/16 14:15, Christophe Milard wrote: Implementation of the driver loading function, of north API Signed-off-by: Christophe Milard

Re: [lng-odp] [API-NEXT PATCHv2 3/5] api: init: driver load function added

On 11/07/16 14:15, Christophe Milard wrote: Function added on the north API to load drivers. Signed-off-by: Christophe Milard --- include/odp/api/spec/init.h | 16 1 file changed, 16 insertions(+) diff --git a/include/odp/api/spec/init.h

[lng-odp] shared odp lib and threads creation

Hello, I added basic ODP input support for Suricata here: https://github.com/muvarov/suricata and now I think how it's better to resolve things with threads. Problem is that when we did dpdk port dpdk run it's workers at early init stage. Then called function passed as call back and dpdk

[lng-odp] [PATCH] travis: linux-gen: add dpdk pktio

Turn on linux-generic dpdk and pcap pktios with their validation tests. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- .travis.yml | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 0d1add3..1092cd0

Re: [lng-odp] [PATCH v2 2/2] add travis.yml for gitub automation

Merged, Maxim. On 10/28/16 19:24, Mike Holmes wrote: On 28 October 2016 at 10:16, Maxim Uvarov <maxim.uva...@linaro.org <mailto:maxim.uva...@linaro.org>> wrote: Mike, all crypto tests failed for me. On laptop I have "Version: 1.0.1f-1ubuntu2.19" w

Re: [lng-odp] [PATCHv2 1/1] validation: classification: fix TCP/UDP checksum update

ping, please review. Maxim. On 10/27/16 16:00, Balasubramanian Manoharan wrote: Fixes https://bugs.linaro.org/show_bug.cgi?id=2512 Signed-off-by: Balasubramanian Manoharan --- v2: Incorporates review comments .../api/classification/odp_classification_common.c

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement splice/reference apis

On 10/11/16 06:45, Bill Fischofer wrote: + +odp_packet_t odp_packet_ref(odp_packet_t pkt, uint32_t offset) +{ + odp_packet_t refpkt; + + if (pkt == ODP_PACKET_INVALID || offset >= odp_packet_len(pkt)) + return ODP_PACKET_INVALID; + + refpkt =

[lng-odp] [PATCHv3] linux-generic: add vlan insertion test

linux-generic packet mmap has separate function to put back vlan tags which stripped out by linux kernel. This test is to add code coverage for this function with receiving vlan traffic from veth device. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- v3: - do not point from

Re: [lng-odp] Deterministic Random Data in ODP

why random_r() can not be used for implementation? On 2 November 2016 at 17:27, Bill Fischofer wrote: > Background: > > The odp_random_data() API is currently being refined [1] to deprecate the > confusing use_entropy parameter in favor of an enum (odp_random_kind_t)

Re: [lng-odp] [RFC 1/4] timer: add odp_timer_pool_res()

_capabilities() to match other functions. On 25 October 2016 at 10:38, Brian Brooks wrote: > On 10/31 17:20:27, Bill Fischofer wrote: > > I've added this to tomorrow's ODP call to discuss, however some general > > comments: > > > > 1. These should be marked [RFC

Re: [lng-odp] [PATCHv2] linux-generic: add vlan insertion test

On 1 November 2016 at 12:43, Christophe Milard <christophe.mil...@linaro.org > wrote: > On 31 October 2016 at 20:53, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > > Use vlan tagged traffic for example validation test > > to add code coverage for pkt_mmap_vlan_ins

[lng-odp] [PATCHv2] linux-generic: add vlan insertion test

Use vlan tagged traffic for example validation test to add code coverage for pkt_mmap_vlan_insert() internal function. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- v2: update to current master. test/common_plat/validation/api/.gitignore | 1 + test/linux-generic/Makef

Re: [lng-odp] [PATCHv2] linux-gen: crypto: fix aes gcm decryption

On 31 October 2016 at 17:51, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > We should first initialize, then set up decryption > and only then push blocks for decryption. > https://bugs.linaro.org/show_bug.cgi?id=2571 > > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro

[lng-odp] [PATCHv2] linux-gen: crypto: fix aes gcm decryption

We should first initialize, then set up decryption and only then push blocks for decryption. https://bugs.linaro.org/show_bug.cgi?id=2571 Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- v2: clear reworking btw, it was tested here: https://s3.amazonaws.com/archive.travis-ci.or

[lng-odp] [PATCH] linux-gen: crypto: fix aes gcm decryption

We should first initialize, then set up decryption also and only then push blocks for decryption. https://bugs.linaro.org/show_bug.cgi?id=2571 Signed-off-by: Max Uvarov <muva...@gmail.com> Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- platform/linux-generic/odp_crypto.c

Re: [lng-odp] [PATCH v2 2/2] add travis.yml for gitub automation

will send a fix in few minutes :) Maxim. On 10/31/16 17:18, Maxim Uvarov wrote: I did test if the latest 1.1.1-dev ssl from github (master branch for today). And the same tests fail. Log is attached. Maxim. On 10/28/16 19:24, Mike Holmes wrote: On 28 October 2016 at 10:16, Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCHv6 05/13] api: shm: add flags to shm_reserve and function to find external mem

Petri, please review API patch. On 10/31/16 11:52, Christophe Milard wrote: The ODP_SHM_SINGLE_VA flag is created: when set (at odp_shm_reserve()), this flag guarantees that all ODP threads sharing this memory block will see the block at the same address (regadless of ODP thread type -pthread

Re: [lng-odp] [PATCH v2 2/2] add travis.yml for gitub automation

On 10/28/16 19:24, Mike Holmes wrote: On 28 October 2016 at 10:16, Maxim Uvarov <maxim.uva...@linaro.org <mailto:maxim.uva...@linaro.org>> wrote: Mike, all crypto tests failed for me. On laptop I have "Version: 1.0.1f-1ubuntu2.19" which is about the same

Re: [lng-odp] driver test autotools issue

On 10/28/16 16:58, Christophe Milard wrote: Hi, The ODP driver development is does not progress due to an autotool problem to which I didn't find any nice solution: INTRODUCTION: ODP will be given the possibility to "include" user space NIC drivers. By "include", I mean either staticaly

Re: [lng-odp] [PATCH v2 2/2] add travis.yml for gitub automation

Mike, all crypto tests failed for me. On laptop I have "Version: 1.0.1f-1ubuntu2.19" which is about the same as Travis uses. Do you see the same errors? Get:2 http://us-central1.gce.archive.ubuntu.com/ubuntu/ precise-updates/main libssl-dev amd64 1.0.1-4ubuntu5.38 [1,581 kB] Get:3

Re: [lng-odp] [PATCH] example: l3fwd: prevent possible use of uninitialised variables

Merged, Maxim. On 10/27/16 17:04, Bill Fischofer wrote: On Thu, Oct 27, 2016 at 8:42 AM, Matias Elo wrote: Fixes bug https://bugs.linaro.org/show_bug.cgi?id=2564 Signed-off-by: Matias Elo Reviewed-by: Bill Fischofer

Re: [lng-odp] [PATCH 1/2] test: perf: add new ordered pktio application

On 10/27/16 16:51, Elo, Matias (Nokia - FI/Espoo) wrote: Ping. On 11 Oct 2016, at 16:21, Matias Elo wrote: Add new test application for ordered queue functionality and performance validation. The application sets sequence numbers to incoming packets using ordered pktin

Re: [lng-odp] [PATCH 1/2] test: perf: add new ordered pktio application

On 10/27/16 16:51, Elo, Matias (Nokia - FI/Espoo) wrote: + "Usage: %s OPTIONS\n" >+ " E.g. %s -i eth0,eth1 -t 1\n" >+ " In the above example,\n" >+ " eth0 will send pkts to eth1 and vice versa\n" >+ " eth2 will send pkts to eth3 and vice versa\n"

Re: [lng-odp] [PATCH] linux-generic: packet: add fall through comments to parser

On 10/27/16 10:56, Elo, Matias (Nokia - FI/Espoo) wrote: Reviewed-by: Matias Elo On 26 Oct 2016, at 15:47, Bill Fischofer wrote: Address bug https://bugs.linaro.org/show_bug.cgi?id=2565 by adding comments to the parser's switch statement to

[lng-odp] [PATCH] linux-gen: sysinfo: check for overflow

In near future cpu mhz more likely will not overflow 64 bit value, but it makes sense to add assert for overflow check. https://bugs.linaro.org/show_bug.cgi?id=2425 Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- platform/linux-generic/arch/x86/odp_sysinfo_parse.c | 7 ++-

Re: [lng-odp] [PATCH] linux-generic: config: add missing doxygen documentation for abi macros

Merged, Maxim. On 10/19/16 18:01, Mike Holmes wrote: On 19 October 2016 at 08:09, Bill Fischofer wrote: Fix Bug https://bugs.linaro.org/show_bug.cgi?id=2553 by adding missing doxygen documentation for the internal macros ODP_ABI_COMPAT and _STATIC. Signed-off-by:

Re: [lng-odp] [PATCH] linux-generic: fix ISO C compiling issue with -Werror=pedantic

Merged, Maxim. On 10/25/16 04:55, Bill Fischofer wrote: On Mon, Oct 24, 2016 at 2:02 AM, > wrote: From: Xuelin Shi > ISO C does not allow extra ‘;’ outside of a

Re: [lng-odp] [PATCHv2] fix out of tree build

Merged, Maxim. On 10/26/16 00:05, Mike Holmes wrote: On 25 October 2016 at 16:28, Maxim Uvarov <maxim.uva...@linaro.org> wrote: Commit: eebd6b0 configure: the version cannot use a script Did generation of version.h which is done in $dest_dir. Includes paths have to be cor

[lng-odp] [PATCHv2] fix out of tree build

Commit: eebd6b0 configure: the version cannot use a script Did generation of version.h which is done in $dest_dir. Includes paths have to be corrected accordingly. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- v2: build.sh in some combination did not pass on v1, fix it

[lng-odp] [PATCH] fix out of tree build

Commit: eebd6b0 configure: the version cannot use a script Did generation of version.h which is done in $dest_dir. Includes paths have to be corrected accordingly. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- example/Makefile.inc | 3 ++- helper/Makef

Re: [lng-odp] [API-NEXT PATCHv2 1/3] api: dev: add device apis for numa support

On 10/24/16 22:56, Bill Fischofer wrote: Add the odp_dev_id() API used for NUMA support probably log also needs to be corrected with removing reference to NUMA. Maxim. Signed-off-by: Bill Fischofer --- Changes for v2: - Incorporate changes suggested by Petri

Re: [lng-odp] [PATCH v2 1/2] configure: the version cannot use a script

first patch is merged with Brian review. Will test second patch tomorrow. Maxim. On 10/21/16 21:40, Mike Holmes wrote: Use of a script in the autotools breaks github CI Define the API version in configure and reuse it in the code Benefits: removes dependence on scripts to build removes

Re: [lng-odp] [PATCH v3 1/5] example: l3fwd: add missing gitignores

Merged. On 10/21/16 17:31, Mike Holmes wrote: On 3 October 2016 at 07:49, Matias Elo wrote: Signed-off-by: Matias Elo Reviewed-by: Mike Holmes But I wonder if we should at some point ignore these in the root of

Re: [lng-odp] [PATCH 1/3] linux-gen: packet: enable parsing only selected packet header layers

Merged, Maxim. On 10/24/16 14:48, Elo, Matias (Nokia - FI/Espoo) wrote: Ping. This patch set has been reviewed and tested. -Matias On 21 Sep 2016, at 22.36, Bill Fischofer > wrote: For this series: Reviewed-and-tested-by: Bill

Re: [lng-odp] [PATCHv3] test: skip pktio_perf tests on 1 and 2 cpus machines

Merged, Maxim. On 10/21/16 17:12, Mike Holmes wrote: On 14 October 2016 at 07:51, Maxim Uvarov <maxim.uva...@linaro.org> wrote: Make check should skip the test instead of failing it. Test splits RX and TX cores for packet processing. Core 0 bind to control thread. So running machine

Re: [lng-odp] [PATCHv3] test: skip pktio_perf tests on 1 and 2 cpus machines

please review v3. Maxim. On 10/14/16 14:51, Maxim Uvarov wrote: Make check should skip the test instead of failing it. Test splits RX and TX cores for packet processing. Core 0 bind to control thread. So running machine should have at least 2 worker threads which is not enough on 1 and 2 cpus

Re: [lng-odp] [PATCH 02/10] linux-gen: pktio: do not free zero packets

On 10/20/16 14:52, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim Uvarov Sent: Wednesday, October 19, 2016 3:49 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 02/10] linux-gen

Re: [lng-odp] [PATCH 01/10] linux-gen: ipc: disable build of ipc pktio

On 10/20/16 15:00, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim Uvarov Sent: Wednesday, October 19, 2016 3:59 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 01/10] linux-gen: ipc

Re: [lng-odp] [PATCH 1/2] example: odp_timer_simple: decrease timer pool resolution

Merged both patches. Second one with my review only. Maxim. On 10/21/16 10:10, Kevin Wang wrote: Reviewed-by: Kevin Wang On 21 October 2016 at 14:17, Yi He wrote: Reply for Kevin Wang to add his review. Best Regards, Yi On 19 July 2016 at 02:29,

Re: [lng-odp] [PATCH v3 1/5] example: l3fwd: add missing gitignores

Does somebody review test this? Maxim. On 10/03/16 14:49, Matias Elo wrote: Signed-off-by: Matias Elo --- example/l3fwd/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/example/l3fwd/.gitignore b/example/l3fwd/.gitignore index 74e501f..3411830 100644

Re: [lng-odp] [API-NEXT PATCH] test: drv: shm: decrease test memory requirement

Merged, Maxim. On 10/21/16 11:21, Elo, Matias (Nokia - FI/Espoo) wrote: Reviewed-and-tested-by: Matias Elo -Original Message- From: Christophe Milard [mailto:christophe.mil...@linaro.org] Sent: Wednesday, October 19, 2016 5:30 PM To: bill.fischo...@linaro.org;

Re: [lng-odp] api-next needs update

Done. On 21 October 2016 at 11:21, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > Hi, > > Api-next needs a *quick* update to the latest level of master branch. > > There's now about 20 commit gap. For example, "Revert example: generator: > actually use

[lng-odp] [API-NEXT PATCH 4/4] linix-gen: pktio ipc: fix race with start 2 process at the same time

Fix race when 2 process start at the same time with delay slave until master will allow to map it's shared rings Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- .../include/odp_packet_io_ipc_internal.h | 2 ++ platform/linux-generic/pktio/ipc.c

[lng-odp] [API-NEXT PATCH 3/4] linix-gen: pktio ipc: allow the same pool name

Allow the same pool name for master and slave processes. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- .../linux-generic/include/odp_packet_io_ipc_internal.h | 2 -- platform/linux-generic/pktio/ipc.c | 17 +++-- test/linux-generic/pkt

[lng-odp] [API-NEXT PATCH 2/4] linux-gen: pktio ipc: remove ipc name space

Remove ipc name space and pass pid of master process to slave. If master does odp_pktio_open("ipc:name"), slave to connect to the same pktio referes to it by pid odp_pktio_open("ipc::name"). Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- platform/linux-gene

[lng-odp] [API-NEXT PATCH 1/4] linux-gen: pktio ipc: repair ipc pktio

Repair ipc after shared memory implementation and keep original logic. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- .../include/odp_packet_io_ipc_internal.h | 1 + platform/linux-generic/pktio/ipc.c | 104 +++-- platform/linux-g

[lng-odp] [API-NEXT PATCH 0/4] linix-gen: pktio ipc: recover after shm patches

First version of patches to recover ipc pktio after Christophe's serries for shm changes. Maxim Uvarov (4): linux-gen: pktio ipc: repair ipc pktio linux-gen: pktio ipc: remove ipc name space linix-gen: pktio ipc: allow the same pool name linix-gen: pktio ipc: fix race with start 2 process

Re: [lng-odp] [PATCH 04/10] linux-gen: align: added round up power of two

On 10/20/16 15:05, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim Uvarov Sent: Wednesday, October 19, 2016 4:01 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 04/10] linux-gen

Re: [lng-odp] [PATCH 04/10] linux-gen: align: added round up power of two

On 10/19/16 15:09, Petri Savolainen wrote: Added a macro to round up a value to the next power of two, if it's not already a power of two. Also removed duplicated code from the same file. Signed-off-by: Petri Savolainen ---

Re: [lng-odp] [PATCH 01/10] linux-gen: ipc: disable build of ipc pktio

On 10/19/16 15:09, Petri Savolainen wrote: IPC pktio implementation depends heavily on pool internals. It's build is disabled due to pool re-implementation. IPC should be re-implemented with a cleaner internal interface towards pool and shm. Signed-off-by: Petri Savolainen

Re: [lng-odp] [PATCH 03/10] linux-gen: ring: created common ring implementation

On 10/19/16 15:09, Petri Savolainen wrote: Moved scheduler ring code into a new header file, so that it can be used also in other parts of the implementation. Signed-off-by: Petri Savolainen --- platform/linux-generic/Makefile.am | 1 +

Re: [lng-odp] [PATCH 02/10] linux-gen: pktio: do not free zero packets

On 10/19/16 15:09, Petri Savolainen wrote: In some error cases, netmap and dpdk pktios were calling odp_packet_free_multi with zero packets. Moved existing error check to avoid a free call with zero packets. Signed-off-by: Petri Savolainen ---

Re: [lng-odp] [PATCH 2/2] add travis.yml for gitub automation

btw, can you also add call for: ./scripts/build-pktio-dpdk to compile dpdk pktio? And I think something similar for netmap. Maxim. On 10/18/16 19:06, Mike Holmes wrote: On 18 October 2016 at 11:52, Maxim Uvarov <maxim.uva...@linaro.org> wrote: On 10/18/16 18:24, Mike Holmes wrote:

Re: [lng-odp] [PATCH 2/2] add travis.yml for gitub automation

On 10/18/16 18:24, Mike Holmes wrote: allows pushes to a github clone of ODP to automatically trigger CI builds Signed-off-by: Mike Holmes --- .travis.yml | 35 +++ 1 file changed, 35 insertions(+) create mode 100644 .travis.yml

Re: [lng-odp] [API-NEXT PATCHv2 1/2] api: dev: add device apis for numa support

On 10/13/16 03:44, Bill Fischofer wrote: + +#ifndef ODP_API_DEV_H_ +#define ODP_API_DEV_H_ +#include + +#ifdef __cplusplus +extern "C" { +#endif + +#include + +/** @defgroup odp_dev ODP DEVICE + * Operations on devices + * @{ + */ + +/** + * @typedef odp_dev_t + * ODP Device + */ + +/** + *

Re: [lng-odp] [PATCH] timers: fix off by one tick in timer expiration processing

Merged. On 10/14/16 14:45, Mike Holmes wrote: also need to put Fixes https://bugs.linaro.org/show_bug.cgi?id=2552 I put this link to git log. Maxim. Into the patch description, maybe that can happen as it is pushed ? On 13 October 2016 at 17:46, Bill Fischofer

Re: [lng-odp] [PATCH] linux-generic: ticketlock: add missing doxygen for ticketlock_inlines.h

Merged, Maxim. On 10/14/16 18:03, Mike Holmes wrote: On 22 September 2016 at 15:04, Bill Fischofer wrote: Add the missing internal doxygen documentation for the ticketlock_inlines functions used to accelerate odp-linux even when building with

Re: [lng-odp] [PATCH] example: generator: actually use specified default

Retested this patch again. Now I can not reproduce issue. Merged. Maxim. On 10/12/16 21:42, Mike Holmes wrote: On 22 September 2016 at 10:33, Maxim Uvarov <maxim.uva...@linaro.org <mailto:maxim.uva...@linaro.org>> wrote: Reverted this patch due to have issues with

[lng-odp] [PATCHv3] test: skip pktio_perf tests on 1 and 2 cpus machines

and not fail on it. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- v3: update if logic (found just after apply.) v2: update description (Mike) test/common_plat/performance/odp_pktio_perf.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/test/commo

Re: [lng-odp] [PATCHv2] test: skip pktio_perf tests on 1 and 2 cpus machines

Reverted patch. I must be more careful with review my own patches. On 10/13/16 23:57, Mike Holmes wrote: On 13 October 2016 at 12:37, Maxim Uvarov <maxim.uva...@linaro.org <mailto:maxim.uva...@linaro.org>> wrote: Make check should skip the test instead of failing it.

Re: [lng-odp] [PATCHv2] test: skip pktio_perf tests on 1 and 2 cpus machines

Merged. I think it will be good to commit .travis.yml into repo. So that any git push to github will run tests. Maxim. On 10/13/16 23:57, Mike Holmes wrote: On 13 October 2016 at 12:37, Maxim Uvarov <maxim.uva...@linaro.org <mailto:maxim.uva...@linaro.org>> wrote: Make

Re: [lng-odp] [API-NEXT PATCH 1/5] api: improve name argument definitions in *_create() functions

On 10/14/16 11:49, Matias Elo wrote: The current APIs don't always define valid name argument values. Fix this by stating when NULL is a valid value and when the name string doesn't have to be unique. Signed-off-by: Matias Elo --- include/odp/api/spec/classification.h |

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

On 10/13/16 19:33, Mike Holmes wrote: Anders comments have not been addressed on the list, are they resloved ? In current patch set - no. Because it's subject for separate patch. But we need resolve version name before tagging. Maxim. On 13 October 2016 at 11:40, Maxim Uvarov <maxim.

[lng-odp] [PATCHv2] test: skip pktio_perf tests on 1 and 2 cpus machines

and not fail on it. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- v2: update description (Mike) test/common_plat/performance/odp_pktio_perf.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/test/common_plat/performance/odp_pktio_perf.c

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

Merged, we also need this option to be tested in CI. Maxim. On 10/12/16 18:21, Bill Fischofer wrote: This version resolves the issue with running from an installed copy of ODP. On Thu, Sep 29, 2016 at 6:46 PM, Petri Savolainen < petri.savolai...@nokia.com> wrote: Building ABI compatible or

Re: [lng-odp] ODPèDPDK Documentation & build

Try to clone it by name, not by IP address: git clone git://dpdk.org/dpdk Get this link from here: http://dpdk.org/dev and please be free to provide link correction patch. Maxim. On 11 October 2016 at 16:51, Elo, Matias (Nokia - FI/Espoo) < matias@nokia-bell-labs.com> wrote: > >

Re: [lng-odp] [API-NEXT PATCH 04/14] api: shm: add flag to guarantee address unicity on all ODP threads

On 10/07/16 13:35, Christophe Milard wrote: The ODP_SHM_SINGLE_VA flag is created: when set (at odp_shm_reserve()), this flag guarantees that all ODP threads sharing this memory block will see the block at the same address (regadless of ODP thread type -pthread vs process- or fork time)

Re: [lng-odp] [API-NEXT PATCH 06/14] api: shm: add flag to lock memory

On 10/07/16 13:35, Christophe Milard wrote: The ODP_SHM_LOCK flag is created: when set (at odp_shm_reserve()), this flag locks the reserved memory (prevent swapping) Signed-off-by: Christophe Milard --- include/odp/api/spec/shared_memory.h | 1 + 1 file

Re: [lng-odp] [API-NEXT PATCH 10/14] linux-gen: _ishm: adding function to map memory from other ODP

On 10/07/16 13:35, Christophe Milard wrote: functionality to export and map memory between ODP instance is added: This includes: - a bit of simplification in _odp_ishm_reserve() for externaly provided file descriptors. - a new function, _odp_ishm_reserve_exported() to map memory from other

Re: [lng-odp] [PATCH] validation: packet: remove todos from packet tests

ping, please review. Maxim. On 09/12/16 23:48, Bill Fischofer wrote: Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2405 by removing todos in packet validation test. Add additional tests for todos that can be resolved within current ODP API set and remove the rest to be deferred for

Re: [lng-odp] [PATCH 1/1] validation: classification: fix TCP/UDP checksum update

On 09/23/16 01:22, Bala Manoharan wrote: Yes. We have to free the packet and mark the test case as failure. Will update the same in next version. Regards, Bala Needed v2 here. Maxim.

Re: [lng-odp] [PATCH] test: skip pktio_perf tests on 1 and 2 cpus machines

please review. Maxim. On 09/23/16 16:44, Maxim Uvarov wrote: Make check should skip the test instead of failing it. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- test/common_plat/performance/odp_pktio_perf.c | 14 ++ 1 file changed, 10 insertions(+), 4 del

Re: [lng-odp] [PATCH] linux-gen: pktio: handle exit if ipc app was killed

ping, please review (after this patch ipc pktio test passes on odp-check). Maxim. On 09/07/16 23:50, Maxim Uvarov wrote: In test script let master process finish his work and don't try to kill him if killing can be avoided. If kill invoked than do not dequeue from empty rings. Also it looks

Re: [lng-odp] [PATCH] linux-gen: pktio: ipc: remove todos

Merged, Maxim. On 09/12/16 21:11, Mike Holmes wrote: On 8 September 2016 at 11:53, Maxim Uvarov <maxim.uva...@linaro.org <mailto:maxim.uva...@linaro.org>> wrote: Remove todo around copying packet data from shared pool as it's not a bug and can be considered as fu

Re: [lng-odp] [PATCH] linux-gen: using ODP instantiation pid as odp instance

Merged. Maxim. On 10/04/16 16:35, Christophe Milard wrote: Ping. This has been reviewed and agreed at ARCH call. Any reason not to merge? Christophe On 20 September 2016 at 04:34, Bill Fischofer wrote: On Mon, Sep 19, 2016 at 10:56 AM, Christophe Milard

[lng-odp] [PATCH] test: skip pktio_perf tests on 1 and 2 cpus machines

Make check should skip the test instead of failing it. Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> --- test/common_plat/performance/odp_pktio_perf.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/test/common_plat/performance/odp_pktio_perf.c

Re: [lng-odp] [PATCH] api:crypto: Adding IPSEC protocol APIs.

patch prefix has to be API-NEXT and comments <*! - looks very stange. At least we did not have such styled comments before. Maxim. On 09/23/16 18:42, Nikhil Agarwal wrote: TODO items: - Event Notification(Eg. Seq Number overflow, SA not found, SA hard/soft expiry) - statistics APIs - Encrpt

Re: [lng-odp] [PATCH v2 1/2] test: perf: add new scheduling latency test

Merged, Maxim. On 09/22/16 01:11, Brian Brooks wrote: For series: Reviewed-and-tested-by: Brian Brooks On 09/14 11:53:06, Matias Elo wrote: Add new scheduling latency benchmark application. The application measures delays (avg, min, max) for high and low priority

Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

that was merged but doxygen needs refining: /opt/Linaro/odp3.git/platform/linux-generic/include/odp/api/plat/ticketlock_inlines.h:21: warning: Member _odp_ticketlock_lock(odp_ticketlock_t *ticketlock) (function) of file ticketlock_inlines.h is not documented.

<    4   5   6   7   8   9   10   11   12   13   >