Signed-off-by: Nicolas Morey-Chaisemartin
---
include/odp/api/buffer.h | 26 ++
1 file changed, 26 insertions(+)
diff --git a/include/odp/api/buffer.h b/include/odp/api/buffer.h
index aea273f..6631f47 100644
--- a/include/odp/api/buffer.h
+++ b/include/odp/api/buffer.h
For the moment just a simple wrapper around buffer_alloc to be used by
odp_buffer_alloc_multi and odp_packet_alloc_multi
Signed-off-by: Nicolas Morey-Chaisemartin
---
platform/linux-generic/include/odp_buffer_internal.h | 2 ++
platform/linux-generic/odp_pool.c| 14
* Test do not make asumptions on the amount of buffer returned
* Add more test coverage
* Free to multiple pools at once
* Alloc more than pool contains
* etc.
v2:
* Fix prototypes
* Add alloc_multi functions
* Add implementations
* Add tests
Nicolas Morey-Chaisemartin (7):
api
ed-off-by: Nicolas Morey-Chaisemartin
---
scripts/checkpatch.pl | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4983a0c..893da37 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3411,7 +3411,7
On 10/08/2015 12:43 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>> -Original Message-
>> From: EXT Nicolas Morey-Chaisemartin [mailto:nmo...@kalray.eu]
>> Sent: Thursday, October 08, 2015 12:43 PM
>> To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@list
On 10/08/2015 11:38 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>> -Original Message-
>> From: EXT Nicolas Morey-Chaisemartin [mailto:nmo...@kalray.eu]
>> Sent: Thursday, October 08, 2015 11:16 AM
>> To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@list
Ping
On 09/10/2015 05:22 PM, Nicolas Morey-Chaisemartin wrote:
> This allows better readability, and make supporting ordered queues
> easier for other platforms
>
> Signed-off-by: Nicolas Morey-Chaisemartin
> ---
> platform/linux-generic
On 09/30/2015 12:47 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>> -Original Message-
>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
>> Nicolas Morey-Chaisemartin
>> Sent: Tuesday, September 29, 2015 5:16 PM
>> To: ln
You could probably generate a convenience library with both merged as a
single.a/.la file ?
I feel it would also be better for an end user to have a single library if we
start having cyclic dependencies.
Nicolas
On 10/06/2015 04:07 PM, Maxim Uvarov wrote:
> Hello,
>
> We had patch Rujiacs to do
request as much as possible
* If there are buffer left, push them to the queue.
On pktio_perf with loop interface, I see ~10% speedup with this patch
Signed-off-by: Nicolas Morey-Chaisemartin
---
platform/linux-generic/odp_packet_io.c | 17 -
1 file changed, 12 insertions(+), 5
Hi all,
Now that pktio have start/stop status and begin as stopped by default, I was
wondering if it would make sense to make sure they are stopped before closing
them.
Either by returning an error code if they aren't, or calling it implicitly in
the odp_pktio_close function.
The reason i'm lo
With both these asserts remove, it's good for me.
Nicolas
On 10/05/2015 01:26 PM, Maxim Uvarov wrote:
> On 10/05/15 13:25, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>>> -Original Message-
>>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behal
On 09/16/2015 09:53 AM, Maxim Uvarov wrote:
> + pkt_ref = odp_packet_create_ref(pkt);
> + /* Handles should be different */
> + CU_ASSERT(pkt != pkt_ref);
> + /* Debug print also should have refcount bits */
> + CU_ASSERT(odp_packet_to_u64(pkt) !=
> + odp_packet_
On 10/01/2015 05:05 PM, Bill Fischofer wrote:
> odp_packet_copy() can copy between pools, which may have different sized
> user areas, hence the size checks.
Ok. But then does it make sense to copy a subpart of the user data ?
If dst user_area >= src user_area it's going to work well but in the o
On 09/30/2015 12:22 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>> -Original Message-
>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
>> Nicolas Morey-Chaisemartin
>> Sent: Tuesday, September 29, 2015 5:16 PM
>> To: ln
On 09/29/2015 04:34 PM, Bill Fischofer wrote:
> On Tue, Sep 29, 2015 at 9:15 AM, Nicolas Morey-Chaisemartin <
> nmo...@kalray.eu> wrote:
>
>
>> +
>> +/**
>> * Free packet
>> *
>> * Frees the packet into the buffer pool it was all
On 09/29/2015 07:02 PM, Nicolas Morey-Chaisemartin wrote:
>
>
> On 09/29/2015 04:31 PM, Bill Fischofer wrote:
>>
>>
>> On Tue, Sep 29, 2015 at 9:15 AM, Nicolas Morey-Chaisemartin
>> wrote:
>>
>> Signed-off-by: Nicolas
On 09/29/2015 04:34 PM, Bill Fischofer wrote:
>
>
> On Tue, Sep 29, 2015 at 9:15 AM, Nicolas Morey-Chaisemartin <mailto:nmo...@kalray.eu>> wrote:
>
> Signed-off-by: Nicolas Morey-Chaisemartin <mailto:nmo...@kalray.eu>>
> ---
On 09/29/2015 04:31 PM, Bill Fischofer wrote:
>
>
> On Tue, Sep 29, 2015 at 9:15 AM, Nicolas Morey-Chaisemartin <mailto:nmo...@kalray.eu>> wrote:
>
> Signed-off-by: Nicolas Morey-Chaisemartin <mailto:nmo...@kalray.eu>>
> ---
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/packet/packet.c | 48 +
test/validation/packet/packet.h | 1 +
2 files changed, 49 insertions(+)
diff --git a/test/validation/packet/packet.c b/test/validation/packet/packet.c
index 0c749c3
Signed-off-by: Nicolas Morey-Chaisemartin
---
platform/linux-generic/odp_packet.c | 28
1 file changed, 28 insertions(+)
diff --git a/platform/linux-generic/odp_packet.c
b/platform/linux-generic/odp_packet.c
index 209a6e6..5a1e870 100644
--- a/platform/linux
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/buffer/buffer.c | 82 +
test/validation/buffer/buffer.h | 2 +
2 files changed, 84 insertions(+)
diff --git a/test/validation/buffer/buffer.c b/test/validation/buffer/buffer.c
index c62938d
Signed-off-by: Nicolas Morey-Chaisemartin
---
platform/linux-generic/odp_pool.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/platform/linux-generic/odp_pool.c
b/platform/linux-generic/odp_pool.c
index 9036147..d4f6f14 100644
--- a/platform/linux-generic/odp_pool.c
+++ b
For the moment just a simple wrapper around buffer_alloc to be used by
odp_buffer_alloc_multi and odp_packet_alloc_multi
Signed-off-by: Nicolas Morey-Chaisemartin
---
platform/linux-generic/include/odp_buffer_internal.h | 2 ++
platform/linux-generic/odp_pool.c| 14
Signed-off-by: Nicolas Morey-Chaisemartin
---
include/odp/api/packet.h | 28
1 file changed, 28 insertions(+)
diff --git a/include/odp/api/packet.h b/include/odp/api/packet.h
index 5d46b7b..c220329 100644
--- a/include/odp/api/packet.h
+++ b/include/odp/api/packet.h
Signed-off-by: Nicolas Morey-Chaisemartin
---
include/odp/api/buffer.h | 25 +
1 file changed, 25 insertions(+)
diff --git a/include/odp/api/buffer.h b/include/odp/api/buffer.h
index aea273f..ec53ce8 100644
--- a/include/odp/api/buffer.h
+++ b/include/odp/api/buffer.h
prototypes
* Add alloc_multi functions
* Add implementations
* Add tests
Nicolas Morey-Chaisemartin (7):
api: buffer: add functions to alloc/free multiple buffers at once
api: packet: add functions to alloc/free multiple packets at once
linux-generic: pool: add buffer_alloc_multi function
On 09/29/2015 01:04 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>> -Original Message-
>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
>> EXT Nicolas Morey-Chaisemartin
>> Sent: Tuesday, September 29, 2015 11:43 AM
>> To: Bala
On 09/29/2015 10:40 AM, Bala Manoharan wrote:
> On 29 September 2015 at 13:48, Nicolas Morey-Chaisemartin
> wrote:
>> Signed-off-by: Nicolas Morey-Chaisemartin
>> ---
>> include/odp/api/packet.h | 11 +++
>> 1 file changed, 11 insertions(+)
>>
>
Signed-off-by: Nicolas Morey-Chaisemartin
---
include/odp/api/buffer.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/odp/api/buffer.h b/include/odp/api/buffer.h
index aea273f..ce13237 100644
--- a/include/odp/api/buffer.h
+++ b/include/odp/api/buffer.h
@@ -113,6 +113,16
Signed-off-by: Nicolas Morey-Chaisemartin
---
include/odp/api/packet.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/odp/api/packet.h b/include/odp/api/packet.h
index 5d46b7b..a73be01 100644
--- a/include/odp/api/packet.h
+++ b/include/odp/api/packet.h
@@ -86,6 +86,17
make sense to add alloc_multi function too. I'd gladly post a
patch if that's something you find interesting
Nicolas Morey-Chaisemartin (2):
api: buffer: add function to free multiple buffers at once
api: packet: add function to free multiple packets at once
include/odp/api/buf
On 09/29/2015 08:28 AM, Matias Elo wrote:
> Added new netmap pktio interface type which operates in the
> same manner as the existing socket io interfaces. The code
> is based on the odp-netmap branch.
>
> Using netmap io requires netmap headers and loaded netmap
> kernel module. Netmap can be in
Add extra mode to disable inputs and/or outputs from a packet io.
This can be used to make pktio read-only, write-only or R/W.
Depending on the chosen mode, platform implementation may be able
to reduce usage of H/W resources.
Signed-off-by: Nicolas Morey-Chaisemartin
---
include/odp/api
Drop packets counts both packets dropped by calls to pktio_send()
and packet which were flagged with errors during parsing.
Add an extra counter to differ these two types of packets.
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/performance/odp_l2fwd.c | 15 ++-
1 file changed
Polling the link status makes sense but isn't setting the link state a bit
redundant with pktio start/stop ?
On 09/17/2015 03:56 PM, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov
> ---
> include/odp/api/packet_io.h | 22 ++
> 1 file changed, 22 insertions(+)
>
> diff --g
On 09/14/2015 11:14 AM, Nicolas Morey-Chaisemartin wrote:
> Remove duplicated code and use preexisting metadata copy function
>
> Signed-off-by: Nicolas Morey-Chaisemartin
> ---
> platform/linux-generic/odp_packet.c | 34 ++
> 1 file cha
Remove duplicated code and use preexisting metadata copy function
Signed-off-by: Nicolas Morey-Chaisemartin
---
platform/linux-generic/odp_packet.c | 34 ++
1 file changed, 2 insertions(+), 32 deletions(-)
diff --git a/platform/linux-generic/odp_packet.c
b
On 09/11/2015 03:25 AM, Bill Fischofer wrote:
> Fix Bug https://bugs.linaro.org/show_bug.cgi?id=1803 by ensuring that
> enqueues are directed at a buffer's target rather than origin queue.
>
> Signed-off-by: Bill Fischofer
Reviewed-by: Nicolas Morey-Chaisemartin
> ---
>
Signed-off-by: Nicolas Morey-Chaisemartin
---
platform/linux-generic/include/odp_queue_internal.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/platform/linux-generic/include/odp_queue_internal.h
b/platform/linux-generic/include/odp_queue_internal.h
index 19a0f07..5747277 100644
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/pktio/pktio.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c
index 5c0799b..735e2a0 100644
--- a/test/validation/pktio/pktio.c
+++ b/test
This allows better readability, and make supporting ordered queues
easier for other platforms
Signed-off-by: Nicolas Morey-Chaisemartin
---
platform/linux-generic/odp_queue.c | 225 +
1 file changed, 127 insertions(+), 98 deletions(-)
diff --git a/platform
Ping?
On 08/26/2015 04:06 PM, Nicolas Morey-Chaisemartin wrote:
> no_barrier and no_lock tests are expected to fail but when
> running a single worker, they do work
>
> Signed-off-by: Nicolas Morey-Chaisemartin
> ---
> test/validation/synchronizers/synchronizers.c | 10 ++
On 09/10/2015 09:23 AM, Ivan Khoronzhuk wrote:
> Nicolas,
>
> On 09.09.15 16:38, Ivan Khoronzhuk wrote:
>>
>>
>> On 09.09.15 16:27, Ivan Khoronzhuk wrote:
>>>
>>>
>>> On 09.09.15 15:44, Savolainen, Petri (Nokia - FI/Espoo) wrote:
> -Original Message-
> From: EXT Ivan Kho
ly want to allow a 200+ character line because
> of this exception?
>
> On Wed, Sep 9, 2015 at 4:06 AM, Nicolas Morey-Chaisemartin <mailto:nmo...@kalray.eu>> wrote:
>
> The default behaviour of checkpatch is to allow long lines
> for log functions if they use an unsegm
ait forever, as 0 corresponds to
> ODP_SCHED_WAIT, it can block program flow at all.
>
> Signed-off-by: Ivan Khoronzhuk
Reviewed-by: Nicolas Morey-Chaisemartin
> ---
>
> Prerequisit for this patch was taken from:
> "[lng-odp] [Patch] validation: scheduler: increase time
On 09/09/2015 11:00 AM, Maxim Uvarov wrote:
> ODP has api to request available number of workers. Now
> no need limit that inside application.
>
> Signed-off-by: Maxim Uvarov
Reviewed-by: Nicolas Morey-Chaisemartin
> ---
> v3: account that thread_tbl calloc can fail.
>
This fixes #1746
Signed-off-by: Nicolas Morey-Chaisemartin
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4983a0c..d36b8a9 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -307,6 +
On 09/09/2015 09:49 AM, Maxim Uvarov wrote:
> On 09/09/15 10:24, Nicolas Morey-Chaisemartin wrote:
>>
>> On 09/08/2015 01:05 PM, Maxim Uvarov wrote:
>>> ODP has api to request available number of workers. Now
>>> no need limit that inside application.
&g
Ping?
On 08/31/2015 01:52 PM, Christophe Milard wrote:
> On 2015-08-27 18:47, Nicolas Morey-Chaisemartin wrote:
>> log_fn is never called when --disable-debug-print was passed to
>> configure which causes replacement_logging_used to stay at 0
>>
>> Signed-off-by:
; - odp_cpumask_def_worker(&cpumask, arg->numthrds);
> + num = odp_cpumask_def_worker(&cpumask, arg->numthrds);
> + thread_tbl = calloc(sizeof(odph_linux_pthread_t), num);
Maybe add a check of the return value here? Everything else looks good
Reviewed-by: Nicolas Morey-Chaisem
ping ?
On 09/01/2015 02:51 PM, Bill Fischofer wrote:
> On Tue, Sep 1, 2015 at 7:50 AM, Nicolas Morey-Chaisemartin > wrote:
>> Signed-off-by: Nicolas Morey-Chaisemartin
>>
> Reviewed-by: Bill Fischofer
>
>
>> ---
>> v3:
>> Packet for add_rem_data i
This one won't apply on master anymore:
Applying: linux-generic: pktio: extend maximum devname length
error: patch failed: platform/linux-generic/odp_packet_io.c:239
error: platform/linux-generic/odp_packet_io.c: patch does not apply
Patch failed at 0001 linux-generic: pktio: extend maximum devnam
On 09/04/2015 03:20 PM, Stuart Haslam wrote:
> Create a new pktio type that allows for reading from and writing to a
> pcap capture file. This is intended to be used as a simple way of
> injecting test packets into an application for functional testing and
> can be used as it is with some of the
bug ID 1787.
>
> Signed-off-by: Christophe Milard
Reviewed-by: Nicolas Morey-Chaisemartin
> ---
>
> since v1: libodp changed to libtest following discussion with
> Maxim
>
> test/validation/buffer/Makefile.am | 6 +++---
> test/validation/classification/Makefile.am
On 09/08/2015 03:33 PM, Ola Liljedahl wrote:
> Sorry I missed this discussion. It is really interesting. IMO the
> linux-generic scheduler is too simplistic to be used as is or its behaviour
> copied. We have seen some undesirable behaviour in our internal work where we
> use ODP. Very simplif
;http://libtestcrypto.la> <http://libtestcrypto.la>" would be good enough for
> me.
>
> Christophe.
>
>
> how about libodptest_crypto.a?
>
> Maxim.
>
>
> On 7 September 2015 at 10:34, Maxim Uvarov <mailto:maxim.uva...@linaro.org> <ma
think
> there will be again problem with autotools.
>
> Because all this libraries are temporary and will not be packaged it's
> reasonable to underline
> it in name prefix.
>
> How about:
>
> libodpv_tmp_crypto.a?
>
> Maxim.
>
> On 09/03/15 19:16, Nicolas Mo
ly it can lead to wait forever ODP_SCHED_WAIT (0).
>
>
> On Thu, Sep 3, 2015 at 1:28 AM, Ivan Khoronzhuk
> mailto:ivan.khoronz...@linaro.org>
> <mailto:ivan.khoronz...@linaro.org <mailto:ivan.khoronz...@linaro.org>>>
> wrote:
>
>
>
>
> From: "Bill Fischofer"
> To: "Nicolas Morey-Chaisemartin"
> Cc: "LNG ODP Mailman List" , "Maxim Uvarov"
>
> Sent: Thursday, 3 September, 2015 6:19:52 PM
> Subject: Re: [lng-odp] [PATCHv2 6/8] linux-generic: queue: correct handling
bug ID 1787.
>
> Signed-off-by: Christophe Milard
Reviewed-by: Nicolas Morey-Chaisemartin
> ---
> test/validation/buffer/Makefile.am | 6 +++---
> test/validation/classification/Makefile.am | 6 +++---
> test/validation/cpumask/Makefile.am| 8
> t
On 09/03/2015 05:16 PM, Bill Fischofer wrote:
> @@ -910,23 +897,28 @@ int release_order(queue_entry_t *origin_qe, uint64_t
> order,
> order_release(origin_qe, 1);
>
> /* Check if this release allows us to unblock waiters.
> - * Note that we can only pro
On 09/03/2015 02:47 PM, Maxim Uvarov wrote:
> On 09/01/15 17:14, Nicolas Morey-Chaisemartin wrote:
>> Otherwise looks good.
> will fix on apply. Can I set you review-by then?
>
> Maxim.
Yes.
Nicolas
___
lng-odp mailing list
lng-od
rrors are fairly easy to reprocude (at least 1 out of 10 run)
On 09/03/2015 01:53 PM, Bill Fischofer wrote:
> Can you share more details about your setup? Number of threads, etc.?
> Thanks.
>
> On Thu, Sep 3, 2015 at 4:28 AM, Nicolas Morey-Chaisemartin <mailto:nmo...@kalray.e
On 09/03/2015 08:37 AM, Maxim Uvarov wrote:
> On 09/03/15 09:29, Nicolas Morey-Chaisemartin wrote:
>> Just a question a bit beside the point:
>> What is the policy about API-NEXT?
>>
>> I was very surprised to see that the api-next branch was merged to master
>&
I still have errors once in a while after applying this series
Test: scheduler_test_multi_mq_mt_prio_o ...FAILED
1. scheduler.c:427 - bctx->sequence == qctx->lock_sequence
2. scheduler.c:427 - bctx->sequence == qctx->lock_sequence
3. scheduler.c:427 - bctx->sequence == qctx->lock_s
Just a question a bit beside the point:
What is the policy about API-NEXT?
I was very surprised to see that the api-next branch was merged to master just
a few commits before the release.
I would have expected it to be merge right after v1.3.0.0 tag so we have a
fairly tested master being releas
On 09/02/2015 11:16 PM, Ivan Khoronzhuk wrote:
>
>
> On 02.09.15 12:42, Nicolas Morey-Chaisemartin wrote:
>>
>> On 08/26/2015 05:47 PM, Ivan Khoronzhuk wrote:
>>>
>>>
>>> On 26.08.15 18:22, Stuart Haslam wrote:
>>>> On Wed, Aug 26,
On 08/26/2015 05:47 PM, Ivan Khoronzhuk wrote:
>
>
> On 26.08.15 18:22, Stuart Haslam wrote:
>> On Wed, Aug 26, 2015 at 06:11:13PM +0300, Ivan Khoronzhuk wrote:
>>> It's needed because time resolution can be a little more than 1ns
>>> and in this case odp_schedule_wait_time(1) returns 0, and test
The odp_scheduler() requires time value in its own ticks, so
pass scheduler wait time instead of ns.
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/pktio/pktio.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/test/validation/pktio/pktio.c b/test
off-by: Nicolas Morey-Chaisemartin
Cc: Ivan Khoronzhuk
---
test/validation/pktio/pktio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c
index b136419..b985e81 100644
--- a/test/validation/pktio/pktio.c
+++ b/test/v
n on api-next and on master.
> git clean -f -d -x before compilation should help.
>
> Maxim.
>
>
> On 09/02/15 10:57, Nicolas Morey-Chaisemartin wrote:
>> Hi,
>>
>> Since all tests were moved to Library I have been hitting the same bug over
>> and over in
Actual check/changes of the pktio state is now done by the pktio
global interface.
Each pktio can still implement a start/stop function to do additional
actions.
Signed-off-by: Nicolas Morey-Chaisemartin
---
platform/linux-generic/odp_packet_io.c | 15 +++
platform/linux-generic
Hi,
Since all tests were moved to Library I have been hitting the same bug over and
over in the build system.
Often when I pull master and try to rebuild from a pre existing build, I have
this error:
libtool: link: rm -fr .libs/libcrypto.a .libs/libcrypto.la
libtool: link: (cd .libs/libcrypto.l
On 08/28/2015 02:59 PM, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov
> ---
> v2: more detailed description.
>
> include/odp/api/packet_io.h | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
> in
On 09/01/2015 03:57 PM, Maxim Uvarov wrote:
> On 09/01/15 16:50, Nicolas Morey-Chaisemartin wrote:
>>
>> On 09/01/2015 03:45 PM, Maxim Uvarov wrote:
>>> On 09/01/15 16:36, Nicolas Morey-Chaisemartin wrote:
>>>> (sorry for the previous mail, thunderbird misfir
On 09/01/2015 03:45 PM, Maxim Uvarov wrote:
> On 09/01/15 16:36, Nicolas Morey-Chaisemartin wrote:
>> (sorry for the previous mail, thunderbird misfired)
>>
>> On 08/28/2015 11:00 AM, Maxim Uvarov wrote:
>>> On 08/28/15 10:55, Nicolas Morey-Chaisemartin wrote:
&
(sorry for the previous mail, thunderbird misfired)
On 08/28/2015 11:00 AM, Maxim Uvarov wrote:
> On 08/28/15 10:55, Nicolas Morey-Chaisemartin wrote:
>> Sorry for the late comment.
>>
>> I noticed something odd. The last patch states that pktio are stopped by
>> defau
On 08/28/2015 11:00 AM, Maxim Uvarov wrote:
> On 08/28/15 10:55, Nicolas Morey-Chaisemartin wrote:
>> Sorry for the late comment.
>>
>> I noticed something odd. The last patch states that pktio are stopped by
>> default.
>> However patches 3 to 5 all set the s
On 08/28/2015 02:41 PM, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov
Reviewed-by: Nicolas Morey-Chaisemartin
> ---
> v2: - add function to check supported cnts;
> - add optional functio to reset cnts;
>
> include/odp/api/packet_io_stats.h
Signed-off-by: Nicolas Morey-Chaisemartin
---
v3:
Packet for add_rem_data is now packet_len so we can add tail data when
segmentation is not supported
v2:
Patch cleanup based on Bill feedback
test/validation/packet/packet.c | 35 +++
1 file changed, 27
On 08/25/2015 02:55 PM, Nicolas Morey-Chaisemartin wrote:
> sizeof(struct udata_struct));
> memcpy(udat, &test_packet_udata, sizeof(struct udata_struct));
>
> - /* Insert one more packet length in the middle of a packet */
> offset = pkt_len /
On 09/01/2015 12:39 PM, Maxim Uvarov wrote:
> On 09/01/15 11:45, Nicolas Morey-Chaisemartin wrote:
>> Hi,
>>
>> I'm having a small issue with the performance/scheduler test. It requires
>> clock_gettime which is not necessary available on every platform (inclu
Hi,
I'm having a small issue with the performance/scheduler test. It requires
clock_gettime which is not necessary available on every platform (including
some of our compilation modes).
The config.h file generated by configure contains a define HAVE_CLOCK_GETTIME
which could be used. But it doe
On 08/31/2015 06:06 PM, Benoît Ganne wrote:
> Signed-off-by: Benoît Ganne
> ---
> .../include/odp_classification_datamodel.h | 2 ++
> .../include/odp_classification_inlines.h | 21 +++
> platform/linux-generic/odp_classification.c| 42
> -
On 08/28/2015 03:59 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>> -Original Message-
>> From: ext Nicolas Morey-Chaisemartin [mailto:nmo...@kalray.eu]
>> Sent: Friday, August 28, 2015 4:40 PM
>> To: Savolainen, Petri (Nokia - FI/Espoo); LNG ODP Mailma
On 08/28/2015 01:56 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>> -Original Message-
>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
>> ext Nicolas Morey-Chaisemartin
>> Sent: Friday, August 28, 2015 11:57 AM
>> To: LNG ODP
Hi all,
I'm currently diving into the scheduler code from linux-generic to understand
how it works and try to write an optimize version for our HW.
Maybe I missed something, but I think there is a big fairness issue there.
Let me sum up what I get. We will stick with only one priority to make i
Sorry for the late comment.
I noticed something odd. The last patch states that pktio are stopped by
default.
However patches 3 to 5 all set the state to START when open is called.
>@@ -39,6 +41,7 @@ static int loopback_open(odp_pktio_t id, pktio_entry_t
>*pktio_entry,
> if (pktio_entry->
log_fn is never called when --disable-debug-print was passed to
configure which causes replacement_logging_used to stay at 0
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/init/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/init/init.c
this behavior.
>
> If appropriate let me send my fix for checkpatch upstream and maybe we can
> pick it up in ODP 1.4, but for now, this does pass our rules :)
>
> I can use it find the missing cases you identified as a test for my fix.
>
> Mike
>
> On 26 August 20
no_barrier and no_lock tests are expected to fail but when
running a single worker, they do work
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/synchronizers/synchronizers.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/test/validation
-name *.c -exec ./scripts/odp_check
> {} \;
>
> I expect the same is needed for test and examples, that may be the
> difference ?
>
>
> On 25 August 2015 at 12:17, Nicolas Morey-Chaisemartin
> wrote:
>
>> I tried to check your patch against the large one I propose
I tried to check your patch against the large one I proposed before and see
many differences.
Did you willingly leave some of these behind? Or did you use a regexp which
missed some?
Nicolas
On 08/25/2015 05:26 PM, Mike Holmes wrote:
> Checkpatch requires that:
> (entry == NULL) be written (!en
Signed-off-by: Nicolas Morey-Chaisemartin
---
v2:
Patch cleanup based on Bill feedback
test/validation/packet/packet.c | 33 ++---
1 file changed, 26 insertions(+), 7 deletions(-)
diff --git a/test/validation/packet/packet.c b/test/validation/packet/packet.c
index
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/packet/packet.c | 40 ++--
1 file changed, 30 insertions(+), 10 deletions(-)
diff --git a/test/validation/packet/packet.c b/test/validation/packet/packet.c
index 99a6745..d6dd3eb 100644
--- a/test
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/pktio/pktio.c | 73 ---
test/validation/pktio/pktio.h | 3 +-
2 files changed, 64 insertions(+), 12 deletions(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c
Signed-off-by: Nicolas Morey-Chaisemartin
---
example/generator/odp_generator.c | 1 -
example/ipsec/odp_ipsec.c | 1 -
example/packet/odp_pktio.c | 1 -
.../linux-generic/include/odp_packet_io_internal.h | 1 -
platform
Fixes bug #1670
Signed-off-by: Nicolas Morey-Chaisemartin
---
platform/linux-generic/include/odp_packet_socket.h | 3 -
platform/linux-generic/pktio/socket.c | 85 +++---
2 files changed, 57 insertions(+), 31 deletions(-)
diff --git a/platform/linux-generic
at 0 to maximize fragmentation.
Platform that do not support fragmentation should pass theses tests
successfully as in their case SEG_LEN_MIN is the maximum packet size.
Nicolas Morey-Chaisemartin (3):
linux-generic: pktio: remove basic socket implementation
linux-generic: pktio: handle
301 - 400 of 650 matches
Mail list logo
