[lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Dmitry Eremin-Solenikov
Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 56 +++- 1 file

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Bill Fischofer
On Fri, Apr 14, 2017 at 9:39 AM, Dmitry Eremin-Solenikov wrote: > On 14.04.2017 17:35, Bill Fischofer wrote: >> Perhaps something like: >> >> typedef enum odp_feature_t { >> ODP_FEATURE_UNSUPPORTED = 0, >> ODP_FEATURE_SUPPORTED = 1, >>

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Dmitry Eremin-Solenikov
On 14.04.2017 17:35, Bill Fischofer wrote: > Perhaps something like: > > typedef enum odp_feature_t { > ODP_FEATURE_UNSUPPORTED = 0, > ODP_FEATURE_SUPPORTED = 1, > ODP_FEATURE_PREFERRED = 2, > } odp_feature_t; I've asked for the advice about the header file, where to

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Bill Fischofer
Perhaps something like: typedef enum odp_feature_t { ODP_FEATURE_UNSUPPORTED = 0, ODP_FEATURE_SUPPORTED = 1, ODP_FEATURE_PREFERRED = 2, } odp_feature_t; On Fri, Apr 14, 2017 at 8:49 AM, Dmitry Eremin-Solenikov wrote: > On 14.04.2017

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Dmitry Eremin-Solenikov
On 14.04.2017 16:25, Bill Fischofer wrote: > On Fri, Apr 14, 2017 at 6:53 AM, Bala Manoharan > wrote: >> Regards, >> Bala >> >> >> On 14 April 2017 at 16:52, Bill Fischofer wrote: >>> On Fri, Apr 14, 2017 at 5:58 AM, Dmitry Eremin-Solenikov

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Bill Fischofer
On Fri, Apr 14, 2017 at 6:53 AM, Bala Manoharan wrote: > Regards, > Bala > > > On 14 April 2017 at 16:52, Bill Fischofer wrote: >> On Fri, Apr 14, 2017 at 5:58 AM, Dmitry Eremin-Solenikov >> wrote: >>>

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Bala Manoharan
Regards, Bala On 14 April 2017 at 16:52, Bill Fischofer wrote: > On Fri, Apr 14, 2017 at 5:58 AM, Dmitry Eremin-Solenikov > wrote: >> Instead of having magic 0-1-2 numbers, let's have the special enum for >> feature support levels

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Bill Fischofer
On Fri, Apr 14, 2017 at 5:58 AM, Dmitry Eremin-Solenikov wrote: > Instead of having magic 0-1-2 numbers, let's have the special enum for > feature support levels (unsupported/supported/preferred). > > Signed-off-by: Dmitry Eremin-Solenikov

[lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Dmitry Eremin-Solenikov
Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 56 +++- 1 file