Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

2015-12-04 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Thursday, December 03, 2015 8:27 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet u

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

2015-12-03 Thread Zoltan Kiss
On 03/12/15 09:52, Savolainen, Petri (Nokia - FI/Espoo) wrote: Why? Why do you need to access the packet, when it's not yet a packet (at init time)? You'll get handle after the packet is received (when it's a packet). I think I've explained it several times why this whole thing is necessary,

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

2015-12-03 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > Why? Why do you need to access the packet, when it's not yet a packet > (at init time)? You'll get handle after the packet is received (when it's > a packet). > > I think I've explained it several times why this whole thing is > necessary, but let me try again: OVS needs to store the packet ha

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

2015-12-01 Thread Zoltan Kiss
] api: pool: redefine packet user area init On 30/11/15 13:31, Savolainen, Petri (Nokia - FI/Espoo) wrote: diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h index 01f770f..7b258c3 100644 --- a/include/odp/api/pool.h +++ b/include/odp/api/pool.h @@ -42,21 +42,25 @@ extern &q

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

2015-12-01 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Monday, November 30, 2015 8:13 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user > area

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

2015-11-30 Thread Zoltan Kiss
On 30/11/15 13:31, Savolainen, Petri (Nokia - FI/Espoo) wrote: diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h index 01f770f..7b258c3 100644 --- a/include/odp/api/pool.h +++ b/include/odp/api/pool.h @@ -42,21 +42,25 @@ extern "C" { #define ODP_POOL_NAME_LEN 32 /** - * Pac

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

2015-11-30 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h > > index 01f770f..7b258c3 100644 > > --- a/include/odp/api/pool.h > > +++ b/include/odp/api/pool.h > > @@ -42,21 +42,25 @@ extern "C" { > > #define ODP_POOL_NAME_LEN 32 > > > > /** > > - * Packet user area initializer callback

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

2015-11-30 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > + > > + /** 0: User area content may be > overwritten when > > + packet is stored in the pool. If > init > > + callback function is defined, it > is > > +

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

2015-11-27 Thread Bala Manoharan
Hi Petri, Comments inline... On 27 November 2015 at 19:52, Petri Savolainen wrote: > User area is either persistent or non-persistent. Init is > called only once for persistent user area. Init is additionally > called for non-persistent area when needed (when ODP overwrites > previously initiali

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

2015-11-27 Thread Zoltan Kiss
On 27/11/15 14:22, Petri Savolainen wrote: User area is either persistent or non-persistent. Init is called only once for persistent user area. Init is additionally called for non-persistent area when needed (when ODP overwrites previously initialized user area or when user area is truely non-p

[lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

2015-11-27 Thread Petri Savolainen
User area is either persistent or non-persistent. Init is called only once for persistent user area. Init is additionally called for non-persistent area when needed (when ODP overwrites previously initialized user area or when user area is truely non-persistent). Signed-off-by: Petri Savolainen -