Re: [lng-odp] [API-NEXT PATCH 1/2] api: linux-generic: no need to define odp_time_null()

2015-12-09 Thread Bill Fischofer
Sorry, my mistake. I had assumed that using odp_time_null() rather than _odp_time_null() was because it was implementing an external API. However that does raise the question of whether odp_time_null() or ODP_TIME_NULL should be part of the external API. On Wed, Dec 9, 2015 at 10:29 AM, Maxim

[lng-odp] [API-NEXT PATCH 1/2] api: linux-generic: no need to define odp_time_null()

2015-12-09 Thread Maxim Uvarov
No need to define odp_time_null() as it only initialize to 0 time. Remove it completely with needed to add doxygen comment for it. Signed-off-by: Maxim Uvarov --- platform/linux-generic/include/odp/plat/time_types.h | 4 +--- platform/linux-generic/odp_time.c

Re: [lng-odp] [API-NEXT PATCH 1/2] api: linux-generic: no need to define odp_time_null()

2015-12-09 Thread Maxim Uvarov
On 12/09/2015 19:33, Bill Fischofer wrote: Sorry, my mistake. I had assumed that using odp_time_null() rather than _odp_time_null() was because it was implementing an external API. However that does raise the question of whether odp_time_null() or ODP_TIME_NULL should be part of the external

Re: [lng-odp] [API-NEXT PATCH 1/2] api: linux-generic: no need to define odp_time_null()

2015-12-09 Thread Ivan Khoronzhuk
On 09.12.15 20:24, Maxim Uvarov wrote: On 12/09/2015 19:33, Bill Fischofer wrote: Sorry, my mistake. I had assumed that using odp_time_null() rather than _odp_time_null() was because it was implementing an external API. However that does raise the question of whether odp_time_null() or

Re: [lng-odp] [API-NEXT PATCH 1/2] api: linux-generic: no need to define odp_time_null()

2015-12-09 Thread Ivan Khoronzhuk
On 09.12.15 18:29, Maxim Uvarov wrote: On 12/09/2015 19:26, Bill Fischofer wrote: This is proposing an API change. It's OK to change how odp_time_null() is implemented in linux-generic, but we can't arbitrarily remove this public API from the linux-generic implementation. But it's not

Re: [lng-odp] [API-NEXT PATCH 1/2] api: linux-generic: no need to define odp_time_null()

2015-12-09 Thread Ivan Khoronzhuk
On 09.12.15 18:33, Bill Fischofer wrote: Sorry, my mistake. I had assumed that using odp_time_null() rather than _odp_time_null() was because it was implementing an external API However that does raise the question of whether odp_time_null() or ODP_TIME_NULL should be part of the external