Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-19 Thread Bill Fischofer
On Wed, Jul 19, 2017 at 2:40 AM, Maxim Uvarov wrote: > > > On 19 July 2017 at 01:13, Bill Fischofer > wrote: > >> >> >> On Tue, Jul 18, 2017 at 2:42 PM, Maxim Uvarov >> wrote: >> >>> On 07/18/17 21:24, Bill Fischofer

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-19 Thread Maxim Uvarov
On 19 July 2017 at 01:13, Bill Fischofer wrote: > > > On Tue, Jul 18, 2017 at 2:42 PM, Maxim Uvarov > wrote: > >> On 07/18/17 21:24, Bill Fischofer wrote: >> > >> > >> > On Tue, Jul 18, 2017 at 11:52 AM, Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-18 Thread Bill Fischofer
On Tue, Jul 18, 2017 at 2:42 PM, Maxim Uvarov wrote: > On 07/18/17 21:24, Bill Fischofer wrote: > > > > > > On Tue, Jul 18, 2017 at 11:52 AM, Maxim Uvarov > > wrote: > > > > On 07/18/17 19:20, Bill Fischofer

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-18 Thread Maxim Uvarov
On 07/18/17 21:24, Bill Fischofer wrote: > > > On Tue, Jul 18, 2017 at 11:52 AM, Maxim Uvarov > wrote: > > On 07/18/17 19:20, Bill Fischofer wrote: > > As agreed during today's ODP Public call: > > > > APIs for MTU

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-18 Thread Bill Fischofer
On Tue, Jul 18, 2017 at 11:52 AM, Maxim Uvarov wrote: > On 07/18/17 19:20, Bill Fischofer wrote: > > As agreed during today's ODP Public call: > > > > APIs for MTU capability and setting OK. Applications should remember that > > in most cases they will not be authorized

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-18 Thread Challa, Mahipal
Thanks Bill for the details. We will work accordingly. Regards, Mahipal From: Bill Fischofer Sent: ‎18-‎07-‎2017 09:50 PM To: Bogdan Pricope Cc: Peltonen, Janne (Nokia -

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-18 Thread Maxim Uvarov
On 07/18/17 19:20, Bill Fischofer wrote: > As agreed during today's ODP Public call: > > APIs for MTU capability and setting OK. Applications should remember that > in most cases they will not be authorized to set the MTU since this relates > to physical properties of the interface. > >

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-18 Thread Bill Fischofer
As agreed during today's ODP Public call: APIs for MTU capability and setting OK. Applications should remember that in most cases they will not be authorized to set the MTU since this relates to physical properties of the interface. odp_pktio_capability() should report number of mac addrs

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-17 Thread Bogdan Pricope
Hi, In DPDK case, default MTU is 1500: /* * Set the default MTU. */ eth_dev->data->mtu = ETHER_MTU; where: #define ETHER_MTU \ (ETHER_MAX_LEN - ETHER_HDR_LEN - ETHER_CRC_LEN) /**< Ethernet MTU. */ So, if you need to jumbo, you have to set MTU yourself (I guess dpdk will

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-14 Thread Bill Fischofer
On Fri, Jul 14, 2017 at 10:09 AM, Peltonen, Janne (Nokia - FI/Espoo) < janne.pelto...@nokia.com> wrote: > Hi, > > > > I think MAC addresses and MTU are a bit different. > > > > There are valid use cases for application wanting to set the MAC address, > even dynamically. For instance, with VRRP

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-14 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, I think MAC addresses and MTU are a bit different. There are valid use cases for application wanting to set the MAC address, even dynamically. For instance, with VRRP one wants to receive packets destined to a VRRP MAC address in addition to the fixed MAC address of a port. The

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-14 Thread Bill Fischofer
On Fri, Jul 14, 2017 at 9:11 AM, Bogdan Pricope wrote: > Hi, > > I think we need both MTU and MAC address to be settable from ODP. > > In OFP, at some point I was considering using tap pktio instead of ofp > tap interface for slow path processing - not being able to

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-14 Thread Bogdan Pricope
Hi, I think we need both MTU and MAC address to be settable from ODP. In OFP, at some point I was considering using tap pktio instead of ofp tap interface for slow path processing - not being able to set MAC address was A problem. What about DHCP by MAC address? Maybe there are systems where

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-14 Thread Bill Fischofer
On Fri, Jul 14, 2017 at 8:41 AM, Narayana Prasad Athreya < pathr...@caviumnetworks.com> wrote: > Hi Bill > The reasons below dont jive with what ODP does today. If the routines > odp_pktio_mtu() and odp_pktio_mac_addr() exist today. They assume that MTU > can be configured and returned to

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-14 Thread Narayana Prasad Athreya
Hi Bill The reasons below dont jive with what ODP does today. If the routines odp_pktio_mtu() and odp_pktio_mac_addr() exist today. They assume that MTU can be configured and returned to the datapath. As an application developer, it does make sense for me to use 2 different paths to talk

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-14 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, ODP API should somewhere define what exactly MTU means in the context of ODP. One can guess that transmission and reception of L2 frames larger than the configured MTU is not guaranteed to succeed, but which bytes are taken into account? For instance, is Ethernet FCS counted towards the

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-14 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Vamsi > Attunuru > Sent: Friday, July 14, 2017 1:05 PM > To: lng-odp@lists.linaro.org > Cc: mcha...@cavium.com; pathr...@cavium.com; vattun...@cavium.com; > sve...@cavium.com > Subject: [lng-odp]

[lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-14 Thread Vamsi Attunuru
Adds new pktio APIs to set MTU and MAC address on pktio interface. Signed-off-by: Vamsi Attunuru Signed-off-by: Mahipal Challa Signed-off-by: Shally Verma --- include/odp/api/spec/packet_io.h | 45