From: Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Friday, April 28, 2017 10:09 PM
To: Petri Savolainen
Cc: lng-odp-forward
Subject: Re: [lng-odp] [API-NEXT PATCH v3 01/11] api: time: remove
odp_time_to_u64 from API
I agree that the validation test for odp_time_to_u64() is
Aside from the deprecation question, for this series:
Reviewed-and-tested-by: Bill Fischofer
Also, Parts 9 and 11 are fine but both cause checkpatch to hiccup:
bill@Ubuntu64:~/linaro/hubodp$ ./scripts/checkpatch.pl
0009-linux-gen-time-use-hw-time-counter-when-available.patch
Unescaped left brac
On 04/28/17 22:09, Bill Fischofer wrote:
> I agree that the validation test for odp_time_to_u64() is suspect and
> should be fixed, but why remove this API? We've established that various
> abstract types have odp_xxx_to_u64() routines designed for debugging use
> and this makes odp_time_t an excep
I agree that the validation test for odp_time_to_u64() is suspect and
should be fixed, but why remove this API? We've established that various
abstract types have odp_xxx_to_u64() routines designed for debugging use
and this makes odp_time_t an exception to that rule.
Also, shouldn't we deprecate
Debug function that converts odp_time_t to u64 is unnecessary
since odp_time_to_ns() returns time as a u64 (nsec) value.
Application can always use that as the 64 bit representation
of an odp_time_t value. Also validation tests for odp_time_to_u64()
were erroneous since those compared returned u64
