Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Jerin Jacob
On Thu, Aug 20, 2015 at 03:20:46PM +0100, Zoltan Kiss wrote: Hi, On 20/08/15 11:53, Jerin Jacob wrote: How about following change in OVS plarform specific packet_get_hash code. odp_packet_rss_hash_set kind of interface wont fit correctly in octeon platform as hash identifier used by

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Zoltan Kiss
On 20/08/15 17:55, Jerin Jacob wrote: On Thu, Aug 20, 2015 at 03:20:46PM +0100, Zoltan Kiss wrote: Hi, On 20/08/15 11:53, Jerin Jacob wrote: How about following change in OVS plarform specific packet_get_hash code. odp_packet_rss_hash_set kind of interface wont fit correctly in octeon

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Santosh Shukla
On 20 August 2015 at 14:48, Balasubramanian Manoharan bala.manoha...@linaro.org wrote: On Sunday 16 August 2015 06:14 PM, Santosh Shukla wrote: On 15 August 2015 at 00:12, Zoltan Kiss zoltan.k...@linaro.org wrote: Applications can read the computed hash (if any) and set it if they changed

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Santosh Shukla
On 20 August 2015 at 16:23, Jerin Jacob jerin.ja...@caviumnetworks.com wrote: On Thu, Aug 20, 2015 at 03:30:23PM +0530, Santosh Shukla wrote: On 20 August 2015 at 14:48, Balasubramanian Manoharan bala.manoha...@linaro.org wrote: On Sunday 16 August 2015 06:14 PM, Santosh Shukla wrote:

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Bill Fischofer
The RSS is relevant to packets originating from a NIC and is independent of the CoS or other flow designators. It's there mainly because some applications (e.g., OVS) use it internally, so it's for legacy support. On Thu, Aug 20, 2015 at 6:43 AM, Jerin Jacob jerin.ja...@caviumnetworks.com

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Jerin Jacob
On Thu, Aug 20, 2015 at 04:52:29PM +0530, Santosh Shukla wrote: On 20 August 2015 at 16:23, Jerin Jacob jerin.ja...@caviumnetworks.com wrote: On Thu, Aug 20, 2015 at 03:30:23PM +0530, Santosh Shukla wrote: On 20 August 2015 at 14:48, Balasubramanian Manoharan bala.manoha...@linaro.org

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Jerin Jacob
On Thu, Aug 20, 2015 at 03:30:23PM +0530, Santosh Shukla wrote: On 20 August 2015 at 14:48, Balasubramanian Manoharan bala.manoha...@linaro.org wrote: On Sunday 16 August 2015 06:14 PM, Santosh Shukla wrote: On 15 August 2015 at 00:12, Zoltan Kiss zoltan.k...@linaro.org wrote:

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Zoltan Kiss
On 20/08/15 12:43, Jerin Jacob wrote: IMO, The term RSS may not be correct in API definition. May be something like flow id, make sense across all platform. Good idea. I'll replace rss with flow instead. ___ lng-odp mailing list

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Zoltan Kiss
On 20/08/15 17:43, Bill Fischofer wrote: Remember that the purpose of RSS is simply to help spread arriving packets to different receiving CPUs. Also, the RSS has itself is not static. It takes as input the RSS key, which defines the packet fields over which the hash is calculated, and the

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Jacob, Jerin
ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values The RSS is relevant to packets originating from a NIC and is independent of the CoS or other flow designators. It's there mainly because some applications (e.g., OVS) use

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Bala Manoharan
Hi, On 20 August 2015 at 17:32, Bill Fischofer bill.fischo...@linaro.org wrote: The RSS is relevant to packets originating from a NIC and is independent of the CoS or other flow designators. It's there mainly because some applications (e.g., OVS) use it internally, so it's for legacy

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-20 Thread Bill Fischofer
Remember that the purpose of RSS is simply to help spread arriving packets to different receiving CPUs. Also, the RSS has itself is not static. It takes as input the RSS key, which defines the packet fields over which the hash is calculated, and the low order bits of it are used as an index into

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-16 Thread Santosh Shukla
On 15 August 2015 at 00:12, Zoltan Kiss zoltan.k...@linaro.org wrote: Applications can read the computed hash (if any) and set it if they changed the packet headers or if the platform haven't calculated the hash. Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- v2: - focus on RSS hash

[lng-odp] [API-NEXT PATCH v3 1/3] api: packet: allow access to packet RSS hash values

2015-08-14 Thread Zoltan Kiss
Applications can read the computed hash (if any) and set it if they changed the packet headers or if the platform haven't calculated the hash. Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- v2: - focus on RSS hash only - use setter/getter's v3: - do not mention pointers - add a note - add