Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-22 Thread Bill Fischofer
On Thu, Dec 22, 2016 at 9:07 AM, Bala Manoharan wrote: > On 21 December 2016 at 19:45, Bill Fischofer > wrote: >> On Wed, Dec 21, 2016 at 6:42 AM, Bala Manoharan >> wrote: >>> Regards, >>> Bala >>> >>> >>> On 20 December 2016 at 22:35, Bill Fischofer >>> wrote: On Tue, Dec 20, 2016 at 8:

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-22 Thread Bala Manoharan
On 21 December 2016 at 19:45, Bill Fischofer wrote: > On Wed, Dec 21, 2016 at 6:42 AM, Bala Manoharan > wrote: >> Regards, >> Bala >> >> >> On 20 December 2016 at 22:35, Bill Fischofer >> wrote: >>> On Tue, Dec 20, 2016 at 8:26 AM, Bala Manoharan >>> wrote: On 20 December 2016 at 18:26, B

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-21 Thread Bill Fischofer
On Wed, Dec 21, 2016 at 6:42 AM, Bala Manoharan wrote: > Regards, > Bala > > > On 20 December 2016 at 22:35, Bill Fischofer > wrote: >> On Tue, Dec 20, 2016 at 8:26 AM, Bala Manoharan >> wrote: >>> On 20 December 2016 at 18:26, Bill Fischofer >>> wrote: On Tue, Dec 20, 2016 at 5:59 AM, B

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-21 Thread Bala Manoharan
Regards, Bala On 20 December 2016 at 22:35, Bill Fischofer wrote: > On Tue, Dec 20, 2016 at 8:26 AM, Bala Manoharan > wrote: >> On 20 December 2016 at 18:26, Bill Fischofer >> wrote: >>> On Tue, Dec 20, 2016 at 5:59 AM, Bala Manoharan >>> wrote: Regards, Bala On 19 D

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-20 Thread Bill Fischofer
On Tue, Dec 20, 2016 at 8:26 AM, Bala Manoharan wrote: > On 20 December 2016 at 18:26, Bill Fischofer > wrote: >> On Tue, Dec 20, 2016 at 5:59 AM, Bala Manoharan >> wrote: >>> Regards, >>> Bala >>> >>> >>> On 19 December 2016 at 20:23, Bill Fischofer >>> wrote: On Mon, Dec 19, 2016 at 4:

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-20 Thread Bala Manoharan
On 20 December 2016 at 18:26, Bill Fischofer wrote: > On Tue, Dec 20, 2016 at 5:59 AM, Bala Manoharan > wrote: >> Regards, >> Bala >> >> >> On 19 December 2016 at 20:23, Bill Fischofer >> wrote: >>> On Mon, Dec 19, 2016 at 4:06 AM, Bala Manoharan >>> wrote: Comments inline >

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-20 Thread Bill Fischofer
On Tue, Dec 20, 2016 at 5:59 AM, Bala Manoharan wrote: > Regards, > Bala > > > On 19 December 2016 at 20:23, Bill Fischofer > wrote: >> On Mon, Dec 19, 2016 at 4:06 AM, Bala Manoharan >> wrote: >>> Comments inline >>> >>> >>> On 15 November 2016 at 20:14, Bill Fischofer >>> wrote: In

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-20 Thread Bala Manoharan
Regards, Bala On 19 December 2016 at 20:23, Bill Fischofer wrote: > On Mon, Dec 19, 2016 at 4:06 AM, Bala Manoharan > wrote: >> Comments inline >> >> >> On 15 November 2016 at 20:14, Bill Fischofer >> wrote: >>> Introduce three new APIs that support efficient sharing of portions of >>> pa

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Bill Fischofer
On Mon, Dec 19, 2016 at 1:22 PM, Maxim Uvarov wrote: > On 12/19/16 19:41, Bill Fischofer wrote: >> On Mon, Dec 19, 2016 at 9:57 AM, Maxim Uvarov >> wrote: >>> how about group all packet reference apis to odp_packet_ref_ naming? >>> >>> In that case >>> >>> odp_packet_ref() -> odp_packet_ref_crea

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Maxim Uvarov
On 12/19/16 19:41, Bill Fischofer wrote: > On Mon, Dec 19, 2016 at 9:57 AM, Maxim Uvarov wrote: >> how about group all packet reference apis to odp_packet_ref_ naming? >> >> In that case >> >> odp_packet_ref() -> odp_packet_ref_create() (same as odp_pool_create, >> odp_queue, create). > > I think

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Bill Fischofer
On Mon, Dec 19, 2016 at 9:57 AM, Maxim Uvarov wrote: > how about group all packet reference apis to odp_packet_ref_ naming? > > In that case > > odp_packet_ref() -> odp_packet_ref_create() (same as odp_pool_create, > odp_queue, create). I think the _create() suffix is unnecessary but have no obje

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Maxim Uvarov
how about group all packet reference apis to odp_packet_ref_ naming? In that case odp_packet_ref() -> odp_packet_ref_create() (same as odp_pool_create, odp_queue, create). both odp_packet_is_ref() and odp_packet_has_ref() -> odp_packet_ref() (function which returns ref counter) It will be more

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Bill Fischofer
On Mon, Dec 19, 2016 at 4:06 AM, Bala Manoharan wrote: > Comments inline > > > On 15 November 2016 at 20:14, Bill Fischofer > wrote: >> Introduce three new APIs that support efficient sharing of portions of >> packets. >> >> odp_packet_ref_static() creates an alias for a base packet >> >> od

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Bala Manoharan
Comments inline On 15 November 2016 at 20:14, Bill Fischofer wrote: > Introduce three new APIs that support efficient sharing of portions of > packets. > > odp_packet_ref_static() creates an alias for a base packet > > odp_packet_ref() creates a reference to a base packet > > odp_packet_ref_

[lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-11-17 Thread Bill Fischofer
Introduce three new APIs that support efficient sharing of portions of packets. odp_packet_ref_static() creates an alias for a base packet odp_packet_ref() creates a reference to a base packet odp_packet_ref_pkt() creates a reference to a base packet from a supplied header packet In addition, t