Re: [lng-odp] [EXT] Re: odp_pktin_queue_param_t - classifier_enable & num_queues

2017-10-03 Thread Liron Himi
Hi, See comments inline -Original Message- From: Bala Manoharan [mailto:bala.manoha...@linaro.org] Sent: Tuesday, October 03, 2017 21:13 To: Bill Fischofer Cc: Liron Himi ; lng-odp@lists.linaro.org Subject: Re: [EXT] Re: [lng-odp]

Re: [lng-odp] [EXT] Re: odp_pktin_queue_param_t - classifier_enable & num_queues

2017-10-03 Thread Bala Manoharan
Yes. This is an implementation bug. Will fix the bug. Minor correction, when classifier_enabled is set the current design is to create all the queues in a single shot rather than as needed since it will create network jitter if queues are created at random. Regards, Bala On 3 October 2017 at

Re: [lng-odp] [EXT] Re: odp_pktin_queue_param_t - classifier_enable & num_queues

2017-10-03 Thread Bill Fischofer
Thanks Liron, I've checked the code and that seems to be another issue. The intent is that when classifier_enable is set the ODP classifier creates queues as needed. +cc Bala for additional commentary. On Tue, Oct 3, 2017 at 8:48 AM, Liron Himi wrote: > Hi Bill, > > > > I

Re: [lng-odp] [EXT] Re: odp_pktin_queue_param_t - classifier_enable & num_queues

2017-10-03 Thread Liron Himi
Hi Bill, I opened ‘https://bugs.linaro.org/show_bug.cgi?id=3289’ for this issue. I think there is another issue related to this topic in case PKTIO was configure in schedule mode. The ‘start’ function assumes ‘num_in_queue’ is bigger than ‘0’ but in the classifier_enable case it is ‘0’ so