Re: [lng-odp] [MONARCH PATCH 0/5] Make lidodp/libodp helper name platform specific

2016-12-05 Thread Nicolas Morey-Chaisemartin
Le 12/05/2016 à 09:02 PM, Mike Holmes a écrit : > I like this patch in principle, but it has to go into master first. > > I think that if you dont set ODP_LIB_NAME and you get something that is > expected to ab ABI compatible is good, if I add a platform name I would > expect it to be less

Re: [lng-odp] [MONARCH PATCH 0/5] Make lidodp/libodp helper name platform specific

2016-12-05 Thread Mike Holmes
I like this patch in principle, but it has to go into master first. I think that if you dont set ODP_LIB_NAME and you get something that is expected to ab ABI compatible is good, if I add a platform name I would expect it to be less portable. I like that odp-dpdk can reuse more of Linux generic

Re: [lng-odp] [MONARCH PATCH 0/5] Make lidodp/libodp helper name platform specific

2016-12-02 Thread Nicolas Morey-Chaisemartin
Le 12/02/2016 à 02:52 PM, Mike Holmes a écrit : > > > On 2 December 2016 at 08:50, Nicolas Morey-Chaisemartin > wrote: > > > > Le 12/02/2016 à 02:45 PM, Maxim Uvarov a écrit : > > On 12/02/16 16:34, Nicolas Morey-Chaisemartin wrote: > >>

Re: [lng-odp] [MONARCH PATCH 0/5] Make lidodp/libodp helper name platform specific

2016-12-02 Thread Mike Holmes
On 2 December 2016 at 08:50, Nicolas Morey-Chaisemartin wrote: > > > Le 12/02/2016 à 02:45 PM, Maxim Uvarov a écrit : > > On 12/02/16 16:34, Nicolas Morey-Chaisemartin wrote: > >> > >> Le 12/02/2016 à 02:30 PM, Maxim Uvarov a écrit : > >>> That needs to go to master first, than

Re: [lng-odp] [MONARCH PATCH 0/5] Make lidodp/libodp helper name platform specific

2016-12-02 Thread Nicolas Morey-Chaisemartin
Le 12/02/2016 à 02:45 PM, Maxim Uvarov a écrit : > On 12/02/16 16:34, Nicolas Morey-Chaisemartin wrote: >> >> Le 12/02/2016 à 02:30 PM, Maxim Uvarov a écrit : >>> That needs to go to master first, than if needed back-ported to Monarch. >> Ok. >> >>> Nicolas, if you name library differently how

Re: [lng-odp] [MONARCH PATCH 0/5] Make lidodp/libodp helper name platform specific

2016-12-02 Thread Maxim Uvarov
On 12/02/16 16:34, Nicolas Morey-Chaisemartin wrote: > > > Le 12/02/2016 à 02:30 PM, Maxim Uvarov a écrit : >> That needs to go to master first, than if needed back-ported to Monarch. > > Ok. > >> >> Nicolas, if you name library differently how will application know how >> to link with it? >

Re: [lng-odp] [MONARCH PATCH 0/5] Make lidodp/libodp helper name platform specific

2016-12-02 Thread Nicolas Morey-Chaisemartin
Le 12/02/2016 à 02:30 PM, Maxim Uvarov a écrit : > That needs to go to master first, than if needed back-ported to Monarch. Ok. > > Nicolas, if you name library differently how will application know how > to link with it? 1) We provide a template makefile for all ODP apps. 2) We don't have

Re: [lng-odp] [MONARCH PATCH 0/5] Make lidodp/libodp helper name platform specific

2016-12-02 Thread Maxim Uvarov
That needs to go to master first, than if needed back-ported to Monarch. Nicolas, if you name library differently how will application know how to link with it? I think that we can stay with fixed name for ABI compat mode and let platforms to change it in non ABI compat mode. Assuming that

[lng-odp] [MONARCH PATCH 0/5] Make lidodp/libodp helper name platform specific

2016-12-02 Thread Nicolas Morey-Chaisemartin
The lib suffix "linux" (libodp-linux, libodphelper-linux) is harcoded pretty much everywhere in the build system. The goal of this series is to allow each platform to define its library suffix so they don't have to touch the generic files but simply the platform specific files. Nicolas