[lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

From: Joe Savage Add an example application implementing lock-free IPv4 fragmentation and reassembly functionality using ODP's packet "concat" and "split". Signed-off-by: Joe Savage Signed-off-by: Maxim Uvarov ---

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

skip that patch. Series has to be with 2 patches and this patch was in my my dir and git am took it. Maxim.

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

On 01/30/17 15:27, Ola Liljedahl wrote: > > > On 30 January 2017 at 02:28, Bill Fischofer > wrote: > > As the maintainer of the ODP git repo, Maxim has final say on style > questions for what is accepted into it, so I

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

On 30 January 2017 at 02:28, Bill Fischofer wrote: > As the maintainer of the ODP git repo, Maxim has final say on style > questions for what is accepted into it, so I recommend deferring to > him on this. This is true of all open source projects, so there's > nothing

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

On 26 January 2017 at 16:56, Maxim Uvarov wrote: > On 01/26/17 18:27, Ola Liljedahl wrote: > > > > > > On 26 January 2017 at 15:19, Joe Savage > > wrote: > > > > > >> It will be very helpful if rehe was some README

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

On 01/26/17 18:27, Ola Liljedahl wrote: > > > On 26 January 2017 at 15:19, Joe Savage > wrote: > > > >> It will be very helpful if rehe was some README with description > about > > >> this app, run environments and some output. So people

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

On 26 January 2017 at 15:19, Joe Savage wrote: > > >> It will be very helpful if rehe was some README with description about > > >> this app, run environments and some output. So people can learn > > >> something before looking to code. > > > > > > I can add one, but I don't

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

On 01/26/17 17:26, Joe Savage wrote: >>> we used MAX_WORKERS before odp_cpumask_default_worker() was implemented, >>> after that we did not rewrite old example. I think it's better to have >>> less defines in code. >> >> Ok, will do. > > Actually, scratch that. MAX_WORKERS is also used allocate

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

> > we used MAX_WORKERS before odp_cpumask_default_worker() was implemented, > > after that we did not rewrite old example. I think it's better to have > > less defines in code. > > Ok, will do. Actually, scratch that. MAX_WORKERS is also used allocate the correct number of elements in the

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

> >> It will be very helpful if rehe was some README with description about > >> this app, run environments and some output. So people can learn > >> something before looking to code. > > > > I can add one, but I don't think there's really that much to describe. Since > > the example doesn't

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

On 01/26/17 14:01, Joe Savage wrote: > Thanks, Maxim. Just a few things... > >> It will be very helpful if rehe was some README with description about >> this app, run environments and some output. So people can learn >> something before looking to code. > > I can add one, but I don't think

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

> > + return __atomic_compare_exchange_16(var, exp, neu, false, > > mo_success, > > + mo_failure); > > This is the line that clang complains about. You're probably more > expert than I in this area but the _odp_atomic_u128_xchg_mm() routine > that

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

Thanks, Maxim. Just a few things... > It will be very helpful if rehe was some README with description about > this app, run environments and some output. So people can learn > something before looking to code. I can add one, but I don't think there's really that much to describe. Since the

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

Additional review comments based on testing: On Wed, Jan 25, 2017 at 8:26 AM, Joe Savage wrote: > Add an example application implementing lock-free IPv4 fragmentation > and reassembly functionality using ODP's packet "concat" and "split". > > Signed-off-by: Joe Savage

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

On Wed, Jan 25, 2017 at 2:03 PM, Bill Fischofer wrote: > I agree with all of Maxim's comments. In addition, attempting to > compile with clang gives these errors: > > Making all in fragreass > make[2]: Entering directory '/home/bill/linaro/review/example/fragreass' >

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

I agree with all of Maxim's comments. In addition, attempting to compile with clang gives these errors: Making all in fragreass make[2]: Entering directory '/home/bill/linaro/review/example/fragreass' CC odp_fragreass-odp_fragreass.o In file included from odp_fragreass.c:21: In file

Re: [lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

quick review for that bellow. It will be very helpful if rehe was some README with description about this app, run environments and some output. So people can learn something before looking to code. On 01/25/17 17:26, Joe Savage wrote: > Add an example application implementing lock-free IPv4

[lng-odp] [PATCH] example: add IPv4 fragmentation/reassembly example

Add an example application implementing lock-free IPv4 fragmentation and reassembly functionality using ODP's packet "concat" and "split". Signed-off-by: Joe Savage --- (This code contribution is provided under the terms of agreement LES-LTM-21309) example/Makefile.am