Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-07 Thread Maxim Uvarov
On 02/07/17 20:52, Dmitry Eremin-Solenikov wrote: > On 07.02.2017 18:59, Maxim Uvarov wrote: >> On 02/07/17 12:21, Dmitry Eremin-Solenikov wrote: >>> Hello, >>> >>> On 7 February 2017 at 10:14, Maxim Uvarov >>> wrote: What is function is not used error? Is it gcc or #error in includes? >>> >>

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-07 Thread Dmitry Eremin-Solenikov
On 07.02.2017 18:59, Maxim Uvarov wrote: On 02/07/17 12:21, Dmitry Eremin-Solenikov wrote: Hello, On 7 February 2017 at 10:14, Maxim Uvarov wrote: What is function is not used error? Is it gcc or #error in includes? First error: In file included from ./include/odp_packet_internal.h:28:0,

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-07 Thread Maxim Uvarov
On 02/07/17 12:21, Dmitry Eremin-Solenikov wrote: > Hello, > > On 7 February 2017 at 10:14, Maxim Uvarov wrote: >> What is function is not used error? Is it gcc or #error in includes? > > First error: > > In file included from ./include/odp_packet_internal.h:28:0, > from odp_cl

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-07 Thread Dmitry Eremin-Solenikov
Hello, On 7 February 2017 at 10:14, Maxim Uvarov wrote: > What is function is not used error? Is it gcc or #error in includes? First error: In file included from ./include/odp_packet_internal.h:28:0, from odp_classification.c:13: ./include/odp_crypto_internal.h:55:5: error: unk

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-06 Thread Maxim Uvarov
I googled this link form compatibility for versions: https://abi-laboratory.pro/tracker/timeline/openssl/ What is function is not used error? Is it gcc or #error in includes? I see that functions should be empty macros: /* * The old locking functions have been removed completely without compat

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-06 Thread Bill Fischofer
On Mon, Feb 6, 2017 at 5:15 PM, Dmitry Eremin-Solenikov wrote: > On 07.02.2017 00:57, Bill Fischofer wrote: >> >> The problem is not what level of OpenSSL ODP might be compiled >> against, but what level is installed on the system the ODP application >> is running on, since we don't distribute Ope

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-06 Thread Dmitry Eremin-Solenikov
On 07.02.2017 00:57, Bill Fischofer wrote: The problem is not what level of OpenSSL ODP might be compiled against, but what level is installed on the system the ODP application is running on, since we don't distribute OpenSSL with ODP. OpenSSL v1.1.0 is backward-compatible with the older callback

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-06 Thread Bill Fischofer
The problem is not what level of OpenSSL ODP might be compiled against, but what level is installed on the system the ODP application is running on, since we don't distribute OpenSSL with ODP. OpenSSL v1.1.0 is backward-compatible with the older callback structure (they become no-ops) so there's no

[lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

2017-02-06 Thread Dmitry Eremin-Solenikov
OpenSSL 1.1.0 uses new threading API. It is no longer necessary to set locking callbacks to use OpenSSL in a multi-threaded environment. The old threading API should no longer be used. Separate old locking code into separate functions that are guarded by OPENSSL_VERSION_NUMBER check. Signed-off-by