Re: [lng-odp] [PATCH] netdev-odp: Use VLOG_ERR instead of ODP_ERR

2014-11-26 Thread Taras Kondratiuk
On 11/25/2014 06:54 PM, Mike Holmes wrote: Taras is submitting a patch that allows you to replace the output stream for ODP_ERR etc with the applications prefered stream - see https://mail.google.com/mail/u/1/#inbox/149e780e4e57d70c Taking into account that ODP_ERR() is not a part of public

Re: [lng-odp] [PATCH] netdev-odp: Use VLOG_ERR instead of ODP_ERR

2014-11-26 Thread Zoltan Kiss
But independent from this, OVS should overwrite the log function, right? So ODP internal log messages won't be lost. Regards, Zoli On 26/11/14 10:47, Taras Kondratiuk wrote: On 11/25/2014 06:54 PM, Mike Holmes wrote: Taras is submitting a patch that allows you to replace the output stream

Re: [lng-odp] [PATCH] netdev-odp: Use VLOG_ERR instead of ODP_ERR

2014-11-26 Thread Taras Kondratiuk
On 11/26/2014 02:54 PM, Zoltan Kiss wrote: But independent from this, OVS should overwrite the log function, right? So ODP internal log messages won't be lost. Right. I assume it should direct log messages into its own logging subsystem. ___ lng-odp

[lng-odp] [PATCH] netdev-odp: Use VLOG_ERR instead of ODP_ERR

2014-11-25 Thread Zoltan Kiss
OVS usually ditches stderr and stdout after startup, so logging there won't be effective. Use instead the proper OVS logging facilities. Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- lib/netdev-odp.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

Re: [lng-odp] [PATCH] netdev-odp: Use VLOG_ERR instead of ODP_ERR

2014-11-25 Thread Mike Holmes
Taras is submitting a patch that allows you to replace the output stream for ODP_ERR etc with the applications prefered stream - see https://mail.google.com/mail/u/1/#inbox/149e780e4e57d70c On 25 November 2014 at 11:00, Zoltan Kiss zoltan.k...@linaro.org wrote: OVS usually ditches stderr and

Re: [lng-odp] [PATCH] netdev-odp: Use VLOG_ERR instead of ODP_ERR

2014-11-25 Thread Mike Holmes
That link might not work this thread [lng-odp] [PATCHv2 1/2] platform: debug: replace fprintf() with odp_override_log() On 25 November 2014 at 11:54, Mike Holmes mike.hol...@linaro.org wrote: Taras is submitting a patch that allows you to replace the output stream for ODP_ERR etc with the