Re: [lng-odp] [PATCH 1/5] implement odp_bool type

2014-11-28 Thread Taras Kondratiuk
On 11/27/2014 07:38 PM, Bill Fischofer wrote: I agree. This type is supposed to be just documentation so typedef int odp_bool_t; is simplest and best. Won't enum be more clear? {ODP_FALSE, ODP_TRUE} ___ lng-odp mailing list

Re: [lng-odp] [PATCH 1/5] implement odp_bool type

2014-11-28 Thread Ola Liljedahl
And you can do #define фальш 0 #define щоправда 1 in your code Taras. On 28 November 2014 at 13:42, Bill Fischofer bill.fischo...@linaro.org wrote: Not really. int has been used for booleans for some time and the 0 = false, 1 = true convention is well established. The purpose of enums is to

Re: [lng-odp] [PATCH 1/5] implement odp_bool type

2014-11-28 Thread Ola Liljedahl
In C conditional expressions (as used by if, for, while, ? ), any non-zero value means true so yes you can pass 2 to indicate true. Using true or TRUE enums or preprocessor symbols that evaluate to 1 is just to enhance readability and understanding (at least that's the hope but then we're having

Re: [lng-odp] [PATCH 1/5] implement odp_bool type

2014-11-28 Thread Bill Fischofer
ODP supports C and as such all normal C idioms apply. False is 0 and true is != false. I don't see a need to overspecify beyond that. For ODP routines that return an odp_bool_t they return 1 for true. On Fri, Nov 28, 2014 at 8:25 AM, Ola Liljedahl ola.liljed...@linaro.org wrote: In C

Re: [lng-odp] [PATCH 1/5] implement odp_bool type

2014-11-27 Thread Maxim Uvarov
On 11/26/2014 08:31 PM, Maxim Uvarov wrote: To have compatibility with other compilers define custom booalen type for odp. Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- platform/linux-generic/include/api/odp_std_types.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

Re: [lng-odp] [PATCH 1/5] implement odp_bool type

2014-11-27 Thread Maxim Uvarov
thanks Ola for explanation, will account that in new version. Maxim. On 27 November 2014 at 19:47, Ola Liljedahl ola.liljed...@linaro.org wrote: On 27 November 2014 at 14:37, Maxim Uvarov maxim.uva...@linaro.org wrote: On 11/26/2014 08:31 PM, Maxim Uvarov wrote: To have compatibility

Re: [lng-odp] [PATCH 1/5] implement odp_bool type

2014-11-27 Thread Bill Fischofer
I agree. This type is supposed to be just documentation so typedef int odp_bool_t; is simplest and best. Bill On Thursday, November 27, 2014, Ola Liljedahl ola.liljed...@linaro.org wrote: On 27 November 2014 at 14:37, Maxim Uvarov maxim.uva...@linaro.org javascript:; wrote: On 11/26/2014