On 30/04/15 20:26, Mike Holmes wrote:
On 30 April 2015 at 08:16, Bill Fischofer bill.fischo...@linaro.org
mailto:bill.fischo...@linaro.org wrote:
You've articulated why we don't need API changes for this. Each
implementation is free to optimize its performance as it chooses
.
-Petri
From: ext Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Tuesday, May 05, 2015 3:33 PM
To: Zoltan Kiss
Cc: Mike Holmes; lng-odp@lists.linaro.org; Savolainen, Petri (Nokia - FI/Espoo)
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse mode
Given Zoltan's
Given Zoltan's confirmation I would recommend that we defer the PktIO
changes until we can have a more complete discussion of what would be
useful/needed as a next-phase classification API (including specifying
parse needs) and rely on lazy parsing in SW to meet the immediate needs for
OVS
...@linaro.org]
Sent: Wednesday, April 29, 2015 8:14 PM
To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse
mode
It doesn't apply to api-next. Anyway, I've sent an implementation, see
[API-NEXT PATCH] packet
Kiss
Cc: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse mode
On 29 April 2015 at 18:14, Zoltan Kiss
zoltan.k...@linaro.orgmailto:zoltan.k...@linaro.org wrote:
It doesn't apply to api-next. Anyway, I've sent
...@linaro.org]
*Sent:* Wednesday, April 29, 2015 8:19 PM
*To:* Zoltan Kiss
*Cc:* Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org
*Subject:* Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse
mode
On 29 April 2015 at 18:14, Zoltan Kiss zoltan.k...@linaro.org wrote
@lists.linaro.org
*Subject:* Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added
parse mode
On 29 April 2015 at 18:14, Zoltan Kiss zoltan.k...@linaro.org wrote:
It doesn't apply to api-next. Anyway, I've sent an implementation, see
[API-NEXT PATCH] packet: implement optional parsing. But if we go
Message-
From: ext Zoltan Kiss [mailto:zoltan.k...@linaro.org]
Sent: Tuesday, April 28, 2015 9:17 PM
To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse
mode
On 28/04/15 08:09, Savolainen, Petri
-Original Message-
From: ext Bala Manoharan [mailto:bala.manoha...@linaro.org]
Sent: Wednesday, April 29, 2015 11:12 AM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: ext Zoltan Kiss; lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse
mode
, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse
mode
On 28/04/15 08:09, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Hi Zoltan,
You should implement the latest version of the patch, which has only
ALL/NONE
: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added
parse
mode
On 28/04/15 08:09, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Hi Zoltan,
You should implement the latest version of the patch, which has only
ALL/NONE defined. We can leave SELECTED for later.
Ok, but where
...@linaro.org]
Sent: Monday, April 27, 2015 8:29 PM
To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added
parse
mode
On 20/04/15 13:10, Petri Savolainen wrote:
Application can indicate which
@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse
mode
On 28/04/15 08:09, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Hi Zoltan,
You should implement the latest version of the patch, which has only
ALL/NONE defined. We can leave SELECTED for later
On 29/04/15 16:41, Ola Liljedahl wrote:
On 29 April 2015 at 16:10, Bill Fischofer bill.fischo...@linaro.org
mailto:bill.fischo...@linaro.org wrote:
We need to be careful about trying to solve problems that haven't
arisen yet. There are several interrelated issues here:
1.
-Original Message-
From: ext Zoltan Kiss [mailto:zoltan.k...@linaro.org]
Sent: Tuesday, April 28, 2015 9:17 PM
To: Savolainen, Petri (Nokia - FI/Espoo);
lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added
parse
mode
@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse
mode
On 29 April 2015 at 13:24, Savolainen, Petri (Nokia - FI/Espoo)
petri.savolai...@nokia.com wrote:
Hi,
Possibly. Although, grouping adds struct complexity, so there should
be
some benefit
BTW, what complicates doing lazy evaluation is the existence of the various
odp_packet_has_xxx_set() APIs we've defined. If you set a value you should
be able to retrieve it without triggering parsing since you've taking
control of that variable yourself. So each parse bit actually needs to
be a
It doesn't apply to api-next. Anyway, I've sent an implementation, see
[API-NEXT PATCH] packet: implement optional parsing. But if we go with
Ola's idea, it won't be needed.
On 29/04/15 07:45, Savolainen, Petri (Nokia - FI/Espoo) wrote:
It's (v2) on the list (since last Thu):
[lng-odp]
On 29 April 2015 at 17:50, Zoltan Kiss zoltan.k...@linaro.org wrote:
On 29/04/15 16:41, Ola Liljedahl wrote:
On 29 April 2015 at 16:10, Bill Fischofer bill.fischo...@linaro.org
mailto:bill.fischo...@linaro.org wrote:
We need to be careful about trying to solve problems that haven't
On 29/04/15 18:19, Ola Liljedahl wrote:
On 29 April 2015 at 18:14, Zoltan Kiss zoltan.k...@linaro.org
mailto:zoltan.k...@linaro.org wrote:
It doesn't apply to api-next. Anyway, I've sent an implementation,
see [API-NEXT PATCH] packet: implement optional parsing. But if we
go with
On 29 April 2015 at 18:14, Zoltan Kiss zoltan.k...@linaro.org wrote:
It doesn't apply to api-next. Anyway, I've sent an implementation, see
[API-NEXT PATCH] packet: implement optional parsing. But if we go with
Ola's idea, it won't be needed.
Actually Bill's idea.
If parsing is made lazy,
I'm currently playing around with this and as usual there's no free lunch.
The only way to know whether you need to parse is to check a bit, which at
least doubles the cost of the odp_packet_has_xxx() calls since normally
they are just returning a bit. So now the logic for each of these is:
if
A lazy parser only parses when the results of parsing are asked for by the
application. So if the application never asks (as is the case for OVS
today) then nothing gets called, so no overhead.
There is a certain amount of overhead imposed by lazy parsing for programs
that do ask for parse
Message-
From: ext Zoltan Kiss [mailto:zoltan.k...@linaro.org]
Sent: Tuesday, April 28, 2015 9:17 PM
To: Savolainen, Petri (Nokia - FI/Espoo);
lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added
parse
mode
On 28/04/15 08
/Espoo); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse
mode
On 20/04/15 13:10, Petri Savolainen wrote:
Application can indicate which packet parsing results it is
interested in (all, none or selected).
Signed-off-by: Petri Savolainen petri.savolai
To: Ola Liljedahl
Cc: Zoltan Kiss; LNG ODP Mailman List; Savolainen, Petri (Nokia - FI/Espoo)
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse mode
This is one of the reasons I suggested that as a first-order approximation we
simply support parse none or all. OVS clearly
are
undefined.
-Petri
-Original Message-
From: ext Zoltan Kiss [mailto:zoltan.k...@linaro.org]
Sent: Monday, April 27, 2015 8:29 PM
To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api: packet_io: added parse
mode
On 20/04
This is one of the reasons I suggested that as a first-order approximation
we simply support parse none or all. OVS clearly wants the former (for
now) and my concern is that trying to get overly fancy with selectable
parsing options isn't going to buy much since the SW will be spending
nearly as
Reviewed-by: Zoltan Kiss zoltan.k...@linaro.org
On 20/04/15 13:10, Petri Savolainen wrote:
Application can indicate which packet parsing results it is
interested in (all, none or selected).
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/packet_flags.h | 26
Application can indicate which packet parsing results it is
interested in (all, none or selected).
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/packet_flags.h | 26 ++
include/odp/api/packet_io.h| 19 +++
2 files
30 matches
Mail list logo
