Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

2017-08-02 Thread Dmitry Eremin-Solenikov
On 02/08/17 10:03, Maxim Uvarov wrote: > On 2 August 2017 at 09:03, shally verma wrote: > >> Shally - One summary to address all responses around output parameter >> "status". >> >> Consider following use case: >> user added mac addresses @ index 0, 1, 2, 3, 4 >>

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

2017-08-02 Thread Dmitry Eremin-Solenikov
On 02/08/17 09:03, shally verma wrote: > On Wed, Aug 2, 2017 at 1:39 AM, Maxim Uvarov wrote: >> On 08/01/17 15:02, Bill Fischofer wrote: int odp_pktio_mac_addr(odp_pktio_t pktio, void *mac_addr, int size); /** + * Set the default MAC address of a

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

2017-08-02 Thread Maxim Uvarov
On 2 August 2017 at 09:03, shally verma wrote: > On Wed, Aug 2, 2017 at 1:39 AM, Maxim Uvarov > wrote: > > On 08/01/17 15:02, Bill Fischofer wrote: > >> Correct tag for this should be --subject-prefix="API-NEXT PATCHv2" > >> > >> Every time

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

2017-08-02 Thread shally verma
On Wed, Aug 2, 2017 at 1:39 AM, Maxim Uvarov wrote: > On 08/01/17 15:02, Bill Fischofer wrote: >> Correct tag for this should be --subject-prefix="API-NEXT PATCHv2" >> >> Every time a revision of a patch is submitted, increment the version. This >> is done automatically

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

2017-08-01 Thread Maxim Uvarov
On 08/01/17 15:02, Bill Fischofer wrote: > Correct tag for this should be --subject-prefix="API-NEXT PATCHv2" > > Every time a revision of a patch is submitted, increment the version. This > is done automatically if you use a GitHub pull request, but must be done > manually if you submit the

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

2017-08-01 Thread Dmitry Eremin-Solenikov
On 01/08/17 21:42, Bill Fischofer wrote: > We discussed this patch during today's ODP public call. Notes from that > discussion: [skipped] > This should be a struct, not a union. If it's a union then all fields > are mapped on top of each other, which is clearly not what you intend > here.

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

2017-08-01 Thread Bill Fischofer
We discussed this patch during today's ODP public call. Notes from that discussion: 1. Ethernet MAC addresses are not of arbitrary length. They are always 48 bits. Some pktios (not currently supported in ODP) may support 64-bit MAC addresses, so it's OK to make provision for future support, but

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

2017-08-01 Thread Dmitry Eremin-Solenikov
On 01/08/17 10:38, Vamsi Attunuru wrote: > Signed-off-by: Vamsi Attunuru > Signed-off-by: Shally Verma > Signed-off-by: Mahipal Challa I'd suggest to split this into two separate patches: one for MTU (seems simpler and will go in

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

2017-08-01 Thread Bill Fischofer
Correct tag for this should be --subject-prefix="API-NEXT PATCHv2" Every time a revision of a patch is submitted, increment the version. This is done automatically if you use a GitHub pull request, but must be done manually if you submit the patch via e-mail. Thanks. On Tue, Aug 1, 2017 at 2:38

[lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

2017-08-01 Thread Vamsi Attunuru
Signed-off-by: Vamsi Attunuru Signed-off-by: Shally Verma Signed-off-by: Mahipal Challa --- include/odp/api/spec/packet_io.h | 167 +++ 1 file changed, 167 insertions(+) diff --git