Re: [lng-odp] [PATCH API-NEXT v5 6/10] api: crypto: add crypto packet operation interface

2017-07-04 Thread Dmitry Eremin-Solenikov
Petri, Thank you for the review! I corrected some of the issues you pointed. For the rest (packet_op_mode, odp_crypto_packet_op()/odp_crypto_packet_op_enq()) I would like to keep them as is, as this shows tighter connection between API. If you'd absolutely insist on that, I can remove _packet_ pa

Re: [lng-odp] [PATCH API-NEXT v5 6/10] api: crypto: add crypto packet operation interface

2017-07-03 Thread Savolainen, Petri (Nokia - FI/Espoo)
> diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h > index 454855ea..9dd60749 100644 > --- a/include/odp/api/spec/crypto.h > +++ b/include/odp/api/spec/crypto.h > @@ -16,6 +16,7 @@ > #include > > #include > +#include > > #ifdef __cplusplus > extern "C" { > @@ -27

[lng-odp] [PATCH API-NEXT v5 6/10] api: crypto: add crypto packet operation interface

2017-07-01 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Input and output of crypto operations are packets. API is more flexible for application and API pipelining when output is packet with additional metadata. Application or API pipeline stages which do not care about crypto results may work on basic packet metadata. Cr