On Tue, Apr 12, 2016 at 5:03 AM, Maxim Uvarov wrote:
> why you do this only for that functions? I think at the beginning of each
> internal.[ch] we need to say:
>
> #pragma GCC visibility push(hidden)
>
> then in the bottom:
> #pragma GCC visibility pop
>
> In that case all internal things will ma
why you do this only for that functions? I think at the beginning of
each internal.[ch] we need to say:
#pragma GCC visibility push(hidden)
then in the bottom:
#pragma GCC visibility pop
In that case all internal things will marked as .hidden and you don't
need to specify it for each symbol.
Agree with Mike. These are effectively platform build issues, not general
API issues.
On Mon, Apr 11, 2016 at 3:45 PM, Mike Holmes wrote:
>
>
> On 11 April 2016 at 16:39, Anders Roxell wrote:
>
>> On 9 April 2016 at 20:07, Mike Holmes wrote:
>> >
>> >
>> > On 8 April 2016 at 17:14, Anders Rox
On 11 April 2016 at 16:39, Anders Roxell wrote:
> On 9 April 2016 at 20:07, Mike Holmes wrote:
> >
> >
> > On 8 April 2016 at 17:14, Anders Roxell
> wrote:
> >>
> >> Internal functions should not be part of symbols is visible outside the
> >> library.
> >>
> >> Suggested-by: Ricardo Salveti
>
On 9 April 2016 at 20:07, Mike Holmes wrote:
>
>
> On 8 April 2016 at 17:14, Anders Roxell wrote:
>>
>> Internal functions should not be part of symbols is visible outside the
>> library.
>>
>> Suggested-by: Ricardo Salveti
>> Signed-off-by: Anders Roxell
>> ---
>> .../linux-generic/include/od
On 9 April 2016 at 17:24, Bill Fischofer wrote:
> Why is this restricted to GCC? What happens when compiling with clang? A
> quick experiment shows clang accepts the same __attribute__ without
> complaint but not sure what it does with it.
Clang works without a problem, so I don't think there i
On 8 April 2016 at 17:14, Anders Roxell wrote:
> Internal functions should not be part of symbols is visible outside the
> library.
>
> Suggested-by: Ricardo Salveti
> Signed-off-by: Anders Roxell
> ---
> .../linux-generic/include/odp_packet_io_internal.h | 23
> +-
> 1 fil
Why is this restricted to GCC? What happens when compiling with clang? A
quick experiment shows clang accepts the same __attribute__ without
complaint but not sure what it does with it.
On Fri, Apr 8, 2016 at 4:14 PM, Anders Roxell
wrote:
> Internal functions should not be part of symbols is v
Internal functions should not be part of symbols is visible outside the
library.
Suggested-by: Ricardo Salveti
Signed-off-by: Anders Roxell
---
.../linux-generic/include/odp_packet_io_internal.h | 23 +-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/platform
