Re: [lng-odp] [PATCHv2] test: linux-gen: add pcap playback test

2016-08-26 Thread Anders Roxell
On 25 August 2016 at 10:14, Maxim Uvarov wrote: > On 08/25/16 00:34, Anders Roxell wrote: > > +#include > >why do we include an internal header file? > > >>> >>> > >>> >because we need access to classifier bits, that is why this test is >>> > under

Re: [lng-odp] [PATCHv2] test: linux-gen: add pcap playback test

2016-08-25 Thread Bill Fischofer
On Thu, Aug 25, 2016 at 3:14 AM, Maxim Uvarov wrote: > On 08/25/16 00:34, Anders Roxell wrote: > >> +#include > > >why do we include an internal header file? > > >>> > >>> >because we need access to classifier bits, that is why this test is >>> under

Re: [lng-odp] [PATCHv2] test: linux-gen: add pcap playback test

2016-08-25 Thread Maxim Uvarov
On 08/25/16 00:34, Anders Roxell wrote: +#include > >why do we include an internal header file? > > > >because we need access to classifier bits, that is why this test is under >linux-generic. OK, but do we really have to fiddle with internal classifier bits? That is good question. For

Re: [lng-odp] [PATCHv2] test: linux-gen: add pcap playback test

2016-08-24 Thread Anders Roxell
On 2016-08-09 15:46, Maxim Uvarov wrote: > On 08/06/16 22:30, Anders Roxell wrote: > >--- a/test/linux-generic/m4/configure.m4 > >>+++ b/test/linux-generic/m4/configure.m4 > >>@@ -1,5 +1,6 @@ > >> AC_CONFIG_FILES([test/linux-generic/Makefile > >>

Re: [lng-odp] [PATCHv2] test: linux-gen: add pcap playback test

2016-08-24 Thread Anders Roxell
On 2016-08-08 09:59, Maxim Uvarov wrote: > Hello Anders, > > thanks for review, there are 2 comments bellow. Will send v2. > > Maxim. > > On 08/06/16 22:30, Anders Roxell wrote: > >On 2016-08-02 19:08, Maxim Uvarov wrote: > >>add pcap play back test which takes 2 arguments: 1 - pcap file, > >>2

Re: [lng-odp] [PATCHv2] test: linux-gen: add pcap playback test

2016-08-15 Thread Maxim Uvarov
Hello Anders, do you agree with current order? My answer was bellow. Thank you, Maxim. On 08/09/16 15:46, Maxim Uvarov wrote: On 08/06/16 22:30, Anders Roxell wrote: --- a/test/linux-generic/m4/configure.m4 >+++ b/test/linux-generic/m4/configure.m4 >@@ -1,5 +1,6 @@ >

Re: [lng-odp] [PATCHv2] test: linux-gen: add pcap playback test

2016-08-09 Thread Maxim Uvarov
On 08/06/16 22:30, Anders Roxell wrote: --- a/test/linux-generic/m4/configure.m4 >+++ b/test/linux-generic/m4/configure.m4 >@@ -1,5 +1,6 @@ > AC_CONFIG_FILES([test/linux-generic/Makefile > test/linux-generic/validation/api/shmem/Makefile >

Re: [lng-odp] [PATCHv2] test: linux-gen: add pcap playback test

2016-08-08 Thread Maxim Uvarov
Hello Anders, thanks for review, there are 2 comments bellow. Will send v2. Maxim. On 08/06/16 22:30, Anders Roxell wrote: On 2016-08-02 19:08, Maxim Uvarov wrote: add pcap play back test which takes 2 arguments: 1 - pcap file, 2 - packet mask to match. Intend is to test odp with different

Re: [lng-odp] [PATCHv2] test: linux-gen: add pcap playback test

2016-08-04 Thread Bill Fischofer
On Tue, Aug 2, 2016 at 11:08 AM, Maxim Uvarov wrote: > add pcap play back test which takes 2 arguments: 1 - pcap file, > 2 - packet mask to match. Intend is to test odp with different > input traffic to check internal implementation functions. In > current case it's test