I have only a few minor comments for this patch.
One major query is that Currently this patch does not integrate
headroom/tailroom at segment level
is the feature available in 1.0?
if it is needed to be supported then we need some modifications in segment
handling.
Regards,
Bala
On Tue, Dec 02,
Hi,
This is the proposed way to break up your patch:
1. break circular dependencies
2. move inline functions to a new odp_buffer_inlines.h file.
3. restructuring ODP buffer pool
4. odp_buffer_pool_create
5. odp_buffer_pool_destroy
6. odp_buffer_pool_info
see more comments inline.
On 2 December
On 12/03/2014 01:07 PM, Anders Roxell wrote:
Hi,
This is the proposed way to break up your patch:
1. break circular dependencies
2. move inline functions to a new odp_buffer_inlines.h file.
3. restructuring ODP buffer pool
4. odp_buffer_pool_create
5. odp_buffer_pool_destroy
6.
On Tue, 2 Dec 2014 13:17:01 -0600 Bill Fischofer bill.fischo...@linaro.org
wrote:
+#define ODP_SEGBITS(x) \
+ ((x) 2 ? 1 : \
+ ((x) 4 ? 2 : \
+ ((x) 8 ? 3 : \
+((x)16 ? 4 : \
+ ((x)32 ? 5 : \
+ ((x)64 ? 6 : \
+
On Wed, Dec 3, 2014 at 5:07 AM, Anders Roxell anders.rox...@linaro.org
wrote:
Hi,
This is the proposed way to break up your patch:
1. break circular dependencies
2. move inline functions to a new odp_buffer_inlines.h file.
3. restructuring ODP buffer pool
4. odp_buffer_pool_create
5.
It simplified debugging because the LOG output is the same independent of
whether I'm testing on big or little endian systems. My mind isn't wired
to read byte-reversed output fields.
On Wed, Dec 3, 2014 at 7:18 AM, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
On 12/02/2014 09:17 PM,
On 2014-12-03 07:05, Bill Fischofer wrote:
On Wed, Dec 3, 2014 at 5:07 AM, Anders Roxell anders.rox...@linaro.org
wrote:
Hi,
This is the proposed way to break up your patch:
1. break circular dependencies
2. move inline functions to a new odp_buffer_inlines.h file.
3. restructuring
What problem do you see with odp_example.c with part 1 of the patch applied
that disappears when you apply the remaining two parts? The code compiles
and runs the same for me.
I had previously mentioned that odp_example.c has a race condition (bug)
that is exacerbated by the fact that the
Restructure ODP buffer pool internals to support new APIs.
Implements new odp_buffer_pool_create() API.
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
example/generator/odp_generator.c | 19 +-
example/ipsec/odp_ipsec.c | 57 +-
prefix this patch with:
api: ...
On 2014-12-02 13:17, Bill Fischofer wrote:
Restructure ODP buffer pool internals to support new APIs.
The comment doesn't add any extra value from the short log.
Modifys linux-generic, example and test to make them ready for adding the
new odp_buffer_pool_create
On Tue, Dec 2, 2014 at 3:05 PM, Anders Roxell anders.rox...@linaro.org
wrote:
prefix this patch with:
api: ...
On 2014-12-02 13:17, Bill Fischofer wrote:
Restructure ODP buffer pool internals to support new APIs.
The comment doesn't add any extra value from the short log.
Modifys
11 matches
Mail list logo
