Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
example/generator/odp_generator.c | 1 -
example/packet/odp_pktio.c | 1 -
.../linux-generic/include/odp_packet_io_internal.h | 3 +-
platform/linux-generic/odp_packet_io.c |
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim
Uvarov
Sent: Wednesday, July 01, 2015 5:39 PM
To: Nicolas Morey-Chaisemartin; Stuart Haslam
Cc: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCHv2 1/3] linux-generic: pktio: remove basic
On Wed, Jul 01, 2015 at 12:15:54PM +, Prashant Upadhyaya wrote:
Hi guys,
I object too. Why would you want to 'remove' a functionality.
The 'basic' socket is a very good lowest common denominator of implementation
across all the machines/linux
And it was anyway a fallback mechanism.
On 06/30/15 19:06, Nicolas Morey-Chaisemartin wrote:
I got a little bit mixed up between the msg and mmsg version.
After a quick look, we should be able to fall back to recvmsg/sendmsg for a
basic socket implementation
But yes, this patch removed a lot of code and a new version would be very
To: Nicolas Morey-Chaisemartin; Stuart Haslam
Cc: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCHv2 1/3] linux-generic: pktio: remove basic
socket implementation
On 06/30/15 19:06, Nicolas Morey-Chaisemartin wrote:
I got a little bit mixed up between the msg and mmsg version.
After
Subject: Re: [lng-odp] [PATCHv2 1/3] linux-generic: pktio: remove basic
socket implementation
On 06/30/15 19:06, Nicolas Morey-Chaisemartin wrote:
I got a little bit mixed up between the msg and mmsg version.
After a quick look, we should be able to fall back to recvmsg/sendmsg
for a basic
] linux-generic: pktio: remove basic socket
implementation
On 06/30/15 19:06, Nicolas Morey-Chaisemartin wrote:
I got a little bit mixed up between the msg and mmsg version.
After a quick look, we should be able to fall back to recvmsg/sendmsg
for a basic socket implementation
But yes
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
example/generator/odp_generator.c | 1 -
example/packet/odp_pktio.c | 1 -
.../linux-generic/include/odp_packet_io_internal.h | 3 +-
platform/linux-generic/odp_packet_io.c |
Why it's needed to remove basic socket? Some people use very old
machines mmap and mmsg might be not supported.
Maxim.
On 06/30/15 17:45, Stuart Haslam wrote:
On Tue, Jun 30, 2015 at 03:33:41PM +0200, Nicolas Morey-Chaisemartin wrote:
Signed-off-by: Nicolas Morey-Chaisemartin
On Tue, Jun 30, 2015 at 06:28:10PM +0300, Maxim Uvarov wrote:
Why it's needed to remove basic socket? Some people use very old
machines mmap and mmsg might be not supported.
Maxim.
It simplifies the implementation - this change removed 127 lines and
avoided having to add another bunch.
On Tue, Jun 30, 2015 at 03:33:41PM +0200, Nicolas Morey-Chaisemartin wrote:
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
Reviewed-by: Stuart Haslam stuart.has...@linaro.org
---
example/generator/odp_generator.c | 1 -
example/packet/odp_pktio.c
I got a little bit mixed up between the msg and mmsg version.
After a quick look, we should be able to fall back to recvmsg/sendmsg for a
basic socket implementation
But yes, this patch removed a lot of code and a new version would be very quick
to implement (mostly replacing mmsg by msg).
12 matches
Mail list logo
