Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

2015-12-08 Thread Ola Liljedahl
On 3 December 2015 at 14:14, Ivan Khoronzhuk wrote: > It's in master already but I wonder how checkpatch missed it. > > On 05.11.15 13:20, huanggaoyang wrote: > >> Signed-off-by: huanggaoyang >> --- >> helper/hashtable.c | 346 >>

Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

2015-12-08 Thread Stuart Haslam
On Thu, Dec 03, 2015 at 08:39:26AM -0500, Mike Holmes wrote: > It does miss it apparently - just shows you we still need a human eye > I have this in my ~/.gitconfig [core] whitespace = trailing-space,space-before-tab,indent-with-non-tab and it warns about it: Applying: helper: table:

Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

2015-12-08 Thread Mike Holmes
On 8 December 2015 at 10:49, Stuart Haslam wrote: > On Thu, Dec 03, 2015 at 08:39:26AM -0500, Mike Holmes wrote: > > It does miss it apparently - just shows you we still need a human eye > > > > I have this in my ~/.gitconfig > [core] > whitespace =

Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

2015-12-03 Thread Ivan Khoronzhuk
On 05.11.15 13:20, huanggaoyang wrote: Signed-off-by: huanggaoyang --- helper/hashtable.c | 346 helper/odph_hashtable.h | 42 ++ helper/odph_list_internal.h | 85 +++ 3 files changed, 473

Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

2015-12-03 Thread Ivan Khoronzhuk
It's in master already but I wonder how checkpatch missed it. On 05.11.15 13:20, huanggaoyang wrote: Signed-off-by: huanggaoyang --- helper/hashtable.c | 346 helper/odph_hashtable.h | 42 ++

Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

2015-12-03 Thread Mike Holmes
It does miss it apparently - just shows you we still need a human eye mike@mike-desktop:~/git/odp$ git format-patch -1 a775afd 0001-helper-table-add-impl-of-hashtable.patch mike@mike-desktop:~/git/odp$ ./scripts/checkpatch.pl 0001-helper-table-add-impl-of-hashtable.patch total: 0 errors, 0

Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

2015-12-01 Thread Ivan Khoronzhuk
On 05.11.15 13:20, huanggaoyang wrote: Signed-off-by: huanggaoyang --- helper/hashtable.c | 346 helper/odph_hashtable.h | 42 ++ helper/odph_list_internal.h | 85 +++ 3 files changed, 473

[lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

2015-11-05 Thread huanggaoyang
Signed-off-by: huanggaoyang --- helper/hashtable.c | 346 helper/odph_hashtable.h | 42 ++ helper/odph_list_internal.h | 85 +++ 3 files changed, 473 insertions(+) create mode 100644