Re: [lng-odp] [PATCHv7] helper : Fix UDP checksum computation

2016-01-08 Thread Ion Grigore
dp] [PATCHv7] helper : Fix UDP checksum computation Done, as it was suggested. Thanks, Grig -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Thursday, December 31, 2015 10:07 AM To: Ilya Maximets <i.maxim...@samsung.com>; Ion Grigore <ion.grig...@fr

Re: [lng-odp] [PATCHv7] helper : Fix UDP checksum computation

2016-01-04 Thread Ion Grigore
Done, as it was suggested. Thanks, Grig -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Thursday, December 31, 2015 10:07 AM To: Ilya Maximets ; Ion Grigore ; lng-odp@lists.linaro.org Subject: Re:

Re: [lng-odp] [PATCHv7] helper : Fix UDP checksum computation

2015-12-31 Thread Maxim Uvarov
On 12/31/2015 08:26, Ilya Maximets wrote: This version almost good. 2 more comments: * no need to remove blank lines at the beginning of the file. that is ok. Our checkpatch did not capture double empty lines at the beginning, now it does. So this patch just removes that checkpatch

Re: [lng-odp] [PATCHv7] helper : Fix UDP checksum computation

2015-12-30 Thread Ilya Maximets
This version almost good. 2 more comments: * no need to remove blank lines at the beginning of the file. * Why checksum is computed in the CPU endianness? There is no reason to do so. I can't imagine case where checksum will be needed in CPU endiannes. IMO, it's

Re: [lng-odp] [PATCHv7] helper : Fix UDP checksum computation

2015-12-30 Thread Maxim Uvarov
Ilya is that version good for you? Do you want to add your Review-by? Maxim. On 12/17/2015 19:36, Ion Grigore wrote: Ping -Original Message- From: ion.grig...@freescale.com [mailto:ion.grig...@freescale.com] Sent: Monday, December 14, 2015 12:52 PM To: lng-odp@lists.linaro.org Cc:

Re: [lng-odp] [PATCHv7] helper : Fix UDP checksum computation

2015-12-17 Thread Ion Grigore
Ping -Original Message- From: ion.grig...@freescale.com [mailto:ion.grig...@freescale.com] Sent: Monday, December 14, 2015 12:52 PM To: lng-odp@lists.linaro.org Cc: Grigore Ion-B17953 Subject: [PATCHv7] helper : Fix UDP checksum computation From: Grigore Ion

[lng-odp] [PATCHv7] helper : Fix UDP checksum computation

2015-12-14 Thread ion.grigore
From: Grigore Ion This patch fixes the following problems: - checksum computation for LE platforms - checksum is computed in the CPU endianness. The returned result must be converted to the BE ordering when it is used to update the UDP checksum in a packet. - checksum