Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-11 Thread Bala Manoharan
Patch posted to fix the issue in odp_classifier. odp_generator is working but showing the following error message continuously. === ktio/netmap.c:139:netmap_open():nm_open(netmap:lo:1) failed odp_timer.c:641:timer_notify(): 2 ticks overrun on timer pool "timer_pool", timer

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Maxim Uvarov
That patches introduce segfault. Pktio is socket_mmap: 8cf523f api: classification: add odp_cls_cos_pool_set() api 8da0ee0 example: classifier: add odp_cls_cos_pool_set() api 4ade6a3 validation: classification: add odp_cls_cos_pool_set() api e695969 linux-generic: classification: implements

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Maxim Uvarov
Bala, I have opposite result. After you patch master never fails. api-next fails and my merge master to api-next also fails. So it looks like we have something in api-next that breaks the work. queue1 |queue2 |queue3 |DefaultCos |Total Packets queue pool |queue pool

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Maxim Uvarov
Bala, can you tested it on merged master to api-next? https://git.linaro.org/people/maxim.uvarov/odp.git api-next We need to check if that changes did not went to merge. And I did not pull error back to api-next. Maxim. On 12/10/2015 18:12, Bala Manoharan wrote: odp_classifier runs on

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Bala Manoharan
Hi Maxim, I just tested it again and I am seeing the same behaviour I explained in the mail above. In Master branch odp_classifier and odp_generator fails and both are working on api-next branch. This behaviour was seen by Stuart as well. Regards, Bala On 11 December 2015 at 01:41, Maxim Uvarov

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Mike Holmes
If the examples are broken, this is a strong reason that we need to add the examples to the "make check" with maybe --enable-test-examples. We touched on this in the JIra scrub for doc and examples this morning https://projects.linaro.org/browse/ODP-203 On 10 December 2015 at 09:19, Bala

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Bala Manoharan
Not sure which was the commit. Maybe Bill can confirm the commit. Regards, Bala On 10 December 2015 at 19:55, Maxim Uvarov wrote: > On 12/10/2015 17:19, Bala Manoharan wrote: >> >> Hi, >> >> odp_classifier and odp_generator is failing in the master branch but >> both

[lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Bala Manoharan
Hi, odp_classifier and odp_generator is failing in the master branch but both are working in api-next branch. Looks like the issue in classifier is a bug is in the queue module which was fixed in api-next branch and this fix needs to be merged into master branch. Regards, Bala

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Maxim Uvarov
How to reproduce that it is broken? Maxim. On 12/10/2015 17:48, Bala Manoharan wrote: Not sure which was the commit. Maybe Bill can confirm the commit. Regards, Bala On 10 December 2015 at 19:55, Maxim Uvarov wrote: On 12/10/2015 17:19, Bala Manoharan wrote: Hi,

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Bala Manoharan
odp_classifier runs on api-next branch but if we run on master it currently crashes during queue_enq function. I remember the crash was similar to the one we had during queue reorder implementation. Regards, Bala On 10 December 2015 at 20:38, Stuart Haslam wrote: > On

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Stuart Haslam
On Thu, Dec 10, 2015 at 06:01:05PM +0300, Maxim Uvarov wrote: > How to reproduce that it is broken? > I was looking at: sudo ODP_PLATFORM=linux-generic ./test/performance/odp_l2fwd_run This shows a few packets going through initially then 0. Turns out this is related to the netmap pktio, this