Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

> On 5 Jul 2017, at 10:09, Maxim Uvarov wrote: > > Matias, > > I would change it from unsigned. That allows to reuse on variable for all > return code. > > int ret; > > re t= odp_init_global() > if (ret) .. > ret = odp_packet()... > if (ret) > ret =

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

Matias, I would change it from unsigned. That allows to reuse on variable for all return code. int ret; re t= odp_init_global() if (ret) .. ret = odp_packet()... if (ret) ret = odp_sys_huge_page_size_all() <- here in your case we will need additional cast to unsigned if (ret) ... return ret;

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

> On 3 Jul 2017, at 15:54, Bill Fischofer wrote: > > On Mon, Jul 3, 2017 at 7:40 AM, Elo, Matias (Nokia - FI/Espoo) > wrote: >> Ping. > > Is the rest of the patch (implementation, validation test updates, doc > updates) in preparation? The API

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

On Mon, Jul 3, 2017 at 7:40 AM, Elo, Matias (Nokia - FI/Espoo) wrote: > Ping. Is the rest of the patch (implementation, validation test updates, doc updates) in preparation? The API changes have already been reviewed by both Petri and me. > > >> On 5 Jun 2017, at 10:11,

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

Ping. > On 5 Jun 2017, at 10:11, Elo, Matias (Nokia - FI/Espoo) > wrote: > > >> On 2 Jun 2017, at 16:48, Maxim Uvarov wrote: >> >> On 06/02/17 12:44, Elo, Matias (Nokia - FI/Espoo) wrote: > > /** > + * System huge page sizes in

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

> On 2 Jun 2017, at 16:48, Maxim Uvarov wrote: > > On 06/02/17 12:44, Elo, Matias (Nokia - FI/Espoo) wrote: /** + * System huge page sizes in bytes + * + * Returns the number of huge page sizes supported by the system. Outputs up to

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

On 06/02/17 12:44, Elo, Matias (Nokia - FI/Espoo) wrote: >>> >>> /** >>> + * System huge page sizes in bytes >>> + * >>> + * Returns the number of huge page sizes supported by the system. Outputs >>> up to >>> + * 'num' sizes when the 'size' array pointer is not NULL. If return value >>> is >>>

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

>> >> /** >> + * System huge page sizes in bytes >> + * >> + * Returns the number of huge page sizes supported by the system. Outputs >> up to >> + * 'num' sizes when the 'size' array pointer is not NULL. If return value is >> + * larger than 'num', there are more supported sizes than the

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

On 06/01/17 13:52, Matias Elo wrote: > A system may simultaneously support multiple huge page sizes. Add a new API > function odp_sys_huge_page_size_all() which returns all supported page > sizes. odp_sys_huge_page_size() stays unmodified to maintain backward > compatibility. > > Signed-off-by:

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

Thanks, will do. -Matias > On 1 Jun 2017, at 15:44, Bill Fischofer wrote: > > This still needs implementation, validation tests, and doc updates to > be complete. > > On Thu, Jun 1, 2017 at 5:52 AM, Matias Elo wrote: >> A system may

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

This still needs implementation, validation tests, and doc updates to be complete. On Thu, Jun 1, 2017 at 5:52 AM, Matias Elo wrote: > A system may simultaneously support multiple huge page sizes. Add a new API > function odp_sys_huge_page_size_all() which returns all

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

>>> + * >>> + * @param[out] size Points to an array of huge page sizes for output >>> + * @param num Maximum number of huge page sizes to output >>> + * >>> + * @return Number of supported huge page sizes >>> + * @retval 0 on no huge pages >>> + */ >>> +unsigned

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

On Thu, Jun 1, 2017 at 6:04 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Reviewed-by: Petri Savolainen > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >> Matias Elo >> Sent:

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Matias Elo > Sent: Thursday, June 01, 2017 1:53 PM > To: lng-odp@lists.linaro.org > Subject: Suspected SPAM - [lng-odp] [API-NEXT