Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

2017-02-20 Thread Peltonen, Janne (Nokia - FI/Espoo)
ject: Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: > implement reference > apis > > First off, thank you very much for this review. > > Please note that this code has been streamlined in patch > http://patches.opendataplane.org/patch/7879/ a

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

2017-02-20 Thread Maxim Uvarov
Add simple, copy based >>> implementation first and continue development/optimization from there. So, >>> that we can step back and compare easily with previous version, if e.g. >>> race conditions are found. >>> >>> -Petri >>> >>> >

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

2017-02-20 Thread Bill Fischofer
tep back and compare easily with previous version, if e.g. >> race conditions are found. >> >> -Petri >> >> >> > -Original Message----- >> > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >> Bill >> > Fischofer >>

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

2017-02-20 Thread Francois Ozog
g. > race conditions are found. > > -Petri > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Bill > > Fischofer > > Sent: Saturday, February 18, 2017 6:28 PM > > To: Francois Ozog <francoi

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

2017-02-20 Thread Savolainen, Petri (Nokia - FI/Espoo)
nal Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: Saturday, February 18, 2017 6:28 PM > To: Francois Ozog <francois.o...@linaro.org> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-g

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

2017-02-18 Thread Bill Fischofer
On Sat, Feb 18, 2017 at 9:57 AM, Francois Ozog wrote: > Well, problem is still there. > You are doing something on a packet that may not exist anymore. > Can you elaborate? The bug fix patch eliminates the race condition that Janne pointed out because no thread

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

2017-02-18 Thread Francois Ozog
Well, problem is still there. You are doing something on a packet that may not exist anymore. On 17 February 2017 at 22:08, Bill Fischofer wrote: > I've posted patch http://patches.opendataplane.org/patch/8155/ to > address this issue. It goes on api-next on top of

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

2017-02-17 Thread Bill Fischofer
I've posted patch http://patches.opendataplane.org/patch/8155/ to address this issue. It goes on api-next on top of patches http://patches.opendataplane.org/patch/7879/ and http://patches.opendataplane.org/patch/8154/ On Fri, Feb 17, 2017 at 2:39 PM, Bill Fischofer

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

2017-02-17 Thread Bill Fischofer
First off, thank you very much for this review. Please note that this code has been streamlined in patch http://patches.opendataplane.org/patch/7879/ and has been further refined with patch http://patches.opendataplane.org/patch/8145/ but the exposure you identify still exists in that code. On

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

2017-02-17 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, I took a look at the packet references and it seems to me that either the implementation is a bit racy or I confused myself when reading the code. Or maybe I got the intended concurrency semantics of the packet references wrong? My first issue is that packet_free() may access freed packet